scss_lint 0.38.0

data/spec/scss_lint/linter/border_zero_spec.rb

@@ -0,0 +1,118 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::BorderZero do
+  context 'when a rule is empty' do
+    let(:scss) { <<-SCSS }
+      p {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a property' do
+    context 'contains a normal border' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: 1px solid #000;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'has a border of 0' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: 0;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'has a border of none' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: none;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'has a border-top of none' do
+      let(:scss) { <<-SCSS }
+        p {
+          border-top: none;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'has a border-right of none' do
+      let(:scss) { <<-SCSS }
+        p {
+          border-right: none;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'has a border-bottom of none' do
+      let(:scss) { <<-SCSS }
+        p {
+          border-bottom: none;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'has a border-left of none' do
+      let(:scss) { <<-SCSS }
+        p {
+          border-left: none;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+  end
+
+  context 'when a convention of `none` is preferred' do
+    let(:linter_config) { { 'convention' => 'none' } }
+
+    context 'and the border is `none`' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: none;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and the border is `0`' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: 0;
+        }
+      SCSS
+
+      it { should report_lint }
+    end
+
+    context 'and the border is a non-zero value' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: 5px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/color_keyword_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::ColorKeyword do
+  context 'when a color is specified as a hex' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: #fff;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a color is specified as a keyword' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: white;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a color keyword exists in a shorthand property' do
+    let(:scss) { <<-SCSS }
+      p {
+        border: 1px solid black;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a property contains a color keyword as a string' do
+    let(:scss) { <<-SCSS }
+      p {
+        content: 'white';
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a function call contains a color keyword' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: function(red);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a mixin include contains a color keyword' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include some-mixin(red);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when the "transparent" color keyword is used' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include mixin(transparent);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when color keyword appears in a string identifier' do
+    let(:scss) { <<-SCSS }
+      p {
+        content: content-with-blue-in-name;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/color_variable_spec.rb

@@ -0,0 +1,155 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::ColorVariable do
+  context 'when a color literal is used in a variable declaration' do
+    let(:scss) { <<-SCSS }
+      $my-color: #f00;
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a color literal is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: #f00;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a color literal is used in a function call' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: my-func(#f00);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a color literal is used in a mixin' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include my-mixin(#f00);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a color literal is used in a shorthand property' do
+    let(:scss) { <<-SCSS }
+      p {
+        border: 1px solid #f00;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a number is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        z-index: 9000;
+        transition-duration: 250ms;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a non-color keyword is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        overflow: hidden;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: $my-color;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable is used in a function call' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: my-func($my-color);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable is used in a shorthand property' do
+    let(:scss) { <<-SCSS }
+      p {
+        border: 1px solid $my-color;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a property contains "transparent"' do
+    let(:scss) { <<-SCSS }
+      p {
+        border: 1px solid transparent;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a property with function calls contains "transparent"' do
+    let(:scss) { <<-SCSS }
+      p {
+        border: 1px solid some-func(transparent);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a color literal is used in the special rgba shorthand helper' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: rgba(#fff, .5);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a color literal is used in a map declaration' do
+    let(:scss) { <<-SCSS }
+      $shades-of-gray: (
+        darker:  #4c4c4c,
+        dark:    #626262,
+        light:   #7d7d7d,
+        lighter: #979797
+      );
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a string with a color name is used in a function call' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: my-func('blue');
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/comment_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::Comment do
+  context 'when no comments exist' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when comment is a single line comment' do
+    let(:scss) { '// Single line comment' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when comment is a single line comment at the end of a line' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0; // Comment at end of line
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when comment is a multi-line comment' do
+    let(:scss) { <<-SCSS }
+      h1 {
+        color: #eee;
+      }
+      /*
+       * This is a multi-line comment that should report a lint
+       */
+      p {
+        color: #DDD;
+      }
+    SCSS
+
+    it { should report_lint line: 4 }
+  end
+
+  context 'when multi-line-style comment is a at the end of a line' do
+    let(:scss) { <<-SCSS }
+      h1 {
+        color: #eee; /* This is a comment */
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when multi-line comment is allowed by config' do
+    let(:linter_config) { { 'allowed' => '^[/\\* ]*Copyright' } }
+    let(:scss) { <<-SCSS }
+      /* Copyright someone. */
+      a {
+        color: #DDD;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when multi-line comment is not allowed by config' do
+    let(:linter_config) { { 'allowed' => '^[/\\* ]*Copyright' } }
+    let(:scss) { <<-SCSS }
+      /* Other multiline. */
+      p {
+        color: #DDD;
+      }
+    SCSS
+
+    it { should report_lint }
+  end
+end

data/spec/scss_lint/linter/compass/property_with_mixin_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::Compass::PropertyWithMixin do
+  context 'when a rule has a property with an equivalent Compass mixin' do
+    let(:scss) { <<-SCSS }
+      p {
+        opacity: .5;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a rule includes a Compass property mixin' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include opacity(.5);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a rule does not have a property with a corresponding Compass mixin' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a rule includes display: inline-block' do
+    let(:scss) { <<-SCSS }
+      p {
+        display: inline-block;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when properties are ignored' do
+    let(:linter_config) { { 'ignore' => %w[inline-block] } }
+
+    let(:scss) { <<-SCSS }
+      p {
+        display: inline-block;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end