scss_lint 0.38.0

data/spec/scss_lint/linter/trailing_semicolon_spec.rb

@@ -0,0 +1,304 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe SCSSLint::Linter::TrailingSemicolon do
+  context 'when a property does not end with a semicolon' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a property ends with a semicolon' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a property ends with a space followed by a semicolon' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0 ;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a property ends with a semicolon and is followed by a comment' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;  // This is a comment
+        padding: 0; /* This is another comment */
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a property contains nested properties' do
+    context 'and there is a value on the namespace' do
+      let(:scss) { <<-SCSS }
+        p {
+          font: 2px/3px {
+            style: italic;
+            weight: bold;
+          }
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and there is no value on the namespace' do
+      let(:scss) { <<-SCSS }
+        p {
+          font: {
+            style: italic;
+            weight: bold;
+          }
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when a nested property does not end with a semicolon' do
+    let(:scss) { <<-SCSS }
+      p {
+        font: {
+          weight: bold
+        }
+      }
+    SCSS
+
+    it { should report_lint line: 3 }
+  end
+
+  context 'when a multi-line property ends with a semicolon' do
+    let(:scss) { <<-SCSS }
+      p {
+        background:
+          top repeat-x url('top-image.jpg'),
+          right repeat-y url('right-image.jpg'),
+          bottom repeat-x url('bottom-image.jpg'),
+          left repeat-y url('left-image.jpg');
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a multi-line property does not end with a semicolon' do
+    let(:scss) { <<-SCSS }
+      p {
+        background:
+          top repeat-x url('top-image.jpg'),
+          right repeat-y url('right-image.jpg'),
+          bottom repeat-x url('bottom-image.jpg'),
+          left repeat-y url('left-image.jpg')
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a oneline rule does not end with a semicolon' do
+    let(:scss) { <<-SCSS }
+      .foo { border: 0 }
+    SCSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when a oneline rule has a space before a semicolon' do
+    let(:scss) { <<-SCSS }
+      .foo { border: 0 ; }
+    SCSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when @extend does not end with a semicolon' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        @extend %bar
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when @extend ends with a semicolon' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        @extend %bar;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when @include does not end with a semicolon' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        @include bar
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when @include takes a block' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        @include bar {
+          border: 0;
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when @include takes a block with nested props' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        @include bar {
+          .bar {
+            border: 0;
+          }
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when @include takes a block with an if-node' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        @include bar {
+          @if $var {
+            border: 0;
+          }
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when @include ends with a semicolon' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        @include bar;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when @import ends with a semicolon' do
+    let(:scss) { '@import "something";' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when @import does not end with a semicolon' do
+    let(:scss) { '@import "something"' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when @import has a space before a semicolon' do
+    let(:scss) { '@import "something" ;' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when an import directive is split over multiple lines' do
+    context 'and is missing the trailing semicolon' do
+      let(:scss) { <<-SCSS }
+        @import 'functions/strip-units',
+                'functions/pc'
+      SCSS
+
+      it { should report_lint }
+    end
+
+    context 'and is not missing the trailing semicolon' do
+      let(:scss) { <<-SCSS }
+        @import 'functions/strip-units',
+                'functions/pc';
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when variable declaration does not end with a semicolon' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        $bar: 1
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when variable declaration ends with a semicolon' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        $bar: 1;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when variable declaration ends with multiple semicolons' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        $bar: 1;;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when interpolation within single quotes is followed by property' do
+    context 'and property has a trailing semicolon' do
+      let(:scss) { "[class~='\#{$test}'] { width: 100%; }" }
+
+      it { should_not report_lint }
+    end
+
+    context 'and property does not have a trailing semicolon' do
+      let(:scss) { "[class~='\#{$test}'] { width : 100% }" }
+
+      it { should report_lint }
+    end
+  end
+
+  context 'when triggering a bug based on Windows IBM437 encoding' do
+    let(:scss) { <<-SCSS.force_encoding('IBM437') }
+      @charset "UTF-8";
+
+      .foo:before {
+        content: '▼';
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/trailing_zero_spec.rb

@@ -0,0 +1,176 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::TrailingZero do
+  context 'when no values exist' do
+    let(:scss) { 'p {}' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when a zero exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an integer value exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        line-height: 2;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an integer value with units exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 5px;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a unitless fractional value with no trailing zero exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        line-height: .5;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a negative unitless fractional value with no trailing zero exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        line-height: -.5;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a fractional value with units and no trailing zero exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: .5em;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a negative fractional value with units and no trailing zero exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: -.5em;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a fractional value with a trailing zero exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        line-height: .50;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a fractional value with units and a trailing zero exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: .50em;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a negative fractional value with units and a trailing zero exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: -.50em;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a fractional value with a mantissa ending in zero exists' do
+    let(:scss) { <<-SCSS }
+      p {
+        line-height: 10.5;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when multiple fractional values with trailing zeros exist' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0.50em .50 0.10px .90pt;
+      }
+    SCSS
+
+    it { should report_lint count: 4, line: 2 }
+  end
+
+  context 'when trailing zeros appear in function arguments' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: some-function(.50em, 0.40 0.30 .2);
+      }
+    SCSS
+
+    it { should report_lint count: 3, line: 2 }
+  end
+
+  context 'when trailing zeros appear in mixin arguments' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include some-mixin(0.50em, 0.40 0.30 .2);
+      }
+    SCSS
+
+    it { should report_lint count: 3, line: 2 }
+  end
+
+  context 'when trailiing zeros appear in variable declarations' do
+    let(:scss) { '$some-var: .50em;' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when trailing zeros appear in named arguments' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include line-clamp($line-height: .90, $line-count: 2);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when trailing zeros appear in parameter defaults' do
+    let(:scss) { <<-SCSS }
+      @mixin my-mixin($bad-value: .50, $good-value: .9, $string-value: ".90") {
+        margin: $some-value;
+        padding: $some-other-value;
+      }
+    SCSS
+
+    it { should report_lint count: 1, line: 1 }
+  end
+end