scss_lint 0.38.0

data/spec/scss_lint/linter/unnecessary_mantissa_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::UnnecessaryMantissa do
+  context 'when value is zero' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;
+        padding: func(0);
+        top: 0em;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when value contains no mantissa' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 1;
+        padding: func(1);
+        top: 1em;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when value contains a mantissa with a zero' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 1.0;
+        padding: func(1.0);
+        top: 1.0em;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+    it { should report_lint line: 4 }
+  end
+
+  context 'when value contains a mantissa with multiple zeroes' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 1.000;
+        padding: func(1.000);
+        top: 1.000em;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+    it { should report_lint line: 4 }
+  end
+
+  context 'when value contains a mantissa with multiple zeroes followed by a number' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 1.0001;
+        padding: func(1.0001);
+        top: 1.0001em;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/unnecessary_parent_reference_spec.rb

@@ -0,0 +1,98 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::UnnecessaryParentReference do
+  context 'when an amperand precedes a direct descendant operator' do
+    let(:scss) { <<-SCSS }
+      p {
+        & > a {}
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when an amperand precedes a general child' do
+    let(:scss) { <<-SCSS }
+      p {
+        & a {}
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when an amperand is chained with class' do
+    let(:scss) { <<-SCSS }
+      p {
+        &.foo {}
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an amperand follows a direct descendant operator' do
+    let(:scss) { <<-SCSS }
+      p {
+        .foo > & {}
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an ampersand precedes a sibling operator' do
+    let(:scss) { <<-SCSS }
+      p {
+        & + & {}
+        & ~ & {}
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when multiple ampersands exist with one concatenated' do
+    let(:scss) { <<-SCSS }
+      p {
+        & + &:hover {}
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an amperand is used in a comma sequence to DRY up code' do
+    let(:scss) { <<-SCSS }
+      p {
+        &,
+        .foo,
+        .bar {
+          margin: 0;
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an ampersand is used by itself' do
+    let(:scss) { <<-SCSS }
+      p {
+        & {}
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when an ampersand is used in concatentation' do
+    let(:scss) { <<-SCSS }
+      .icon {
+        &-small {}
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/url_format_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::UrlFormat do
+  shared_examples_for 'UrlFormat linter' do
+    context 'when URL contains protocol' do
+      let(:url) { 'https://something.com/image.png' }
+
+      it { should report_lint }
+    end
+
+    context 'when URL contains domain with protocol-less double slashes' do
+      let(:url) { '//something.com/image.png' }
+
+      it { should report_lint }
+    end
+
+    context 'when URL contains absolute path' do
+      let(:url) { '/absolute/path/to/image.png' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when URL contains relative path' do
+      let(:url) { 'relative/path/to/image.png' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when URL is a data URI' do
+      let(:url) { 'data:image/png;base64,iVBORI=' }
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when URL is enclosed in quotes' do
+    let(:scss) { <<-SCSS }
+      .block {
+        background: url('#{url}');
+      }
+    SCSS
+
+    it_should_behave_like 'UrlFormat linter'
+  end
+
+  context 'when URL is not enclosed in quotes' do
+    let(:scss) { <<-SCSS }
+      .block {
+        background: url(#{url});
+      }
+    SCSS
+
+    it_should_behave_like 'UrlFormat linter'
+  end
+end

data/spec/scss_lint/linter/url_quotes_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::UrlQuotes do
+  context 'when property has a literal URL' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: url(example.png);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when property has a URL enclosed in single quotes' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: url('example.png');
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property has a URL enclosed in double quotes' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: url("example.png");
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property has a literal URL in a list' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: transparent url(example.png);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when property has a single-quoted URL in a list' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: transparent url('example.png');
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property has a double-quoted URL in a list' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: transparent url("example.png");
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property has a data URI' do
+    let(:scss) { <<-SCSS }
+      .tracking-pixel {
+        background: url(data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/variable_for_property_spec.rb

@@ -0,0 +1,145 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::VariableForProperty do
+  context 'when properties are specified' do
+    let(:linter_config) { { 'properties' => %w[color font] } }
+
+    context 'when configured property value is a variable' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: $black;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when configured property value is a hex string' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: #000;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when configured property value is a color keyword' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: red;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when an unspecified property value is a variable' do
+      let(:scss) { <<-SCSS }
+        p {
+          background-color: $black;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when an unspecified property value is not a variable' do
+      let(:scss) { <<-SCSS }
+        p {
+          background-color: #000;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when multiple configured property values are variables' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: $black;
+          font: $small;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when multiple configured property values are not variables' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: #000;
+          font: 8px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+    end
+
+    context 'when configured property values are mixed' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: $black;
+          font: 8px;
+        }
+      SCSS
+
+      it { should report_lint line: 3 }
+    end
+
+    context 'when property specifies `currentColor`' do
+      let(:scss) { <<-SCSS }
+        p {
+          background-color: currentColor;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when property specifies `inherit`' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: inherit;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when property specifies `transparent`' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: transparent;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when properties are not specified' do
+    let(:linter_config) { { 'properties' => [] } }
+
+    context 'when property value is a variable' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: $black;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when property value is not a variable' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: #000;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/vendor_prefix_spec.rb

@@ -0,0 +1,371 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::VendorPrefix do
+  context 'when no vendor-prefix is used' do
+    let(:scss) { <<-SCSS }
+      div {
+        transition: none;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a rule is empty' do
+    let(:scss) { <<-SCSS }
+      div {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  # Properties
+
+  context 'when a vendor-prefixed listed property is used' do
+    let(:scss) { <<-SCSS }
+      div {
+        -webkit-transition: none;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when an unprefixed listed property is used' do
+    let(:scss) { <<-SCSS }
+      div {
+        transition: none;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-prefixed unlisted property is used' do
+    let(:scss) { <<-SCSS }
+      div {
+        -webkit-appearance: none;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-prefixed custom-listed property is used' do
+    let(:linter_config) { { 'identifier_list' => ['transform'] } }
+
+    let(:scss) { <<-SCSS }
+      div {
+        -webkit-transform: none;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a proprietary unlisted vendor-prefixed property is used' do
+    let(:scss) { <<-SCSS }
+      div {
+        -moz-padding-end: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a proprietary listed vendor-prefixed property is used' do
+    let(:linter_config) { { 'identifier_list' => ['padding-end'] } }
+
+    let(:scss) { <<-SCSS }
+      div {
+        -moz-padding-end: 0;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  # Selectors
+
+  context 'when a vendor-prefixed listed selector is used' do
+    let(:scss) { <<-SCSS }
+      ::-moz-placeholder {
+        color: red;
+      }
+      :-ms-placeholder {
+        color: pink;
+      }
+      :-moz-fullscreen p {
+        font-size: 200%;
+      }
+    SCSS
+
+    it { should report_lint line: 1 }
+    it { should report_lint line: 4 }
+    it { should report_lint line: 7 }
+  end
+
+  context 'when an unprefixed listed selector is used' do
+    let(:scss) { <<-SCSS }
+      ::placeholder {
+        color: red;
+      }
+      :fullscreen p {
+        font-size: 200%;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-prefixed unlisted selector is used' do
+    let(:linter_config) { { 'identifier_list' => ['transform'] } }
+
+    let(:scss) { <<-SCSS }
+      ::-moz-placeholder {
+        color: red;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-prefixed custom-listed selector is used' do
+    let(:linter_config) { { 'identifier_list' => ['placeholder'] } }
+
+    let(:scss) { <<-SCSS }
+      ::-moz-placeholder {
+        color: red;
+      }
+    SCSS
+
+    it { should report_lint line: 1 }
+  end
+
+  # Directives
+
+  context 'when a vendor-prefixed listed directive is used' do
+    let(:scss) { <<-SCSS }
+      @-webkit-keyframes anim {
+        0% { opacity: 0; }
+      }
+    SCSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when an unprefixed listed directive is used' do
+    let(:scss) { <<-SCSS }
+      @keyframes anim {
+        0% { opacity: 0; }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an vendor-prefixed unlisted directive is used' do
+    let(:linter_config) { { 'identifier_list' => ['placeholder'] } }
+
+    let(:scss) { <<-SCSS }
+      @-webkit-keyframes anim {
+        0% { opacity: 0; }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an vendor-prefixed custom-listed directive is used' do
+    let(:linter_config) { { 'identifier_list' => ['keyframes'] } }
+
+    let(:scss) { <<-SCSS }
+      @-webkit-keyframes anim {
+        0% { opacity: 0; }
+      }
+    SCSS
+
+    it { should report_lint line: 1 }
+  end
+
+  # Values
+
+  context 'when a vendor-prefixed listed value is used' do
+    let(:scss) { <<-SCSS }
+      div {
+        background-image: -webkit-linear-gradient(#000, #fff);
+        position: -moz-sticky;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+  end
+
+  context 'when an unprefixed listed value is used' do
+    let(:scss) { <<-SCSS }
+      div {
+        background-image: linear-gradient(#000, #fff);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-unprefixed unlisted value is used' do
+    let(:linter_config) { { 'identifier_list' => ['keyframes'] } }
+
+    let(:scss) { <<-SCSS }
+      div {
+        background-image: -webkit-linear-gradient(#000, #fff);
+        position: -moz-sticky;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a vendor-unprefixed custom-listed value is used' do
+    let(:linter_config) { { 'identifier_list' => ['linear-gradient'] } }
+
+    let(:scss) { <<-SCSS }
+      div {
+        background-image: -webkit-linear-gradient(#000, #fff);
+        position: -moz-sticky;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  # Identifier lists
+
+  context 'when using non-default named identifier list' do
+    let(:linter_config) { { 'identifier_list' => 'bourbon' } }
+
+    context 'and a standard vendor-prefixed property is used' do
+      let(:scss) { <<-SCSS }
+        div {
+          background-image: -webkit-linear-gradient(#000, #fff);
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'and a list-specific vendor-prefixed property is used' do
+      let(:scss) { <<-SCSS }
+        div {
+          image-rendering: -moz-crisp-edges;
+          -webkit-appearance: none;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+    end
+
+    context 'and a list-exempt vendor-prefixed property is used' do
+      let(:scss) { <<-SCSS }
+        div {
+          -webkit-mask-repeat: inherit;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  # Excluding and Including
+
+  context 'when manually excluding identifiers' do
+    let(:linter_config) do
+      {
+        'identifier_list' => 'base',
+        'excluded_identifiers' => %w[transform selection],
+      }
+    end
+
+    let(:scss) { <<-SCSS }
+      div {
+        -webkit-transform: translateZ(0);
+      }
+      ::-moz-selection {
+        color: #000;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when manually including identifiers' do
+    let(:linter_config) do
+      {
+        'identifier_list' => 'base',
+        'additional_identifiers' => ['padding-end'],
+        'excluded_identifiers' => [],
+      }
+    end
+
+    let(:scss) { <<-SCSS }
+      div {
+        -moz-padding-end: 0;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  # More
+  context 'when dealing with many-hyphened vendor-prefixed identifiers' do
+    let(:scss) { <<-SCSS }
+      div {
+        -moz-animation-timing-function: ease-out;
+        -webkit-border-bottom-right-radius: 5px;
+        background: -o-repeating-radial-gradient(#000, #000 5px, #fff 5px, #fff 10px)
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+    it { should report_lint line: 4 }
+  end
+
+  context 'when dealing with many-hyphened unprefixed identifiers' do
+    let(:scss) { <<-SCSS }
+      div {
+        animation-timing-function: ease-out;
+        border-bottom-right-radius: 5px;
+        background: repeating-radial-gradient(#000, #000 5px, #fff 5px, #fff 10px)
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when vendor-prefixed media queries are used' do
+    let(:scss) { <<-SCSS }
+    @media
+      only screen and (-webkit-min-device-pixel-ratio: 1.3),
+      only screen and (-o-min-device-pixel-ratio: 13/10),
+      only screen and (min-resolution: 120dpi) {
+        body {
+          background: #fff;
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property contains a list literal with an empty list' do
+    let(:scss) { <<-SCSS }
+      p {
+        content: 0 ();
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end