scss_lint 0.38.0

data/spec/scss_lint/linter/shorthand_spec.rb

@@ -0,0 +1,198 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::Shorthand do
+  context 'when a rule' do
+    context 'is empty' do
+      let(:scss) { <<-SCSS }
+        p {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'contains properties with valid shorthand values' do
+      let(:scss) { <<-SCSS }
+        p {
+          border-radius: 1px 2px 1px 3px;
+          border-width: 1px;
+          color: rgba(0, 0, 0, .5);
+          margin: 1px 2px;
+          padding: 0 0 1px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when a property' do
+    context 'has a value repeated 4 times' do
+      let(:scss) { <<-SCSS }
+        p {
+          padding: 1px 1px 1px 1px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'has a value repeated 3 times' do
+      let(:scss) { <<-SCSS }
+        p {
+          padding: 3px 3px 3px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'has interpolation in its name and starts with a shorthandable property' do
+      let(:scss) { <<-SCSS }
+        p {
+          border-color\#{$type}: 1px 1px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'has exactly two identical values' do
+      let(:scss) { <<-SCSS }
+        p {
+          padding: 10px 10px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'appears to have two identical values, but cannot be shorthanded' do
+      let(:scss) { <<-SCSS }
+        p:before {
+          content: ' ';
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'has its first two values repeated' do
+      let(:scss) { <<-SCSS }
+        p {
+          padding: 1px 2px 1px 2px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'has its first value repeated in the third position' do
+      let(:scss) { <<-SCSS }
+        p {
+          padding: 1px 2px 1px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'has its second value repeated in the fourth position' do
+      let(:scss) { <<-SCSS }
+        p {
+          padding: 1px 2px 3px 2px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'contains numeric values and function calls' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 10px percentage(1 / 100);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'contains a list of function calls that can be shortened' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: percentage(1 / 100) percentage(1 / 100);
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'contains a list of function calls that cannot be shortened' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: percentage(1 / 100) percentage(5 / 100);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'contains a list of variables that can be shortened' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: $my-var 1px $my-var;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'contains a number with no trailing semicolon' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 4px
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'can be shortened and is followed by !important modifier' do
+      let(:scss) { <<-SCSS }
+        p {
+          padding: 1px 2px 3px 2px !important;
+          margin: 0 0 0 0 !important; // A comment
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+    end
+  end
+
+  context 'when configured with allowed_shorthands, and a rule' do
+    let(:linter_config) { { 'allowed_shorthands' => allowed } }
+
+    context 'can be shortened to 1, 2, or 3, but 1 is not allowed' do
+      let(:allowed) { [2, 3] }
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 4px 4px 4px 4px;
+        }
+      SCSS
+
+      it { should report_lint }
+    end
+
+    context 'can be shortened to 1, but 1 is not allowed' do
+      let(:allowed) { [2, 3] }
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 4px 4px 4px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/single_line_per_property_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SingleLinePerProperty do
+  context 'when properties are each on their own line' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: #fff;
+        margin: 0;
+        padding: 5px;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when two properties share a line' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: #fff;
+        margin: 0; padding: 5px;
+      }
+    SCSS
+
+    it { should_not report_lint line: 2 }
+    it { should report_lint line: 3, count: 1 }
+  end
+
+  context 'when multiple properties share a line' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: #fff; margin: 0; padding: 5px;
+      }
+    SCSS
+
+    it { should report_lint line: 2, count: 2 }
+  end
+
+  context 'when multiple properties share a line on a single line rule set' do
+    let(:scss) { <<-SCSS }
+      p { color: #fff; margin: 0; padding: 5px; }
+    SCSS
+
+    context 'and single line rule sets are allowed' do
+      let(:linter_config) { { 'allow_single_line_rule_sets' => true } }
+
+      it { should_not report_lint }
+    end
+
+    context 'and single line rule sets are not allowed' do
+      let(:linter_config) { { 'allow_single_line_rule_sets' => false } }
+
+      it { should report_lint }
+    end
+  end
+
+  context 'when a single line rule set contains a single property' do
+    let(:scss) { <<-SCSS }
+      p { color: #fff; }
+    SCSS
+
+    context 'and single line rule sets are allowed' do
+      let(:linter_config) { { 'allow_single_line_rule_sets' => true } }
+
+      it { should_not report_lint }
+    end
+
+    context 'and single line rule sets are not allowed' do
+      let(:linter_config) { { 'allow_single_line_rule_sets' => false } }
+
+      it { should report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/single_line_per_selector_spec.rb

@@ -0,0 +1,130 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SingleLinePerSelector do
+  context 'when rule has one selector' do
+    let(:scss) { <<-SCSS }
+      p {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule has one selector on each line' do
+    let(:scss) { <<-SCSS }
+      p,
+      a {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains multiple selectors on the same line' do
+    let(:scss) { <<-SCSS }
+      .first,
+      .second,
+      .third, .fourth,
+      .fifth {
+      }
+    SCSS
+
+    it { should report_lint line: 3 }
+  end
+
+  context 'when commas are not at the end of the line' do
+    let(:scss) { <<-SCSS }
+      .foo
+      , .bar {
+      }
+    SCSS
+
+    it { should report_lint }
+  end
+
+  context 'when commas are on their own line' do
+    let(:scss) { <<-SCSS }
+      .foo
+      ,
+      .bar {
+      }
+    SCSS
+
+    it { should report_lint }
+  end
+
+  context 'when nested rule contains multiple selectors on the same line' do
+    let(:scss) { <<-SCSS }
+      #foo {
+        .first,
+        .second,
+        .third, .fourth,
+        .fifth {
+        }
+      }
+    SCSS
+
+    it { should report_lint line: 4 }
+  end
+
+  context 'when rule contains interpolated selectors' do
+    let(:scss) { <<-SCSS }
+      .first,
+      \#{interpolated-selector}.thing,
+      .third {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains an interpolated selector not on its own line' do
+    let(:scss) { <<-SCSS }
+      .first,
+      .second, \#{$interpolated-selector}.thing,
+      .fourth {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains an inline comment' do
+    let(:scss) { <<-SCSS }
+      .first,  /* A comment */
+      .second, // Another comment
+      .third {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when interpolation contains a comma' do
+    let(:scss) { <<-SCSS }
+      .my-\#{function(1, 2)}-selector .nested {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when selector contains an interpolated string' do
+    let(:scss) { <<-SCSS }
+      div,
+      \#{$selector},
+      p {}
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a function is used in the selector' do
+    let(:scss) { <<-SCSS }
+      \#{function()} {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/space_after_comma_spec.rb

@@ -0,0 +1,332 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SpaceAfterComma do
+  context 'in a mixin declaration' do
+    context 'where spaces do not follow commas' do
+      let(:scss) { <<-SCSS }
+        @mixin mixin($arg1,$arg2,$kwarg1: 'default',$kwarg2: 'default') {
+        }
+      SCSS
+
+      it { should report_lint count: 3 }
+    end
+
+    context 'where spaces follow commas' do
+      let(:scss) { <<-SCSS }
+        @mixin mixin($arg1, $arg2, $kwarg1: 'default', $kwarg2: 'default') {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'where spaces surround commas' do
+      let(:scss) { <<-SCSS }
+        @mixin mixin($arg1 , $arg2 , $kwarg1: 'default' , $kwarg2: 'default') {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'where commas are followed by a newline' do
+      let(:scss) { <<-SCSS }
+        @mixin mixin($arg1,
+                     $arg2,
+                     $kwarg1: 'default',
+                     $kwarg2: 'default') {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'definining a variable argument' do
+      context 'where spaces do not follow commas' do
+        let(:scss) { <<-SCSS }
+          @mixin mixin($arg,$args...) {
+          }
+        SCSS
+
+        it { should report_lint count: 1 }
+      end
+
+      context 'where spaces follow commas' do
+        let(:scss) { <<-SCSS }
+          @mixin mixin($arg, $args...) {
+          }
+        SCSS
+
+        it { should_not report_lint }
+      end
+
+      context 'where spaces surround commas' do
+        let(:scss) { <<-SCSS }
+          @mixin mixin($arg , $args...) {
+          }
+        SCSS
+
+        it { should_not report_lint }
+      end
+
+      context 'where commas are followed by a newline' do
+        let(:scss) { <<-SCSS }
+          @mixin mixin($arg,
+                       $args...) {
+          }
+        SCSS
+
+        it { should_not report_lint }
+      end
+    end
+  end
+
+  context 'in a mixin inclusion' do
+    context 'where spaces do not follow commas' do
+      let(:scss) { <<-SCSS }
+        p {
+          @include mixin(1,2,3,$args...,$kwarg1: 4,$kwarg2: 5,$kwargs...);
+        }
+      SCSS
+
+      it { should report_lint count: 6 }
+    end
+
+    context 'where spaces follow commas' do
+      let(:scss) { <<-SCSS }
+        p {
+          @include mixin(1, 2, 3, $args..., $kwarg1: 4, $kwarg2: 5, $kwargs...);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'where spaces surround commas' do
+      let(:scss) { <<-SCSS }
+        p {
+          @include mixin(1 , 2 , 3 , $args... , $kwarg1: 4 , $kwarg2: 5 , $kwargs...);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'where commas are followed by a newline' do
+      let(:scss) { <<-SCSS }
+        p {
+          @include mixin(1,
+                         2,
+                         3,
+                         $args...,
+                         $kwarg1: 4,
+                         $kwarg2: 5,
+                         $kwargs...);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'in a function declaration' do
+    context 'where spaces do not follow commas' do
+      let(:scss) { <<-SCSS }
+        @function func($arg1,$arg2,$kwarg1: 'default',$kwarg2: 'default') {
+        }
+      SCSS
+
+      it { should report_lint count: 3 }
+    end
+
+    context 'where spaces follow commas' do
+      let(:scss) { <<-SCSS }
+        @function func($arg1, $arg2, $kwarg1: 'default', $kwarg2: 'default') {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'where spaces surround commas' do
+      let(:scss) { <<-SCSS }
+        @function func($arg1 , $arg2 , $kwarg1: 'default' , $kwarg2: 'default') {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'where commas are followed by a newline' do
+      let(:scss) { <<-SCSS }
+        @function func($arg1,
+                       $arg2,
+                       $kwarg1: 'default',
+                       $kwarg2: 'default') {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'definining a variable argument' do
+      context 'where spaces do not follow commas' do
+        let(:scss) { <<-SCSS }
+          @function func($arg,$args...) {
+          }
+        SCSS
+
+        it { should report_lint count: 1 }
+      end
+
+      context 'where spaces follow commas' do
+        let(:scss) { <<-SCSS }
+          @function func($arg, $args...) {
+          }
+        SCSS
+
+        it { should_not report_lint }
+      end
+
+      context 'where spaces surround commas' do
+        let(:scss) { <<-SCSS }
+          @function func($arg , $args...) {
+          }
+        SCSS
+
+        it { should_not report_lint }
+      end
+
+      context 'where commas are followed by a newline' do
+        let(:scss) { <<-SCSS }
+          @function func($arg,
+                         $args...) {
+          }
+        SCSS
+
+        it { should_not report_lint }
+      end
+    end
+  end
+
+  context 'in a function invocation' do
+    context 'where spaces do not follow commas' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: func(1,2,3,$args...,$kwarg1: 4,$kwarg2: 5,$kwargs...);
+        }
+      SCSS
+
+      it { should report_lint count: 6 }
+    end
+
+    context 'where spaces follow commas' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: func(1, 2, 3, $args..., $kwarg1: 4, $kwarg2: 5, $kwargs...);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'where spaces surround commas' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: func(1 , 2 , 3 , $args... , $kwarg1: 4 , $kwarg2: 5 , $kwargs...);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'where commas are followed by a newline' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: func(1,
+                       2,
+                       3,
+                       $args...,
+                       $kwarg1: 4,
+                       $kwarg2: 5,
+                       $kwargs...);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'in a comma-separated literal list' do
+    context 'where spaces do not follow commas' do
+      let(:scss) { <<-SCSS }
+        p {
+          property: $a,$b,$c,$d;
+        }
+      SCSS
+
+      it { should report_lint count: 3 }
+    end
+
+    context 'where spaces follow commas' do
+      let(:scss) { <<-SCSS }
+        p {
+          property: $a, $b, $c, $d;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'where spaces surround commas' do
+      let(:scss) { <<-SCSS }
+        p {
+          property: $a , $b , $c , $d;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'where commas are followed by a newline' do
+      let(:scss) { <<-SCSS }
+        p {
+          property: $a,
+                    $b,
+                    $c,
+                    $d;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when commas are followed by a space and a newline' do
+      let(:scss) { <<-SCSS }
+        p {
+          property: $a,\s
+                    $b;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when declaring list variables' do
+    context 'and one argument does not have a trailing comma' do
+      let(:scss) { <<-SCSS }
+        $z-list: (
+          (
+            name1
+          ),
+          (
+            name2,
+          )
+        );
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+end