rubocop 0.68.1 → 0.69.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ca0a417513e7e81c8c52ba5637cf8ab60ec57ee22b6c328bd6564a4cea90376f
-  data.tar.gz: b6a8bc46c9c4b1b43ad52cb8cfd301193246abc2fc0bbe156e3b9cd663d77c53
+  metadata.gz: 1ceeff27cb7a9a5422da99021b22d3d729445de0cfc8db0fcd451a7b59644564
+  data.tar.gz: 975afb9f919e4b698091be763cbe0ae668aff0a76e79eea297eaf46113156049
 SHA512:
-  metadata.gz: 954a7c8b1155ec9359cf59675084554c0e3c17e2d8e87d621a73fb1ddbd7b8fe522dafe4ad816aa5162fb81a65305616299c4b248cb72554f69729ecb77c1fae
-  data.tar.gz: 9bbc404dc1c34e98033deae94361924489747ae5ff5b740884e26f08f6eb7ae15c73693af3b82bb505c1db89701599aa166916f06360a95208d9c903153fbbb8
+  metadata.gz: 502807f9a65b63922679174a7e32e7232d1191ea30b06199811f2c7485cdd47b02548a576f88e6bbadee9ed5e2a525eec570674d6b69fdfe5bfa2843edad465f
+  data.tar.gz: fdd08613fb4d3292b99f2b9764df4b91981b5c31300c879cfdd80203f2965b8994187dff36f79e0c16c38665f9b76bf93ad57f1b0df834a42ffe9aa057f82070

data/README.md

@@ -53,7 +53,7 @@ haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
 might want to use a conservative version lock in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 0.68.1', require: false
+gem 'rubocop', '~> 0.69.0', require: false
 ```
 
 ## Quickstart
@@ -73,8 +73,8 @@ You can read a ton more about RuboCop in its [official manual](https://docs.rubo
 
 RuboCop supports the following Ruby implementations:
 
-* MRI 2.2+
-* JRuby 9.0+
+* MRI 2.3+
+* JRuby 9.1+
 
 The Rails cops support the following versions:
 

data/config/default.yml

@@ -123,7 +123,7 @@ AllCops:
   # followed by the Gemfile.lock or gems.locked file. (Although the Ruby version
   # is specified in the Gemfile or gems.rb file, RuboCop reads the final value
   # from the lock file.) If the Ruby version is still unresolved, RuboCop will
-  # use the oldest officially supported Ruby version (currently Ruby 2.2).
+  # use the oldest officially supported Ruby version (currently Ruby 2.3).
   TargetRubyVersion: ~
   # What version of Rails is the inspected code using?  If a value is specified
   # for TargetRailsVersion then it is used. Acceptable values are specificed
@@ -650,6 +650,7 @@ Layout/HeredocArgumentClosingParenthesis:
                  Checks for the placement of the closing parenthesis in a
                  method call that passes a HEREDOC string as an argument.
   Enabled: false
+  StyleGuide: '#heredoc-argument-closing-parentheses'
   VersionAdded: '0.68'
 
 Layout/IndentAssignment:
@@ -756,9 +757,9 @@ Layout/IndentHeredoc:
   StyleGuide: '#squiggly-heredocs'
   Enabled: true
   VersionAdded: '0.49'
-  EnforcedStyle: auto_detection
+  VersionChanged: '0.69'
+  EnforcedStyle: squiggly
   SupportedStyles:
-    - auto_detection
     - squiggly
     - active_support
     - powerpack
@@ -1365,6 +1366,7 @@ Lint/HeredocMethodCallPosition:
                  Checks for the ordering of a method call where
                  the receiver of the call is a HEREDOC.
   Enabled: false
+  StyleGuide: '#heredoc-method-calls'
   VersionAdded: '0.68'
 
 Lint/ImplicitStringConcatenation:
@@ -2310,7 +2312,10 @@ Rails/LexicallyScopedActionFilter:
 
 Rails/LinkToBlank:
   Description: 'Checks that `link_to` with a `target: "_blank"` have a `rel: "noopener"` option passed to them.'
-  Reference: https://mathiasbynens.github.io/rel-noopener/
+  Reference:
+    - https://mathiasbynens.github.io/rel-noopener/
+    - https://html.spec.whatwg.org/multipage/links.html#link-type-noopener
+    - https://html.spec.whatwg.org/multipage/links.html#link-type-noreferrer
   Enabled: true
   VersionAdded: '0.62'
 
@@ -3128,12 +3133,9 @@ Style/FrozenStringLiteralComment:
                  to help transition to frozen string literals by default.
   Enabled: true
   VersionAdded: '0.36'
-  VersionChanged: '0.47'
-  EnforcedStyle: when_needed
+  VersionChanged: '0.69'
+  EnforcedStyle: always
   SupportedStyles:
-    # `when_needed` will add the frozen string literal comment to files
-    # only when the `TargetRubyVersion` is set to 2.3+.
-    - when_needed
     # `always` will always add the frozen string literal comment to a file
     # regardless of the Ruby version or if `freeze` or `<<` are called on a
     # string literal. If you run code against multiple versions of Ruby, it is
@@ -3505,6 +3507,20 @@ Style/NegatedIf:
     - prefix
     - postfix
 
+Style/NegatedUnless:
+  Description: 'Favor if over unless for negative conditions.'
+  StyleGuide: '#if-for-negatives'
+  Enabled: true
+  VersionAdded: '0.69'
+  EnforcedStyle: both
+  SupportedStyles:
+    # both: prefix and postfix negated `unless` should both use `if`
+    # prefix: only use `if` for negated `unless` statements positioned before the body of the statement
+    # postfix: only use `if` for negated `unless` statements positioned after the body of the statement
+    - both
+    - prefix
+    - postfix
+
 Style/NegatedWhile:
   Description: 'Favor until over while for negative conditions.'
   StyleGuide: '#until-for-negatives'

data/lib/rubocop.rb

@@ -464,6 +464,7 @@ require_relative 'rubocop/cop/style/multiline_ternary_operator'
 require_relative 'rubocop/cop/style/multiple_comparison'
 require_relative 'rubocop/cop/style/mutable_constant'
 require_relative 'rubocop/cop/style/negated_if'
+require_relative 'rubocop/cop/style/negated_unless'
 require_relative 'rubocop/cop/style/negated_while'
 require_relative 'rubocop/cop/style/nested_modifier'
 require_relative 'rubocop/cop/style/nested_parenthesized_calls'

data/lib/rubocop/ast/node.rb

@@ -459,12 +459,16 @@ module RuboCop
         loc.respond_to?(:begin) && loc.begin && loc.begin.is?('(')
       end
 
+      def call_type?
+        send_type? || csend_type?
+      end
+
       def chained?
-        parent && parent.send_type? && eql?(parent.receiver)
+        parent&.call_type? && eql?(parent.receiver)
       end
 
       def argument?
-        parent && parent.send_type? && parent.arguments.include?(self)
+        parent&.send_type? && parent.arguments.include?(self)
       end
 
       def numeric_type?

data/lib/rubocop/ast/node/array_node.rb

@@ -22,7 +22,7 @@ module RuboCop
       #
       # @return [Boolean] whether the array is enclosed in square brackets
       def square_brackets?
-        loc.begin && loc.begin.is?('[')
+        loc.begin&.is?('[')
       end
 
       # Checks whether the `array` literal is delimited by percent brackets.
@@ -40,7 +40,7 @@ module RuboCop
         if type
           loc.begin && loc.begin.source =~ PERCENT_LITERAL_TYPES[type]
         else
-          loc.begin && loc.begin.source.start_with?('%')
+          loc.begin&.source&.start_with?('%')
         end
       end
 

data/lib/rubocop/ast/node/block_node.rb

@@ -50,14 +50,14 @@ module RuboCop
       #
       # @return [Boolean] whether the `block` literal is enclosed in braces
       def braces?
-        loc.end && loc.end.is?('}')
+        loc.end&.is?('}')
       end
 
       # Checks whether the `block` literal is delimited by `do`-`end` keywords.
       #
       # @return [Boolean] whether the `block` literal is enclosed in `do`-`end`
       def keywords?
-        loc.end && loc.end.is?('end')
+        loc.end&.is?('end')
       end
 
       # The delimiters for this `block` literal.

data/lib/rubocop/ast/node/for_node.rb

@@ -17,7 +17,7 @@ module RuboCop
       #
       # @return [Boolean] whether the `for` node has a `do` keyword
       def do?
-        loc.begin && loc.begin.is?('do')
+        loc.begin&.is?('do')
       end
 
       # Checks whether this node body is a void context.

data/lib/rubocop/ast/node/hash_node.rb

@@ -102,7 +102,7 @@ module RuboCop
       #
       # @return [Boolean] whether the `hash` literal is enclosed in braces
       def braces?
-        loc.end && loc.end.is?('}')
+        loc.end&.is?('}')
       end
     end
   end

data/lib/rubocop/ast/node/if_node.rb

@@ -103,7 +103,7 @@ module RuboCop
       #
       # @return [Boolean] whether the `if` node has at least one `elsif` branch
       def elsif_conditional?
-        else_branch && else_branch.if_type? && else_branch.elsif?
+        else_branch&.if_type? && else_branch&.elsif?
       end
 
       # Returns the branch of the `if` node that gets evaluated when its

data/lib/rubocop/ast/node/keyword_splat_node.rb

@@ -8,7 +8,7 @@ module RuboCop
     class KeywordSplatNode < Node
       include HashElementNode
 
-      DOUBLE_SPLAT = '**'.freeze
+      DOUBLE_SPLAT = '**'
 
       # This is used for duck typing with `pair` nodes which also appear as
       # `hash` elements.

data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb

@@ -116,7 +116,7 @@ module RuboCop
       #
       # @return [Boolean] whether the receiver of this method dispatch is `self`
       def self_receiver?
-        receiver && receiver.self_type?
+        receiver&.self_type?
       end
 
       # Checks whether the *explicit* receiver of this method dispatch is a
@@ -125,7 +125,7 @@ module RuboCop
       # @return [Boolean] whether the receiver of this method dispatch
       #                   is a `const` node
       def const_receiver?
-        receiver && receiver.const_type?
+        receiver&.const_type?
       end
 
       # Checks whether the method dispatch is the implicit form of `#call`,
@@ -140,7 +140,7 @@ module RuboCop
       #
       # @return [Boolean] whether the dispatched method has a block
       def block_literal?
-        parent && parent.block_type? && eql?(parent.send_node)
+        parent&.block_type? && eql?(parent.send_node)
       end
 
       # Checks whether this node is an arithmetic operation

data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb

@@ -79,14 +79,14 @@ module RuboCop
       #
       # @return [Boolean] whether the receiver of this node is `self`
       def self_receiver?
-        receiver && receiver.self_type?
+        receiver&.self_type?
       end
 
       # Checks whether the *explicit* receiver of node is a `const` node.
       #
       # @return [Boolean] whether the receiver of this node is a `const` node
       def const_receiver?
-        receiver && receiver.const_type?
+        receiver&.const_type?
       end
 
       # Checks whether this is a negation method, i.e. `!` or keyword `not`.

data/lib/rubocop/ast/node/mixin/parameterized_node.rb

@@ -10,7 +10,7 @@ module RuboCop
       # @return [Boolean] whether this node's arguments are
       #                   wrapped in parentheses
       def parenthesized?
-        loc.end && loc.end.is?(')')
+        loc.end&.is?(')')
       end
 
       # A shorthand for getting the first argument of the node.

data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb

@@ -5,10 +5,10 @@ module RuboCop
     # Common functionality for nodes that are predicates:
     # `or`, `and` ...
     module PredicateOperatorNode
-      LOGICAL_AND  = '&&'.freeze
-      SEMANTIC_AND = 'and'.freeze
-      LOGICAL_OR   = '||'.freeze
-      SEMANTIC_OR  = 'or'.freeze
+      LOGICAL_AND  = '&&'
+      SEMANTIC_AND = 'and'
+      LOGICAL_OR   = '||'
+      SEMANTIC_OR  = 'or'
 
       # Returns the operator as a string.
       #

data/lib/rubocop/ast/node/pair_node.rb

@@ -8,10 +8,10 @@ module RuboCop
     class PairNode < Node
       include HashElementNode
 
-      HASH_ROCKET = '=>'.freeze
-      SPACED_HASH_ROCKET = ' => '.freeze
-      COLON = ':'.freeze
-      SPACED_COLON = ': '.freeze
+      HASH_ROCKET = '=>'
+      SPACED_HASH_ROCKET = ' => '
+      COLON = ':'
+      SPACED_COLON = ': '
 
       # Checks whether the `pair` uses a hash rocket delimiter.
       #

data/lib/rubocop/ast/node/until_node.rb

@@ -28,7 +28,7 @@ module RuboCop
       #
       # @return [Boolean] whether the `until` node has a `do` keyword
       def do?
-        loc.begin && loc.begin.is?('do')
+        loc.begin&.is?('do')
       end
     end
   end

data/lib/rubocop/ast/node/when_node.rb

@@ -39,7 +39,7 @@ module RuboCop
       #
       # @return [Boolean] whether the `when` node has a `then` keyword
       def then?
-        loc.begin && loc.begin.is?('then')
+        loc.begin&.is?('then')
       end
 
       # Returns the body of the `when` node.

data/lib/rubocop/ast/node/while_node.rb

@@ -28,7 +28,7 @@ module RuboCop
       #
       # @return [Boolean] whether the `until` node has a `do` keyword
       def do?
-        loc.begin && loc.begin.is?('do')
+        loc.begin&.is?('do')
       end
     end
   end

data/lib/rubocop/cli.rb

@@ -7,13 +7,13 @@ module RuboCop
   class CLI
     include Formatter::TextUtil
 
-    PHASE_1 = 'Phase 1 of 2: run Metrics/LineLength cop'.freeze
-    PHASE_2 = 'Phase 2 of 2: run all cops'.freeze
+    PHASE_1 = 'Phase 1 of 2: run Metrics/LineLength cop'
+    PHASE_2 = 'Phase 2 of 2: run all cops'
 
     PHASE_1_OVERRIDDEN = '(skipped because the default Metrics/LineLength:Max' \
-                         ' is overridden)'.freeze
+                         ' is overridden)'
     PHASE_1_DISABLED   = '(skipped because Metrics/LineLength is ' \
-                         'disabled)'.freeze
+                         'disabled)'
 
     STATUS_SUCCESS     = 0
     STATUS_OFFENSES    = 1
@@ -145,7 +145,7 @@ module RuboCop
 
         STATUS_ERROR
       else
-        description = <<-DESC.strip_indent
+        description = <<~DESC
           # The behavior of RuboCop can be controlled via the .rubocop.yml
           # configuration file. It makes it possible to enable/disable
           # certain cops (checks) and to alter their behavior if they accept
@@ -317,7 +317,7 @@ module RuboCop
 
       errors.each { |error| warn error }
 
-      warn <<-WARNING.strip_indent
+      warn <<~WARNING
         Errors are usually caused by RuboCop bugs.
         Please, report your problems to RuboCop's issue tracker.
         #{Gem.loaded_specs['rubocop'].metadata['bug_tracker_uri']}

data/lib/rubocop/comment_config.rb

@@ -4,11 +4,11 @@ module RuboCop
   # This class parses the special `rubocop:disable` comments in a source
   # and provides a way to check if each cop is enabled at arbitrary line.
   class CommentConfig
-    UNNEEDED_DISABLE = 'Lint/UnneededCopDisableDirective'.freeze
+    UNNEEDED_DISABLE = 'Lint/UnneededCopDisableDirective'
 
-    COP_NAME_PATTERN = '([A-Z]\w+/)?(?:[A-Z]\w+)'.freeze
-    COP_NAMES_PATTERN = "(?:#{COP_NAME_PATTERN} , )*#{COP_NAME_PATTERN}".freeze
-    COPS_PATTERN = "(all|#{COP_NAMES_PATTERN})".freeze
+    COP_NAME_PATTERN = '([A-Z]\w+/)?(?:[A-Z]\w+)'
+    COP_NAMES_PATTERN = "(?:#{COP_NAME_PATTERN} , )*#{COP_NAME_PATTERN}"
+    COPS_PATTERN = "(all|#{COP_NAMES_PATTERN})"
 
     COMMENT_DIRECTIVE_REGEXP = Regexp.new(
       ('# rubocop : ((?:dis|en)able)\b ' + COPS_PATTERN).gsub(' ', '\s*')
@@ -175,7 +175,7 @@ module RuboCop
     def handle_enable_all(names, extras, comment)
       enabled_cops = 0
       names.each do |name, counter|
-        next unless counter > 0
+        next unless counter.positive?
 
         names[name] -= 1
         enabled_cops += 1
@@ -189,7 +189,7 @@ module RuboCop
         names[name] ||= 0
         if disabled
           names[name] += 1
-        elsif names[name] > 0
+        elsif (names[name]).positive?
           names[name] -= 1
         else
           extras << [comment, name]

data/lib/rubocop/config.rb

@@ -19,11 +19,13 @@ module RuboCop
     INTERNAL_PARAMS = %w[Description StyleGuide VersionAdded
                          VersionChanged Reference Safe SafeAutoCorrect].freeze
 
-    # 2.2 is the oldest officially supported Ruby version.
-    DEFAULT_RUBY_VERSION = 2.2
-    KNOWN_RUBIES = [2.2, 2.3, 2.4, 2.5, 2.6].freeze
-    OBSOLETE_RUBIES = { 1.9 => '0.50', 2.0 => '0.50', 2.1 => '0.58' }.freeze
-    RUBY_VERSION_FILENAME = '.ruby-version'.freeze
+    # 2.3 is the oldest officially supported Ruby version.
+    DEFAULT_RUBY_VERSION = 2.3
+    KNOWN_RUBIES = [2.3, 2.4, 2.5, 2.6].freeze
+    OBSOLETE_RUBIES = {
+      1.9 => '0.50', 2.0 => '0.50', 2.1 => '0.58', 2.2 => '0.69'
+    }.freeze
+    RUBY_VERSION_FILENAME = '.ruby-version'
     DEFAULT_RAILS_VERSION = 5.0
     OBSOLETE_COPS = {
       'Style/FlipFlop' =>
@@ -570,7 +572,7 @@ module RuboCop
     end
 
     def obsolete_parameter_message(cop, parameter, alternative)
-      return unless self[cop] && self[cop].key?(parameter)
+      return unless self[cop]&.key?(parameter)
 
       "obsolete parameter #{parameter} (for #{cop}) " \
         "found in #{smart_loaded_path}" \

data/lib/rubocop/config_loader.rb

@@ -14,11 +14,11 @@ module RuboCop
   # during a run of the rubocop program, if files in several
   # directories are inspected.
   class ConfigLoader
-    DOTFILE = '.rubocop.yml'.freeze
-    XDG_CONFIG = 'config.yml'.freeze
+    DOTFILE = '.rubocop.yml'
+    XDG_CONFIG = 'config.yml'
     RUBOCOP_HOME = File.realpath(File.join(File.dirname(__FILE__), '..', '..'))
     DEFAULT_FILE = File.join(RUBOCOP_HOME, 'config', 'default.yml')
-    AUTO_GENERATED_FILE = '.rubocop_todo.yml'.freeze
+    AUTO_GENERATED_FILE = '.rubocop_todo.yml'
 
     class << self
       include FileFinder