rubocop 0.68.1 → 0.69.0

data/lib/rubocop/cop/style/random_with_offset.rb

@@ -25,7 +25,7 @@ module RuboCop
       #   rand(1...7)
       class RandomWithOffset < Cop
         MSG = 'Prefer ranges when generating random numbers instead of ' \
-          'integers with offsets.'.freeze
+          'integers with offsets.'
 
         def_node_matcher :integer_op_rand?, <<-PATTERN
           (send

data/lib/rubocop/cop/style/redundant_begin.rb

@@ -55,7 +55,7 @@ module RuboCop
       #     end
       #   end
       class RedundantBegin < Cop
-        MSG = 'Redundant `begin` block detected.'.freeze
+        MSG = 'Redundant `begin` block detected.'
 
         def on_def(node)
           check(node)
@@ -81,7 +81,7 @@ module RuboCop
         private
 
         def check(node)
-          return unless node.body && node.body.kwbegin_type?
+          return unless node.body&.kwbegin_type?
 
           add_offense(node.body, location: :begin)
         end

data/lib/rubocop/cop/style/redundant_conditional.rb

@@ -30,7 +30,7 @@ module RuboCop
         COMPARISON_OPERATORS = RuboCop::AST::Node::COMPARISON_OPERATORS
 
         MSG = 'This conditional expression can just be replaced ' \
-              'by `%<msg>s`.'.freeze
+              'by `%<msg>s`.'
 
         def on_if(node)
           return unless offense?(node)

data/lib/rubocop/cop/style/redundant_exception.rb

@@ -17,9 +17,9 @@ module RuboCop
       #   # Good
       #   raise 'message'
       class RedundantException < Cop
-        MSG_1 = 'Redundant `RuntimeError` argument can be removed.'.freeze
+        MSG_1 = 'Redundant `RuntimeError` argument can be removed.'
         MSG_2 = 'Redundant `RuntimeError.new` call can be replaced with ' \
-                'just the message.'.freeze
+                'just the message.'
 
         def on_send(node)
           exploded?(node) { return add_offense(node, message: MSG_1) }

data/lib/rubocop/cop/style/redundant_freeze.rb

@@ -15,7 +15,7 @@ module RuboCop
         include FrozenStringLiteral
 
         MSG = 'Do not freeze immutable objects, as freezing them has no ' \
-              'effect.'.freeze
+              'effect.'
 
         def on_send(node)
           return unless node.receiver && node.method?(:freeze) &&

data/lib/rubocop/cop/style/redundant_parentheses.rb

@@ -126,7 +126,7 @@ module RuboCop
         end
 
         def keyword_ancestor?(node)
-          node.parent && node.parent.keyword?
+          node.parent&.keyword?
         end
 
         def allowed_array_or_hash_element?(node)
@@ -140,11 +140,11 @@ module RuboCop
         end
 
         def hash_element?(node)
-          node.parent && node.parent.pair_type?
+          node.parent&.pair_type?
         end
 
         def array_element?(node)
-          node.parent && node.parent.array_type?
+          node.parent&.array_type?
         end
 
         def only_closing_paren_before_comma?(node)
@@ -163,13 +163,13 @@ module RuboCop
         def raised_to_power_negative_numeric?(begin_node, node)
           return false unless node.numeric_type?
 
-          siblings = begin_node.parent && begin_node.parent.children
+          siblings = begin_node.parent&.children
           return false if siblings.nil?
 
           next_sibling = siblings[begin_node.sibling_index + 1]
           base_value = node.children.first
 
-          base_value < 0 && next_sibling == :**
+          base_value.negative? && next_sibling == :**
         end
 
         def keyword_with_redundant_parentheses?(node)
@@ -213,7 +213,7 @@ module RuboCop
 
         def call_chain_starts_with_int?(begin_node, send_node)
           recv = first_part_of_call_chain(send_node)
-          recv && recv.int_type? && (parent = begin_node.parent) &&
+          recv&.int_type? && (parent = begin_node.parent) &&
             parent.send_type? && (parent.method?(:-@) || parent.method?(:+@))
         end
       end

data/lib/rubocop/cop/style/redundant_return.rb

@@ -38,8 +38,8 @@ module RuboCop
       class RedundantReturn < Cop
         include RangeHelp
 
-        MSG = 'Redundant `return` detected.'.freeze
-        MULTI_RETURN_MSG = 'To return multiple values, use an array.'.freeze
+        MSG = 'Redundant `return` detected.'
+        MULTI_RETURN_MSG = 'To return multiple values, use an array.'
 
         def on_def(node)
           return unless node.body
@@ -139,7 +139,7 @@ module RuboCop
           expressions = *node
           last_expr = expressions.last
 
-          return unless last_expr && last_expr.return_type?
+          return unless last_expr&.return_type?
 
           check_return_node(last_expr)
         end

data/lib/rubocop/cop/style/redundant_self.rb

@@ -42,7 +42,7 @@ module RuboCop
       #     end
       #   end
       class RedundantSelf < Cop
-        MSG = 'Redundant `self` detected.'.freeze
+        MSG = 'Redundant `self` detected.'
         KERNEL_METHODS = Kernel.methods(false)
 
         def self.autocorrect_incompatible_with
@@ -90,7 +90,7 @@ module RuboCop
 
         def on_send(node)
           return unless node.self_receiver? && regular_method_call?(node)
-          return if node.parent && node.parent.mlhs_type?
+          return if node.parent&.mlhs_type?
 
           return if allowed_send_node?(node)
 

data/lib/rubocop/cop/style/redundant_sort_by.rb

@@ -18,7 +18,7 @@ module RuboCop
       class RedundantSortBy < Cop
         include RangeHelp
 
-        MSG = 'Use `sort` instead of `sort_by { |%<var>s| %<var>s }`.'.freeze
+        MSG = 'Use `sort` instead of `sort_by { |%<var>s| %<var>s }`.'
 
         def_node_matcher :redundant_sort_by, <<-PATTERN
           (block $(send _ :sort_by) (args (arg $_x)) (lvar _x))

data/lib/rubocop/cop/style/regexp_literal.rb

@@ -85,8 +85,8 @@ module RuboCop
         include ConfigurableEnforcedStyle
         include RangeHelp
 
-        MSG_USE_SLASHES = 'Use `//` around regular expression.'.freeze
-        MSG_USE_PERCENT_R = 'Use `%r` around regular expression.'.freeze
+        MSG_USE_SLASHES = 'Use `//` around regular expression.'
+        MSG_USE_PERCENT_R = 'Use `%r` around regular expression.'
 
         def on_regexp(node)
           if slash_literal?(node)

data/lib/rubocop/cop/style/rescue_modifier.rb

@@ -19,7 +19,7 @@ module RuboCop
         include Alignment
         include RescueNode
 
-        MSG = 'Avoid using `rescue` in its modifier form.'.freeze
+        MSG = 'Avoid using `rescue` in its modifier form.'
 
         def on_resbody(node)
           return unless rescue_modifier?(node)

data/lib/rubocop/cop/style/rescue_standard_error.rb

@@ -76,9 +76,9 @@ module RuboCop
         include RangeHelp
 
         MSG_IMPLICIT = 'Omit the error class when rescuing ' \
-          '`StandardError` by itself.'.freeze
+          '`StandardError` by itself.'
         MSG_EXPLICIT = 'Avoid rescuing without specifying ' \
-          'an error class.'.freeze
+          'an error class.'
 
         def_node_matcher :rescue_without_error_class?, <<-PATTERN
           (resbody nil? _ _)

data/lib/rubocop/cop/style/return_nil.rb

@@ -31,8 +31,8 @@ module RuboCop
       class ReturnNil < Cop
         include ConfigurableEnforcedStyle
 
-        RETURN_MSG = 'Use `return` instead of `return nil`.'.freeze
-        RETURN_NIL_MSG = 'Use `return nil` instead of `return`.'.freeze
+        RETURN_MSG = 'Use `return` instead of `return nil`.'
+        RETURN_NIL_MSG = 'Use `return nil` instead of `return`.'
 
         def_node_matcher :return_node?, '(return)'
         def_node_matcher :return_nil_node?, '(return nil)'

data/lib/rubocop/cop/style/safe_navigation.rb

@@ -59,17 +59,14 @@ module RuboCop
       #   foo.baz + bar if foo
       #   foo.bar > 2 if foo
       class SafeNavigation < Cop
-        extend TargetRubyVersion
         include NilMethods
         include RangeHelp
 
         MSG = 'Use safe navigation (`&.`) instead of checking if an object ' \
-              'exists before calling the method.'.freeze
+              'exists before calling the method.'
         LOGIC_JUMP_KEYWORDS = %i[break fail next raise
                                  return throw yield].freeze
 
-        minimum_target_ruby_version 2.3
-
         # if format: (if checked_variable body nil)
         # unless format: (if checked_variable nil body)
         def_node_matcher :modifier_if_safe_navigation_candidate, <<-PATTERN
@@ -99,8 +96,6 @@ module RuboCop
         end
 
         def check_node(node)
-          return if target_ruby_version < 2.3
-
           checked_variable, receiver, method_chain, method = extract_parts(node)
           return unless receiver == checked_variable
           return if use_var_only_in_unless_modifier?(node, checked_variable)
@@ -229,7 +224,7 @@ module RuboCop
         end
 
         def method_called?(send_node)
-          send_node.parent && send_node.parent.send_type?
+          send_node.parent&.send_type?
         end
 
         def begin_range(node, method_call)

data/lib/rubocop/cop/style/sample.rb

@@ -28,7 +28,7 @@ module RuboCop
       #   [1, 2, 3].shuffle[foo, bar]
       #   [1, 2, 3].shuffle(random: Random.new)
       class Sample < Cop
-        MSG = 'Use `%<correct>s` instead of `%<incorrect>s`.'.freeze
+        MSG = 'Use `%<correct>s` instead of `%<incorrect>s`.'
 
         def_node_matcher :sample_candidate?, <<-PATTERN
           (send $(send _ :shuffle $...) ${:first :last :[] :at :slice} $...)

data/lib/rubocop/cop/style/self_assignment.rb

@@ -13,7 +13,7 @@ module RuboCop
       #   # good
       #   x += 1
       class SelfAssignment < Cop
-        MSG = 'Use self-assignment shorthand `%<method>s=`.'.freeze
+        MSG = 'Use self-assignment shorthand `%<method>s=`.'
         OPS = %i[+ - * ** / | &].freeze
 
         def self.autocorrect_incompatible_with

data/lib/rubocop/cop/style/semicolon.rb

@@ -18,7 +18,7 @@ module RuboCop
       class Semicolon < Cop
         include RangeHelp
 
-        MSG = 'Do not use semicolons to terminate expressions.'.freeze
+        MSG = 'Do not use semicolons to terminate expressions.'
 
         def investigate(processed_source)
           return if processed_source.blank?

data/lib/rubocop/cop/style/send.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   quuz.public_send(:fred)
       class Send < Cop
         MSG = 'Prefer `Object#__send__` or `Object#public_send` to ' \
-              '`send`.'.freeze
+              '`send`.'
 
         def_node_matcher :sending?, '({send csend} _ :send ...)'
 

data/lib/rubocop/cop/style/signal_exception.rb

@@ -107,9 +107,9 @@ module RuboCop
       class SignalException < Cop
         include ConfigurableEnforcedStyle
 
-        FAIL_MSG = 'Use `fail` instead of `raise` to signal exceptions.'.freeze
+        FAIL_MSG = 'Use `fail` instead of `raise` to signal exceptions.'
         RAISE_MSG = 'Use `raise` instead of `fail` to ' \
-                    'rethrow exceptions.'.freeze
+                    'rethrow exceptions.'
 
         def_node_matcher :kernel_call?, '(send (const nil? :Kernel) %1 ...)'
         def_node_search :custom_fail_methods,

data/lib/rubocop/cop/style/single_line_block_params.rb

@@ -29,7 +29,7 @@ module RuboCop
       #     c + d
       #   end
       class SingleLineBlockParams < Cop
-        MSG = 'Name `%<method>s` block params `|%<params>s|`.'.freeze
+        MSG = 'Name `%<method>s` block params `|%<params>s|`.'
 
         def on_block(node)
           return unless node.single_line?

data/lib/rubocop/cop/style/single_line_methods.rb

@@ -20,7 +20,7 @@ module RuboCop
       class SingleLineMethods < Cop
         include Alignment
 
-        MSG = 'Avoid single-line method definitions.'.freeze
+        MSG = 'Avoid single-line method definitions.'
 
         def on_def(node)
           return unless node.single_line?

data/lib/rubocop/cop/style/special_global_vars.rb

@@ -61,10 +61,10 @@ module RuboCop
 
         MSG_BOTH = 'Prefer `%<prefer>s` from the stdlib \'English\' ' \
         'module (don\'t forget to require it) or `%<regular>s` over ' \
-        '`%<global>s`.'.freeze
+        '`%<global>s`.'
         MSG_ENGLISH = 'Prefer `%<prefer>s` from the stdlib \'English\' ' \
-        'module (don\'t forget to require it) over `%<global>s`.'.freeze
-        MSG_REGULAR = 'Prefer `%<prefer>s` over `%<global>s`.'.freeze
+        'module (don\'t forget to require it) over `%<global>s`.'
+        MSG_REGULAR = 'Prefer `%<prefer>s` over `%<global>s`.'
 
         ENGLISH_VARS = { # rubocop:disable Style/MutableConstant
           :$: => [:$LOAD_PATH],
@@ -140,7 +140,7 @@ module RuboCop
           lambda do |corrector|
             global_var, = *node
 
-            while node.parent && node.parent.begin_type? &&
+            while node.parent&.begin_type? &&
                   node.parent.children.one?
               node = node.parent
             end
@@ -180,7 +180,7 @@ module RuboCop
         end
 
         def replacement(node, global_var)
-          parent_type = node.parent && node.parent.type
+          parent_type = node.parent&.type
           preferred_name = preferred_names(global_var).first
 
           unless %i[dstr xstr regexp].include?(parent_type)

data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb

@@ -22,9 +22,9 @@ module RuboCop
       class StabbyLambdaParentheses < Cop
         include ConfigurableEnforcedStyle
 
-        MSG_REQUIRE = 'Wrap stabby lambda arguments with parentheses.'.freeze
+        MSG_REQUIRE = 'Wrap stabby lambda arguments with parentheses.'
         MSG_NO_REQUIRE = 'Do not wrap stabby lambda arguments ' \
-                         'with parentheses.'.freeze
+                         'with parentheses.'
         def on_send(node)
           return unless stabby_lambda_with_args?(node)
           return unless redundant_parentheses?(node) ||

data/lib/rubocop/cop/style/stderr_puts.rb

@@ -19,7 +19,6 @@ module RuboCop
 
         MSG =
           'Use `warn` instead of `%<bad>s` to allow such output to be disabled.'
-          .freeze
 
         def_node_matcher :stderr_puts?, <<-PATTERN
           (send

data/lib/rubocop/cop/style/string_hash_keys.rb

@@ -13,7 +13,7 @@ module RuboCop
       #   # good
       #   { one: 1, two: 2, three: 3 }
       class StringHashKeys < Cop
-        MSG = 'Prefer symbols instead of strings as hash keys.'.freeze
+        MSG = 'Prefer symbols instead of strings as hash keys.'
 
         def_node_matcher :string_hash_key?, <<-PATTERN
           (pair (str _) _)
@@ -27,6 +27,7 @@ module RuboCop
             ^^^(send (const {nil? cbase} :Open3)
                 {:pipeline :pipeline_r :pipeline_rw :pipeline_start :pipeline_w} ...)
             ^^(send {nil? (const {nil? cbase} :Kernel)} {:spawn :system} ...)
+            ^^(send _ {:gsub :gsub!} ...)
           }
         PATTERN
 

data/lib/rubocop/cop/style/string_literals.rb

@@ -30,7 +30,7 @@ module RuboCop
         include ConfigurableEnforcedStyle
         include StringLiteralsHelp
 
-        MSG_INCONSISTENT = 'Inconsistent quote style.'.freeze
+        MSG_INCONSISTENT = 'Inconsistent quote style.'
 
         def on_dstr(node)
           # Strings which are continued across multiple lines using \

data/lib/rubocop/cop/style/string_methods.rb

@@ -17,7 +17,7 @@ module RuboCop
       class StringMethods < Cop
         include MethodPreference
 
-        MSG = 'Prefer `%<prefer>s` over `%<current>s`.'.freeze
+        MSG = 'Prefer `%<prefer>s` over `%<current>s`.'
 
         def on_send(node)
           return unless preferred_method(node.method_name)

data/lib/rubocop/cop/style/strip.rb

@@ -16,7 +16,7 @@ module RuboCop
       class Strip < Cop
         include RangeHelp
 
-        MSG = 'Use `strip` instead of `%<methods>s`.'.freeze
+        MSG = 'Use `strip` instead of `%<methods>s`.'
 
         def_node_matcher :lstrip_rstrip, <<-PATTERN
           {(send $(send _ $:rstrip) $:lstrip)

data/lib/rubocop/cop/style/struct_inheritance.rb

@@ -21,7 +21,7 @@ module RuboCop
       #   end
       class StructInheritance < Cop
         MSG = "Don't extend an instance initialized by `Struct.new`. " \
-              'Use a block to customize the struct.'.freeze
+              'Use a block to customize the struct.'
 
         def on_class(node)
           return unless struct_constructor?(node.parent_class)

data/lib/rubocop/cop/style/symbol_array.rb

@@ -33,8 +33,8 @@ module RuboCop
         include ConfigurableEnforcedStyle
         include PercentArray
 
-        PERCENT_MSG = 'Use `%i` or `%I` for an array of symbols.'.freeze
-        ARRAY_MSG = 'Use `[]` for an array of symbols.'.freeze
+        PERCENT_MSG = 'Use `%i` or `%I` for an array of symbols.'
+        ARRAY_MSG = 'Use `[]` for an array of symbols.'
 
         class << self
           attr_accessor :largest_brackets

data/lib/rubocop/cop/style/symbol_literal.rb

@@ -13,7 +13,7 @@ module RuboCop
       #   # good
       #   :symbol
       class SymbolLiteral < Cop
-        MSG = 'Do not use strings for word-like symbol literals.'.freeze
+        MSG = 'Do not use strings for word-like symbol literals.'
 
         def on_sym(node)
           return unless node.source =~ /\A:["'][A-Za-z_]\w*["']\z/

data/lib/rubocop/cop/style/symbol_proc.rb

@@ -16,7 +16,7 @@ module RuboCop
         include IgnoredMethods
 
         MSG = 'Pass `&:%<method>s` as an argument to `%<block_method>s` ' \
-              'instead of a block.'.freeze
+              'instead of a block.'
         SUPER_TYPES = %i[super zsuper].freeze
 
         def_node_matcher :proc_node?, '(send (const nil? :Proc) :new)'