rubocop 0.68.1 → 0.69.0

data/lib/rubocop/cop/style/class_check.rb

@@ -26,7 +26,7 @@ module RuboCop
       class ClassCheck < Cop
         include ConfigurableEnforcedStyle
 
-        MSG = 'Prefer `Object#%<prefer>s` over `Object#%<current>s`.'.freeze
+        MSG = 'Prefer `Object#%<prefer>s` over `Object#%<current>s`.'
 
         def_node_matcher :class_check?, '(send _ ${:is_a? :kind_of?} _)'
 

data/lib/rubocop/cop/style/class_methods.rb

@@ -21,7 +21,7 @@ module RuboCop
       #     end
       #   end
       class ClassMethods < Cop
-        MSG = 'Use `self.%<method>s` instead of `%<class>s.%<method>s`.'.freeze
+        MSG = 'Use `self.%<method>s` instead of `%<class>s.%<method>s`.'
 
         def on_class(node)
           return unless node.body

data/lib/rubocop/cop/style/class_vars.rb

@@ -32,7 +32,7 @@ module RuboCop
       #
       class ClassVars < Cop
         MSG = 'Replace class var %<class_var>s with a class ' \
-              'instance var.'.freeze
+              'instance var.'
 
         def on_cvasgn(node)
           add_offense(node, location: :name)

data/lib/rubocop/cop/style/collection_methods.rb

@@ -38,7 +38,7 @@ module RuboCop
       class CollectionMethods < Cop
         include MethodPreference
 
-        MSG = 'Prefer `%<prefer>s` over `%<current>s`.'.freeze
+        MSG = 'Prefer `%<prefer>s` over `%<current>s`.'
 
         def on_block(node)
           check_method_node(node.send_node)

data/lib/rubocop/cop/style/colon_method_call.rb

@@ -18,7 +18,7 @@ module RuboCop
       #   Marshal.dump(obj)
       #
       class ColonMethodCall < Cop
-        MSG = 'Do not use `::` for method calls.'.freeze
+        MSG = 'Do not use `::` for method calls.'
 
         def_node_matcher :java_type_node?, <<-PATTERN
           (send

data/lib/rubocop/cop/style/colon_method_definition.rb

@@ -20,7 +20,7 @@ module RuboCop
       #   end
       #
       class ColonMethodDefinition < Cop
-        MSG = 'Do not use `::` for defining class methods.'.freeze
+        MSG = 'Do not use `::` for defining class methods.'
 
         def on_defs(node)
           return unless node.loc.operator.source == '::'

data/lib/rubocop/cop/style/command_literal.rb

@@ -78,8 +78,8 @@ module RuboCop
       class CommandLiteral < Cop
         include ConfigurableEnforcedStyle
 
-        MSG_USE_BACKTICKS = 'Use backticks around command string.'.freeze
-        MSG_USE_PERCENT_X = 'Use `%x` around command string.'.freeze
+        MSG_USE_BACKTICKS = 'Use backticks around command string.'
+        MSG_USE_PERCENT_X = 'Use `%x` around command string.'
 
         def on_xstr(node)
           return if node.heredoc?

data/lib/rubocop/cop/style/comment_annotation.rb

@@ -36,9 +36,9 @@ module RuboCop
 
         MSG = 'Annotation keywords like `%<keyword>s` should be all ' \
               'upper case, followed by a colon, and a space, ' \
-              'then a note describing the problem.'.freeze
+              'then a note describing the problem.'
         MISSING_NOTE = 'Annotation comment, with keyword `%<keyword>s`, ' \
-                       'is missing a note.'.freeze
+                       'is missing a note.'
 
         def investigate(processed_source)
           processed_source.comments.each_with_index do |comment, index|

data/lib/rubocop/cop/style/commented_keyword.rb

@@ -36,7 +36,7 @@ module RuboCop
         include RangeHelp
 
         MSG = 'Do not place comments on the same line as the ' \
-              '`%<keyword>s` keyword.'.freeze
+              '`%<keyword>s` keyword.'
 
         def investigate(processed_source)
           heredoc_lines = extract_heredoc_lines(processed_source.ast)

data/lib/rubocop/cop/style/conditional_assignment.rb

@@ -8,10 +8,10 @@ module RuboCop
       module ConditionalAssignmentHelper
         extend NodePattern::Macros
 
-        EQUAL = '='.freeze
-        END_ALIGNMENT = 'Layout/EndAlignment'.freeze
-        ALIGN_WITH = 'EnforcedStyleAlignWith'.freeze
-        KEYWORD = 'keyword'.freeze
+        EQUAL = '='
+        END_ALIGNMENT = 'Layout/EndAlignment'
+        ALIGN_WITH = 'EnforcedStyleAlignWith'
+        KEYWORD = 'keyword'
 
         # `elsif` branches show up in the `node` as an `else`. We need
         # to recursively iterate over all `else` branches and consider all
@@ -72,7 +72,7 @@ module RuboCop
 
           elsif_branches << node.if_branch
 
-          if node.else_branch && node.else_branch.if_type?
+          if node.else_branch&.if_type?
             expand_elsif(node.else_branch, elsif_branches)
           else
             elsif_branches << node.else_branch
@@ -205,19 +205,19 @@ module RuboCop
         include IgnoredNode
 
         MSG = 'Use the return of the conditional for variable assignment ' \
-              'and comparison.'.freeze
+              'and comparison.'
         ASSIGN_TO_CONDITION_MSG =
-          'Assign variables inside of conditionals'.freeze
+          'Assign variables inside of conditionals'
         VARIABLE_ASSIGNMENT_TYPES =
           %i[casgn cvasgn gvasgn ivasgn lvasgn].freeze
         ASSIGNMENT_TYPES = VARIABLE_ASSIGNMENT_TYPES +
                            %i[and_asgn or_asgn op_asgn masgn].freeze
-        LINE_LENGTH = 'Metrics/LineLength'.freeze
-        INDENTATION_WIDTH = 'Layout/IndentationWidth'.freeze
-        ENABLED = 'Enabled'.freeze
-        MAX = 'Max'.freeze
-        SINGLE_LINE_CONDITIONS_ONLY = 'SingleLineConditionsOnly'.freeze
-        WIDTH = 'Width'.freeze
+        LINE_LENGTH = 'Metrics/LineLength'
+        INDENTATION_WIDTH = 'Layout/IndentationWidth'
+        ENABLED = 'Enabled'
+        MAX = 'Max'
+        SINGLE_LINE_CONDITIONS_ONLY = 'SingleLineConditionsOnly'
+        WIDTH = 'Width'
 
         def_node_matcher :condition?, '{if case}'
 
@@ -312,7 +312,7 @@ module RuboCop
           *_variable, assignment = *node
 
           # ignore pseudo-assignments without rhs in for nodes
-          return if node.parent && node.parent.for_type?
+          return if node.parent&.for_type?
 
           if assignment.begin_type? && assignment.children.one?
             assignment, = *assignment

data/lib/rubocop/cop/style/constant_visibility.rb

@@ -28,7 +28,7 @@ module RuboCop
       #
       class ConstantVisibility < Cop
         MSG = 'Explicitly make `%<constant_name>s` public or private using ' \
-              'either `#public_constant` or `#private_constant`.'.freeze
+              'either `#public_constant` or `#private_constant`.'
 
         def on_casgn(node)
           return unless class_or_module_scope?(node)

data/lib/rubocop/cop/style/copyright.rb

@@ -19,9 +19,9 @@ module RuboCop
         include RangeHelp
 
         MSG = 'Include a copyright notice matching /%<notice>s/ before ' \
-              'any code.'.freeze
+              'any code.'
         AUTOCORRECT_EMPTY_WARNING = 'An AutocorrectNotice must be defined in ' \
-                                    'your RuboCop config'.freeze
+                                    'your RuboCop config'
 
         def investigate(processed_source)
           return if notice.empty?

data/lib/rubocop/cop/style/date_time.rb

@@ -42,8 +42,8 @@ module RuboCop
       #   # good
       #   something.to_time
       class DateTime < Cop
-        CLASS_MSG = 'Prefer Time over DateTime.'.freeze
-        COERCION_MSG = 'Do not use #to_datetime.'.freeze
+        CLASS_MSG = 'Prefer Time over DateTime.'
+        COERCION_MSG = 'Do not use #to_datetime.'
 
         def_node_matcher :date_time?, <<-PATTERN
           (send (const {nil? (cbase)} :DateTime) ...)

data/lib/rubocop/cop/style/def_with_parentheses.rb

@@ -35,7 +35,7 @@ module RuboCop
       #   end
       class DefWithParentheses < Cop
         MSG = "Omit the parentheses in defs when the method doesn't accept " \
-              'any arguments.'.freeze
+              'any arguments.'
 
         def on_def(node)
           return if node.single_line?

data/lib/rubocop/cop/style/dir.rb

@@ -18,7 +18,7 @@ module RuboCop
       #   path = __dir__
       class Dir < Cop
         MSG = 'Use `__dir__` to get an absolute path to the current ' \
-              "file's directory.".freeze
+              "file's directory."
 
         def_node_matcher :dir_replacement?, <<-PATTERN
           {(send (const nil? :File) :expand_path (send (const nil? :File) :dirname  #file_keyword?))

data/lib/rubocop/cop/style/documentation.rb

@@ -27,7 +27,7 @@ module RuboCop
       class Documentation < Cop
         include DocumentationComment
 
-        MSG = 'Missing top-level %<type>s documentation comment.'.freeze
+        MSG = 'Missing top-level %<type>s documentation comment.'
 
         def_node_matcher :constant_definition?, '{class module casgn}'
         def_node_search :outer_module, '(const (const nil? _) _)'
@@ -75,7 +75,7 @@ module RuboCop
         # Note: How end-of-line comments are associated with code changed in
         # parser-2.2.0.4.
         def nodoc_comment?(node, require_all = false)
-          return false unless node && node.children.first
+          return false unless node&.children&.first
 
           nodoc = nodoc(node)
 

data/lib/rubocop/cop/style/documentation_method.rb

@@ -51,7 +51,7 @@ module RuboCop
         include DocumentationComment
         include DefNode
 
-        MSG = 'Missing method documentation comment.'.freeze
+        MSG = 'Missing method documentation comment.'
 
         def_node_matcher :module_function_node?, <<-PATTERN
           (send nil? :module_function ...)

data/lib/rubocop/cop/style/double_negation.rb

@@ -20,7 +20,7 @@ module RuboCop
       # As you're unlikely to write code that can accept values of any type
       # this is rarely a problem in practice.
       class DoubleNegation < Cop
-        MSG = 'Avoid the use of double negation (`!!`).'.freeze
+        MSG = 'Avoid the use of double negation (`!!`).'
 
         def_node_matcher :double_negative?, '(send (send _ :!) :!)'
 

data/lib/rubocop/cop/style/each_for_simple_loop.rb

@@ -24,7 +24,7 @@ module RuboCop
       #   10.times {}
       class EachForSimpleLoop < Cop
         MSG = 'Use `Integer#times` for a simple loop which iterates a fixed ' \
-              'number of times.'.freeze
+              'number of times.'
 
         def on_block(node)
           return unless offending_each_range(node)

data/lib/rubocop/cop/style/each_with_object.rb

@@ -19,7 +19,7 @@ module RuboCop
       class EachWithObject < Cop
         include RangeHelp
 
-        MSG = 'Use `each_with_object` instead of `%<method>s`.'.freeze
+        MSG = 'Use `each_with_object` instead of `%<method>s`.'
         METHODS = %i[inject reduce].freeze
 
         def_node_matcher :each_with_object_candidate?, <<-PATTERN
@@ -65,7 +65,7 @@ module RuboCop
         private
 
         def simple_method_arg?(method_arg)
-          method_arg && method_arg.basic_literal?
+          method_arg&.basic_literal?
         end
 
         # if the accumulator parameter is assigned to in the block,
@@ -86,7 +86,7 @@ module RuboCop
           return unless body
 
           return_value = body.begin_type? ? body.children.last : body
-          return_value if return_value && return_value.lvar_type?
+          return_value if return_value&.lvar_type?
         end
 
         def first_argument_returned?(args, return_value)

data/lib/rubocop/cop/style/empty_block_parameter.rb

@@ -25,7 +25,7 @@ module RuboCop
         include EmptyParameter
         include RangeHelp
 
-        MSG = 'Omit pipes for the empty block parameters.'.freeze
+        MSG = 'Omit pipes for the empty block parameters.'
 
         def on_block(node)
           send_node = node.send_node

data/lib/rubocop/cop/style/empty_case_condition.rb

@@ -39,7 +39,7 @@ module RuboCop
         include RangeHelp
 
         MSG = 'Do not use empty `case` condition, instead use an `if` '\
-              'expression.'.freeze
+              'expression.'
 
         def on_case(case_node)
           return if case_node.condition

data/lib/rubocop/cop/style/empty_else.rb

@@ -94,7 +94,7 @@ module RuboCop
         include ConfigurableEnforcedStyle
         include RangeHelp
 
-        MSG = 'Redundant `else`-clause.'.freeze
+        MSG = 'Redundant `else`-clause.'
 
         def on_normal_if_unless(node)
           check(node)
@@ -136,7 +136,7 @@ module RuboCop
         end
 
         def nil_check(node)
-          return unless node.else_branch && node.else_branch.nil_type?
+          return unless node.else_branch&.nil_type?
 
           add_offense(node, location: :else)
         end

data/lib/rubocop/cop/style/empty_lambda_parameter.rb

@@ -20,7 +20,7 @@ module RuboCop
         include EmptyParameter
         include RangeHelp
 
-        MSG = 'Omit parentheses for the empty lambda parameters.'.freeze
+        MSG = 'Omit parentheses for the empty lambda parameters.'
 
         def on_block(node)
           send_node = node.send_node

data/lib/rubocop/cop/style/empty_literal.rb

@@ -20,10 +20,10 @@ module RuboCop
         include FrozenStringLiteral
         include RangeHelp
 
-        ARR_MSG = 'Use array literal `[]` instead of `Array.new`.'.freeze
-        HASH_MSG = 'Use hash literal `{}` instead of `Hash.new`.'.freeze
+        ARR_MSG = 'Use array literal `[]` instead of `Array.new`.'
+        HASH_MSG = 'Use hash literal `{}` instead of `Hash.new`.'
         STR_MSG = 'Use string literal `%<prefer>s` instead of ' \
-                  '`String.new`.'.freeze
+                  '`String.new`.'
 
         def_node_matcher :array_node, '(send (const nil? :Array) :new)'
         def_node_matcher :hash_node, '(send (const nil? :Hash) :new)'

data/lib/rubocop/cop/style/empty_method.rb

@@ -43,9 +43,9 @@ module RuboCop
       class EmptyMethod < Cop
         include ConfigurableEnforcedStyle
 
-        MSG_COMPACT = 'Put empty method definitions on a single line.'.freeze
+        MSG_COMPACT = 'Put empty method definitions on a single line.'
         MSG_EXPANDED = 'Put the `end` of empty method definitions on the ' \
-                       'next line.'.freeze
+                       'next line.'
 
         def on_def(node)
           return if node.body || comment_lines?(node)

data/lib/rubocop/cop/style/encoding.rb

@@ -12,9 +12,9 @@ module RuboCop
       class Encoding < Cop
         include RangeHelp
 
-        MSG_UNNECESSARY = 'Unnecessary utf-8 encoding comment.'.freeze
+        MSG_UNNECESSARY = 'Unnecessary utf-8 encoding comment.'
         ENCODING_PATTERN = /#.*coding\s?[:=]\s?(?:UTF|utf)-8/.freeze
-        SHEBANG = '#!'.freeze
+        SHEBANG = '#!'
 
         def investigate(processed_source)
           return if processed_source.buffer.source.empty?

data/lib/rubocop/cop/style/end_block.rb

@@ -14,7 +14,7 @@ module RuboCop
       #
       class EndBlock < Cop
         MSG = 'Avoid the use of `END` blocks. ' \
-              'Use `Kernel#at_exit` instead.'.freeze
+              'Use `Kernel#at_exit` instead.'
 
         def on_postexe(node)
           add_offense(node, location: :keyword)

data/lib/rubocop/cop/style/eval_with_location.rb

@@ -33,9 +33,9 @@ module RuboCop
       #   RUBY
       class EvalWithLocation < Cop
         MSG = 'Pass `__FILE__` and `__LINE__` to `eval` method, ' \
-              'as they are used by backtraces.'.freeze
+              'as they are used by backtraces.'
         MSG_INCORRECT_LINE = 'Use `%<expected>s` instead of `%<actual>s`, ' \
-                             'as they are used by backtraces.'.freeze
+                             'as they are used by backtraces.'
 
         def_node_matcher :eval_without_location?, <<-PATTERN
           {
@@ -133,7 +133,7 @@ module RuboCop
         end
 
         def add_offense_for_different_line(node, line_node, line_diff)
-          sign = line_diff > 0 ? :+ : :-
+          sign = line_diff.positive? ? :+ : :-
           return if line_with_offset?(line_node, sign, line_diff.abs)
 
           add_offense(

data/lib/rubocop/cop/style/even_odd.rb

@@ -16,7 +16,7 @@ module RuboCop
       #   if x.even?
       #   end
       class EvenOdd < Cop
-        MSG = 'Replace with `Integer#%<method>s?`.'.freeze
+        MSG = 'Replace with `Integer#%<method>s?`.'
 
         def_node_matcher :even_odd_candidate?, <<-PATTERN
           (send

data/lib/rubocop/cop/style/expand_path_arguments.rb

@@ -44,12 +44,12 @@ module RuboCop
         include RangeHelp
 
         MSG = 'Use `expand_path(%<new_path>s%<new_default_dir>s)` instead of ' \
-              '`expand_path(%<current_path>s, __FILE__)`.'.freeze
+              '`expand_path(%<current_path>s, __FILE__)`.'
         PATHNAME_MSG = 'Use `Pathname(__dir__).expand_path` instead of ' \
-                       '`Pathname(__FILE__).parent.expand_path`.'.freeze
+                       '`Pathname(__FILE__).parent.expand_path`.'
         PATHNAME_NEW_MSG = 'Use `Pathname.new(__dir__).expand_path` ' \
                            'instead of ' \
-                           '`Pathname.new(__FILE__).parent.expand_path`.'.freeze
+                           '`Pathname.new(__FILE__).parent.expand_path`.'
 
         def_node_matcher :file_expand_path, <<-PATTERN
           (send

data/lib/rubocop/cop/style/for.rb

@@ -43,8 +43,8 @@ module RuboCop
         include RangeHelp
 
         EACH_LENGTH = 'each'.length
-        PREFER_EACH = 'Prefer `each` over `for`.'.freeze
-        PREFER_FOR = 'Prefer `for` over `each`.'.freeze
+        PREFER_EACH = 'Prefer `each` over `for`.'
+        PREFER_FOR = 'Prefer `for` over `each`.'
 
         def on_for(node)
           if style == :each

data/lib/rubocop/cop/style/format_string.rb

@@ -38,7 +38,7 @@ module RuboCop
       class FormatString < Cop
         include ConfigurableEnforcedStyle
 
-        MSG = 'Favor `%<prefer>s` over `%<current>s`.'.freeze
+        MSG = 'Favor `%<prefer>s` over `%<current>s`.'
 
         def_node_matcher :formatter, <<-PATTERN
         {