RubyGems - rubocop - Versions diffs - 0.68.1 → 0.69.0 - Mend

rubocop 0.68.1 → 0.69.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (472) hide show

data/lib/rubocop/cop/layout/space_around_operators.rb CHANGED

@@ -23,7 +23,7 @@ module RuboCop
         include RangeHelp
         IRREGULAR_METHODS = %i[[] ! []=].freeze
-        EXCESSIVE_SPACE = '  '.freeze
+        EXCESSIVE_SPACE = '  '
         def self.autocorrect_incompatible_with
           [Style::SelfAssignment]

data/lib/rubocop/cop/layout/space_before_block_braces.rb CHANGED

@@ -31,8 +31,8 @@ module RuboCop
         include ConfigurableEnforcedStyle
         include RangeHelp
-        MISSING_MSG = 'Space missing to the left of {.'.freeze
-        DETECTED_MSG = 'Space detected to the left of {.'.freeze
+        MISSING_MSG = 'Space missing to the left of {.'
+        DETECTED_MSG = 'Space detected to the left of {.'
         def self.autocorrect_incompatible_with
           [Style::SymbolProc]

data/lib/rubocop/cop/layout/space_before_comment.rb CHANGED

@@ -13,7 +13,7 @@ module RuboCop
       #   # good
       #   1 + 1 # this operation does ...
       class SpaceBeforeComment < Cop
-        MSG = 'Put a space before an end-of-line comment.'.freeze
+        MSG = 'Put a space before an end-of-line comment.'
         def investigate(processed_source)
           processed_source.tokens.each_cons(2) do |token1, token2|

data/lib/rubocop/cop/layout/space_before_first_arg.rb CHANGED

@@ -26,7 +26,7 @@ module RuboCop
         include RangeHelp
         MSG = 'Put one space between the method name and ' \
-              'the first argument.'.freeze
+              'the first argument.'
         def on_send(node)
           return unless regular_method_call_with_arguments?(node)

data/lib/rubocop/cop/layout/space_in_lambda_literal.rb CHANGED

@@ -24,9 +24,9 @@ module RuboCop
         include RangeHelp
         MSG_REQUIRE_SPACE = 'Use a space between `->` and ' \
-                            '`(` in lambda literals.'.freeze
+                            '`(` in lambda literals.'
         MSG_REQUIRE_NO_SPACE = 'Do not use spaces between `->` and ' \
-                               '`(` in lambda literals.'.freeze
+                               '`(` in lambda literals.'
         def on_send(node)
           return unless arrow_lambda_with_args?(node)
@@ -64,7 +64,8 @@ module RuboCop
         def space_after_arrow?(lambda_node)
           arrow = lambda_node.parent.children[0]
           parentheses = lambda_node.parent.children[1]
-          parentheses.source_range.begin_pos - arrow.source_range.end_pos > 0
+          (parentheses.source_range.begin_pos - arrow.source_range.end_pos)
+            .positive?
         end
         def range_of_offense(node)

data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb CHANGED

@@ -71,8 +71,8 @@ module RuboCop
         include SurroundingSpace
         include ConfigurableEnforcedStyle
-        MSG = '%<command>s space inside array brackets.'.freeze
-        EMPTY_MSG = '%<command>s space inside empty array brackets.'.freeze
+        MSG = '%<command>s space inside array brackets.'
+        EMPTY_MSG = '%<command>s space inside empty array brackets.'
         def on_array(node)
           return unless node.square_brackets?

data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb CHANGED

@@ -16,7 +16,7 @@ module RuboCop
         include MatchRange
         include PercentLiteral
-        MSG = 'Use only a single space inside array percent literal.'.freeze
+        MSG = 'Use only a single space inside array percent literal.'
         MULTIPLE_SPACES_BETWEEN_ITEMS_REGEX =
           /(?:[\S&&[^\\]](?:\\ )*)( {2,})(?=\S)/.freeze

data/lib/rubocop/cop/layout/space_inside_block_braces.rb CHANGED

@@ -185,7 +185,7 @@ module RuboCop
         end
         def pipe?(args_delimiter)
-          args_delimiter && args_delimiter.is?('|')
+          args_delimiter&.is?('|')
         end
         def space_inside_right_brace(right_brace)

data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb CHANGED

@@ -68,7 +68,7 @@ module RuboCop
         include ConfigurableEnforcedStyle
         include RangeHelp
-        MSG = 'Space inside %<problem>s.'.freeze
+        MSG = 'Space inside %<problem>s.'
         def on_hash(node)
           tokens = processed_source.tokens

data/lib/rubocop/cop/layout/space_inside_parens.rb CHANGED

@@ -36,8 +36,8 @@ module RuboCop
         include RangeHelp
         include ConfigurableEnforcedStyle
-        MSG       = 'Space inside parentheses detected.'.freeze
-        MSG_SPACE = 'No space inside parentheses detected.'.freeze
+        MSG       = 'Space inside parentheses detected.'
+        MSG_SPACE = 'No space inside parentheses detected.'
         def investigate(processed_source)
           @processed_source = processed_source

data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb CHANGED

@@ -20,7 +20,7 @@ module RuboCop
         include MatchRange
         include PercentLiteral
-        MSG = 'Do not use spaces inside percent literal delimiters.'.freeze
+        MSG = 'Do not use spaces inside percent literal delimiters.'
         BEGIN_REGEX = /\A( +)/.freeze
         END_REGEX = /(?<!\\)( +)\z/.freeze

data/lib/rubocop/cop/layout/space_inside_range_literal.rb CHANGED

@@ -18,7 +18,7 @@ module RuboCop
       #   # good
       #   'a'..'z'
       class SpaceInsideRangeLiteral < Cop
-        MSG = 'Space inside range literal.'.freeze
+        MSG = 'Space inside range literal.'
         def on_irange(node)
           check(node)

data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb CHANGED

@@ -57,8 +57,8 @@ module RuboCop
         include SurroundingSpace
         include ConfigurableEnforcedStyle
-        MSG = '%<command>s space inside reference brackets.'.freeze
-        EMPTY_MSG = '%<command>s space inside empty reference brackets.'.freeze
+        MSG = '%<command>s space inside reference brackets.'
+        EMPTY_MSG = '%<command>s space inside empty reference brackets.'
         BRACKET_METHODS = %i[[] []=].freeze

data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb CHANGED

@@ -22,8 +22,8 @@ module RuboCop
         include ConfigurableEnforcedStyle
         include RangeHelp
-        NO_SPACE_MSG = 'Space inside string interpolation detected.'.freeze
-        SPACE_MSG = 'Missing space around string interpolation detected.'.freeze
+        NO_SPACE_MSG = 'Space inside string interpolation detected.'
+        SPACE_MSG = 'Missing space around string interpolation detected.'
         def on_dstr(node)
           each_style_violation(node) do |final_node|

data/lib/rubocop/cop/layout/tab.rb CHANGED

@@ -24,7 +24,7 @@ module RuboCop
         include Alignment
         include RangeHelp
-        MSG = 'Tab detected.'.freeze
+        MSG = 'Tab detected.'
         def investigate(processed_source)
           str_ranges = string_literal_ranges(processed_source.ast)

data/lib/rubocop/cop/layout/trailing_blank_lines.rb CHANGED

@@ -88,7 +88,7 @@ module RuboCop
           return false if processed_source.tokens.empty?
           extra = buffer.source[processed_source.tokens.last.end_pos..-1]
-          extra && extra.strip.start_with?('__END__')
+          extra&.strip&.start_with?('__END__')
         end
         def message(wanted_blank_lines, blank_lines)

data/lib/rubocop/cop/layout/trailing_whitespace.rb CHANGED

@@ -17,7 +17,7 @@ module RuboCop
       class TrailingWhitespace < Cop
         include RangeHelp
-        MSG = 'Trailing whitespace detected.'.freeze
+        MSG = 'Trailing whitespace detected.'
         def investigate(processed_source)
           heredoc_ranges = extract_heredoc_ranges(processed_source.ast)

data/lib/rubocop/cop/lint/ambiguous_block_association.rb CHANGED

@@ -27,7 +27,7 @@ module RuboCop
       class AmbiguousBlockAssociation < Cop
         MSG = 'Parenthesize the param `%<param>s` to make sure that the ' \
               'block will be associated with the `%<method>s` method ' \
-              'call.'.freeze
+              'call.'
         def on_send(node)
           return if !node.arguments? || node.parenthesized? ||

data/lib/rubocop/cop/lint/ambiguous_operator.rb CHANGED

@@ -36,7 +36,7 @@ module RuboCop
         MSG_FORMAT = 'Ambiguous %<actual>s operator. Parenthesize the method ' \
                      "arguments if it's surely a %<actual>s operator, or add " \
                      'a whitespace to the right of the `%<operator>s` if it ' \
-                     'should be a %<possible>s.'.freeze
+                     'should be a %<possible>s.'
         private

data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb CHANGED

@@ -26,7 +26,7 @@ module RuboCop
         MSG = 'Ambiguous regexp literal. Parenthesize the method arguments ' \
               "if it's surely a regexp literal, or add a whitespace to the " \
-              'right of the `/` if it should be a division.'.freeze
+              'right of the `/` if it should be a division.'
         private

data/lib/rubocop/cop/lint/assignment_in_condition.rb CHANGED

@@ -27,10 +27,10 @@ module RuboCop
         MSG_WITH_SAFE_ASSIGNMENT_ALLOWED =
           'Use `==` if you meant to do a comparison or wrap the expression ' \
           'in parentheses to indicate you meant to assign in a ' \
-          'condition.'.freeze
+          'condition.'
         MSG_WITHOUT_SAFE_ASSIGNMENT_ALLOWED =
           'Use `==` if you meant to do a comparison or move the assignment ' \
-          'up out of the condition.'.freeze
+          'up out of the condition.'
         ASGN_TYPES = [:begin, *AST::Node::EQUALS_ASSIGNMENTS, :send].freeze
         def on_if(node)

data/lib/rubocop/cop/lint/big_decimal_new.rb CHANGED

@@ -16,7 +16,7 @@ module RuboCop
       #
       class BigDecimalNew < Cop
         MSG = '`%<double_colon>sBigDecimal.new()` is deprecated. ' \
-              'Use `%<double_colon>sBigDecimal()` instead.'.freeze
+              'Use `%<double_colon>sBigDecimal()` instead.'
         def_node_matcher :big_decimal_new, <<-PATTERN
           (send

data/lib/rubocop/cop/lint/boolean_symbol.rb CHANGED

@@ -23,7 +23,7 @@ module RuboCop
       #   false
       class BooleanSymbol < Cop
         MSG = 'Symbol with a boolean name - ' \
-              'you probably meant to use `%<boolean>s`.'.freeze
+              'you probably meant to use `%<boolean>s`.'
         def_node_matcher :boolean_symbol?, '(sym {:true :false})'

data/lib/rubocop/cop/lint/circular_argument_reference.rb CHANGED

@@ -48,7 +48,7 @@ module RuboCop
       #     dry_ingredients.combine
       #   end
       class CircularArgumentReference < Cop
-        MSG = 'Circular argument reference - `%<arg_name>s`.'.freeze
+        MSG = 'Circular argument reference - `%<arg_name>s`.'
         def on_kwoptarg(node)
           check_for_circular_argument_references(*node)

data/lib/rubocop/cop/lint/debugger.rb CHANGED

@@ -33,7 +33,7 @@ module RuboCop
       #     do_something
       #   end
       class Debugger < Cop
-        MSG = 'Remove debugger entry point `%<source>s`.'.freeze
+        MSG = 'Remove debugger entry point `%<source>s`.'
         def_node_matcher :kernel?, <<-PATTERN
           {

data/lib/rubocop/cop/lint/deprecated_class_methods.rb CHANGED

@@ -48,7 +48,7 @@ module RuboCop
           end
         end
-        MSG = '`%<current>s` is deprecated in favor of `%<prefer>s`.'.freeze
+        MSG = '`%<current>s` is deprecated in favor of `%<prefer>s`.'
         DEPRECATED_METHODS_OBJECT = [
           DeprecatedClassMethod.new(deprecated: :exists?,
                                     replacement: :exist?,

data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb CHANGED

@@ -23,7 +23,7 @@ module RuboCop
       #     @x = 1
       #   end
       class DisjunctiveAssignmentInConstructor < Cop
-        MSG = 'Unnecessary disjunctive assignment. Use plain assignment.'.freeze
+        MSG = 'Unnecessary disjunctive assignment. Use plain assignment.'
         def on_def(node)
           check(node)

data/lib/rubocop/cop/lint/duplicate_case_condition.rb CHANGED

@@ -28,7 +28,7 @@ module RuboCop
       #     do_something_else
       #   end
       class DuplicateCaseCondition < Cop
-        MSG = 'Duplicate `when` condition detected.'.freeze
+        MSG = 'Duplicate `when` condition detected.'
         def on_case(case_node)
           case_node.when_branches.each_with_object([]) do |when_node, previous|

data/lib/rubocop/cop/lint/duplicate_methods.rb CHANGED

@@ -51,7 +51,7 @@ module RuboCop
       #   alias bar foo
       class DuplicateMethods < Cop
         MSG = 'Method `%<method>s` is defined at both %<defined>s and ' \
-              '%<current>s.'.freeze
+              '%<current>s.'
         def initialize(config = nil, options = nil)
           super

data/lib/rubocop/cop/lint/duplicated_key.rb CHANGED

@@ -21,7 +21,7 @@ module RuboCop
       class DuplicatedKey < Cop
         include Duplication
-        MSG = 'Duplicated key in hash literal.'.freeze
+        MSG = 'Duplicated key in hash literal.'
         def on_hash(node)
           keys = node.keys.select(&:recursive_basic_literal?)

data/lib/rubocop/cop/lint/each_with_object_argument.rb CHANGED

@@ -22,7 +22,7 @@ module RuboCop
       #   num = 0
       #   sum = numbers.each_with_object(num) { |e, a| a += e }
       class EachWithObjectArgument < Cop
-        MSG = 'The argument to each_with_object can not be immutable.'.freeze
+        MSG = 'The argument to each_with_object can not be immutable.'
         def_node_matcher :each_with_object?, <<-PATTERN
           ({send csend} _ :each_with_object $_)

data/lib/rubocop/cop/lint/else_layout.rb CHANGED

@@ -28,7 +28,7 @@ module RuboCop
       #     do_that
       #   end
       class ElseLayout < Cop
-        MSG = 'Odd `else` layout detected. Did you mean to use `elsif`?'.freeze
+        MSG = 'Odd `else` layout detected. Did you mean to use `elsif`?'
         def on_if(node)
           return if node.ternary? || node.elsif?

data/lib/rubocop/cop/lint/empty_ensure.rb CHANGED

@@ -43,7 +43,7 @@ module RuboCop
       #     do_something_else
       #   end
       class EmptyEnsure < Cop
-        MSG = 'Empty `ensure` block detected.'.freeze
+        MSG = 'Empty `ensure` block detected.'
         def on_ensure(node)
           add_offense(node, location: :keyword) unless node.body

data/lib/rubocop/cop/lint/empty_expression.rb CHANGED

@@ -23,7 +23,7 @@ module RuboCop
       #     bar
       #   end
       class EmptyExpression < Cop
-        MSG = 'Avoid empty expressions.'.freeze
+        MSG = 'Avoid empty expressions.'
         def on_begin(node)
           return unless empty_expression?(node)

data/lib/rubocop/cop/lint/empty_interpolation.rb CHANGED

@@ -17,7 +17,7 @@ module RuboCop
       #
       #   "result is #{some_result}"
       class EmptyInterpolation < Cop
-        MSG = 'Empty interpolation detected.'.freeze
+        MSG = 'Empty interpolation detected.'
         def on_dstr(node)
           node.each_child_node(:begin) do |begin_node|

data/lib/rubocop/cop/lint/empty_when.rb CHANGED

@@ -23,7 +23,7 @@ module RuboCop
       #   when baz then 2
       #   end
       class EmptyWhen < Cop
-        MSG = 'Avoid `when` branches without a body.'.freeze
+        MSG = 'Avoid `when` branches without a body.'
         def on_case(node)
           node.each_when do |when_node|

data/lib/rubocop/cop/lint/end_in_method.rb CHANGED

@@ -28,7 +28,7 @@ module RuboCop
       #   # outside defs
       #   END { do_something }
       class EndInMethod < Cop
-        MSG = '`END` found in method definition. Use `at_exit` instead.'.freeze
+        MSG = '`END` found in method definition. Use `at_exit` instead.'
         def on_postexe(node)
           inside_of_method = node.each_ancestor(:def, :defs).count.nonzero?

data/lib/rubocop/cop/lint/ensure_return.rb CHANGED

@@ -29,7 +29,7 @@ module RuboCop
       #     do_something_else
       #   end
       class EnsureReturn < Cop
-        MSG = 'Do not return from an `ensure` block.'.freeze
+        MSG = 'Do not return from an `ensure` block.'
         def on_ensure(node)
           ensure_body = node.body

data/lib/rubocop/cop/lint/flip_flop.rb CHANGED

@@ -17,7 +17,7 @@ module RuboCop
       #     puts x if (x >= 5) && (x <= 10)
       #   end
       class FlipFlop < Cop
-        MSG = 'Avoid the use of flip-flop operators.'.freeze
+        MSG = 'Avoid the use of flip-flop operators.'
         def on_iflipflop(node)
           add_offense(node)

data/lib/rubocop/cop/lint/float_out_of_range.rb CHANGED

@@ -19,7 +19,7 @@ module RuboCop
       #
       #   float = 42.9
       class FloatOutOfRange < Cop
-        MSG = 'Float out of range.'.freeze
+        MSG = 'Float out of range.'
         def on_float(node)
           value, = *node

data/lib/rubocop/cop/lint/format_parameter_mismatch.rb CHANGED

@@ -21,14 +21,14 @@ module RuboCop
       class FormatParameterMismatch < Cop
         # http://rubular.com/r/CvpbxkcTzy
         MSG = "Number of arguments (%<arg_num>i) to `%<method>s` doesn't " \
-              'match the number of fields (%<field_num>i).'.freeze
+              'match the number of fields (%<field_num>i).'
         FIELD_REGEX =
           /(%(([\s#+-0\*]*)(\d*)?(\.\d+)?[bBdiouxXeEfgGaAcps]|%))/.freeze
         NAMED_FIELD_REGEX = /%\{[_a-zA-Z][_a-zA-Z]+\}/.freeze
-        KERNEL = 'Kernel'.freeze
-        SHOVEL = '<<'.freeze
-        PERCENT = '%'.freeze
-        PERCENT_PERCENT = '%%'.freeze
+        KERNEL = 'Kernel'
+        SHOVEL = '<<'
+        PERCENT = '%'
+        PERCENT_PERCENT = '%%'
         DIGIT_DOLLAR_FLAG = /%(\d+)\$/.freeze
         STRING_TYPES = %i[str dstr].freeze
         NAMED_INTERPOLATION = /%(?:<\w+>|\{\w+\})/.freeze
@@ -54,7 +54,7 @@ module RuboCop
         end
         def matched_arguments_count?(expected, passed)
-          if passed < 0
+          if passed.negative?
             expected < passed.abs
           else
             expected != passed
@@ -130,8 +130,7 @@ module RuboCop
           return 1 if node.source =~ NAMED_INTERPOLATION
           max_digit_dollar_num = max_digit_dollar_num(node)
-          return max_digit_dollar_num if max_digit_dollar_num &&
-                                         max_digit_dollar_num.nonzero?
+          return max_digit_dollar_num if max_digit_dollar_num&.nonzero?
           node
             .source