rubocop 0.68.1 → 0.69.0

data/lib/rubocop/cop/lint/handle_exceptions.rb

@@ -45,7 +45,7 @@ module RuboCop
       #     handle_exception
       #   end
       class HandleExceptions < Cop
-        MSG = 'Do not suppress exceptions.'.freeze
+        MSG = 'Do not suppress exceptions.'
 
         def on_resbody(node)
           add_offense(node) unless node.body

data/lib/rubocop/cop/lint/heredoc_method_call_position.rb

@@ -22,11 +22,11 @@ module RuboCop
       #
       #   # good
       #
-      #      <<-SQL.strip_indent
+      #      <<~SQL
       #        bar
       #      SQL
       #
-      #      <<-SQL.strip_indent.trim
+      #      <<~SQL.trim
       #        bar
       #      SQL
       #
@@ -34,9 +34,8 @@ module RuboCop
         include RangeHelp
 
         MSG = 'Put a method call with a HEREDOC receiver on the ' \
-        'same line as the HEREDOC opening.'.freeze
+        'same line as the HEREDOC opening.'
 
-        STRING_TYPES = %i[str dstr xstr].freeze
         def on_send(node)
           heredoc = heredoc_node_descendent_receiver(node)
           return unless heredoc
@@ -72,11 +71,11 @@ module RuboCop
         def send_node?(node)
           return nil unless node
 
-          node.send_type? || node.csend_type?
+          node.call_type?
         end
 
         def heredoc_node?(node)
-          node && STRING_TYPES.include?(node.type) && node.heredoc?
+          node.respond_to?(:heredoc?) && node.heredoc?
         end
 
         def call_after_heredoc_range(heredoc)

data/lib/rubocop/cop/lint/implicit_string_concatenation.rb

@@ -24,11 +24,11 @@ module RuboCop
       #   ]
       class ImplicitStringConcatenation < Cop
         MSG = 'Combine %<string1>s and %<string2>s into a single string ' \
-              'literal, rather than using implicit string concatenation.'.freeze
+              'literal, rather than using implicit string concatenation.'
         FOR_ARRAY = ' Or, if they were intended to be separate array ' \
-                    'elements, separate them with a comma.'.freeze
+                    'elements, separate them with a comma.'
         FOR_METHOD = ' Or, if they were intended to be separate method ' \
-                     'arguments, separate them with a comma.'.freeze
+                     'arguments, separate them with a comma.'
 
         def on_dstr(node)
           each_bad_cons(node) do |child_node1, child_node2|
@@ -36,9 +36,9 @@ module RuboCop
             message = format(MSG,
                              string1: display_str(child_node1),
                              string2: display_str(child_node2))
-            if node.parent && node.parent.array_type?
+            if node.parent&.array_type?
               message << FOR_ARRAY
-            elsif node.parent && node.parent.send_type?
+            elsif node.parent&.send_type?
               message << FOR_METHOD
             end
             add_offense(node, location: range, message: message)

data/lib/rubocop/cop/lint/ineffective_access_modifier.rb

@@ -47,11 +47,11 @@ module RuboCop
       #   end
       class IneffectiveAccessModifier < Cop
         MSG = '`%<modifier>s` (on line %<line>d) does not make singleton ' \
-              'methods %<modifier>s. Use %<alternative>s instead.'.freeze
+              'methods %<modifier>s. Use %<alternative>s instead.'
         ALTERNATIVE_PRIVATE = '`private_class_method` or `private` inside a ' \
-                              '`class << self` block'.freeze
+                              '`class << self` block'
         ALTERNATIVE_PROTECTED = '`protected` inside a `class << self` ' \
-                                'block'.freeze
+                                'block'
 
         def_node_search :private_class_methods, <<-PATTERN
           (send nil? :private_class_method $...)
@@ -68,7 +68,7 @@ module RuboCop
         private
 
         def check_node(node)
-          return unless node && node.begin_type?
+          return unless node&.begin_type?
 
           ignored_methods = private_class_method_names(node)
 

data/lib/rubocop/cop/lint/inherit_exception.rb

@@ -13,22 +13,30 @@ module RuboCop
       #
       #   class C < Exception; end
       #
+      #   C = Class.new(Exception)
+      #
       #   # good
       #
       #   class C < RuntimeError; end
       #
+      #   C = Class.new(RuntimeError)
+      #
       # @example EnforcedStyle: standard_error
       #   # bad
       #
       #   class C < Exception; end
       #
+      #   C = Class.new(Exception)
+      #
       #   # good
       #
       #   class C < StandardError; end
+      #
+      #   C = Class.new(StandardError)
       class InheritException < Cop
         include ConfigurableEnforcedStyle
 
-        MSG = 'Inherit from `%<prefer>s` instead of `%<current>s`.'.freeze
+        MSG = 'Inherit from `%<prefer>s` instead of `%<current>s`.'
         PREFERRED_BASE_CLASS = {
           runtime_error: 'RuntimeError',
           standard_error: 'StandardError'
@@ -47,6 +55,12 @@ module RuboCop
           SystemExit
         ].freeze
 
+        def_node_matcher :class_new_call?, <<-PATTERN
+          (send
+            (const {cbase nil?} :Class) :new
+            $(const {cbase nil?} _))
+        PATTERN
+
         def on_class(node)
           return unless node.parent_class &&
                         illegal_class_name?(node.parent_class)
@@ -54,6 +68,13 @@ module RuboCop
           add_offense(node.parent_class)
         end
 
+        def on_send(node)
+          constant = class_new_call?(node)
+          return unless constant && illegal_class_name?(constant)
+
+          add_offense(constant)
+        end
+
         def autocorrect(node)
           lambda do |corrector|
             corrector.replace(node.loc.expression, preferred_base_class)

data/lib/rubocop/cop/lint/interpolation_check.rb

@@ -18,7 +18,7 @@ module RuboCop
       #   foo = "something with #{interpolation} inside"
       class InterpolationCheck < Cop
         MSG = 'Interpolation in single quoted string detected. '\
-              'Use double quoted strings if you need interpolation.'.freeze
+              'Use double quoted strings if you need interpolation.'
 
         def on_str(node)
           return if heredoc?(node)

data/lib/rubocop/cop/lint/literal_as_condition.rb

@@ -31,7 +31,7 @@ module RuboCop
       #     do_something
       #   end
       class LiteralAsCondition < Cop
-        MSG = 'Literal `%<literal>s` appeared as a condition.'.freeze
+        MSG = 'Literal `%<literal>s` appeared as a condition.'
 
         def on_if(node)
           check_for_literal(node)

data/lib/rubocop/cop/lint/literal_in_interpolation.rb

@@ -20,7 +20,7 @@ module RuboCop
         include RangeHelp
         include PercentLiteral
 
-        MSG = 'Literal interpolation detected.'.freeze
+        MSG = 'Literal interpolation detected.'
         COMPOSITE = %i[array hash pair irange erange].freeze
 
         def on_dstr(node)

data/lib/rubocop/cop/lint/loop.rb

@@ -42,7 +42,7 @@ module RuboCop
       #   end
       class Loop < Cop
         MSG = 'Use `Kernel#loop` with `break` rather than ' \
-              '`begin/end/until`(or `while`).'.freeze
+              '`begin/end/until`(or `while`).'
 
         def on_while_post(node)
           register_offense(node)

data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb

@@ -46,9 +46,9 @@ module RuboCop
         include RangeHelp
 
         MSG = 'Re-enable %<cop>s cop with `# rubocop:enable` after ' \
-              'disabling it.'.freeze
+              'disabling it.'
         MSG_BOUND = 'Re-enable %<cop>s cop within %<max_range>s lines after ' \
-                    'disabling it.'.freeze
+                    'disabling it.'
 
         def investigate(processed_source)
           max_range = cop_config['MaximumRangeSize']

data/lib/rubocop/cop/lint/multiple_compare.rb

@@ -22,7 +22,7 @@ module RuboCop
       #   x < y && y < z
       #   10 <= x && x <= 20
       class MultipleCompare < Cop
-        MSG = 'Use the `&&` operator to compare multiple values.'.freeze
+        MSG = 'Use the `&&` operator to compare multiple values.'
 
         def_node_matcher :multiple_compare?, <<-PATTERN
           (send (send _ {:< :> :<= :>=} $_) {:< :> :<= :>=} _)

data/lib/rubocop/cop/lint/nested_method_definition.rb

@@ -56,7 +56,7 @@ module RuboCop
       #   end
       class NestedMethodDefinition < Cop
         MSG = 'Method definitions must not be nested. ' \
-              'Use `lambda` instead.'.freeze
+              'Use `lambda` instead.'
 
         def on_def(node)
           find_nested_defs(node) do |nested_def_node|

data/lib/rubocop/cop/lint/nested_percent_literal.rb

@@ -19,7 +19,7 @@ module RuboCop
         include PercentLiteral
 
         MSG = 'Within percent literals, nested percent literals do not ' \
-          'function and may be unwanted in the result.'.freeze
+          'function and may be unwanted in the result.'
 
         # The array of regular expressions representing percent literals that,
         # if found within a percent literal expression, will cause a

data/lib/rubocop/cop/lint/next_without_accumulator.rb

@@ -23,7 +23,7 @@ module RuboCop
       #     acc + i
       #   end
       class NextWithoutAccumulator < Cop
-        MSG = 'Use `next` with an accumulator argument in a `reduce`.'.freeze
+        MSG = 'Use `next` with an accumulator argument in a `reduce`.'
 
         def_node_matcher :on_body_of_reduce, <<-PATTERN
           (block (send _recv {:reduce :inject} !sym) _blockargs $(begin ...))

data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb

@@ -41,7 +41,7 @@ module RuboCop
       class NonLocalExitFromIterator < Cop
         MSG = 'Non-local exit from iterator, without return value. ' \
               '`next`, `break`, `Array#find`, `Array#any?`, etc. ' \
-              'is preferred.'.freeze
+              'is preferred.'
 
         def on_return(return_node)
           return if return_value?(return_node)

data/lib/rubocop/cop/lint/number_conversion.rb

@@ -29,14 +29,20 @@ module RuboCop
         MSG = 'Replace unsafe number conversion with number '\
               'class parsing, instead of using '\
               '%<number_object>s.%<to_method>s, use stricter '\
-              '%<corrected_method>s.'.freeze
+              '%<corrected_method>s.'
 
         def_node_matcher :to_method, <<-PATTERN
           (send $_ ${:to_i :to_f :to_c})
         PATTERN
 
+        def_node_matcher :datetime?, <<-PATTERN
+          (send (const {nil? (cbase)} {:Time :DateTime}) ...)
+        PATTERN
+
         def on_send(node)
           to_method(node) do |receiver, to_method|
+            next if date_time_object?(receiver)
+
             message = format(
               MSG,
               number_object: receiver.source,
@@ -49,6 +55,15 @@ module RuboCop
 
         private
 
+        def date_time_object?(node)
+          child = node
+          while child.send_type?
+            return true if datetime? child
+
+            child = child.children[0]
+          end
+        end
+
         def correct_method(node, receiver)
           format(CONVERSION_METHOD_CLASS_MAPPING[node.method_name],
                  number_object: receiver.source)

data/lib/rubocop/cop/lint/ordered_magic_comments.rb

@@ -31,7 +31,7 @@ module RuboCop
         include FrozenStringLiteral
 
         MSG = 'The encoding magic comment should precede all other ' \
-              'magic comments.'.freeze
+              'magic comments.'
 
         def investigate(processed_source)
           return if processed_source.buffer.source.empty?

data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb

@@ -20,7 +20,7 @@ module RuboCop
       class ParenthesesAsGroupedExpression < Cop
         include RangeHelp
 
-        MSG = '`(...)` interpreted as grouped expression.'.freeze
+        MSG = '`(...)` interpreted as grouped expression.'
 
         def on_send(node)
           return unless node.arguments.one?
@@ -29,7 +29,7 @@ module RuboCop
           return unless node.first_argument.source.start_with?('(')
 
           space_length = spaces_before_left_parenthesis(node)
-          return unless space_length > 0
+          return unless space_length.positive?
 
           range = space_range(node.first_argument.source_range, space_length)
 

data/lib/rubocop/cop/lint/percent_string_array.rb

@@ -28,7 +28,7 @@ module RuboCop
         TRAILING_QUOTE = /['"]?,?$/.freeze
 
         MSG = "Within `%w`/`%W`, quotes and ',' are unnecessary and may be " \
-          'unwanted in the resulting strings.'.freeze
+          'unwanted in the resulting strings.'
 
         def on_array(node)
           process(node, '%w', '%W')

data/lib/rubocop/cop/lint/percent_symbol_array.rb

@@ -24,7 +24,7 @@ module RuboCop
         include PercentLiteral
 
         MSG = "Within `%i`/`%I`, ':' and ',' are unnecessary and may be " \
-          'unwanted in the resulting symbols.'.freeze
+          'unwanted in the resulting symbols.'
 
         def on_array(node)
           process(node, '%i', '%I')

data/lib/rubocop/cop/lint/rand_one.rb

@@ -22,7 +22,7 @@ module RuboCop
       #   0 # just use 0 instead
       class RandOne < Cop
         MSG = '`%<method>s` always returns `0`. ' \
-              'Perhaps you meant `rand(2)` or `rand`?'.freeze
+              'Perhaps you meant `rand(2)` or `rand`?'
 
         def_node_matcher :rand_one?, <<-PATTERN
           (send {(const nil? :Kernel) nil?} :rand {(int {-1 1}) (float {-1.0 1.0})})

data/lib/rubocop/cop/lint/redundant_with_index.rb

@@ -29,8 +29,8 @@ module RuboCop
       class RedundantWithIndex < Cop
         include RangeHelp
 
-        MSG_EACH_WITH_INDEX = 'Use `each` instead of `each_with_index`.'.freeze
-        MSG_WITH_INDEX = 'Remove redundant `with_index`.'.freeze
+        MSG_EACH_WITH_INDEX = 'Use `each` instead of `each_with_index`.'
+        MSG_WITH_INDEX = 'Remove redundant `with_index`.'
 
         def_node_matcher :redundant_with_index?, <<-PATTERN
           (block

data/lib/rubocop/cop/lint/redundant_with_object.rb

@@ -30,8 +30,8 @@ module RuboCop
         include RangeHelp
 
         MSG_EACH_WITH_OBJECT = 'Use `each` instead of `each_with_object`.'
-                               .freeze
-        MSG_WITH_OBJECT = 'Remove redundant `with_object`.'.freeze
+
+        MSG_WITH_OBJECT = 'Remove redundant `with_object`.'
 
         def_node_matcher :redundant_with_object?, <<-PATTERN
           (block

data/lib/rubocop/cop/lint/regexp_as_condition.rb

@@ -18,7 +18,7 @@ module RuboCop
       #   end
       class RegexpAsCondition < Cop
         MSG = 'Do not use regexp literal as a condition.' \
-              ' The regexp literal matches `$_` implicitly.'.freeze
+              ' The regexp literal matches `$_` implicitly.'
 
         def on_match_current_line(node)
           add_offense(node)

data/lib/rubocop/cop/lint/require_parentheses.rb

@@ -31,7 +31,7 @@ module RuboCop
         include RangeHelp
 
         MSG = 'Use parentheses in the method call to avoid confusion about ' \
-              'precedence.'.freeze
+              'precedence.'
 
         def on_send(node)
           return if !node.arguments? || node.parenthesized?

data/lib/rubocop/cop/lint/rescue_exception.rb

@@ -26,7 +26,7 @@ module RuboCop
       #   end
       class RescueException < Cop
         MSG = 'Avoid rescuing the `Exception` class. ' \
-              'Perhaps you meant to rescue `StandardError`?'.freeze
+              'Perhaps you meant to rescue `StandardError`?'
 
         def on_resbody(node)
           return unless node.children.first

data/lib/rubocop/cop/lint/rescue_type.rb

@@ -38,7 +38,7 @@ module RuboCop
         include RescueNode
 
         MSG = 'Rescuing from `%<invalid_exceptions>s` will raise a ' \
-              '`TypeError` instead of catching the actual exception.'.freeze
+              '`TypeError` instead of catching the actual exception.'
         INVALID_TYPES = %i[array dstr float hash nil int str sym].freeze
 
         def on_resbody(node)

data/lib/rubocop/cop/lint/return_in_void_context.rb

@@ -32,14 +32,14 @@ module RuboCop
       #     return
       #   end
       class ReturnInVoidContext < Cop
-        MSG = 'Do not return a value in `%<method>s`.'.freeze
+        MSG = 'Do not return a value in `%<method>s`.'
 
         def on_return(return_node)
           return unless return_node.descendants.any?
 
           context_node = non_void_context(return_node)
 
-          return unless context_node && context_node.def_type?
+          return unless context_node&.def_type?
 
           method_name = method_name(context_node)
 

data/lib/rubocop/cop/lint/safe_navigation_chain.rb

@@ -25,10 +25,9 @@ module RuboCop
       #   x&.foo || bar
       class SafeNavigationChain < Cop
         include NilMethods
-        extend TargetRubyVersion
 
         MSG = 'Do not chain ordinary method call' \
-              ' after safe navigation operator.'.freeze
+              ' after safe navigation operator.'
 
         def_node_matcher :bad_method?, <<-PATTERN
         {
@@ -37,8 +36,6 @@ module RuboCop
         }
         PATTERN
 
-        minimum_target_ruby_version 2.3
-
         def on_send(node)
           bad_method?(node) do |safe_nav, method|
             return if nil_methods.include?(method)