rubocop 0.68.1 → 0.69.0

data/lib/rubocop/cop/style/frozen_string_literal_comment.rb

@@ -9,22 +9,7 @@ module RuboCop
       # after Ruby 3.0. The comment will be added below a shebang and encoding
       # comment. The frozen string literal comment is only valid in Ruby 2.3+.
       #
-      # @example EnforcedStyle: when_needed (default)
-      #   # The `when_needed` style will add the frozen string literal comment
-      #   # to files only when the `TargetRubyVersion` is set to 2.3+.
-      #   # bad
-      #   module Foo
-      #     # ...
-      #   end
-      #
-      #   # good
-      #   # frozen_string_literal: true
-      #
-      #   module Foo
-      #     # ...
-      #   end
-      #
-      # @example EnforcedStyle: always
+      # @example EnforcedStyle: always (default)
       #   # The `always` style will always add the frozen string literal comment
       #   # to a file, regardless of the Ruby version or if `freeze` or `<<` are
       #   # called on a string literal.
@@ -59,12 +44,11 @@ module RuboCop
         include FrozenStringLiteral
         include RangeHelp
 
-        MSG = 'Missing magic comment `# frozen_string_literal: true`.'.freeze
-        MSG_UNNECESSARY = 'Unnecessary frozen string literal comment.'.freeze
-        SHEBANG = '#!'.freeze
+        MSG = 'Missing magic comment `# frozen_string_literal: true`.'
+        MSG_UNNECESSARY = 'Unnecessary frozen string literal comment.'
+        SHEBANG = '#!'
 
         def investigate(processed_source)
-          return if style == :when_needed && target_ruby_version < 2.3
           return if processed_source.tokens.empty?
 
           if frozen_string_literal_comment_exists?
@@ -157,7 +141,7 @@ module RuboCop
           last_special_comment = last_special_comment(processed_source)
           following_line = processed_source.following_line(last_special_comment)
 
-          if following_line && following_line.empty?
+          if following_line&.empty?
             "\n#{FROZEN_STRING_LITERAL_ENABLED}"
           else
             "\n#{FROZEN_STRING_LITERAL_ENABLED}\n"

data/lib/rubocop/cop/style/global_vars.rb

@@ -20,7 +20,7 @@ module RuboCop
       #   foo = 2
       #   $stdin.read
       class GlobalVars < Cop
-        MSG = 'Do not introduce global variables.'.freeze
+        MSG = 'Do not introduce global variables.'
 
         # built-in global variables and their English aliases
         # https://www.zenspider.com/ruby/quickref.html

data/lib/rubocop/cop/style/guard_clause.rb

@@ -39,7 +39,7 @@ module RuboCop
         include MinBodyLength
 
         MSG = 'Use a guard clause instead of wrapping the code inside a ' \
-              'conditional expression.'.freeze
+              'conditional expression.'
 
         def on_def(node)
           body = node.body
@@ -83,8 +83,8 @@ module RuboCop
         end
 
         def contains_guard_clause?(node)
-          node.if_branch && node.if_branch.guard_clause? ||
-            node.else_branch && node.else_branch.guard_clause?
+          node.if_branch&.guard_clause? ||
+            node.else_branch&.guard_clause?
         end
       end
     end

data/lib/rubocop/cop/style/hash_syntax.rb

@@ -58,9 +58,9 @@ module RuboCop
         include ConfigurableEnforcedStyle
         include RangeHelp
 
-        MSG_19 = 'Use the new Ruby 1.9 hash syntax.'.freeze
-        MSG_NO_MIXED_KEYS = "Don't mix styles in the same hash.".freeze
-        MSG_HASH_ROCKETS = 'Use hash rockets syntax.'.freeze
+        MSG_19 = 'Use the new Ruby 1.9 hash syntax.'
+        MSG_NO_MIXED_KEYS = "Don't mix styles in the same hash."
+        MSG_HASH_ROCKETS = 'Use hash rockets syntax.'
 
         def on_hash(node)
           pairs = node.pairs

data/lib/rubocop/cop/style/identical_conditional_branches.rb

@@ -63,7 +63,7 @@ module RuboCop
       #     do_z
       #   end
       class IdenticalConditionalBranches < Cop
-        MSG = 'Move `%<source>s` out of the conditional.'.freeze
+        MSG = 'Move `%<source>s` out of the conditional.'
 
         def on_if(node)
           return if node.elsif?

data/lib/rubocop/cop/style/if_inside_else.rb

@@ -28,14 +28,14 @@ module RuboCop
       #     action_c
       #   end
       class IfInsideElse < Cop
-        MSG = 'Convert `if` nested inside `else` to `elsif`.'.freeze
+        MSG = 'Convert `if` nested inside `else` to `elsif`.'
 
         def on_if(node)
           return if node.ternary? || node.unless?
 
           else_branch = node.else_branch
 
-          return unless else_branch && else_branch.if_type? && else_branch.if?
+          return unless else_branch&.if_type? && else_branch&.if?
 
           add_offense(else_branch, location: :keyword)
         end

data/lib/rubocop/cop/style/if_unless_modifier.rb

@@ -26,7 +26,7 @@ module RuboCop
 
         MSG = 'Favor modifier `%<keyword>s` usage when having a single-line ' \
               'body. Another good alternative is the usage of control flow ' \
-              '`&&`/`||`.'.freeze
+              '`&&`/`||`.'
 
         ASSIGNMENT_TYPES = %i[lvasgn casgn cvasgn
                               gvasgn ivasgn masgn].freeze

data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb

@@ -25,7 +25,7 @@ module RuboCop
       class IfUnlessModifierOfIfUnless < Cop
         include StatementModifier
 
-        MSG = 'Avoid modifier `%<keyword>s` after another conditional.'.freeze
+        MSG = 'Avoid modifier `%<keyword>s` after another conditional.'
 
         def on_if(node)
           return unless node.modifier_form? && node.body.if_type?

data/lib/rubocop/cop/style/if_with_semicolon.rb

@@ -16,11 +16,11 @@ module RuboCop
       class IfWithSemicolon < Cop
         include OnNormalIfUnless
 
-        MSG = 'Do not use if x; Use the ternary operator instead.'.freeze
+        MSG = 'Do not use if x; Use the ternary operator instead.'
 
         def on_normal_if_unless(node)
           beginning = node.loc.begin
-          return unless beginning && beginning.is?(';')
+          return unless beginning&.is?(';')
 
           add_offense(node)
         end

data/lib/rubocop/cop/style/implicit_runtime_error.rb

@@ -16,7 +16,7 @@ module RuboCop
       #   raise ArgumentError, 'Error message here'
       class ImplicitRuntimeError < Cop
         MSG = 'Use `%<method>s` with an explicit exception class and message,' \
-              ' rather than just a message.'.freeze
+              ' rather than just a message.'
 
         def_node_matcher :implicit_runtime_error_raise_or_fail,
                          '(send nil? ${:raise :fail} {str dstr})'

data/lib/rubocop/cop/style/infinite_loop.rb

@@ -18,7 +18,7 @@ module RuboCop
       class InfiniteLoop < Cop
         LEADING_SPACE = /\A(\s*)/.freeze
 
-        MSG = 'Use `Kernel#loop` for infinite loops.'.freeze
+        MSG = 'Use `Kernel#loop` for infinite loops.'
 
         def join_force?(force_class)
           force_class == VariableForce

data/lib/rubocop/cop/style/inline_comment.rb

@@ -18,7 +18,7 @@ module RuboCop
       #     f.bar # Trailing inline comment
       #   end
       class InlineComment < Cop
-        MSG = 'Avoid trailing inline comments.'.freeze
+        MSG = 'Avoid trailing inline comments.'
 
         def investigate(processed_source)
           processed_source.each_comment do |comment|

data/lib/rubocop/cop/style/inverse_methods.rb

@@ -28,11 +28,16 @@ module RuboCop
       #   foo == bar
       #   !!('foo' =~ /^\w+$/)
       #   !(foo.class < Numeric) # Checking class hierarchy is allowed
+      #   # Blocks with guard clauses are ignored:
+      #   foo.select do |f|
+      #     next if f.zero?
+      #     f != 1
+      #   end
       class InverseMethods < Cop
         include IgnoredNode
         include RangeHelp
 
-        MSG = 'Use `%<inverse>s` instead of inverting `%<method>s`.'.freeze
+        MSG = 'Use `%<inverse>s` instead of inverting `%<method>s`.'
         CLASS_COMPARISON_METHODS = %i[<= >= < >].freeze
         EQUALITY_METHODS = %i[== != =~ !~ <= >= < >].freeze
         NEGATED_EQUALITY_METHODS = %i[!= !~].freeze
@@ -76,6 +81,7 @@ module RuboCop
           inverse_block?(node) do |_method_call, method, block|
             return unless inverse_blocks.key?(method)
             return if negated?(node) && negated?(node.parent)
+            return if node.each_node(:next).any?
 
             # Inverse method offenses inside of the block of an inverse method
             # offense, such as `y.reject { |key, _value| !(key =~ /c\d/) }`,

data/lib/rubocop/cop/style/ip_addresses.rb

@@ -22,7 +22,7 @@ module RuboCop
         include StringHelp
 
         IPV6_MAX_SIZE = 45 # IPv4-mapped IPv6 is the longest
-        MSG = 'Do not hardcode IP addresses.'.freeze
+        MSG = 'Do not hardcode IP addresses.'
 
         def offense?(node)
           contents = node.source[1...-1]

data/lib/rubocop/cop/style/lambda.rb

@@ -50,9 +50,9 @@ module RuboCop
         include ConfigurableEnforcedStyle
 
         LITERAL_MESSAGE = 'Use the `-> { ... }` lambda literal syntax for ' \
-                          '%<modifier>s lambdas.'.freeze
+                          '%<modifier>s lambdas.'
         METHOD_MESSAGE = 'Use the `lambda` method for %<modifier>s ' \
-                         'lambdas.'.freeze
+                         'lambdas.'
 
         OFFENDING_SELECTORS = {
           style: {

data/lib/rubocop/cop/style/line_end_concatenation.rb

@@ -23,7 +23,7 @@ module RuboCop
         include RangeHelp
 
         MSG = 'Use `\\` instead of `+` or `<<` to concatenate ' \
-              'those strings.'.freeze
+              'those strings.'
         CONCAT_TOKEN_TYPES = %i[tPLUS tLSHFT].freeze
         SIMPLE_STRING_TOKEN_TYPE = :tSTRING
         COMPLEX_STRING_EDGE_TOKEN_TYPES = %i[tSTRING_BEG tSTRING_END].freeze
@@ -94,7 +94,7 @@ module RuboCop
           begin_token, end_token = COMPLEX_STRING_EDGE_TOKEN_TYPES
           if successor.type == begin_token
             ends_to_find = 1
-            while ends_to_find > 0
+            while ends_to_find.positive?
               case processed_source.tokens[index].type
               when begin_token then ends_to_find += 1
               when end_token then ends_to_find -= 1

data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb

@@ -163,9 +163,9 @@ module RuboCop
         def message(_node = nil)
           case style
           when :require_parentheses
-            'Use parentheses for method calls with arguments.'.freeze
+            'Use parentheses for method calls with arguments.'
           when :omit_parentheses
-            'Omit parentheses for method calls with arguments.'.freeze
+            'Omit parentheses for method calls with arguments.'
           end
         end
 
@@ -327,7 +327,7 @@ module RuboCop
           return false unless cop_config['AllowParenthesesInChaining']
 
           previous = node.descendants.first
-          return false unless previous && previous.send_type?
+          return false unless previous&.send_type?
 
           previous.parenthesized? ||
             allowed_chained_call_with_parentheses?(previous)

data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb

@@ -15,7 +15,7 @@ module RuboCop
         include IgnoredMethods
 
         MSG = 'Do not use parentheses for method calls with ' \
-              'no arguments.'.freeze
+              'no arguments.'
 
         def on_send(node)
           return if ineligible_node?(node)

data/lib/rubocop/cop/style/method_called_on_do_end_block.rb

@@ -15,7 +15,7 @@ module RuboCop
       class MethodCalledOnDoEndBlock < Cop
         include RangeHelp
 
-        MSG = 'Avoid chaining a method call on a do...end block.'.freeze
+        MSG = 'Avoid chaining a method call on a do...end block.'
 
         def on_block(node)
           # If the method that is chained on the do...end block is itself a
@@ -31,7 +31,7 @@ module RuboCop
 
           receiver = node.receiver
 
-          return unless receiver && receiver.block_type? &&
+          return unless receiver&.block_type? &&
                         receiver.loc.end.is?('end')
 
           range = range_between(receiver.loc.end.begin_pos,

data/lib/rubocop/cop/style/method_def_parentheses.rb

@@ -88,9 +88,9 @@ module RuboCop
         include ConfigurableEnforcedStyle
         include RangeHelp
 
-        MSG_PRESENT = 'Use def without parentheses.'.freeze
+        MSG_PRESENT = 'Use def without parentheses.'
         MSG_MISSING = 'Use def with parentheses when there are ' \
-                      'parameters.'.freeze
+                      'parameters.'
 
         def on_def(node)
           args = node.arguments

data/lib/rubocop/cop/style/method_missing_super.rb

@@ -19,7 +19,7 @@ module RuboCop
       #     super
       #   end
       class MethodMissingSuper < Cop
-        MSG = 'When using `method_missing`, fall back on `super`.'.freeze
+        MSG = 'When using `method_missing`, fall back on `super`.'
 
         def on_def(node)
           return unless node.method?(:method_missing)

data/lib/rubocop/cop/style/min_max.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   bar = foo.minmax
       #   return foo.minmax
       class MinMax < Cop
-        MSG = 'Use `%<receiver>s.minmax` instead of `%<offender>s`.'.freeze
+        MSG = 'Use `%<receiver>s.minmax` instead of `%<offender>s`.'
 
         def on_array(node)
           min_max_candidate(node) do |receiver|

data/lib/rubocop/cop/style/missing_else.rb

@@ -97,11 +97,11 @@ module RuboCop
         include OnNormalIfUnless
         include ConfigurableEnforcedStyle
 
-        MSG = '`%<type>s` condition requires an `else`-clause.'.freeze
+        MSG = '`%<type>s` condition requires an `else`-clause.'
         MSG_NIL = '`%<type>s` condition requires an `else`-clause with ' \
-                  '`nil` in it.'.freeze
+                  '`nil` in it.'
         MSG_EMPTY = '`%<type>s` condition requires an empty ' \
-                    '`else`-clause.'.freeze
+                    '`else`-clause.'
 
         def on_normal_if_unless(node)
           return if case_style?

data/lib/rubocop/cop/style/missing_respond_to_missing.rb

@@ -23,7 +23,7 @@ module RuboCop
       #
       class MissingRespondToMissing < Cop
         MSG =
-          'When using `method_missing`, define `respond_to_missing?`.'.freeze
+          'When using `method_missing`, define `respond_to_missing?`.'
 
         def on_def(node)
           return unless node.method?(:method_missing)

data/lib/rubocop/cop/style/mixin_grouping.rb

@@ -34,7 +34,7 @@ module RuboCop
         include ConfigurableEnforcedStyle
 
         MIXIN_METHODS = %i[extend include prepend].freeze
-        MSG = 'Put `%<mixin>s` mixins in %<suffix>s.'.freeze
+        MSG = 'Put `%<mixin>s` mixins in %<suffix>s.'
 
         def on_class(node)
           begin_node = node.child_nodes.find(&:begin_type?) || node

data/lib/rubocop/cop/style/mixin_usage.rb

@@ -42,7 +42,7 @@ module RuboCop
       #   end
       class MixinUsage < Cop
         MSG = '`%<statement>s` is used at the top level. Use inside `class` ' \
-              'or `module`.'.freeze
+              'or `module`.'
 
         def_node_matcher :include_statement, <<-PATTERN
           (send nil? ${:include :extend :prepend}

data/lib/rubocop/cop/style/module_function.rb

@@ -52,16 +52,16 @@ module RuboCop
         include ConfigurableEnforcedStyle
 
         MODULE_FUNCTION_MSG =
-          'Use `module_function` instead of `extend self`.'.freeze
+          'Use `module_function` instead of `extend self`.'
         EXTEND_SELF_MSG =
-          'Use `extend self` instead of `module_function`.'.freeze
+          'Use `extend self` instead of `module_function`.'
 
         def_node_matcher :module_function_node?, '(send nil? :module_function)'
         def_node_matcher :extend_self_node?, '(send nil? :extend self)'
         def_node_matcher :private_directive?, '(send nil? :private ...)'
 
         def on_module(node)
-          return unless node.body && node.body.begin_type?
+          return unless node.body&.begin_type?
 
           each_wrong_style(node.body.children) do |child_node|
             add_offense(child_node)

data/lib/rubocop/cop/style/multiline_block_chain.rb

@@ -16,13 +16,13 @@ module RuboCop
       class MultilineBlockChain < Cop
         include RangeHelp
 
-        MSG = 'Avoid multi-line chains of blocks.'.freeze
+        MSG = 'Avoid multi-line chains of blocks.'
 
         def on_block(node)
           node.send_node.each_node(:send) do |send_node|
             receiver = send_node.receiver
 
-            next unless receiver && receiver.block_type? && receiver.multiline?
+            next unless receiver&.block_type? && receiver&.multiline?
 
             range = range_between(receiver.loc.end.begin_pos,
                                   node.send_node.source_range.end_pos)

data/lib/rubocop/cop/style/multiline_if_modifier.rb

@@ -19,7 +19,7 @@ module RuboCop
         include Alignment
 
         MSG = 'Favor a normal %<keyword>s-statement over a modifier' \
-              ' clause in a multiline statement.'.freeze
+              ' clause in a multiline statement.'
 
         def on_if(node)
           return unless node.modifier_form? && node.body.multiline?

data/lib/rubocop/cop/style/multiline_if_then.rb

@@ -22,7 +22,7 @@ module RuboCop
 
         NON_MODIFIER_THEN = /then\s*(#.*)?$/.freeze
 
-        MSG = 'Do not use `then` for multi-line `%<keyword>s`.'.freeze
+        MSG = 'Do not use `then` for multi-line `%<keyword>s`.'
 
         def on_normal_if_unless(node)
           return unless non_modifier_then?(node)

data/lib/rubocop/cop/style/multiline_memoization.rb

@@ -33,7 +33,7 @@ module RuboCop
       class MultilineMemoization < Cop
         include ConfigurableEnforcedStyle
 
-        MSG = 'Wrap multiline memoization blocks in `begin` and `end`.'.freeze
+        MSG = 'Wrap multiline memoization blocks in `begin` and `end`.'
 
         def on_or_asgn(node)
           _lhs, rhs = *node