RubyGems - rubocop - Versions diffs - 0.68.1 → 0.69.0 - Mend

rubocop 0.68.1 → 0.69.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (472) hide show

data/lib/rubocop/cop/lint/safe_navigation_consistency.rb CHANGED

@@ -31,10 +31,10 @@ module RuboCop
         include NilMethods
         MSG = 'Ensure that safe navigation is used consistently ' \
-          'inside of `&&` and `||`.'.freeze
+          'inside of `&&` and `||`.'
         def on_csend(node)
-          return unless node.parent && node.parent.operator_keyword?
+          return unless node.parent&.operator_keyword?
           check(node)
         end

data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb CHANGED

@@ -21,7 +21,7 @@ module RuboCop
       #
       class SafeNavigationWithEmpty < Cop
         MSG = 'Avoid calling `empty?` with the safe navigation operator ' \
-          'in conditionals.'.freeze
+          'in conditionals.'
         def_node_matcher :safe_navigation_empty_in_conditional?, <<-PATTERN
           (if (csend (send ...) :empty?) ...)

data/lib/rubocop/cop/lint/script_permission.rb CHANGED

@@ -31,8 +31,8 @@ module RuboCop
       #   puts 'hello, world'
       #
       class ScriptPermission < Cop
-        MSG = "Script file %<file>s doesn't have execute permission.".freeze
-        SHEBANG = '#!'.freeze
+        MSG = "Script file %<file>s doesn't have execute permission."
+        SHEBANG = '#!'
         def investigate(processed_source)
           return if @options.key?(:stdin)

data/lib/rubocop/cop/lint/shadowed_argument.rb CHANGED

@@ -65,7 +65,7 @@ module RuboCop
       #
       class ShadowedArgument < Cop
         MSG = 'Argument `%<argument>s` was shadowed by a local variable ' \
-              'before it was used.'.freeze
+              'before it was used.'
         def_node_search :uses_var?, '(lvar %)'

data/lib/rubocop/cop/lint/shadowed_exception.rb CHANGED

@@ -47,7 +47,7 @@ module RuboCop
         include RescueNode
         include RangeHelp
-        MSG = 'Do not shadow rescued Exceptions.'.freeze
+        MSG = 'Do not shadow rescued Exceptions.'
         def on_rescue(node)
           return if rescue_modifier?(node)

data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb CHANGED

@@ -32,7 +32,7 @@ module RuboCop
       #     end
       #   end
       class ShadowingOuterLocalVariable < Cop
-        MSG = 'Shadowing outer local variable - `%<variable>s`.'.freeze
+        MSG = 'Shadowing outer local variable - `%<variable>s`.'
         def join_force?(force_class)
           force_class == VariableForce

data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb CHANGED

@@ -18,9 +18,9 @@ module RuboCop
       #
       #   "result is #{something}"
       class StringConversionInInterpolation < Cop
-        MSG_DEFAULT = 'Redundant use of `Object#to_s` in interpolation.'.freeze
+        MSG_DEFAULT = 'Redundant use of `Object#to_s` in interpolation.'
         MSG_SELF = 'Use `self` instead of `Object#to_s` in ' \
-                   'interpolation.'.freeze
+                   'interpolation.'
         def_node_matcher :to_s_without_args?, '(send _ :to_s)'

data/lib/rubocop/cop/lint/to_json.rb CHANGED

@@ -19,7 +19,7 @@ module RuboCop
       #
       class ToJSON < Cop
         MSG = ' `#to_json` requires an optional argument to be parsable ' \
-          'via JSON.generate(obj).'.freeze
+          'via JSON.generate(obj).'
         def on_def(node)
           return unless node.method?(:to_json) && node.arguments.empty?

data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb CHANGED

@@ -41,7 +41,7 @@ module RuboCop
       #   end
       #
       class UnderscorePrefixedVariableName < Cop
-        MSG = 'Do not use prefix `_` for a variable that is used.'.freeze
+        MSG = 'Do not use prefix `_` for a variable that is used.'
         def join_force?(force_class)
           force_class == VariableForce

data/lib/rubocop/cop/lint/unified_integer.rb CHANGED

@@ -18,7 +18,7 @@ module RuboCop
       #
       #   1.is_a?(Integer)
       class UnifiedInteger < Cop
-        MSG = 'Use `Integer` instead of `%<klass>s`.'.freeze
+        MSG = 'Use `Integer` instead of `%<klass>s`.'
         def_node_matcher :fixnum_or_bignum_const, <<-PATTERN
           (:const {nil? (:cbase)} ${:Fixnum :Bignum})
@@ -33,6 +33,8 @@ module RuboCop
         end
         def autocorrect(node)
+          return false if target_ruby_version <= 2.3
           lambda do |corrector|
             corrector.replace(node.loc.name, 'Integer')
           end

data/lib/rubocop/cop/lint/unneeded_cop_disable_directive.rb CHANGED

@@ -29,7 +29,7 @@ module RuboCop
         include NameSimilarity
         include RangeHelp
-        COP_NAME = 'Lint/UnneededCopDisableDirective'.freeze
+        COP_NAME = 'Lint/UnneededCopDisableDirective'
         def check(offenses, cop_disabled_line_ranges, comments)
           unneeded_cops = Hash.new { |h, k| h[k] = Set.new }

data/lib/rubocop/cop/lint/unneeded_cop_enable_directive.rb CHANGED

@@ -36,7 +36,7 @@ module RuboCop
         include RangeHelp
         include SurroundingSpace
-        MSG = 'Unnecessary enabling of %<cop>s.'.freeze
+        MSG = 'Unnecessary enabling of %<cop>s.'
         def investigate(processed_source)
           return if processed_source.blank?

data/lib/rubocop/cop/lint/unneeded_require_statement.rb CHANGED

@@ -24,7 +24,7 @@ module RuboCop
       class UnneededRequireStatement < Cop
         include RangeHelp
-        MSG = 'Remove unnecessary `require` statement.'.freeze
+        MSG = 'Remove unnecessary `require` statement.'
         def_node_matcher :unnecessary_require_statement?, <<-PATTERN
           (send nil? :require

data/lib/rubocop/cop/lint/unneeded_splat_expansion.rb CHANGED

@@ -50,12 +50,12 @@ module RuboCop
       #     baz
       #   end
       class UnneededSplatExpansion < Cop
-        MSG = 'Replace splat expansion with comma separated values.'.freeze
-        ARRAY_PARAM_MSG = 'Pass array contents as separate arguments.'.freeze
-        PERCENT_W = '%w'.freeze
-        PERCENT_CAPITAL_W = '%W'.freeze
-        PERCENT_I = '%i'.freeze
-        PERCENT_CAPITAL_I = '%I'.freeze
+        MSG = 'Replace splat expansion with comma separated values.'
+        ARRAY_PARAM_MSG = 'Pass array contents as separate arguments.'
+        PERCENT_W = '%w'
+        PERCENT_CAPITAL_W = '%W'
+        PERCENT_I = '%i'
+        PERCENT_CAPITAL_I = '%I'
         ASSIGNMENT_TYPES = %i[lvasgn ivasgn cvasgn gvasgn].freeze
         def_node_matcher :array_new?, '$(send (const nil? :Array) :new ...)'
@@ -141,7 +141,7 @@ module RuboCop
           grandparent = node.parent.parent
           parent.when_type? || parent.send_type? || part_of_an_array?(node) ||
-            (grandparent && grandparent.resbody_type?)
+            (grandparent&.resbody_type?)
         end
         def remove_brackets(array)

data/lib/rubocop/cop/lint/unreachable_code.rb CHANGED

@@ -35,7 +35,7 @@ module RuboCop
       #     do_something
       #   end
       class UnreachableCode < Cop
-        MSG = 'Unreachable code detected.'.freeze
+        MSG = 'Unreachable code detected.'
         def on_begin(node)
           expressions = *node

data/lib/rubocop/cop/lint/unused_method_argument.rb CHANGED

@@ -44,7 +44,7 @@ module RuboCop
         end
         def message(variable)
-          message = String.new("Unused method argument - `#{variable.name}`.")
+          message = +"Unused method argument - `#{variable.name}`."
           unless variable.keyword_argument?
             message << " If it's necessary, use `_` or `_#{variable.name}` " \

data/lib/rubocop/cop/lint/uri_escape_unescape.rb CHANGED

@@ -43,7 +43,7 @@ module RuboCop
         MSG = '`%<uri_method>s` method is obsolete and should not be used. ' \
               'Instead, use %<replacements>s depending on your specific use ' \
-              'case.'.freeze
+              'case.'
         def_node_matcher :uri_escape_unescape?, <<-PATTERN
           (send

data/lib/rubocop/cop/lint/uri_regexp.rb CHANGED

@@ -16,7 +16,7 @@ module RuboCop
       class UriRegexp < Cop
         MSG = '`%<top_level>sURI.regexp%<arg>s` is obsolete and should not ' \
               'be used. Instead, use `%<top_level>sURI::DEFAULT_PARSER.' \
-              'make_regexp%<arg>s`.'.freeze
+              'make_regexp%<arg>s`.'
         def_node_matcher :uri_regexp_with_argument?, <<-PATTERN
           (send

data/lib/rubocop/cop/lint/useless_access_modifier.rb CHANGED

@@ -91,7 +91,7 @@ module RuboCop
       #     delegate :method_a, to: :method_b
       #   end
       class UselessAccessModifier < Cop
-        MSG = 'Useless `%<current>s` access modifier.'.freeze
+        MSG = 'Useless `%<current>s` access modifier.'
         def on_class(node)
           check_node(node.children[2]) # class body

data/lib/rubocop/cop/lint/useless_assignment.rb CHANGED

@@ -32,7 +32,7 @@ module RuboCop
       #   end
       class UselessAssignment < Cop
         include NameSimilarity
-        MSG = 'Useless assignment to variable - `%<variable>s`.'.freeze
+        MSG = 'Useless assignment to variable - `%<variable>s`.'
         def join_force?(force_class)
           force_class == VariableForce

data/lib/rubocop/cop/lint/useless_comparison.rb CHANGED

@@ -11,7 +11,7 @@ module RuboCop
       #
       #   x.top >= x.top
       class UselessComparison < Cop
-        MSG = 'Comparison of something with itself detected.'.freeze
+        MSG = 'Comparison of something with itself detected.'
         OPS = %w[== === != < > <= >= <=>].freeze
         def_node_matcher :useless_comparison?,

data/lib/rubocop/cop/lint/useless_else_without_rescue.rb CHANGED

@@ -29,7 +29,7 @@ module RuboCop
       class UselessElseWithoutRescue < Cop
         include ParserDiagnostic
-        MSG = '`else` without `rescue` is useless.'.freeze
+        MSG = '`else` without `rescue` is useless.'
         private

data/lib/rubocop/cop/lint/useless_setter_call.rb CHANGED

@@ -25,7 +25,7 @@ module RuboCop
       #     x
       #   end
       class UselessSetterCall < Cop
-        MSG = 'Useless setter call to local variable `%<variable>s`.'.freeze
+        MSG = 'Useless setter call to local variable `%<variable>s`.'
         ASSIGNMENT_TYPES = %i[lvasgn ivasgn cvasgn gvasgn].freeze
         def on_def(node)

data/lib/rubocop/cop/lint/void.rb CHANGED

@@ -60,13 +60,13 @@ module RuboCop
       #     do_something(some_array)
       #   end
       class Void < Cop
-        OP_MSG = 'Operator `%<op>s` used in void context.'.freeze
-        VAR_MSG = 'Variable `%<var>s` used in void context.'.freeze
-        LIT_MSG = 'Literal `%<lit>s` used in void context.'.freeze
-        SELF_MSG = '`self` used in void context.'.freeze
-        DEFINED_MSG = '`%<defined>s` used in void context.'.freeze
+        OP_MSG = 'Operator `%<op>s` used in void context.'
+        VAR_MSG = 'Variable `%<var>s` used in void context.'
+        LIT_MSG = 'Literal `%<lit>s` used in void context.'
+        SELF_MSG = '`self` used in void context.'
+        DEFINED_MSG = '`%<defined>s` used in void context.'
         NONMUTATING_MSG = 'Method `#%<method>s` used in void context. ' \
-          'Did you mean `#%<method>s!`?'.freeze
+          'Did you mean `#%<method>s!`?'
         BINARY_OPERATORS = %i[* / % + - == === != < > <= >= <=>].freeze
         UNARY_OPERATORS = %i[+@ -@ ~ !].freeze

data/lib/rubocop/cop/metrics/abc_size.rb CHANGED

@@ -11,7 +11,7 @@ module RuboCop
         include MethodComplexity
         MSG = 'Assignment Branch Condition size for %<method>s is too high. ' \
-              '[%<complexity>.4g/%<max>.4g]'.freeze
+              '[%<complexity>.4g/%<max>.4g]'
         private

data/lib/rubocop/cop/metrics/block_length.rb CHANGED

@@ -10,7 +10,7 @@ module RuboCop
       class BlockLength < Cop
         include TooManyLines
-        LABEL = 'Block'.freeze
+        LABEL = 'Block'
         def on_block(node)
           return if excluded_method?(node)
@@ -22,7 +22,7 @@ module RuboCop
         private
         def excluded_method?(node)
-          node_receiver = node.receiver && node.receiver.source.gsub(/\s+/, '')
+          node_receiver = node.receiver&.source&.gsub(/\s+/, '')
           node_method = String(node.method_name)
           excluded_methods.any? do |config|

data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb CHANGED

@@ -17,7 +17,7 @@ module RuboCop
         include MethodComplexity
         MSG = 'Cyclomatic complexity for %<method>s is too high. ' \
-              '[%<complexity>d/%<max>d]'.freeze
+              '[%<complexity>d/%<max>d]'
         COUNTED_NODES = %i[if while until for
                            rescue when and or].freeze

data/lib/rubocop/cop/metrics/line_length.rb CHANGED

@@ -58,7 +58,7 @@ module RuboCop
         include IgnoredPattern
         include RangeHelp
-        MSG = 'Line is too long. [%<length>d/%<max>d]'.freeze
+        MSG = 'Line is too long. [%<length>d/%<max>d]'
         def on_potential_breakable_node(node)
           check_for_breakable_node(node)

data/lib/rubocop/cop/metrics/method_length.rb CHANGED

@@ -9,7 +9,7 @@ module RuboCop
       class MethodLength < Cop
         include TooManyLines
-        LABEL = 'Method'.freeze
+        LABEL = 'Method'
         def on_def(node)
           excluded_methods = cop_config['ExcludedMethods']

data/lib/rubocop/cop/metrics/parameter_lists.rb CHANGED

@@ -10,7 +10,7 @@ module RuboCop
         include ConfigurableMax
         MSG = 'Avoid parameter lists longer than %<max>d parameters. ' \
-              '[%<count>d/%<max>d]'.freeze
+              '[%<count>d/%<max>d]'
         def on_args(node)
           count = args_count(node)

data/lib/rubocop/cop/metrics/perceived_complexity.rb CHANGED

@@ -30,7 +30,7 @@ module RuboCop
         include MethodComplexity
         MSG = 'Perceived complexity for %<method>s is too high. ' \
-              '[%<complexity>d/%<max>d]'.freeze
+              '[%<complexity>d/%<max>d]'
         COUNTED_NODES = %i[if case while until
                            for rescue and or].freeze

data/lib/rubocop/cop/mixin/alignment.rb CHANGED

@@ -7,7 +7,7 @@ module RuboCop
     module Alignment
       private
-      SPACE = ' '.freeze
+      SPACE = ' '
       attr_reader :column_delta

data/lib/rubocop/cop/mixin/check_assignment.rb CHANGED

@@ -31,7 +31,7 @@ module RuboCop
           _scope, _lhs, rhs = *node
         elsif node.op_asgn_type?
           _lhs, _op, rhs = *node
-        elsif node.send_type? || node.csend_type?
+        elsif node.call_type?
           rhs = node.last_argument
         elsif node.assignment?
           _lhs, rhs = *node

data/lib/rubocop/cop/mixin/empty_lines_around_body.rb CHANGED

@@ -11,10 +11,10 @@ module RuboCop
         include RangeHelp
         MSG_EXTRA = 'Extra empty line detected at %<kind>s body ' \
-                    '%<location>s.'.freeze
-        MSG_MISSING = 'Empty line missing at %<kind>s body %<location>s.'.freeze
+                    '%<location>s.'
+        MSG_MISSING = 'Empty line missing at %<kind>s body %<location>s.'
         MSG_DEFERRED = 'Empty line missing before first %<type>s ' \
-                       'definition'.freeze
+                       'definition'
         private

data/lib/rubocop/cop/mixin/end_keyword_alignment.rb CHANGED

@@ -8,7 +8,7 @@ module RuboCop
       include RangeHelp
       MSG = '`end` at %<end_line>d, %<end_col>d is not aligned with ' \
-            '`%<source>s` at %<align_line>d, %<align_col>d.'.freeze
+            '`%<source>s` at %<align_line>d, %<align_col>d.'
       private

data/lib/rubocop/cop/mixin/frozen_string_literal.rb CHANGED

@@ -6,8 +6,8 @@ module RuboCop
     module FrozenStringLiteral
       module_function
-      FROZEN_STRING_LITERAL = '# frozen_string_literal:'.freeze
-      FROZEN_STRING_LITERAL_ENABLED = '# frozen_string_literal: true'.freeze
+      FROZEN_STRING_LITERAL = '# frozen_string_literal:'
+      FROZEN_STRING_LITERAL_ENABLED = '# frozen_string_literal: true'
       FROZEN_STRING_LITERAL_TYPES = %i[str dstr].freeze
       def frozen_string_literal_comment_exists?
@@ -21,6 +21,7 @@ module RuboCop
       def frozen_string_literals_enabled?
         ruby_version = processed_source.ruby_version
         return false unless ruby_version
         # TODO: Ruby officially abandon making frozen string literals default
         # for Ruby 3.0.
         # https://bugs.ruby-lang.org/issues/11473#note-53
@@ -33,8 +34,6 @@ module RuboCop
         # And the above `ruby_version >= 3.1` is undecided whether it will be
         # Ruby 3.1, 3.2, 4.0 or others.
         # See https://bugs.ruby-lang.org/issues/8976#note-41 for details.
-        return false unless ruby_version >= 2.3
         leading_comment_lines.any? do |line|
           MagicComment.parse(line).frozen_string_literal?
         end

data/lib/rubocop/cop/mixin/min_body_length.rb CHANGED

@@ -12,7 +12,7 @@ module RuboCop
       def min_body_length
         length = cop_config['MinBodyLength'] || 1
-        return length if length.is_a?(Integer) && length > 0
+        return length if length.is_a?(Integer) && length.positive?
         raise 'MinBodyLength needs to be a positive integer!'
       end

data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb CHANGED

@@ -8,10 +8,10 @@ module RuboCop
       KEYWORD_ANCESTOR_TYPES  = %i[for if while until return].freeze
       UNALIGNED_RHS_TYPES     = %i[if while until for return
                                    array kwbegin].freeze
-      DEFAULT_MESSAGE_TAIL    = 'an expression'.freeze
-      ASSIGNMENT_MESSAGE_TAIL = 'an expression in an assignment'.freeze
+      DEFAULT_MESSAGE_TAIL    = 'an expression'
+      ASSIGNMENT_MESSAGE_TAIL = 'an expression in an assignment'
       KEYWORD_MESSAGE_TAIL    = 'a %<kind>s in %<article>s `%<keyword>s` ' \
-                                'statement'.freeze
+                                'statement'
       def on_send(node)
         return if !node.receiver || node.method?(:[])
@@ -31,7 +31,7 @@ module RuboCop
       #   b c { block }.            <-- b is indented relative to a
       #   d                         <-- d is indented relative to a
       def left_hand_side(lhs)
-        lhs = lhs.parent while lhs.parent && lhs.parent.send_type?
+        lhs = lhs.parent while lhs.parent&.send_type?
         lhs
       end