rubocop 0.68.1 → 0.69.0

data/lib/rubocop/cop/rails/delegate.rb

@@ -53,7 +53,7 @@ module RuboCop
       #   # good
       #   delegate :bar, to: :foo, prefix: true
       class Delegate < Cop
-        MSG = 'Use `delegate` to define delegations.'.freeze
+        MSG = 'Use `delegate` to define delegations.'
 
         def_node_matcher :delegate?, <<-PATTERN
           (def _method_name _args

data/lib/rubocop/cop/rails/delegate_allow_blank.rb

@@ -14,7 +14,7 @@ module RuboCop
       #   # good
       #   delegate :foo, to: :bar, allow_nil: true
       class DelegateAllowBlank < Cop
-        MSG = '`allow_blank` is not a valid option, use `allow_nil`.'.freeze
+        MSG = '`allow_blank` is not a valid option, use `allow_nil`.'
 
         def_node_matcher :allow_blank_option, <<-PATTERN
           (send nil? :delegate _ (hash <$(pair (sym :allow_blank) true) ...>))

data/lib/rubocop/cop/rails/dynamic_find_by.rb

@@ -26,7 +26,7 @@ module RuboCop
       #   # good
       #   User.find_by!(email: email)
       class DynamicFindBy < Cop
-        MSG = 'Use `%<static_name>s` instead of dynamic `%<method>s`.'.freeze
+        MSG = 'Use `%<static_name>s` instead of dynamic `%<method>s`.'
         METHOD_PATTERN = /^find_by_(.+?)(!)?$/.freeze
 
         def on_send(node)

data/lib/rubocop/cop/rails/enum_uniqueness.rb

@@ -21,7 +21,7 @@ module RuboCop
         include Duplication
 
         MSG = 'Duplicate value `%<value>s` found in `%<enum>s` ' \
-              'enum declaration.'.freeze
+              'enum declaration.'
 
         def_node_matcher :enum_declaration, <<-PATTERN
           (send nil? :enum (hash (pair (_ $_) ${array hash})))

data/lib/rubocop/cop/rails/environment_comparison.rb

@@ -16,10 +16,10 @@ module RuboCop
       #   # good
       #   Rails.env.production?
       class EnvironmentComparison < Cop
-        MSG = "Favor `Rails.env.%<env>s?` over `Rails.env == '%<env>s'`.".freeze
+        MSG = "Favor `Rails.env.%<env>s?` over `Rails.env == '%<env>s'`."
 
         SYM_MSG = 'Do not compare `Rails.env` with a symbol, it will always ' \
-          'evaluate to `false`.'.freeze
+          'evaluate to `false`.'
 
         def_node_matcher :environment_str_comparison?, <<-PATTERN
           (send

data/lib/rubocop/cop/rails/exit.rb

@@ -26,7 +26,7 @@ module RuboCop
       class Exit < Cop
         include ConfigurableEnforcedStyle
 
-        MSG = 'Do not use `exit` in Rails applications.'.freeze
+        MSG = 'Do not use `exit` in Rails applications.'
         TARGET_METHODS = %i[exit exit!].freeze
         EXPLICIT_RECEIVERS = %i[Kernel Process].freeze
 

data/lib/rubocop/cop/rails/file_path.rb

@@ -30,9 +30,9 @@ module RuboCop
         include RangeHelp
 
         MSG_SLASHES = 'Please use `Rails.root.join(\'path/to\')` ' \
-                      'instead.'.freeze
+                      'instead.'
         MSG_ARGUMENTS = 'Please use `Rails.root.join(\'path\', \'to\')` ' \
-                        'instead.'.freeze
+                        'instead.'
 
         def_node_matcher :file_join_nodes?, <<-PATTERN
           (send (const nil? :File) :join ...)

data/lib/rubocop/cop/rails/find_by.rb

@@ -16,7 +16,7 @@ module RuboCop
       class FindBy < Cop
         include RangeHelp
 
-        MSG = 'Use `find_by` instead of `where.%<method>s`.'.freeze
+        MSG = 'Use `find_by` instead of `where.%<method>s`.'
         TARGET_SELECTORS = %i[first take].freeze
 
         def_node_matcher :where_first?, <<-PATTERN

data/lib/rubocop/cop/rails/find_each.rb

@@ -13,7 +13,7 @@ module RuboCop
       #   # good
       #   User.all.find_each
       class FindEach < Cop
-        MSG = 'Use `find_each` instead of `each`.'.freeze
+        MSG = 'Use `find_each` instead of `each`.'
 
         SCOPE_METHODS = %i[
           all eager_load includes joins left_joins left_outer_joins not preload
@@ -22,8 +22,7 @@ module RuboCop
         IGNORED_METHODS = %i[order limit select].freeze
 
         def on_send(node)
-          return unless node.receiver &&
-                        node.receiver.send_type? &&
+          return unless node.receiver&.send_type? &&
                         node.method?(:each)
 
           return unless SCOPE_METHODS.include?(node.receiver.method_name)

data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb

@@ -12,7 +12,7 @@ module RuboCop
       #   # good
       #   # has_many :ingredients, through: :recipe_ingredients
       class HasAndBelongsToMany < Cop
-        MSG = 'Prefer `has_many :through` to `has_and_belongs_to_many`.'.freeze
+        MSG = 'Prefer `has_many :through` to `has_and_belongs_to_many`.'
 
         def on_send(node)
           return unless node.command?(:has_and_belongs_to_many)

data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb

@@ -21,7 +21,7 @@ module RuboCop
       #     has_many :patients, through: :appointments
       #   end
       class HasManyOrHasOneDependent < Cop
-        MSG = 'Specify a `:dependent` option.'.freeze
+        MSG = 'Specify a `:dependent` option.'
 
         def_node_search :active_resource_class?, <<-PATTERN
           (const (const nil? :ActiveResource) :Base)

data/lib/rubocop/cop/rails/http_positional_arguments.rb

@@ -20,7 +20,7 @@ module RuboCop
         extend TargetRailsVersion
 
         MSG = 'Use keyword arguments instead of ' \
-              'positional arguments for http call: `%<verb>s`.'.freeze
+              'positional arguments for http call: `%<verb>s`.'
         KEYWORD_ARGS = %i[
           method params session body flash xhr as headers env
         ].freeze

data/lib/rubocop/cop/rails/http_status.rb

@@ -89,9 +89,9 @@ module RuboCop
         # :nodoc:
         class SymbolicStyleChecker
           MSG = 'Prefer `%<prefer>s` over `%<current>s` ' \
-                'to define HTTP status code.'.freeze
+                'to define HTTP status code.'
           DEFAULT_MSG = 'Prefer `symbolic` over `numeric` ' \
-                        'to define HTTP status code.'.freeze
+                        'to define HTTP status code.'
 
           attr_reader :node
           def initialize(node)
@@ -133,9 +133,9 @@ module RuboCop
         # :nodoc:
         class NumericStyleChecker
           MSG = 'Prefer `%<prefer>s` over `%<current>s` ' \
-                'to define HTTP status code.'.freeze
+                'to define HTTP status code.'
           DEFAULT_MSG = 'Prefer `numeric` over `symbolic` ' \
-                        'to define HTTP status code.'.freeze
+                        'to define HTTP status code.'
           PERMITTED_STATUS = %i[error success missing redirect].freeze
 
           attr_reader :node

data/lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb

@@ -38,7 +38,7 @@ module RuboCop
       #
       # @see https://api.rubyonrails.org/classes/AbstractController/Callbacks/ClassMethods.html#method-i-_normalize_callback_options
       class IgnoredSkipActionFilterOption < Cop
-        MSG = <<-MSG.strip_indent.chomp.freeze
+        MSG = <<~MSG.chomp.freeze
           `%<ignore>s` option will be ignored when `%<prefer>s` and `%<ignore>s` are used together.
         MSG
 

data/lib/rubocop/cop/rails/inverse_of.rb

@@ -133,9 +133,9 @@ module RuboCop
 
         minimum_target_rails_version 4.1
 
-        SPECIFY_MSG = 'Specify an `:inverse_of` option.'.freeze
+        SPECIFY_MSG = 'Specify an `:inverse_of` option.'
         NIL_MSG = 'You specified `inverse_of: nil`, you probably meant to ' \
-          'use `inverse_of: false`.'.freeze
+          'use `inverse_of: false`.'
 
         def_node_matcher :association_recv_arguments, <<-PATTERN
           (send $_ {:has_many :has_one :belongs_to} _ $...)

data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb

@@ -83,7 +83,7 @@ module RuboCop
       #     end
       #   end
       class LexicallyScopedActionFilter < Cop
-        MSG = '%<action>s not explicitly defined on the %<type>s.'.freeze
+        MSG = '%<action>s not explicitly defined on the %<type>s.'
 
         FILTERS = %w[
           :after_action

data/lib/rubocop/cop/rails/link_to_blank.rb

@@ -8,14 +8,20 @@ module RuboCop
       # risk as the loaded page will have control over the previous page
       # and could change its location for phishing purposes.
       #
+      # The option `rel: 'noreferrer'` also blocks this behavior
+      # and removes the http-referrer header.
+      #
       # @example
       #   # bad
       #   link_to 'Click here', url, target: '_blank'
       #
       #   # good
       #   link_to 'Click here', url, target: '_blank', rel: 'noopener'
+      #
+      #   # good
+      #   link_to 'Click here', url, target: '_blank', rel: 'noreferrer'
       class LinkToBlank < Cop
-        MSG = 'Specify a `:rel` option containing noopener.'.freeze
+        MSG = 'Specify a `:rel` option containing noopener.'
 
         def_node_matcher :blank_target?, <<-PATTERN
           (pair {(sym :target) (str "target")} {(str "_blank") (sym :_blank)})
@@ -83,7 +89,8 @@ module RuboCop
         def contains_noopener?(value)
           return false unless value
 
-          value.to_s.split(' ').include?('noopener')
+          rel_array = value.to_s.split(' ')
+          rel_array.include?('noopener') || rel_array.include?('noreferrer')
         end
       end
     end

data/lib/rubocop/cop/rails/not_null_column.rb

@@ -17,7 +17,7 @@ module RuboCop
       #   add_reference :products, :category
       #   add_reference :products, :category, null: false, default: 1
       class NotNullColumn < Cop
-        MSG = 'Do not add a NOT NULL column without a default value.'.freeze
+        MSG = 'Do not add a NOT NULL column without a default value.'
 
         def_node_matcher :add_not_null_column?, <<-PATTERN
           (send nil? :add_column _ _ _ (hash $...))

data/lib/rubocop/cop/rails/output.rb

@@ -15,7 +15,7 @@ module RuboCop
       #   Rails.logger.debug 'A debug message'
       class Output < Cop
         MSG = 'Do not write to stdout. ' \
-              "Use Rails's logger if you want to log.".freeze
+              "Use Rails's logger if you want to log."
 
         def_node_matcher :output?, <<-PATTERN
           (send nil? {:ap :p :pp :pretty_print :print :puts} ...)

data/lib/rubocop/cop/rails/output_safety.rb

@@ -63,7 +63,7 @@ module RuboCop
       #   # => ActiveSupport::SafeBuffer
       #   #    "&lt;b&gt;hi&lt;/b&gt; <span>&lt;b&gt;hi&lt;/b&gt;</span>"
       class OutputSafety < Cop
-        MSG = 'Tagging a string as html safe may be a security risk.'.freeze
+        MSG = 'Tagging a string as html safe may be a security risk.'
 
         def on_send(node)
           return if non_interpolated_string?(node)
@@ -79,7 +79,7 @@ module RuboCop
         private
 
         def non_interpolated_string?(node)
-          node.receiver && node.receiver.str_type? && !node.receiver.dstr_type?
+          node.receiver&.str_type? && !node.receiver.dstr_type?
         end
 
         def looks_like_rails_html_safe?(node)

data/lib/rubocop/cop/rails/pluralization_grammar.rb

@@ -26,7 +26,7 @@ module RuboCop
 
         PLURAL_DURATION_METHODS = SINGULAR_DURATION_METHODS.invert.freeze
 
-        MSG = 'Prefer `%<number>s.%<correct>s`.'.freeze
+        MSG = 'Prefer `%<number>s.%<correct>s`.'
 
         def on_send(node)
           return unless duration_method?(node.method_name)

data/lib/rubocop/cop/rails/presence.rb

@@ -38,7 +38,7 @@ module RuboCop
       #   # good
       #   a.presence || b
       class Presence < Cop
-        MSG = 'Use `%<prefer>s` instead of `%<current>s`.'.freeze
+        MSG = 'Use `%<prefer>s` instead of `%<current>s`.'
 
         def_node_matcher :redundant_receiver_and_other, <<-PATTERN
           {

data/lib/rubocop/cop/rails/present.rb

@@ -44,11 +44,11 @@ module RuboCop
       #   # good
       #   something if foo.present?
       class Present < Cop
-        MSG_NOT_BLANK = 'Use `%<prefer>s` instead of `%<current>s`.'.freeze
+        MSG_NOT_BLANK = 'Use `%<prefer>s` instead of `%<current>s`.'
         MSG_EXISTS_AND_NOT_EMPTY = 'Use `%<prefer>s` instead of ' \
-                                   '`%<current>s`.'.freeze
+                                   '`%<current>s`.'
         MSG_UNLESS_BLANK = 'Use `if %<prefer>s` instead of ' \
-                           '`%<current>s`.'.freeze
+                           '`%<current>s`.'
 
         def_node_matcher :exists_and_not_empty?, <<-PATTERN
           (and

data/lib/rubocop/cop/rails/read_write_attribute.rb

@@ -24,7 +24,7 @@ module RuboCop
       #   x = self[:attr]
       #   self[:attr] = val
       class ReadWriteAttribute < Cop
-        MSG = 'Prefer `%<prefer>s` over `%<current>s`.'.freeze
+        MSG = 'Prefer `%<prefer>s` over `%<current>s`.'
 
         def_node_matcher :read_write_attribute?, <<-PATTERN
           {

data/lib/rubocop/cop/rails/redundant_allow_nil.rb

@@ -31,9 +31,9 @@ module RuboCop
 
         MSG_SAME =
           '`allow_nil` is redundant when `allow_blank` has the same value.'
-          .freeze
+
         MSG_ALLOW_NIL_FALSE =
-          '`allow_nil: false` is redundant when `allow_blank` is true.'.freeze
+          '`allow_nil: false` is redundant when `allow_blank` is true.'
 
         def on_send(node)
           return unless node.method_name == :validates

data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb

@@ -60,7 +60,7 @@ module RuboCop
 
         minimum_target_rails_version 4.2
 
-        MSG = 'Redundant receiver in `with_options`.'.freeze
+        MSG = 'Redundant receiver in `with_options`.'
 
         def_node_matcher :with_options?, <<-PATTERN
           (block

data/lib/rubocop/cop/rails/reflection_class_name.rb

@@ -14,7 +14,7 @@ module RuboCop
       #   # good
       #   has_many :accounts, class_name: 'Account'
       class ReflectionClassName < Cop
-        MSG = 'Use a string value for `class_name`.'.freeze
+        MSG = 'Use a string value for `class_name`.'
 
         def_node_matcher :association_with_reflection, <<-PATTERN
           (send nil? {:has_many :has_one :belongs_to} _

data/lib/rubocop/cop/rails/refute_methods.rb

@@ -18,7 +18,7 @@ module RuboCop
       #   assert_not_equal true, false
       #
       class RefuteMethods < Cop
-        MSG = 'Prefer `%<assert_method>s` over `%<refute_method>s`.'.freeze
+        MSG = 'Prefer `%<assert_method>s` over `%<refute_method>s`.'
 
         CORRECTIONS = {
           refute: 'assert_not',

data/lib/rubocop/cop/rails/relative_date_constant.rb

@@ -22,7 +22,7 @@ module RuboCop
         include RangeHelp
 
         MSG = 'Do not assign %<method_name>s to constants as it ' \
-              'will be evaluated only once.'.freeze
+              'will be evaluated only once.'
 
         def on_casgn(node)
           relative_date_assignment?(node) do |method_name|
@@ -33,7 +33,7 @@ module RuboCop
         def on_masgn(node)
           lhs, rhs = *node
 
-          return unless rhs && rhs.array_type?
+          return unless rhs&.array_type?
 
           lhs.children.zip(rhs.children).each do |(name, value)|
             next unless name.casgn_type?

data/lib/rubocop/cop/rails/request_referer.rb

@@ -23,7 +23,7 @@ module RuboCop
         include ConfigurableEnforcedStyle
 
         MSG = 'Use `request.%<prefer>s` instead of ' \
-              '`request.%<current>s`.'.freeze
+              '`request.%<current>s`.'
 
         def_node_matcher :referer?, <<-PATTERN
           (send (send nil? :request) {:referer :referrer})

data/lib/rubocop/cop/rails/reversible_migration.rb

@@ -126,7 +126,7 @@ module RuboCop
       #
       # @see https://api.rubyonrails.org/classes/ActiveRecord/Migration/CommandRecorder.html
       class ReversibleMigration < Cop
-        MSG = '%<action>s is not reversible.'.freeze
+        MSG = '%<action>s is not reversible.'
         IRREVERSIBLE_CHANGE_TABLE_CALLS = %i[
           change change_default remove
         ].freeze
@@ -140,7 +140,7 @@ module RuboCop
         PATTERN
 
         def_node_matcher :change_column_default_call, <<-PATTERN
-          (send nil? :change_column_default _ _ $...)
+          (send nil? :change_column_default {[(sym _) (sym _)] (splat _)} $...)
         PATTERN
 
         def_node_matcher :remove_column_call, <<-PATTERN
@@ -195,7 +195,7 @@ module RuboCop
 
         def check_change_column_default_node(node)
           change_column_default_call(node) do |args|
-            unless all_hash_key?(args.first, :from, :to)
+            unless all_hash_key?(args.last, :from, :to)
               add_offense(
                 node,
                 message: format(
@@ -272,7 +272,7 @@ module RuboCop
         end
 
         def all_hash_key?(args, *keys)
-          return false unless args && args.hash_type?
+          return false unless args&.hash_type?
 
           hash_keys = args.keys.map do |key|
             key.children.first.to_sym

data/lib/rubocop/cop/rails/safe_navigation.rb

@@ -4,8 +4,7 @@ module RuboCop
   module Cop
     module Rails
       # This cop converts usages of `try!` to `&.`. It can also be configured
-      # to convert `try`. It will convert code to use safe navigation if the
-      # target Ruby version is set to 2.3+
+      # to convert `try`. It will convert code to use safe navigation.
       #
       # @example
       #   # ConvertTry: false
@@ -40,17 +39,14 @@ module RuboCop
       #     foo&.bar(baz)
       #     foo&.bar { |e| e.baz }
       class SafeNavigation < Cop
-        extend TargetRubyVersion
         include RangeHelp
 
-        MSG = 'Use safe navigation (`&.`) instead of `%<try>s`.'.freeze
+        MSG = 'Use safe navigation (`&.`) instead of `%<try>s`.'
 
         def_node_matcher :try_call, <<-PATTERN
           (send !nil? ${:try :try!} $_ ...)
         PATTERN
 
-        minimum_target_ruby_version 2.3
-
         def on_send(node)
           try_call(node) do |try_method, dispatch|
             return if try_method == :try && !cop_config['ConvertTry']

data/lib/rubocop/cop/rails/save_bang.rb

@@ -100,12 +100,12 @@ module RuboCop
         include NegativeConditional
 
         MSG = 'Use `%<prefer>s` instead of `%<current>s` if the return ' \
-              'value is not checked.'.freeze
+              'value is not checked.'
         CREATE_MSG = (MSG +
                       ' Or check `persisted?` on model returned from ' \
                       '`%<current>s`.').freeze
         CREATE_CONDITIONAL_MSG = '`%<current>s` returns a model which is ' \
-                                 'always truthy.'.freeze
+                                 'always truthy.'
 
         CREATE_PERSIST_METHODS = %i[create
                                     first_or_create find_or_create_by].freeze
@@ -129,7 +129,7 @@ module RuboCop
         def check_assignment(assignment)
           node = right_assignment_node(assignment)
 
-          return unless node && node.send_type?
+          return unless node&.send_type?
           return unless persist_method?(node, CREATE_PERSIST_METHODS)
           return if persisted_referenced?(assignment)
 
@@ -167,7 +167,7 @@ module RuboCop
         def right_assignment_node(assignment)
           node = assignment.node.child_nodes.first
 
-          return node unless node && node.block_type?
+          return node unless node&.block_type?
 
           node.send_node
         end
@@ -195,17 +195,17 @@ module RuboCop
 
         def hash_parent(node)
           pair = node.parent
-          return unless pair && pair.pair_type?
+          return unless pair&.pair_type?
 
           hash = pair.parent
-          return unless hash && hash.hash_type?
+          return unless hash&.hash_type?
 
           hash
         end
 
         def array_parent(node)
           array = node.parent
-          return unless array && array.array_type?
+          return unless array&.array_type?
 
           array
         end
@@ -293,7 +293,7 @@ module RuboCop
 
         def return_value_assigned?(node)
           assignment = assignable_node(node).parent
-          assignment && assignment.lvasgn_type?
+          assignment&.lvasgn_type?
         end
 
         def persist_method?(node, methods = PERSIST_METHODS)