rubocop 0.18.1 → 0.19.0

data/lib/rubocop/cop/style/favor_sprintf.rb

@@ -1,26 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    module Style
-      # This cop checks for uses of String#%.
-      #
-      # It cannot be implemented in a reliable manner for all cases, so
-      # only two scenarios are considered - if the first argument is a string
-      # literal and if the second argument is an array literal.
-      class FavorSprintf < Cop
-        MSG = 'Favor sprintf over String#%.'
-
-        def on_send(node)
-          receiver_node, method_name, *arg_nodes = *node
-
-          if method_name == :% &&
-              ([:str, :dstr].include?(receiver_node.type) ||
-               arg_nodes[0].type == :array)
-            add_offence(node, :selector)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/formatter/offence_count_formatter.rb

@@ -1,49 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Formatter
-    # This formatter displays the list of offended cops with a count of how
-    # many offences of their kind were found. Ordered by desc offence count
-    #
-    # Here's the format:
-    #
-    # (26)  LineLength
-    # (3)   OneLineConditional
-    class OffenceCountFormatter < BaseFormatter
-      attr_reader :offence_counts
-
-      def started(target_files)
-        super
-        @offence_counts = Hash.new(0)
-      end
-
-      def file_finished(file, offences)
-        offences.each { |o| @offence_counts[o.cop_name] += 1 }
-      end
-
-      def finished(inspected_files)
-        report_summary(inspected_files.count,
-                       ordered_offence_counts(@offence_counts))
-      end
-
-      def report_summary(file_count, offence_counts)
-        output.puts
-
-        offence_count = total_offence_count(offence_counts)
-        offence_counts.each do |cop_name, count|
-          output.puts "#{count.to_s.ljust(offence_count.to_s.length + 2)}" +
-                      "#{cop_name}\n"
-        end
-        output.puts
-      end
-
-      def ordered_offence_counts(offence_counts)
-        Hash[offence_counts.sort_by { |k, v| v }.reverse]
-      end
-
-      def total_offence_count(offence_counts = {})
-        offence_counts.values.inject(0, :+)
-      end
-    end
-  end
-end

data/spec/rubocop/cop/style/favor_sprintf_spec.rb

@@ -1,47 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe Rubocop::Cop::Style::FavorSprintf do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offence for a string followed by something' do
-    inspect_source(cop,
-                   ['puts "%d" % 10'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Favor sprintf over String#%.'])
-  end
-
-  it 'registers an offence for something followed by an array' do
-    inspect_source(cop,
-                   ['puts x % [10, 11]'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Favor sprintf over String#%.'])
-  end
-
-  it 'does not register an offence for numbers' do
-    inspect_source(cop,
-                   ['puts 10 % 4'])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'does not register an offence for ambiguous cases' do
-    inspect_source(cop,
-                   ['puts x % 4'])
-    expect(cop.offences).to be_empty
-
-    inspect_source(cop,
-                   ['puts x % Y'])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'works if the first operand contains embedded expressions' do
-    inspect_source(cop,
-                   ['puts "#{x * 5} %d #{@test}" % 10'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Favor sprintf over String#%.'])
-  end
-end

data/spec/rubocop/formatter/offence_count_formatter_spec.rb

@@ -1,52 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-require 'stringio'
-require 'tempfile'
-
-module Rubocop
-  module Formatter
-    describe OffenceCountFormatter do
-      subject(:formatter) { described_class.new(output) }
-      let(:output) { StringIO.new }
-
-      let(:files) do
-        %w(lib/rubocop.rb spec/spec_helper.rb bin/rubocop).map do |path|
-          File.expand_path(path)
-        end
-      end
-
-      describe '#file_finished' do
-        before { formatter.started(files) }
-
-        let(:finish) { formatter.file_finished(files.first, offences) }
-
-        context 'when no offences are detected' do
-          let(:offences) { [] }
-          it 'shouldn\'t add to offence_counts' do
-            expect { finish }.to_not change { formatter.offence_counts }
-          end
-        end
-
-        context 'when any offences are detected' do
-          let(:offences) { [double('offence', cop_name: 'OffendedCop')] }
-          it 'should increment the count for the cop in offence_counts' do
-            expect { finish }.to change { formatter.offence_counts }
-          end
-        end
-      end
-
-      describe '#report_summary' do
-        context 'when a offence detected' do
-          let(:cop_counts) { { 'OffendedCop' => 1 } }
-          it 'shows the cop and the offence count' do
-            formatter.report_summary(1, cop_counts)
-            expect(output.string).to include(
-              "\n1  OffendedCop")
-          end
-        end
-      end
-
-    end
-  end
-end