rubocop 0.18.1 → 0.19.0

data/spec/rubocop/cop/style/method_name_spec.rb

@@ -6,17 +6,17 @@ describe Rubocop::Cop::Style::MethodName, :config do
   subject(:cop) { described_class.new(config) }
 
   shared_examples 'never accepted' do
-    it 'registers an offence for mixed snake case and camel case' do
+    it 'registers an offense for mixed snake case and camel case' do
       inspect_source(cop, ['def visit_Arel_Nodes_SelectStatement',
                            'end'])
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['visit_Arel_Nodes_SelectStatement'])
     end
 
-    it 'registers an offence for capitalized camel case' do
+    it 'registers an offense for capitalized camel case' do
       inspect_source(cop, ['def MyMethod',
                            'end'])
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['MyMethod'])
     end
   end
@@ -24,51 +24,51 @@ describe Rubocop::Cop::Style::MethodName, :config do
   shared_examples 'always accepted' do
     it 'accepts one line methods' do
       inspect_source(cop, "def body; '' end")
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts operator definitions' do
       inspect_source(cop, ['def +(other)',
                            '  # ...',
                            'end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 
   context 'when configured for snake_case' do
     let(:cop_config) { { 'EnforcedStyle' => 'snake_case' } }
 
-    it 'registers an offence for camel case in instance method name' do
+    it 'registers an offense for camel case in instance method name' do
       inspect_source(cop, ['def myMethod',
                            '  # ...',
                            'end'])
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['myMethod'])
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' =>
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
                                                  'camelCase')
     end
 
-    it 'registers an offence for opposite + correct' do
+    it 'registers an offense for opposite + correct' do
       inspect_source(cop, ['def my_method',
                            'end',
                            'def myMethod',
                            'end'])
       expect(cop.highlights).to eq(['myMethod'])
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
-    it 'registers an offence for camel case in singleton method name' do
+    it 'registers an offense for camel case in singleton method name' do
       inspect_source(cop, ['def self.myMethod',
                            '  # ...',
                            'end'])
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['myMethod'])
     end
 
     it 'accepts snake case in names' do
       inspect_source(cop, ['def my_method',
                            'end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     include_examples 'never accepted'
@@ -82,32 +82,32 @@ describe Rubocop::Cop::Style::MethodName, :config do
       inspect_source(cop, ['def myMethod',
                            '  # ...',
                            'end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts camel case in singleton method name' do
       inspect_source(cop, ['def self.myMethod',
                            '  # ...',
                            'end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
-    it 'registers an offence for snake case in names' do
+    it 'registers an offense for snake case in names' do
       inspect_source(cop, ['def my_method',
                            'end'])
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['my_method'])
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' =>
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
                                                  'snake_case')
     end
 
-    it 'registers an offence for correct + opposite' do
+    it 'registers an offense for correct + opposite' do
       inspect_source(cop, ['def my_method',
                            'end',
                            'def myMethod',
                            'end'])
       expect(cop.highlights).to eq(['my_method'])
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
     include_examples 'always accepted'

data/spec/rubocop/cop/style/module_function_spec.rb

@@ -5,13 +5,13 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::ModuleFunction do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for extend self in module' do
+  it 'registers an offense for extend self in module' do
     inspect_source(cop,
                    ['module Test',
                     '  extend self',
                     '  def test; end',
                     'end'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts extend self in class' do
@@ -19,6 +19,6 @@ describe Rubocop::Cop::Style::ModuleFunction do
                    ['class Test',
                     '  extend self',
                     'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/multiline_block_chain_spec.rb

@@ -6,27 +6,27 @@ describe Rubocop::Cop::Style::MultilineBlockChain do
   subject(:cop) { described_class.new }
 
   context 'with multi-line block chaining' do
-    it 'registers an offence for a simple case' do
+    it 'registers an offense for a simple case' do
       inspect_source(cop, ['a do',
                            '  b',
                            'end.c do',
                            '  d',
                            'end'])
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['end.c'])
     end
 
-    it 'registers an offence for a slightly more complicated case' do
+    it 'registers an offense for a slightly more complicated case' do
       inspect_source(cop, ['a do',
                            '  b',
                            'end.c1.c2 do',
                            '  d',
                            'end'])
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['end.c1.c2'])
     end
 
-    it 'registers two offences for a chain of three blocks' do
+    it 'registers two offenses for a chain of three blocks' do
       inspect_source(cop, ['a do',
                            '  b',
                            'end.c do',
@@ -34,16 +34,16 @@ describe Rubocop::Cop::Style::MultilineBlockChain do
                            'end.e do',
                            '  f',
                            'end'])
-      expect(cop.offences.size).to eq(2)
+      expect(cop.offenses.size).to eq(2)
       expect(cop.highlights).to eq(['end.c', 'end.e'])
     end
 
-    it 'registers an offence for a chain where the second block is ' \
-      'single-line' do
+    it 'registers an offense for a chain where the second block is ' \
+       'single-line' do
       inspect_source(cop, ['Thread.list.find_all { |t|',
                            '  t.alive?',
                            '}.map { |thread| thread.object_id }'])
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['}.map'])
     end
 
@@ -52,27 +52,27 @@ describe Rubocop::Cop::Style::MultilineBlockChain do
                      ['Thread.list.find_all { |t| t.alive? }.map { |t| ',
                       '  t.object_id',
                       '}'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 
   it 'accepts a chain of blocks spanning one line' do
     inspect_source(cop, ['a { b }.c { d }',
                          'w do x end.y do z end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a multi-line block chained with calls on one line' do
     inspect_source(cop, ['a do',
                          '  b',
                          'end.c.d'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a chain of calls followed by a multi-line block' do
     inspect_source(cop, ['a1.a2.a3 do',
                          '  b',
                          'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/multiline_if_then_spec.rb

@@ -7,7 +7,7 @@ describe Rubocop::Cop::Style::MultilineIfThen do
 
   # if
 
-  it 'registers an offence for then in multiline if' do
+  it 'registers an offense for then in multiline if' do
     inspect_source(cop, ['if cond then',
                          'end',
                          "if cond then\t",
@@ -19,13 +19,13 @@ describe Rubocop::Cop::Style::MultilineIfThen do
                          'end',
                          'if cond then # bad',
                          'end'])
-    expect(cop.offences.map(&:line)).to eq([1, 3, 5, 7, 10])
+    expect(cop.offenses.map(&:line)).to eq([1, 3, 5, 7, 10])
   end
 
   it 'accepts multiline if without then' do
     inspect_source(cop, ['if cond',
                          'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts table style if/then/elsif/ends' do
@@ -35,7 +35,7 @@ describe Rubocop::Cop::Style::MultilineIfThen do
                     'elsif @io == $stderr then str << "$stderr"',
                     'else                      str << @io.class.to_s',
                     'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'does not get confused by a then in a when' do
@@ -45,7 +45,7 @@ describe Rubocop::Cop::Style::MultilineIfThen do
                     '  when c then',
                     '  end',
                     'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'does not get confused by a commented-out then' do
@@ -55,7 +55,7 @@ describe Rubocop::Cop::Style::MultilineIfThen do
                     'end',
                     'if c # then',
                     'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'does not raise an error for an implicit match if' do
@@ -68,7 +68,7 @@ describe Rubocop::Cop::Style::MultilineIfThen do
 
   # unless
 
-  it 'registers an offence for then in multiline unless' do
+  it 'registers an offense for then in multiline unless' do
     inspect_source(cop, ['unless cond then',
                          'end'])
     expect(cop.messages).to eq(
@@ -78,14 +78,14 @@ describe Rubocop::Cop::Style::MultilineIfThen do
   it 'accepts multiline unless without then' do
     inspect_source(cop, ['unless cond',
                          'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'does not get confused by a postfix unless' do
     inspect_source(cop,
                    ['two unless one'
                    ])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'does not get confused by a nested postfix unless' do
@@ -94,7 +94,7 @@ describe Rubocop::Cop::Style::MultilineIfThen do
                     '  puts 1',
                     'end unless two'
                    ])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'does not raise an error for an implicit match unless' do

data/spec/rubocop/cop/style/multiline_ternary_operator_spec.rb

@@ -5,14 +5,14 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::MultilineTernaryOperator do
   subject(:cop) { described_class.new }
 
-  it 'registers offence for a multiline ternary operator expression' do
+  it 'registers offense for a multiline ternary operator expression' do
     inspect_source(cop, ['a = cond ?',
                          '  b : c'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts a single line ternary operator expression' do
     inspect_source(cop, ['a = cond ? b : c'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/nested_ternary_operator_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::NestedTernaryOperator do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for a nested ternary operator expression' do
+  it 'registers an offense for a nested ternary operator expression' do
     inspect_source(cop, ['a ? (b ? b1 : b2) : a2'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts a non-nested ternary operator within an if' do
@@ -16,6 +16,6 @@ describe Rubocop::Cop::Style::NestedTernaryOperator do
                          'else',
                          '  d',
                          'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/nil_comparison_spec.rb

@@ -5,26 +5,26 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::NilComparison do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for == nil' do
+  it 'registers an offense for == nil' do
     inspect_source(cop,
                    ['x == nil'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'registers an offence for === nil' do
+  it 'registers an offense for === nil' do
     inspect_source(cop,
                    ['x === nil'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'registers an offence for === nil' do
+  it 'registers an offense for === nil' do
     inspect_source(cop,
                    ['x != nil'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'works with lambda.()' do
     inspect_source(cop, ['a.(x) == nil'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 end

data/spec/rubocop/cop/style/not_spec.rb

@@ -5,18 +5,13 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::Not do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for not' do
-    inspect_source(cop, ['not test'])
-    expect(cop.offences.size).to eq(1)
+  it 'registers an offense for not' do
+    inspect_source(cop, 'not test')
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'does not register an offence for !' do
-    inspect_source(cop, ['!test'])
-    expect(cop.offences).to be_empty
-  end
-
-  it 'does not register an offence for :not' do
-    inspect_source(cop, ['[:not, :if, :else]'])
-    expect(cop.offences).to be_empty
+  it 'does not register an offense for !' do
+    inspect_source(cop, '!test')
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/numeric_literals_spec.rb

@@ -6,16 +6,16 @@ describe Rubocop::Cop::Style::NumericLiterals, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'MinDigits' => 5 } }
 
-  it 'registers an offence for a long integer without underscores' do
+  it 'registers an offense for a long integer without underscores' do
     inspect_source(cop, ['a = 123456'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.config_to_allow_offences).to eq('MinDigits' => 6)
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.config_to_allow_offenses).to eq('MinDigits' => 6)
   end
 
-  it 'registers an offence for an integer with misplaced underscore' do
+  it 'registers an offense for an integer with misplaced underscore' do
     inspect_source(cop, ['a = 123_456_78_90_00'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
   end
 
   it 'accepts long numbers with underscore' do
@@ -44,10 +44,10 @@ describe Rubocop::Cop::Style::NumericLiterals, :config do
     inspect_source(cop, ['a = 0b1010101010101',
                          'b = 01717171717171',
                          'c = 0xab11111111bb'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
-  it 'autocorrects a long integer offence' do
+  it 'autocorrects a long integer offense' do
     corrected = autocorrect_source(cop, ['a = 123456'])
     expect(corrected).to eq 'a = 123_456'
   end