rubocop 0.18.1 → 0.19.0

data/spec/rubocop/cop/style/special_global_vars_spec.rb

@@ -5,30 +5,30 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::SpecialGlobalVars do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for $:' do
+  it 'registers an offense for $:' do
     inspect_source(cop, ['puts $:'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Prefer $LOAD_PATH over $:.'])
   end
 
-  it 'registers an offence for $"' do
+  it 'registers an offense for $"' do
     inspect_source(cop, ['puts $"'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Prefer $LOADED_FEATURES over $".'])
   end
 
-  it 'registers an offence for $0' do
+  it 'registers an offense for $0' do
     inspect_source(cop, ['puts $0'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Prefer $PROGRAM_NAME over $0.'])
   end
 
-  it 'registers an offence for $$' do
+  it 'registers an offense for $$' do
     inspect_source(cop, ['puts $$'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Prefer $PROCESS_ID or $PID from the English library over $$.'])
   end
@@ -39,9 +39,9 @@ describe Rubocop::Cop::Style::SpecialGlobalVars do
       .to eq(['Prefer $ARGV from the English library, or ARGV over $*.'])
   end
 
-  it 'does not register an offence for backrefs like $1' do
+  it 'does not register an offense for backrefs like $1' do
     inspect_source(cop, ['puts $1'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'auto-corrects $: to $LOAD_PATH' do

data/spec/rubocop/cop/style/string_literals_spec.rb

@@ -8,8 +8,8 @@ describe Rubocop::Cop::Style::StringLiterals, :config do
   context 'configured with single quotes preferred' do
     let(:cop_config) { { 'EnforcedStyle' => 'single_quotes' } }
 
-    it 'registers offence for double quotes when single quotes ' \
-      'suffice' do
+    it 'registers offense for double quotes when single quotes ' \
+       'suffice' do
       inspect_source(cop, ['s = "abc"',
                            'x = "a\\\\b"',
                            'y ="\\\\b"',
@@ -21,32 +21,32 @@ describe Rubocop::Cop::Style::StringLiterals, :config do
       expect(cop.messages)
         .to eq(["Prefer single-quoted strings when you don't need " \
                 'string interpolation or special symbols.'] * 4)
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' =>
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
                                                  'double_quotes')
     end
 
-    it 'registers offence for correct + opposite' do
+    it 'registers offense for correct + opposite' do
       inspect_source(cop, ['s = "abc"',
                            "x = 'abc'"])
       expect(cop.messages)
         .to eq(["Prefer single-quoted strings when you don't need " \
                 'string interpolation or special symbols.'])
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
     it 'accepts single quotes' do
       inspect_source(cop, ["a = 'x'"])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts %q and %Q quotes' do
       inspect_source(cop, ['a = %q(x) + %Q[x]'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts % quotes' do
       inspect_source(cop, ['a = %(x)'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts heredocs' do
@@ -55,7 +55,7 @@ describe Rubocop::Cop::Style::StringLiterals, :config do
                       '  SELECT name from users',
                       'SQL'])
 
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts double quotes when they are needed' do
@@ -68,12 +68,12 @@ describe Rubocop::Cop::Style::StringLiterals, :config do
              'f = "\e"',
              'g = "#@@test"']
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts double quotes at the start of regexp literals' do
       inspect_source(cop, ['s = /"((?:[^\\"]|\\.)*)"/'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts double quotes with some other special symbols' do
@@ -82,23 +82,23 @@ describe Rubocop::Cop::Style::StringLiterals, :config do
       src = ['g = "\xf9"',
              'copyright = "\u00A9"']
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts " in a %w' do
       inspect_source(cop, ['%w(")'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts \\\\\n in a string' do # this would be: "\\\n"
       inspect_source(cop, ['"foo \\\\\n bar"'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'can handle double quotes within embedded expression' do
       src = ['"#{"A"}"']
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'can handle a built-in constant parsed as string' do
@@ -106,13 +106,13 @@ describe Rubocop::Cop::Style::StringLiterals, :config do
       src = ['if __FILE__ == $PROGRAM_NAME',
              'end']
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'can handle character literals' do
       src = 'a = ?/'
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'auto-corrects " with \'' do
@@ -124,41 +124,41 @@ describe Rubocop::Cop::Style::StringLiterals, :config do
   context 'configured with double quotes preferred' do
     let(:cop_config) { { 'EnforcedStyle' => 'double_quotes' } }
 
-    it 'registers offence for single quotes when double quotes would ' \
+    it 'registers offense for single quotes when double quotes would ' \
       'be equivalent' do
       inspect_source(cop, ["s = 'abc'"])
       expect(cop.highlights).to eq(["'abc'"])
       expect(cop.messages)
         .to eq(['Prefer double-quoted strings unless you need ' \
-                'single quotes to avoid extra backslashes for ' +
+                'single quotes to avoid extra backslashes for ' \
                 'escaping.'])
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' =>
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
                                                  'single_quotes')
     end
 
-    it 'registers offence for opposite + correct' do
+    it 'registers offense for opposite + correct' do
       inspect_source(cop, ['s = "abc"',
                            "x = 'abc'"])
       expect(cop.messages)
         .to eq(['Prefer double-quoted strings unless you need ' \
-                'single quotes to avoid extra backslashes for ' +
+                'single quotes to avoid extra backslashes for ' \
                 'escaping.'])
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
     it 'accepts double quotes' do
       inspect_source(cop, ['a = "x"'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts %q and %Q quotes' do
       inspect_source(cop, ['a = %q(x) + %Q[x]'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts % quotes' do
       inspect_source(cop, ['a = %(x)'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts heredocs' do
@@ -167,24 +167,24 @@ describe Rubocop::Cop::Style::StringLiterals, :config do
                       '  SELECT name from users',
                       'SQL'])
 
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts single quotes when they are needed' do
       src = ["a = '\\n'",
              "b = '\"'"]
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts single quotes at the start of regexp literals' do
       inspect_source(cop, ["s = /'((?:[^\\']|\\.)*)'/"])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it "accepts ' in a %w" do
       inspect_source(cop, ["%w(')"])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'can handle a built-in constant parsed as string' do
@@ -192,7 +192,7 @@ describe Rubocop::Cop::Style::StringLiterals, :config do
       src = ['if __FILE__ == $PROGRAM_NAME',
              'end']
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it "auto-corrects ' with \"" do

data/spec/rubocop/cop/style/symbol_array_spec.rb

@@ -5,33 +5,33 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::SymbolArray do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for arrays of symbols', ruby: 2.0 do
+  it 'registers an offense for arrays of symbols', ruby: 2.0 do
     inspect_source(cop,
                    ['[:one, :two, :three]'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'does not reg an offence for array with non-syms', ruby: 2.0 do
+  it 'does not reg an offense for array with non-syms', ruby: 2.0 do
     inspect_source(cop,
                    ['[:one, :two, "three"]'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
-  it 'does not reg an offence for array starting with %i', ruby: 2.0 do
+  it 'does not reg an offense for array starting with %i', ruby: 2.0 do
     inspect_source(cop,
                    ['%i(one two three)'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
-  it 'does not reg an offence for array with one element', ruby: 2.0 do
+  it 'does not reg an offense for array with one element', ruby: 2.0 do
     inspect_source(cop,
                    ['[:three]'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'does nothing on Ruby 1.9', ruby: 1.9 do
     inspect_source(cop,
                    ['[:one, :two, :three]'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/tab_spec.rb

@@ -5,13 +5,13 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::Tab do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for a line indented with tab' do
+  it 'registers an offense for a line indented with tab' do
     inspect_source(cop, ["\tx = 0"])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts a line with tab in a string' do
     inspect_source(cop, ["(x = \"\t\")"])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/trailing_blank_lines_spec.rb

@@ -10,12 +10,12 @@ describe Rubocop::Cop::Style::TrailingBlankLines do
 
   it 'accepts final newline' do
     inspect_source(cop, ['x = 0', ''])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
-  it 'registers an offence for multiple trailing blank lines' do
+  it 'registers an offense for multiple trailing blank lines' do
     inspect_source(cop, ['x = 0', '', '', '', ''])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['3 trailing blank lines detected.'])
   end
 

data/spec/rubocop/cop/style/trailing_comma_spec.rb

@@ -7,29 +7,29 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
   let(:cop_config) { { 'EnforcedStyleForMultiline' => 'no_comma' } }
 
   context 'with single line list of values' do
-    it 'registers an offence for trailing comma in an Array literal' do
+    it 'registers an offense for trailing comma in an Array literal' do
       inspect_source(cop, 'VALUES = [1001, 2020, 3333, ]')
       expect(cop.messages)
         .to eq(['Avoid comma after the last item of an array.'])
       expect(cop.highlights).to eq([','])
     end
 
-    it 'registers an offence for trailing comma in a Hash literal' do
+    it 'registers an offense for trailing comma in a Hash literal' do
       inspect_source(cop, 'MAP = { a: 1001, b: 2020, c: 3333, }')
       expect(cop.messages)
         .to eq(['Avoid comma after the last item of a hash.'])
       expect(cop.highlights).to eq([','])
     end
 
-    it 'registers an offence for trailing comma in a method call' do
+    it 'registers an offense for trailing comma in a method call' do
       inspect_source(cop, 'some_method(a, b, c, )')
       expect(cop.messages)
         .to eq(['Avoid comma after the last parameter of a method call.'])
       expect(cop.highlights).to eq([','])
     end
 
-    it 'registers an offence for trailing comma in a method call with hash' \
-      ' parameters at the end' do
+    it 'registers an offense for trailing comma in a method call with hash' \
+       ' parameters at the end' do
       inspect_source(cop, 'some_method(a, b, c: 0, d: 1, )')
       expect(cop.messages)
         .to eq(['Avoid comma after the last parameter of a method call.'])
@@ -38,12 +38,12 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
 
     it 'accepts Array literal without trailing comma' do
       inspect_source(cop, 'VALUES = [1001, 2020, 3333]')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts empty Array literal' do
       inspect_source(cop, 'VALUES = []')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts rescue clause' do
@@ -52,33 +52,33 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
                            '  do_something',
                            'rescue RuntimeError',
                            'end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts Hash literal without trailing comma' do
       inspect_source(cop, 'MAP = { a: 1001, b: 2020, c: 3333 }')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts empty Hash literal' do
       inspect_source(cop, 'MAP = {}')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts method call without trailing comma' do
       inspect_source(cop, 'some_method(a, b, c)')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts method call without parameters' do
       inspect_source(cop, 'some_method')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 
   context 'with multi-line list of values' do
     context 'when EnforcedStyleForMultiline is no_comma' do
-      it 'registers an offence for trailing comma in an Array literal' do
+      it 'registers an offense for trailing comma in an Array literal' do
         inspect_source(cop, ['VALUES = [',
                              '           1001,',
                              '           2020,',
@@ -87,7 +87,7 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
         expect(cop.highlights).to eq([','])
       end
 
-      it 'registers an offence for trailing comma in a Hash literal' do
+      it 'registers an offense for trailing comma in a Hash literal' do
         inspect_source(cop, ['MAP = { a: 1001,',
                              '        b: 2020,',
                              '        c: 3333,',
@@ -95,8 +95,8 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
         expect(cop.highlights).to eq([','])
       end
 
-      it 'registers an offence for trailing comma in a method call with ' \
-        'hash parameters at the end' do
+      it 'registers an offense for trailing comma in a method call with ' \
+         'hash parameters at the end' do
         inspect_source(cop, ['some_method(',
                              '              a,',
                              '              b,',
@@ -109,7 +109,7 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
         inspect_source(cop, ['VALUES = [ 1001,',
                              '           2020,',
                              '           3333 ]'])
-        expect(cop.offences).to be_empty
+        expect(cop.offenses).to be_empty
       end
 
       it 'accepts a Hash literal with no trailing comma' do
@@ -118,34 +118,34 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
                              '        b: 2020,',
                              '        c: 3333',
                              '      }'])
-        expect(cop.offences).to be_empty
+        expect(cop.offenses).to be_empty
       end
 
       it 'accepts a method call with ' \
-        'hash parameters at the end and no trailing comma' do
+         'hash parameters at the end and no trailing comma' do
         inspect_source(cop, ['some_method(a,',
                              '            b,',
                              '            c: 0,',
                              '            d: 1',
                              '           )'])
-        expect(cop.offences).to be_empty
+        expect(cop.offenses).to be_empty
       end
 
       it 'accepts comma inside a heredoc' \
-        ' parameters at the end' do
+         ' parameters at the end' do
         inspect_source(cop, ['route(help: {',
                              "  'auth' => <<-HELP.chomp",
                              ',',
                              'HELP',
                              '})'])
-        expect(cop.offences).to be_empty
+        expect(cop.offenses).to be_empty
       end
     end
 
     context 'when EnforcedStyleForMultiline is comma' do
       let(:cop_config) { { 'EnforcedStyleForMultiline' => 'comma' } }
 
-      it 'registers an offence for no trailing comma in an Array literal' do
+      it 'registers an offense for no trailing comma in an Array literal' do
         inspect_source(cop, ['VALUES = [',
                              '           1001,',
                              '           2020,',
@@ -155,7 +155,7 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
         expect(cop.highlights).to eq(['3333'])
       end
 
-      it 'registers an offence for no trailing comma in a Hash literal' do
+      it 'registers an offense for no trailing comma in a Hash literal' do
         inspect_source(cop, ['MAP = { a: 1001,',
                              '        b: 2020,',
                              '        c: 3333 }'])
@@ -164,8 +164,8 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
         expect(cop.highlights).to eq(['c: 3333'])
       end
 
-      it 'registers an offence for no trailing comma in a method call with' \
-        ' hash parameters at the end' do
+      it 'registers an offense for no trailing comma in a method call with' \
+         ' hash parameters at the end' do
         inspect_source(cop, ['some_method(',
                              '              a,',
                              '              b,',
@@ -183,7 +183,7 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
                              '          2020,',
                              '          3333,',
                              '         ]'])
-        expect(cop.offences).to be_empty
+        expect(cop.offenses).to be_empty
       end
 
       it 'accepts trailing comma in a Hash literal' do
@@ -192,18 +192,18 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
                              '        b: 2020,',
                              '        c: 3333,',
                              '      }'])
-        expect(cop.offences).to be_empty
+        expect(cop.offenses).to be_empty
       end
 
       it 'accepts trailing comma in a method call with hash' \
-        ' parameters at the end' do
+         ' parameters at the end' do
         inspect_source(cop, ['some_method(',
                              '              a,',
                              '              b,',
                              '              c: 0,',
                              '              d: 1,',
                              '           )'])
-        expect(cop.offences).to be_empty
+        expect(cop.offenses).to be_empty
       end
 
       it 'accepts a multiline word array' do
@@ -212,7 +212,7 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
                              '  anchovies',
                              '  olives',
                              ')'])
-        expect(cop.offences).to be_empty
+        expect(cop.offenses).to be_empty
       end
 
       it 'accepts missing comma after a heredoc' do
@@ -223,7 +223,7 @@ describe Rubocop::Cop::Style::TrailingComma, :config do
                              '...',
                              'HELP',
                              '},)']) # We still need a comma after the hash.
-        expect(cop.offences).to be_empty
+        expect(cop.offenses).to be_empty
       end
     end
   end