rubocop 0.18.1 → 0.19.0

data/spec/rubocop/cop/style/perl_backrefs_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::PerlBackrefs do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for $1' do
+  it 'registers an offense for $1' do
     inspect_source(cop, ['puts $1'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'auto-corrects $1 to Regexp.last_match[1]' do

data/spec/rubocop/cop/style/predicate_name_spec.rb

@@ -7,11 +7,11 @@ describe Rubocop::Cop::Style::PredicateName, :config do
   let(:cop_config) { { 'NamePrefixBlacklist' => %w(has_ is_) } }
 
   %w(has_ is_).each do |prefix|
-    it 'registers an offence for blacklisted method_name' do
+    it 'registers an offense for blacklisted method_name' do
       inspect_source(cop, ["def #{prefix}_attr",
                            '  # ...',
                            'end'])
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(["#{prefix}_attr"])
     end
   end
@@ -20,6 +20,6 @@ describe Rubocop::Cop::Style::PredicateName, :config do
     inspect_source(cop, ['def have_attr',
                          '  # ...',
                          'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/proc_spec.rb

@@ -5,19 +5,19 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::Proc do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for a Proc.new call' do
+  it 'registers an offense for a Proc.new call' do
     inspect_source(cop, ['f = Proc.new { |x| puts x }'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts the proc method' do
     inspect_source(cop, ['f = proc { |x| puts x }'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts the Proc.new call outside of block' do
     inspect_source(cop, ['p = Proc.new'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'auto-corrects Proc.new to proc' do

data/spec/rubocop/cop/style/raise_args_spec.rb

@@ -8,75 +8,75 @@ describe Rubocop::Cop::Style::RaiseArgs, :config do
   context 'when enforced style is compact' do
     let(:cop_config) { { 'EnforcedStyle' => 'compact' } }
 
-    it 'reports an offence for a raise with 2 args' do
+    it 'reports an offense for a raise with 2 args' do
       inspect_source(cop, ['raise RuntimeError, msg'])
-      expect(cop.offences.size).to eq(1)
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' => 'exploded')
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'exploded')
     end
 
-    it 'reports an offence for correct + opposite' do
+    it 'reports an offense for correct + opposite' do
       inspect_source(cop, ['if a',
                            '  raise RuntimeError, msg',
                            'else',
                            '  raise Ex.new(msg)',
                            'end'])
-      expect(cop.offences.size).to eq(1)
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
-    it 'reports an offence for a raise with 3 args' do
+    it 'reports an offense for a raise with 3 args' do
       inspect_source(cop, ['raise RuntimeError, msg, caller'])
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
     end
 
     it 'accepts a raise with msg argument' do
       inspect_source(cop, ['raise msg'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts a raise with an exception argument' do
       inspect_source(cop, ['raise Ex.new(msg)'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 
   context 'when enforced style is exploded' do
     let(:cop_config) { { 'EnforcedStyle' => 'exploded' } }
 
-    it 'reports an offence for a raise with exception object' do
+    it 'reports an offense for a raise with exception object' do
       inspect_source(cop, ['raise Ex.new(msg)'])
-      expect(cop.offences.size).to eq(1)
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' => 'compact')
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'compact')
     end
 
-    it 'reports an offence for opposite + correct' do
+    it 'reports an offense for opposite + correct' do
       inspect_source(cop, ['if a',
                            '  raise RuntimeError, msg',
                            'else',
                            '  raise Ex.new(msg)',
                            'end'])
-      expect(cop.offences.size).to eq(1)
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
     it 'accepts exception constructor with more than 1 argument' do
       inspect_source(cop, ['raise RuntimeError.new(a1, a2, a3)'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts a raise with 3 args' do
       inspect_source(cop, ['raise RuntimeError, msg, caller'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts a raise with 2 args' do
       inspect_source(cop, ['raise RuntimeError, msg'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts a raise with msg argument' do
       inspect_source(cop, ['raise msg'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 end

data/spec/rubocop/cop/style/redundant_begin_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::RedundantBegin do
   subject(:cop) { described_class.new }
 
-  it 'reports an offence for def with redundant begin block' do
+  it 'reports an offense for def with redundant begin block' do
     src = ['def func',
            '  begin',
            '    ala',
@@ -14,10 +14,10 @@ describe Rubocop::Cop::Style::RedundantBegin do
            '  end',
            'end']
     inspect_source(cop, src)
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'reports an offence for defs with redundant begin block' do
+  it 'reports an offense for defs with redundant begin block' do
     src = ['def Test.func',
            '  begin',
            '    ala',
@@ -26,7 +26,7 @@ describe Rubocop::Cop::Style::RedundantBegin do
            '  end',
            'end']
     inspect_source(cop, src)
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts a def with required begin block' do
@@ -39,7 +39,7 @@ describe Rubocop::Cop::Style::RedundantBegin do
            '  something',
            'end']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a defs with required begin block' do
@@ -52,6 +52,6 @@ describe Rubocop::Cop::Style::RedundantBegin do
            '  something',
            'end']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/redundant_exception_spec.rb

@@ -5,23 +5,23 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::RedundantException do
   subject(:cop) { described_class.new }
 
-  it 'reports an offence for a raise with RuntimeError' do
+  it 'reports an offense for a raise with RuntimeError' do
     inspect_source(cop, ['raise RuntimeError, msg'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'reports an offence for a fail with RuntimeError' do
+  it 'reports an offense for a fail with RuntimeError' do
     inspect_source(cop, ['fail RuntimeError, msg'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts a raise with RuntimeError if it does not have 2 args' do
     inspect_source(cop, ['raise RuntimeError, msg, caller'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a fail with RuntimeError if it does not have 2 args' do
     inspect_source(cop, ['fail RuntimeError, msg, caller'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/redundant_return_spec.rb

@@ -6,40 +6,40 @@ describe Rubocop::Cop::Style::RedundantReturn, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'AllowMultipleReturnValues' => false } }
 
-  it 'reports an offence for def with only a return' do
+  it 'reports an offense for def with only a return' do
     src = ['def func',
            '  return something',
            'end']
     inspect_source(cop, src)
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'reports an offence for defs with only a return' do
+  it 'reports an offense for defs with only a return' do
     src = ['def Test.func',
            '  return something',
            'end']
     inspect_source(cop, src)
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'reports an offence for def ending with return' do
+  it 'reports an offense for def ending with return' do
     src = ['def func',
            '  one',
            '  two',
            '  return something',
            'end']
     inspect_source(cop, src)
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'reports an offence for defs ending with return' do
+  it 'reports an offense for defs ending with return' do
     src = ['def func',
            '  one',
            '  two',
            '  return something',
            'end']
     inspect_source(cop, src)
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts return in a non-final position' do
@@ -47,14 +47,14 @@ describe Rubocop::Cop::Style::RedundantReturn, :config do
            '  return something if something_else',
            'end']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'does not blow up on empty method body' do
     src = ['def func',
            'end']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'auto-corrects by removing redundant returns' do
@@ -73,40 +73,40 @@ describe Rubocop::Cop::Style::RedundantReturn, :config do
   end
 
   context 'when multi-value returns are not allowed' do
-    it 'reports an offence for def with only a return' do
+    it 'reports an offense for def with only a return' do
       src = ['def func',
              '  return something, test',
              'end']
       inspect_source(cop, src)
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
     end
 
-    it 'reports an offence for defs with only a return' do
+    it 'reports an offense for defs with only a return' do
       src = ['def Test.func',
              '  return something, test',
              'end']
       inspect_source(cop, src)
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
     end
 
-    it 'reports an offence for def ending with return' do
+    it 'reports an offense for def ending with return' do
       src = ['def func',
              '  one',
              '  two',
              '  return something, test',
              'end']
       inspect_source(cop, src)
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
     end
 
-    it 'reports an offence for defs ending with return' do
+    it 'reports an offense for defs ending with return' do
       src = ['def func',
              '  one',
              '  two',
              '  return something, test',
              'end']
       inspect_source(cop, src)
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
     end
 
     it 'auto-corrects by making implicit arrays explicit' do
@@ -129,7 +129,7 @@ describe Rubocop::Cop::Style::RedundantReturn, :config do
              '  return something, test',
              'end']
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts defs with only a return' do
@@ -137,7 +137,7 @@ describe Rubocop::Cop::Style::RedundantReturn, :config do
              '  return something, test',
              'end']
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts def ending with return' do
@@ -147,7 +147,7 @@ describe Rubocop::Cop::Style::RedundantReturn, :config do
              '  return something, test',
              'end']
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts defs ending with return' do
@@ -157,7 +157,7 @@ describe Rubocop::Cop::Style::RedundantReturn, :config do
              '  return something, test',
              'end']
       inspect_source(cop, src)
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'does not auto-correct' do

data/spec/rubocop/cop/style/redundant_self_spec.rb

@@ -5,46 +5,46 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::RedundantSelf do
   subject(:cop) { described_class.new }
 
-  it 'reports an offence a self receiver on an rvalue' do
+  it 'reports an offense a self receiver on an rvalue' do
     src = ['a = self.b']
     inspect_source(cop, src)
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts a self receiver on an lvalue of an assignment' do
     src = ['self.a = b']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver on an lvalue of an or-assignment' do
     src = ['self.logger ||= Rails.logger']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver on an lvalue of an and-assignment' do
     src = ['self.flag &&= value']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver on an lvalue of a plus-assignment' do
     src = ['self.sum += 10']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver with the square bracket operator' do
     src = ['self[a]']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver with the double less-than operator' do
     src = ['self << a']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver for methods named like ruby keywords' do
@@ -86,7 +86,7 @@ describe Rubocop::Cop::Style::RedundantSelf do
            'self.yield'
           ]
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver used to distinguish from blockarg' do
@@ -95,7 +95,7 @@ describe Rubocop::Cop::Style::RedundantSelf do
            'end'
           ]
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver used to distinguish from argument' do
@@ -104,7 +104,7 @@ describe Rubocop::Cop::Style::RedundantSelf do
            'end'
           ]
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver used to distinguish from argument' do
@@ -113,7 +113,7 @@ describe Rubocop::Cop::Style::RedundantSelf do
            'end'
           ]
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver used to distinguish from local variable' do
@@ -126,13 +126,13 @@ describe Rubocop::Cop::Style::RedundantSelf do
            'end'
           ]
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts a self receiver used to distinguish from constant' do
     src = ['self.Foo']
     inspect_source(cop, src)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'auto-corrects by removing redundant self' do