rubocop 0.18.1 → 0.19.0

data/spec/rubocop/cop/style/trailing_whitespace_spec.rb

@@ -5,20 +5,20 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::TrailingWhitespace do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for a line ending with space' do
+  it 'registers an offense for a line ending with space' do
     source = ['x = 0 ']
     inspect_source(cop, source)
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'registers an offence for a line ending with tab' do
+  it 'registers an offense for a line ending with tab' do
     inspect_source(cop, ["x = 0\t"])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts a line without trailing whitespace' do
     inspect_source(cop, ["x = 0\n"])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'auto-corrects unwanted space' do

data/spec/rubocop/cop/style/trivial_accessors_spec.rb

@@ -15,8 +15,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     'def Foo',
                     '  @Foo',
                     'end'])
-    expect(cop.offences.size).to eq(2)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(2)
+    expect(cop.offenses
              .map(&:line).sort).to eq([1, 5])
   end
 
@@ -30,8 +30,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '    !foo',
                     '  end',
                     'end'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses
              .map(&:line).sort).to eq([2])
   end
 
@@ -45,8 +45,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '    !foo',
                     '  end',
                     'end'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses
              .map(&:line).sort).to eq([2])
   end
 
@@ -59,8 +59,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '    end',
                     '  end',
                     'end'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses
              .map(&:line).sort).to eq([3])
   end
 
@@ -119,8 +119,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '   @val',
                     ' end',
                     'end'])
-    expect(cop.offences.size).to eq(2)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(2)
+    expect(cop.offenses
              .map(&:line).sort).to eq([2, 8])
   end
 
@@ -132,8 +132,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '    @name',
                     '  end',
                     'end'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses
              .map(&:line).sort).to eq([3])
   end
 
@@ -145,8 +145,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '    @name = name',
                     '  end',
                     'end'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses
              .map(&:line).sort).to eq([3])
   end
 
@@ -159,7 +159,7 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '   or_more_of_them',
                     ' end',
                     'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'finds trivials with less peculiar methods' do
@@ -198,7 +198,7 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '  #do stuff',
                     'end',
                     'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'treats splats as non-trivial' do
@@ -206,7 +206,7 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                    [' def splatomatic(*values)',
                     '   @splatomatic = values',
                     ' end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'finds oneliner trivials' do
@@ -215,8 +215,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '  def foo; @foo; end',
                     '  def foo= foo; @foo = foo; end',
                     'end'])
-    expect(cop.offences.size).to eq(2)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(2)
+    expect(cop.offenses
              .map(&:line).sort).to eq([2, 3])
   end
 
@@ -225,7 +225,7 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                    ['def bar',
                     '  @bar + foo',
                     'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'finds trivial writer' do
@@ -233,8 +233,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                    ['def foo=(val)',
                     ' @foo = val',
                     'end'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses
              .map(&:line).sort).to eq([1])
   end
 
@@ -259,8 +259,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '    end',
                     '  end',
                     'end'])
-    expect(cop.offences.size).to eq(1)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses
              .map(&:line).sort).to eq([2])
   end
 
@@ -280,8 +280,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     ' @bar = bar_value',
                     ' end',
                     'end'])
-    expect(cop.offences.size).to eq(3)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(3)
+    expect(cop.offenses
              .map(&:line).sort).to eq([2, 8, 11])
   end
 
@@ -290,7 +290,7 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                    ['def bar=(value)',
                     ' @bar = value + 42',
                     'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'finds trivial writers in a little less trivial class' do
@@ -306,8 +306,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     ' @bar = bar_value',
                     ' end',
                     'end'])
-    expect(cop.offences.size).to eq(2)
-    expect(cop.offences
+    expect(cop.offenses.size).to eq(2)
+    expect(cop.offenses
              .map(&:line).sort).to eq([5, 8])
   end
 
@@ -326,7 +326,7 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '   foo_method',
                     ' end',
                     'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'does not find trivial writer with exceptions' do
@@ -339,7 +339,7 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                     '   end',
                     '   self[:expiration] = @expiration',
                     ' end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts an initialize method looking like a writer' do
@@ -347,7 +347,7 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                    [' def initialize(value)',
                     '   @top = value',
                     ' end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   context 'exact name match required' do
@@ -362,8 +362,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                       'def bar',
                       '  @barr',
                       'end'])
-      expect(cop.offences.size).to eq(1)
-      expect(cop.offences
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.offenses
                .map(&:line).sort).to eq([1])
     end
 
@@ -376,8 +376,8 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                       'def bar=(bar)',
                       '  @barr = bar',
                       'end'])
-      expect(cop.offences.size).to eq(1)
-      expect(cop.offences
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.offenses
                .map(&:line).sort).to eq([1])
     end
   end
@@ -390,7 +390,7 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                      [' def foo?',
                       '   @foo',
                       ' end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 
@@ -402,14 +402,14 @@ describe Rubocop::Cop::Style::TrivialAccessors, :config do
                      [' def to_foo',
                       '   @foo',
                       ' end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
     it 'ignores writers in the whitelist' do
       inspect_source(cop,
                      [' def bar=(bar)',
                       '   @bar = bar',
                       ' end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 end

data/spec/rubocop/cop/style/unless_else_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::UnlessElse do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for an unless with else' do
+  it 'registers an offense for an unless with else' do
     inspect_source(cop, ['unless x',
                          '  a = 1',
                          'else',

data/spec/rubocop/cop/style/variable_interpolation_spec.rb

@@ -5,43 +5,43 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::VariableInterpolation do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for interpolated global variables' do
+  it 'registers an offense for interpolated global variables' do
     inspect_source(cop,
                    ['puts "this is a #$test"'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Replace interpolated var $test' \
-        ' with expression #{$test}.'])
+              ' with expression #{$test}.'])
   end
 
-  it 'registers an offence for interpolated regexp back references' do
+  it 'registers an offense for interpolated regexp back references' do
     inspect_source(cop,
                    ['puts "this is a #$1"'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Replace interpolated var $1 with expression #{$1}.'])
   end
 
-  it 'registers an offence for interpolated instance variables' do
+  it 'registers an offense for interpolated instance variables' do
     inspect_source(cop,
                    ['puts "this is a #@test"'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Replace interpolated var @test' \
-        ' with expression #{@test}.'])
+              ' with expression #{@test}.'])
   end
 
-  it 'registers an offence for interpolated class variables' do
+  it 'registers an offense for interpolated class variables' do
     inspect_source(cop,
                    ['puts "this is a #@@t"'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Replace interpolated var @@t with expression #{@@t}.'])
   end
 
-  it 'does not register an offence for variables in expressions' do
+  it 'does not register an offense for variables in expressions' do
     inspect_source(cop,
                    ['puts "this is a #{@test} #{@@t} #{$t} #{$1}"'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/variable_name_spec.rb

@@ -8,52 +8,52 @@ describe Rubocop::Cop::Style::VariableName, :config do
   shared_examples 'always accepted' do
     it 'accepts screaming snake case globals' do
       inspect_source(cop, '$MY_GLOBAL = 0')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts screaming snake case constants' do
       inspect_source(cop, 'MY_CONSTANT = 0')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts assigning to camel case constant' do
       inspect_source(cop, 'Paren = Struct.new :left, :right, :kind')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts assignment with indexing of self' do
       inspect_source(cop, 'self[:a] = b')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 
   context 'when configured for snake_case' do
     let(:cop_config) { { 'EnforcedStyle' => 'snake_case' } }
 
-    it 'registers an offence for camel case in local variable name' do
+    it 'registers an offense for camel case in local variable name' do
       inspect_source(cop, 'myLocal = 1')
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['myLocal'])
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' =>
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
                                                  'camelCase')
     end
 
-    it 'registers an offence for correct + opposite' do
+    it 'registers an offense for correct + opposite' do
       inspect_source(cop, ['my_local = 1',
                            'myLocal = 1'])
       expect(cop.highlights).to eq(['myLocal'])
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
-    it 'registers an offence for camel case in instance variable name' do
+    it 'registers an offense for camel case in instance variable name' do
       inspect_source(cop, '@myAttribute = 3')
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['@myAttribute'])
     end
 
-    it 'registers an offence for camel case in setter name' do
+    it 'registers an offense for camel case in setter name' do
       inspect_source(cop, 'self.mySetter = 2')
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['mySetter'])
     end
 
@@ -63,34 +63,34 @@ describe Rubocop::Cop::Style::VariableName, :config do
   context 'when configured for camelCase' do
     let(:cop_config) { { 'EnforcedStyle' => 'camelCase' } }
 
-    it 'registers an offence for snake case in local variable name' do
+    it 'registers an offense for snake case in local variable name' do
       inspect_source(cop, 'my_local = 1')
-      expect(cop.offences.size).to eq(1)
+      expect(cop.offenses.size).to eq(1)
       expect(cop.highlights).to eq(['my_local'])
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' =>
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
                                                  'snake_case')
     end
 
-    it 'registers an offence for opposite + correct' do
+    it 'registers an offense for opposite + correct' do
       inspect_source(cop, ['my_local = 1',
                            'myLocal = 1'])
       expect(cop.highlights).to eq(['my_local'])
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
     it 'accepts camel case in local variable name' do
       inspect_source(cop, 'myLocal = 1')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts camel case in instance variable name' do
       inspect_source(cop, '@myAttribute = 3')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts camel case in setter name' do
       inspect_source(cop, 'self.mySetter = 2')
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     include_examples 'always accepted'

data/spec/rubocop/cop/style/when_then_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::WhenThen do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for when x;' do
+  it 'registers an offense for when x;' do
     inspect_source(cop, ['case a',
                          'when b; c',
                          'end'])