rubocop 0.18.1 → 0.19.0

data/spec/rubocop/cop/style/end_block_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::EndBlock do
   subject(:cop) { described_class.new }
 
-  it 'reports an offence for an END block' do
+  it 'reports an offense for an END block' do
     src = ['END { test }']
     inspect_source(cop, src)
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 end

data/spec/rubocop/cop/style/end_of_line_spec.rb

@@ -6,7 +6,7 @@ require 'tempfile'
 describe Rubocop::Cop::Style::EndOfLine do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for CR+LF' do
+  it 'registers an offense for CR+LF' do
     inspect_source_file(cop, ['x=0', '', "y=1\r"])
     expect(cop.messages).to eq(['Carriage return character detected.'])
   end
@@ -16,13 +16,13 @@ describe Rubocop::Cop::Style::EndOfLine do
     expect(cop.highlights).to eq(["y=1\r"])
   end
 
-  it 'registers an offence for CR at end of file' do
+  it 'registers an offense for CR at end of file' do
     inspect_source_file(cop, ["x=0\r"])
     expect(cop.messages).to eq(['Carriage return character detected.'])
   end
 
   context 'when there are many lines ending with CR+LF' do
-    it 'registers only one offence' do
+    it 'registers only one offense' do
       inspect_source_file(cop, ['x=0', '', 'y=1'].join("\r\n"))
       expect(cop.messages.size).to eq(1)
     end
@@ -41,7 +41,7 @@ describe Rubocop::Cop::Style::EndOfLine do
                            'class Epd::ReportsController < EpdAreaController',
                            "  'terecht bij uw ROM-coördinator.'",
                            'end'].join("\n"))
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 end

data/spec/rubocop/cop/style/even_odd_spec.rb

@@ -5,71 +5,71 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::EvenOdd do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for x % 2 == 0' do
+  it 'registers an offense for x % 2 == 0' do
     inspect_source(cop,
                    ['x % 2 == 0'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['Use Fixnum.even?'])
   end
 
-  it 'registers an offence for x % 2 != 0' do
+  it 'registers an offense for x % 2 != 0' do
     inspect_source(cop,
                    ['x % 2 != 0'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['Use Fixnum.odd?'])
   end
 
-  it 'registers an offence for (x % 2) == 0' do
+  it 'registers an offense for (x % 2) == 0' do
     inspect_source(cop,
                    ['(x % 2) == 0'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['Use Fixnum.even?'])
   end
 
-  it 'registers an offence for (x % 2) != 0' do
+  it 'registers an offense for (x % 2) != 0' do
     inspect_source(cop,
                    ['(x % 2) != 0'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['Use Fixnum.odd?'])
   end
 
-  it 'registers an offence for x % 2 == 1' do
+  it 'registers an offense for x % 2 == 1' do
     inspect_source(cop,
                    ['x % 2 == 1'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['Use Fixnum.odd?'])
   end
 
-  it 'registers an offence for x % 2 != 1' do
+  it 'registers an offense for x % 2 != 1' do
     inspect_source(cop,
                    ['x % 2 != 1'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['Use Fixnum.even?'])
   end
 
-  it 'registers an offence for (x % 2) == 1' do
+  it 'registers an offense for (x % 2) == 1' do
     inspect_source(cop,
                    ['(x % 2) == 1'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['Use Fixnum.odd?'])
   end
 
-  it 'registers an offence for (x % 2) != 1' do
+  it 'registers an offense for (x % 2) != 1' do
     inspect_source(cop,
                    ['(x % 2) != 1'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages).to eq(['Use Fixnum.even?'])
   end
 
   it 'accepts x % 3 == 0' do
     inspect_source(cop,
                    ['x % 3 == 0'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts x % 3 != 0' do
     inspect_source(cop,
                    ['x % 3 != 0'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/favor_join_spec.rb

@@ -5,27 +5,27 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::FavorJoin do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for an array followed by string' do
+  it 'registers an offense for an array followed by string' do
     inspect_source(cop,
                    ['%w(one two three) * ", "'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['Favor Array#join over Array#*.'])
   end
 
-  it 'does not register an offence for numbers' do
+  it 'does not register an offense for numbers' do
     inspect_source(cop,
                    ['%w(one two three) * 4'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
-  it 'does not register an offence for ambiguous cases' do
+  it 'does not register an offense for ambiguous cases' do
     inspect_source(cop,
                    ['test * ", "'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
 
     inspect_source(cop,
                    ['%w(one two three) * test'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/favor_unless_over_negated_if_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::FavorUnlessOverNegatedIf do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for if with exclamation point condition' do
+  it 'registers an offense for if with exclamation point condition' do
     inspect_source(cop,
                    ['if !a_condition',
                     '  some_method',
@@ -17,7 +17,7 @@ describe Rubocop::Cop::Style::FavorUnlessOverNegatedIf do
        'conditions.'] * 2)
   end
 
-  it 'registers an offence for if with "not" condition' do
+  it 'registers an offense for if with "not" condition' do
     inspect_source(cop,
                    ['if not a_condition',
                     '  some_method',
@@ -26,7 +26,7 @@ describe Rubocop::Cop::Style::FavorUnlessOverNegatedIf do
     expect(cop.messages).to eq(
       ['Favor unless (or control flow or) over if for negative ' \
        'conditions.'] * 2)
-    expect(cop.offences.map(&:line)).to eq([1, 4])
+    expect(cop.offenses.map(&:line)).to eq([1, 4])
   end
 
   it 'accepts an if/else with negative condition' do
@@ -41,7 +41,7 @@ describe Rubocop::Cop::Style::FavorUnlessOverNegatedIf do
                     'elsif other_condition',
                     '  something_else',
                     'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts an if where only part of the contition is negated' do
@@ -53,7 +53,7 @@ describe Rubocop::Cop::Style::FavorUnlessOverNegatedIf do
                     '  some_method',
                     'end',
                     'some_method if not condition or another_condition'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'is not confused by negated elsif' do
@@ -66,11 +66,11 @@ describe Rubocop::Cop::Style::FavorUnlessOverNegatedIf do
                     '  1',
                     'end'])
 
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'does not blow up for ternary ops' do
     inspect_source(cop, 'a ? b : c')
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/favor_until_over_negated_while_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::FavorUntilOverNegatedWhile do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for while with exclamation point condition' do
+  it 'registers an offense for while with exclamation point condition' do
     inspect_source(cop,
                    ['while !a_condition',
                     '  some_method',
@@ -16,7 +16,7 @@ describe Rubocop::Cop::Style::FavorUntilOverNegatedWhile do
       ['Favor until over while for negative conditions.'] * 2)
   end
 
-  it 'registers an offence for while with "not" condition' do
+  it 'registers an offense for while with "not" condition' do
     inspect_source(cop,
                    ['while (not a_condition)',
                     '  some_method',
@@ -24,7 +24,7 @@ describe Rubocop::Cop::Style::FavorUntilOverNegatedWhile do
                     'some_method while not a_condition'])
     expect(cop.messages).to eq(
       ['Favor until over while for negative conditions.'] * 2)
-    expect(cop.offences.map(&:line)).to eq([1, 4])
+    expect(cop.offenses.map(&:line)).to eq([1, 4])
   end
 
   it 'accepts an while where only part of the contition is negated' do

data/spec/rubocop/cop/style/file_name_spec.rb

@@ -0,0 +1,71 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::FileName do
+  subject(:cop) { described_class.new(config) }
+
+  let(:config) do
+    Rubocop::Config.new('AllCops' => { 'Includes' => includes })
+  end
+
+  let(:includes) { [] }
+
+  it 'reports offense for camelCase file names ending in .rb' do
+    source = ['print 1']
+    processed_source = parse_source(source)
+    allow(processed_source.buffer)
+      .to receive(:name).and_return('/some/dir/testCase.rb')
+    _investigate(cop, processed_source)
+    expect(cop.offenses.size).to eq(1)
+  end
+
+  it 'reports offense for camelCase file names without file extension' do
+    source = ['print 1']
+    processed_source = parse_source(source)
+    allow(processed_source.buffer)
+      .to receive(:name).and_return('/some/dir/testCase')
+    _investigate(cop, processed_source)
+    expect(cop.offenses.size).to eq(1)
+  end
+
+  it 'accepts offense for snake_case file names ending in .rb' do
+    source = ['print 1']
+    processed_source = parse_source(source)
+    allow(processed_source.buffer)
+      .to receive(:name).and_return('/some/dir/test_case.rb')
+    _investigate(cop, processed_source)
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts offense for snake_case file names without file extension' do
+    source = ['print 1']
+    processed_source = parse_source(source)
+    allow(processed_source.buffer)
+      .to receive(:name).and_return('/some/dir/test_case')
+    _investigate(cop, processed_source)
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts offense for snake_case file names with non-rb extension' do
+    source = ['print 1']
+    processed_source = parse_source(source)
+    allow(processed_source.buffer)
+      .to receive(:name).and_return('/some/dir/some_task.rake')
+    _investigate(cop, processed_source)
+    expect(cop.offenses).to be_empty
+  end
+
+  context 'when the file is specified in AllCops/Includes' do
+    let(:includes) { ['**/Gemfile'] }
+
+    it 'accepts the file name even if it is not snake_case' do
+      source = ['print 1']
+      processed_source = parse_source(source)
+      allow(processed_source.buffer)
+        .to receive(:name).and_return('/some/dir/Gemfile')
+      _investigate(cop, processed_source)
+      expect(cop.offenses).to be_empty
+    end
+  end
+end

data/spec/rubocop/cop/style/final_newline_spec.rb

@@ -5,22 +5,22 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::FinalNewline do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for missing final newline' do
+  it 'registers an offense for missing final newline' do
     source = ['x = 0', 'top']
     inspect_source(cop, source)
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'accepts a final newline' do
     source = ['x = 0', 'top', '']
     inspect_source(cop, source)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts an empty file' do
     source = ['']
     inspect_source(cop, source)
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'auto-corrects missing newline' do

data/spec/rubocop/cop/style/flip_flop_spec.rb

@@ -5,19 +5,19 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::FlipFlop do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for inclusive flip flops' do
+  it 'registers an offense for inclusive flip flops' do
     inspect_source(cop,
                    ['DATA.each_line do |line|',
                     'print line if (line =~ /begin/)..(line =~ /end/)',
                     'end'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
-  it 'registers an offence for exclusive flip flops' do
+  it 'registers an offense for exclusive flip flops' do
     inspect_source(cop,
                    ['DATA.each_line do |line|',
                     'print line if (line =~ /begin/)...(line =~ /end/)',
                     'end'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 end

data/spec/rubocop/cop/style/for_spec.rb

@@ -8,7 +8,7 @@ describe Rubocop::Cop::Style::For, :config do
   context 'when each is the enforced style' do
     let(:cop_config) { { 'EnforcedStyle' => 'each' } }
 
-    it 'registers an offence for for' do
+    it 'registers an offense for for' do
       inspect_source(cop,
                      ['def func',
                       '  for n in [1, 2, 3] do',
@@ -17,10 +17,10 @@ describe Rubocop::Cop::Style::For, :config do
                       'end'])
       expect(cop.messages).to eq(['Prefer *each* over *for*.'])
       expect(cop.highlights).to eq(['for'])
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' => 'for')
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'for')
     end
 
-    it 'registers an offence for opposite + correct style' do
+    it 'registers an offense for opposite + correct style' do
       inspect_source(cop,
                      ['def func',
                       '  for n in [1, 2, 3] do',
@@ -31,7 +31,7 @@ describe Rubocop::Cop::Style::For, :config do
                       '  end',
                       'end'])
       expect(cop.messages).to eq(['Prefer *each* over *for*.'])
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
     it 'accepts multiline each' do
@@ -41,17 +41,17 @@ describe Rubocop::Cop::Style::For, :config do
                       '    puts n',
                       '  end',
                       'end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts :for' do
       inspect_source(cop, ['[:for, :ala, :bala]'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
     it 'accepts def for' do
       inspect_source(cop, ['def for; end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 
@@ -65,10 +65,10 @@ describe Rubocop::Cop::Style::For, :config do
                       '    puts n',
                       '  end',
                       'end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
 
-    it 'registers an offence for multiline each' do
+    it 'registers an offense for multiline each' do
       inspect_source(cop,
                      ['def func',
                       '  [1, 2, 3].each do |n|',
@@ -77,10 +77,10 @@ describe Rubocop::Cop::Style::For, :config do
                       'end'])
       expect(cop.messages).to eq(['Prefer *for* over *each*.'])
       expect(cop.highlights).to eq(['each'])
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' => 'each')
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'each')
     end
 
-    it 'registers an offence for correct + opposite style' do
+    it 'registers an offense for correct + opposite style' do
       inspect_source(cop,
                      ['def func',
                       '  for n in [1, 2, 3] do',
@@ -91,7 +91,7 @@ describe Rubocop::Cop::Style::For, :config do
                       '  end',
                       'end'])
       expect(cop.messages).to eq(['Prefer *for* over *each*.'])
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
     it 'accepts single line each' do
@@ -99,7 +99,7 @@ describe Rubocop::Cop::Style::For, :config do
                      ['def func',
                       '  [1, 2, 3].each { |n| puts n }',
                       'end'])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 end