rubocop 0.18.1 → 0.19.0

data/spec/rubocop/cop/style/format_string_spec.rb

@@ -0,0 +1,136 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::FormatString, :config do
+  subject(:cop) { described_class.new(config) }
+
+  context 'when enforced style is sprintf' do
+    let(:cop_config) { { 'EnforcedStyle' => 'sprintf' } }
+    it 'registers an offense for a string followed by something' do
+      inspect_source(cop,
+                     ['puts "%d" % 10'])
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Favor sprintf over String#%.'])
+    end
+
+    it 'registers an offense for something followed by an array' do
+      inspect_source(cop,
+                     ['puts x % [10, 11]'])
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Favor sprintf over String#%.'])
+    end
+
+    it 'does not register an offense for numbers' do
+      inspect_source(cop,
+                     ['puts 10 % 4'])
+      expect(cop.offenses).to be_empty
+    end
+
+    it 'does not register an offense for ambiguous cases' do
+      inspect_source(cop,
+                     ['puts x % 4'])
+      expect(cop.offenses).to be_empty
+
+      inspect_source(cop,
+                     ['puts x % Y'])
+      expect(cop.offenses).to be_empty
+    end
+
+    it 'works if the first operand contains embedded expressions' do
+      inspect_source(cop,
+                     ['puts "#{x * 5} %d #{@test}" % 10'])
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Favor sprintf over String#%.'])
+    end
+
+    it 'registers an offense for format' do
+      inspect_source(cop,
+                     ['format(something, a, b)'])
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Favor sprintf over format.'])
+    end
+  end
+
+  context 'when enforced style is format' do
+    let(:cop_config) { { 'EnforcedStyle' => 'format' } }
+
+    it 'registers an offense for a string followed by something' do
+      inspect_source(cop,
+                     ['puts "%d" % 10'])
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Favor format over String#%.'])
+    end
+
+    it 'registers an offense for something followed by an array' do
+      inspect_source(cop,
+                     ['puts x % [10, 11]'])
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Favor format over String#%.'])
+    end
+
+    it 'does not register an offense for numbers' do
+      inspect_source(cop,
+                     ['puts 10 % 4'])
+      expect(cop.offenses).to be_empty
+    end
+
+    it 'does not register an offense for ambiguous cases' do
+      inspect_source(cop,
+                     ['puts x % 4'])
+      expect(cop.offenses).to be_empty
+
+      inspect_source(cop,
+                     ['puts x % Y'])
+      expect(cop.offenses).to be_empty
+    end
+
+    it 'works if the first operand contains embedded expressions' do
+      inspect_source(cop,
+                     ['puts "#{x * 5} %d #{@test}" % 10'])
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Favor format over String#%.'])
+    end
+
+    it 'registers an offense for sprintf' do
+      inspect_source(cop,
+                     ['sprintf(something, a, b)'])
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Favor format over sprintf.'])
+    end
+  end
+
+  context 'when enforced style is percent' do
+    let(:cop_config) { { 'EnforcedStyle' => 'percent' } }
+
+    it 'registers an offense for format' do
+      inspect_source(cop,
+                     ['format(something, a, b)'])
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Favor String#% over format.'])
+    end
+
+    it 'registers an offense for sprintf' do
+      inspect_source(cop,
+                     ['sprintf(something, a, b)'])
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Favor String#% over sprintf.'])
+    end
+
+    it 'accepts String#%' do
+      inspect_source(cop,
+                     ['puts "%d" % 10'])
+      expect(cop.offenses).to be_empty
+    end
+  end
+end

data/spec/rubocop/cop/style/global_vars_spec.rb

@@ -10,25 +10,25 @@ describe Rubocop::Cop::Style::GlobalVars, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { cop_config }
 
-  it 'registers an offence for $custom' do
+  it 'registers an offense for $custom' do
     inspect_source(cop, ['puts $custom'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it 'allows user whitelisted variables' do
     inspect_source(cop, ['puts $allowed'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   described_class::BUILT_IN_VARS.each do |var|
-    it "does not register an offence for built-in variable #{var}" do
+    it "does not register an offense for built-in variable #{var}" do
       inspect_source(cop, ["puts #{var}"])
-      expect(cop.offences).to be_empty
+      expect(cop.offenses).to be_empty
     end
   end
 
-  it 'does not register an offence for backrefs like $1' do
+  it 'does not register an offense for backrefs like $1' do
     inspect_source(cop, ['puts $1'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/style/hash_methods_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::HashMethods do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for has_key? with one arg' do
+  it 'registers an offense for has_key? with one arg' do
     inspect_source(cop,
                    ['o.has_key?(o)'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['has_key? is deprecated in favor of key?.'])
   end
@@ -16,13 +16,13 @@ describe Rubocop::Cop::Style::HashMethods do
   it 'accepts has_key? with no args' do
     inspect_source(cop,
                    ['o.has_key?'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
-  it 'registers an offence for has_value? with one arg' do
+  it 'registers an offense for has_value? with one arg' do
     inspect_source(cop,
                    ['o.has_value?(o)'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
     expect(cop.messages)
       .to eq(['has_value? is deprecated in favor of value?.'])
   end
@@ -30,7 +30,7 @@ describe Rubocop::Cop::Style::HashMethods do
   it 'accepts has_value? with no args' do
     inspect_source(cop,
                    ['o.has_value?'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'auto-corrects has_key? with key?' do

data/spec/rubocop/cop/style/hash_syntax_spec.rb

@@ -14,20 +14,20 @@ describe Rubocop::Cop::Style::HashSyntax, :config do
                           'SpaceAroundOperators' => { 'Enabled' => true })
     end
 
-    it 'registers offence for hash rocket syntax when new is possible' do
+    it 'registers offense for hash rocket syntax when new is possible' do
       inspect_source(cop, ['x = { :a => 0 }'])
       expect(cop.messages).to eq(['Use the new Ruby 1.9 hash syntax.'])
-      expect(cop.config_to_allow_offences)
+      expect(cop.config_to_allow_offenses)
         .to eq('EnforcedStyle' => 'hash_rockets')
     end
 
-    it 'registers an offence for mixed syntax when new is possible' do
+    it 'registers an offense for mixed syntax when new is possible' do
       inspect_source(cop, ['x = { :a => 0, b: 1 }'])
       expect(cop.messages).to eq(['Use the new Ruby 1.9 hash syntax.'])
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
-    it 'registers an offence for hash rockets in method calls' do
+    it 'registers an offense for hash rockets in method calls' do
       inspect_source(cop, ['func(3, :a => 0)'])
       expect(cop.messages).to eq(['Use the new Ruby 1.9 hash syntax.'])
     end
@@ -52,7 +52,7 @@ describe Rubocop::Cop::Style::HashSyntax, :config do
       expect(cop.messages).to be_empty
     end
 
-    it 'registers offence when keys start with an uppercase letter' do
+    it 'registers offense when keys start with an uppercase letter' do
       inspect_source(cop, ['x = { :A => 0 }'])
       expect(cop.messages).to eq(['Use the new Ruby 1.9 hash syntax.'])
     end
@@ -96,19 +96,19 @@ describe Rubocop::Cop::Style::HashSyntax, :config do
   context 'configured to enforce hash rockets style' do
     let(:cop_config) { { 'EnforcedStyle' => 'hash_rockets' } }
 
-    it 'registers offence for Ruby 1.9 style' do
+    it 'registers offense for Ruby 1.9 style' do
       inspect_source(cop, ['x = { a: 0 }'])
       expect(cop.messages).to eq(['Always use hash rockets in hashes.'])
-      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' => 'ruby19')
+      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'ruby19')
     end
 
-    it 'registers an offence for mixed syntax' do
+    it 'registers an offense for mixed syntax' do
       inspect_source(cop, ['x = { :a => 0, b: 1 }'])
       expect(cop.messages).to eq(['Always use hash rockets in hashes.'])
-      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
-    it 'registers an offence for 1.9 style in method calls' do
+    it 'registers an offense for 1.9 style in method calls' do
       inspect_source(cop, ['func(3, a: 0)'])
       expect(cop.messages).to eq(['Always use hash rockets in hashes.'])
     end

data/spec/rubocop/cop/style/if_unless_modifier_spec.rb

@@ -11,7 +11,7 @@ describe Rubocop::Cop::Style::IfUnlessModifier do
     Rubocop::Config.new(hash)
   end
 
-  it 'registers an offence for multiline if that fits on one line' do
+  it 'registers an offense for multiline if that fits on one line' do
     # This if statement fits exactly on one line if written as a
     # modifier.
     condition = 'a' * 38
@@ -24,11 +24,11 @@ describe Rubocop::Cop::Style::IfUnlessModifier do
                     '  end'])
     expect(cop.messages).to eq(
       ['Favor modifier if usage when you have a single-line' \
-       ' body. Another good alternative is the usage of control flow' +
+       ' body. Another good alternative is the usage of control flow' \
        ' &&/||.'])
   end
 
-  it 'registers an offence for short multiline if near an else etc' do
+  it 'registers an offense for short multiline if near an else etc' do
     inspect_source(cop,
                    ['if x',
                     '  y',
@@ -43,7 +43,7 @@ describe Rubocop::Cop::Style::IfUnlessModifier do
                     'if a',
                     '  b',
                     'end'])
-    expect(cop.offences.size).to eq(1)
+    expect(cop.offenses.size).to eq(1)
   end
 
   it "accepts multiline if that doesn't fit on one line" do
@@ -54,13 +54,13 @@ describe Rubocop::Cop::Style::IfUnlessModifier do
     check_short_multiline(cop, 'if')
   end
 
-  it 'registers an offence for multiline unless that fits on one line' do
+  it 'registers an offense for multiline unless that fits on one line' do
     inspect_source(cop, ['unless a',
                          '  b',
                          'end'])
     expect(cop.messages).to eq(
       ['Favor modifier unless usage when you have a single-line' \
-       ' body. Another good alternative is the usage of control flow' +
+       ' body. Another good alternative is the usage of control flow' \
        ' &&/||.'])
   end
 
@@ -68,7 +68,7 @@ describe Rubocop::Cop::Style::IfUnlessModifier do
     inspect_source(cop, ['unless a',
                          '  b # A comment',
                          'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   it 'accepts if-else-end' do
@@ -89,7 +89,7 @@ describe Rubocop::Cop::Style::IfUnlessModifier do
                          'elsif test2',
                          '  something_else',
                          'end'])
-    expect(cop.offences).to be_empty
+    expect(cop.offenses).to be_empty
   end
 
   context 'with implicit match conditional' do
@@ -106,11 +106,11 @@ describe Rubocop::Cop::Style::IfUnlessModifier do
     context 'when a multiline if fits on one line' do
       let(:conditional) { "/#{'a' * 36}/" }
 
-      it 'registers an offence' do
+      it 'registers an offense' do
         expect("  #{body} if #{conditional}".length).to eq(79)
 
         inspect_source(cop, source)
-        expect(cop.offences.size).to eq(1)
+        expect(cop.offenses.size).to eq(1)
       end
     end
 
@@ -121,7 +121,25 @@ describe Rubocop::Cop::Style::IfUnlessModifier do
         expect("  #{body} if #{conditional}".length).to eq(80)
 
         inspect_source(cop, source)
-        expect(cop.offences).to be_empty
+        expect(cop.offenses).to be_empty
+      end
+    end
+
+    context 'when the maximum line length is specified by the cop itself' do
+      let(:config) do
+        hash = {
+          'LineLength' => { 'Max' => 100 },
+          'IfUnlessModifier' => { 'MaxLineLength' => 79 }
+        }
+        Rubocop::Config.new(hash)
+      end
+
+      it "accepts multiline if that doesn't fit on one line" do
+        check_too_long(cop, 'if')
+      end
+
+      it "accepts multiline unless that doesn't fit on one line" do
+        check_too_long(cop, 'unless')
       end
     end
   end

data/spec/rubocop/cop/style/if_with_semicolon_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Rubocop::Cop::Style::IfWithSemicolon do
   subject(:cop) { described_class.new }
 
-  it 'registers an offence for one line if/;/end' do
+  it 'registers an offense for one line if/;/end' do
     inspect_source(cop, ['if cond; run else dont end'])
     expect(cop.messages).to eq(
       ['Never use if x; Use the ternary operator instead.'])

data/spec/rubocop/cop/style/indent_array_spec.rb

@@ -0,0 +1,136 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::IndentArray do
+  subject(:cop) { described_class.new }
+
+  it 'accepts multi-assignments' do
+    inspect_source(cop, 'a, b = b, a')
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts correctly indented only element' do
+    inspect_source(cop,
+                   ['a << [',
+                    '  1',
+                    ']'])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'registers an offense for incorrectly indented only element' do
+    inspect_source(cop,
+                   ['a << [',
+                    ' 1',
+                    ']'])
+    expect(cop.highlights).to eq(['1'])
+  end
+
+  it 'auto-corrects incorrectly indented only element' do
+    corrected = autocorrect_source(cop, ['a << [',
+                                         ' 1',
+                                         ']'])
+    expect(corrected).to eq ['a << [',
+                             '  1',
+                             ']'].join("\n")
+  end
+
+  it 'accepts correctly indented first element' do
+    inspect_source(cop,
+                   ['[',
+                    '  x,',
+                    '  y',
+                    ']'])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'registers an offense for incorrectly indented first element' do
+    inspect_source(cop,
+                   ['[',
+                    'x,',
+                    '  y',
+                    ']'])
+    expect(cop.highlights).to eq(['x'])
+  end
+
+  it 'accepts several elements per line' do
+    inspect_source(cop,
+                   ['a = [',
+                    '  1, 2',
+                    ']'])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts a first element on the same line as the left bracket' do
+    inspect_source(cop,
+                   ['a = ["a",',
+                    '     "b"]'])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts single line array' do
+    inspect_source(cop,
+                   ['a = [1, 2]'])
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'accepts an empty array' do
+    inspect_source(cop,
+                   ['a = []'])
+    expect(cop.offenses).to be_empty
+  end
+
+  context 'when array is method argument' do
+    context 'and arguments are surrounded by parentheses' do
+      it 'accepts normal indentation for first argument' do
+        inspect_source(cop,
+                       ['func([',
+                        '  1',
+                        '])'])
+        expect(cop.offenses).to be_empty
+      end
+
+      it 'registers an offense for incorrect indentation' do
+        inspect_source(cop,
+                       ['func([',
+                        '      1',
+                        '     ])'])
+        expect(cop.messages)
+          .to eq(['Use 2 spaces for indentation in an array, relative to ' \
+                  'the start of the line where the left bracket is.'])
+      end
+
+      it 'accepts normal indentation for second argument' do
+        inspect_source(cop,
+                       ['body.should have_tag("input", [',
+                        '  :name])'])
+        expect(cop.offenses).to be_empty
+      end
+    end
+
+    context 'and arguments are not surrounded by parentheses' do
+      it 'accepts single line array' do
+        inspect_source(cop,
+                       ['func x, [1, 2]'])
+        expect(cop.offenses).to be_empty
+      end
+
+      it 'accepts a correctly indented multi-line array' do
+        inspect_source(cop,
+                       ['func x, [',
+                        '  1, 2]'])
+        expect(cop.offenses).to be_empty
+      end
+
+      it 'registers an offense for incorrectly indented multi-line array' do
+        inspect_source(cop,
+                       ['func x, [',
+                        '       1, 2]'])
+        expect(cop.messages)
+          .to eq(['Use 2 spaces for indentation in an array, relative to ' \
+                  'the start of the line where the left bracket is.'])
+        expect(cop.highlights).to eq(['1'])
+      end
+    end
+  end
+end