rubocop-rspec 1.15.1 → 1.16.0

data/spec/rubocop/cop/rspec/iterated_expectation_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe RuboCop::Cop::RSpec::IteratedExpectation do
   subject(:cop) { described_class.new }
 
   it 'flags `each` with an expectation' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       it 'validates users' do
         [user1, user2, user3].each { |user| expect(user).to be_valid }
         ^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using the `all` matcher instead of iterating over an array.
@@ -11,7 +11,7 @@ RSpec.describe RuboCop::Cop::RSpec::IteratedExpectation do
   end
 
   it 'flags `each` when expectation calls method with arguments' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       it 'validates users' do
         [user1, user2, user3].each { |user| expect(user).to be_a(User) }
         ^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using the `all` matcher instead of iterating over an array.
@@ -20,7 +20,7 @@ RSpec.describe RuboCop::Cop::RSpec::IteratedExpectation do
   end
 
   it 'ignores `each` without expectation' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it 'validates users' do
         [user1, user2, user3].each { |user| allow(user).to receive(:method) }
       end
@@ -28,7 +28,7 @@ RSpec.describe RuboCop::Cop::RSpec::IteratedExpectation do
   end
 
   it 'flags `each` with multiple expectations' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       it 'validates users' do
         [user1, user2, user3].each do |user|
         ^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using the `all` matcher instead of iterating over an array.
@@ -40,7 +40,7 @@ RSpec.describe RuboCop::Cop::RSpec::IteratedExpectation do
   end
 
   it 'ignore `each` when the body does not contain only expectations' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it 'validates users' do
         [user1, user2, user3].each do |user|
           allow(Something).to receive(:method).and_return(user)
@@ -52,7 +52,7 @@ RSpec.describe RuboCop::Cop::RSpec::IteratedExpectation do
   end
 
   it 'ignores `each` with expectation on property' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it 'validates users' do
         [user1, user2, user3].each { |user| expect(user.name).to be }
       end
@@ -60,7 +60,7 @@ RSpec.describe RuboCop::Cop::RSpec::IteratedExpectation do
   end
 
   it 'ignores assignments in the iteration' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it 'validates users' do
         [user1, user2, user3].each { |user| array = array.concat(user) }
       end
@@ -68,7 +68,7 @@ RSpec.describe RuboCop::Cop::RSpec::IteratedExpectation do
   end
 
   it 'ignores `each` when there is a negative expectation' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it 'validates users' do
         [user1, user2, user3].each do |user|
           expect(user).not_to receive(:method)

data/spec/rubocop/cop/rspec/leading_subject_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
   subject(:cop) { described_class.new }
 
   it 'checks subject below let' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       RSpec.describe User do
         let(:params) { foo }
 
@@ -15,7 +15,7 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
   end
 
   it 'checks subject below let!' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       RSpec.describe User do
         let!(:params) { foo }
 
@@ -26,7 +26,7 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
   end
 
   it 'approves of subject above let' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         context 'blah' do
         end
@@ -39,7 +39,7 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
   end
 
   it 'handles subjects in contexts' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         let(:params) { foo }
 
@@ -51,7 +51,7 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
   end
 
   it 'handles subjects in tests' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         # This shouldn't really ever happen in a sane codebase but I still
         # want to avoid false positives

data/spec/rubocop/cop/rspec/let_before_examples_spec.rb

@@ -0,0 +1,83 @@
+RSpec.describe RuboCop::Cop::RSpec::LetBeforeExamples do
+  subject(:cop) { described_class.new }
+
+  it 'flags `let` after `it`' do
+    expect_offense(<<-RUBY)
+      RSpec.describe User do
+        it { is_expected.to be_after_let }
+        let(:foo) { bar }
+        ^^^^^^^^^^^^^^^^^ Move `let` before the examples in the group.
+      end
+    RUBY
+  end
+
+  it 'flags `let` after `context`' do
+    expect_offense(<<-RUBY)
+      RSpec.describe User do
+        context 'a context' do
+          it { is_expected.to be_after_let }
+        end
+
+        let(:foo) { bar }
+        ^^^^^^^^^^^^^^^^^ Move `let` before the examples in the group.
+      end
+    RUBY
+  end
+
+  it 'flags `let` after `include_examples`' do
+    expect_offense(<<-RUBY)
+      RSpec.describe User do
+        include_examples('should be after let')
+
+        let(:foo) { bar }
+        ^^^^^^^^^^^^^^^^^ Move `let` before the examples in the group.
+      end
+    RUBY
+  end
+
+  it 'does not flag `let` before the examples' do
+    expect_no_offenses(<<-RUBY)
+      RSpec.describe User do
+        let(:foo) { bar }
+
+        it { is_expected.to be_after_let }
+
+        context 'a context' do
+          it { is_expected.to work }
+        end
+
+        include_examples('everything is fine')
+      end
+    RUBY
+  end
+
+  it 'does not flag `let` in a nested context' do
+    expect_no_offenses(<<-RUBY)
+      RSpec.describe User do
+        let(:foo) { bar }
+
+        context 'something else' do
+          let(:foo) { baz }
+          it { is_expected.to work }
+        end
+
+        include_examples('everything is fine')
+      end
+    RUBY
+  end
+
+  it 'allows inclusion of context before `let`' do
+    expect_no_offenses(<<-RUBY)
+      RSpec.describe User do
+        include_context 'special user'
+
+        let(:foo) { bar }
+      end
+    RUBY
+  end
+
+  it 'does not encounter an error when handling an empty describe' do
+    expect { inspect_source(cop, 'RSpec.describe(User) do end', 'a_spec.rb') }
+      .not_to raise_error
+  end
+end

data/spec/rubocop/cop/rspec/let_setup_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe RuboCop::Cop::RSpec::LetSetup do
   subject(:cop) { described_class.new }
 
   it 'complains when let! is used and not referenced' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         let!(:foo) { bar }
         ^^^^^^^^^^ Do not use `let!` for test setup.
@@ -17,7 +17,7 @@ RSpec.describe RuboCop::Cop::RSpec::LetSetup do
   end
 
   it 'ignores let! when used in `before`' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         let!(:foo) { bar }
 
@@ -33,7 +33,7 @@ RSpec.describe RuboCop::Cop::RSpec::LetSetup do
   end
 
   it 'ignores let! when used in example' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         let!(:foo) { bar }
 
@@ -46,7 +46,7 @@ RSpec.describe RuboCop::Cop::RSpec::LetSetup do
   end
 
   it 'complains when let! is used and not referenced within nested group' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         context 'when something special happens' do
           let!(:foo) { bar }

data/spec/rubocop/cop/rspec/message_chain_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe RuboCop::Cop::RSpec::MessageChain do
   subject(:cop) { described_class.new }
 
   it 'finds `receive_message_chain`' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       before do
         allow(foo).to receive_message_chain(:one, :two) { :three }
                       ^^^^^^^^^^^^^^^^^^^^^ Avoid stubbing using `receive_message_chain`.
@@ -11,7 +11,7 @@ RSpec.describe RuboCop::Cop::RSpec::MessageChain do
   end
 
   it 'finds old `stub_chain` syntax' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       before do
         foo.stub_chain(:one, :two).and_return(:three)
             ^^^^^^^^^^ Avoid stubbing using `stub_chain`.

data/spec/rubocop/cop/rspec/message_expectation_spec.rb

@@ -9,14 +9,14 @@ RSpec.describe RuboCop::Cop::RSpec::MessageExpectation, :config do
     end
 
     it 'flags expect(...).to receive' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).to receive(:bar)
         ^^^^^^ Prefer `allow` for setting message expectations.
       RUBY
     end
 
     it 'approves of allow(...).to receive' do
-      expect_no_violations('allow(foo).to receive(:bar)')
+      expect_no_offenses('allow(foo).to receive(:bar)')
     end
 
     include_examples 'detects style', 'allow(foo).to receive(:bar)',  'allow'
@@ -29,14 +29,14 @@ RSpec.describe RuboCop::Cop::RSpec::MessageExpectation, :config do
     end
 
     it 'flags allow(...).to receive' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         allow(foo).to receive(:bar)
         ^^^^^ Prefer `expect` for setting message expectations.
       RUBY
     end
 
     it 'approves of expect(...).to receive' do
-      expect_no_violations('expect(foo).to receive(:bar)')
+      expect_no_offenses('expect(foo).to receive(:bar)')
     end
 
     include_examples 'detects style', 'expect(foo).to receive(:bar)', 'expect'

data/spec/rubocop/cop/rspec/message_spies_spec.rb

@@ -9,14 +9,14 @@ RSpec.describe RuboCop::Cop::RSpec::MessageSpies, :config do
     end
 
     it 'flags expect(send).to receive' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).to receive(:bar)
                        ^^^^^^^ Prefer `have_received` for setting message expectations. Setup `foo` as a spy using `allow` or `instance_spy`.
       RUBY
     end
 
     it 'flags expect(lvar).to receive' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         foo = baz
         expect(foo).to receive(:bar)
                        ^^^^^^^ Prefer `have_received` for setting message expectations. Setup `foo` as a spy using `allow` or `instance_spy`.
@@ -24,49 +24,49 @@ RSpec.describe RuboCop::Cop::RSpec::MessageSpies, :config do
     end
 
     it 'flags expect(ivar).to receive' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(@foo).to receive(:bar)
                         ^^^^^^^ Prefer `have_received` for setting message expectations. Setup `@foo` as a spy using `allow` or `instance_spy`.
       RUBY
     end
 
     it 'flags expect(const).to receive' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(Foo).to receive(:bar)
                        ^^^^^^^ Prefer `have_received` for setting message expectations. Setup `Foo` as a spy using `allow` or `instance_spy`.
       RUBY
     end
 
     it 'flags expect(...).not_to receive' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).not_to receive(:bar)
                            ^^^^^^^ Prefer `have_received` for setting message expectations. Setup `foo` as a spy using `allow` or `instance_spy`.
       RUBY
     end
 
     it 'flags expect(...).to_not receive' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).to_not receive(:bar)
                            ^^^^^^^ Prefer `have_received` for setting message expectations. Setup `foo` as a spy using `allow` or `instance_spy`.
       RUBY
     end
 
     it 'flags expect(...).to receive with' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).to receive(:bar).with(:baz)
                        ^^^^^^^ Prefer `have_received` for setting message expectations. Setup `foo` as a spy using `allow` or `instance_spy`.
       RUBY
     end
 
     it 'flags expect(...).to receive at_most' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).to receive(:bar).at_most(42).times
                        ^^^^^^^ Prefer `have_received` for setting message expectations. Setup `foo` as a spy using `allow` or `instance_spy`.
       RUBY
     end
 
     it 'approves of expect(...).to have_received' do
-      expect_no_violations('expect(foo).to have_received(:bar)')
+      expect_no_offenses('expect(foo).to have_received(:bar)')
     end
 
     include_examples 'detects style', 'expect(foo).to receive(:bar)', 'receive'
@@ -82,14 +82,14 @@ RSpec.describe RuboCop::Cop::RSpec::MessageSpies, :config do
     end
 
     it 'flags expect(send).to have_received' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).to have_received(:bar)
                        ^^^^^^^^^^^^^ Prefer `receive` for setting message expectations.
       RUBY
     end
 
     it 'flags expect(lvar).to have_received' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         foo = baz
         expect(foo).to have_received(:bar)
                        ^^^^^^^^^^^^^ Prefer `receive` for setting message expectations.
@@ -97,49 +97,49 @@ RSpec.describe RuboCop::Cop::RSpec::MessageSpies, :config do
     end
 
     it 'flags expect(ivar).to have_received' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(@foo).to have_received(:bar)
                         ^^^^^^^^^^^^^ Prefer `receive` for setting message expectations.
       RUBY
     end
 
     it 'flags expect(const).to have_received' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(Foo).to have_received(:bar)
                        ^^^^^^^^^^^^^ Prefer `receive` for setting message expectations.
       RUBY
     end
 
     it 'flags expect(...).not_to have_received' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).not_to have_received(:bar)
                            ^^^^^^^^^^^^^ Prefer `receive` for setting message expectations.
       RUBY
     end
 
     it 'flags expect(...).to_not have_received' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).to_not have_received(:bar)
                            ^^^^^^^^^^^^^ Prefer `receive` for setting message expectations.
       RUBY
     end
 
     it 'flags expect(...).to have_received with' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).to have_received(:bar).with(:baz)
                        ^^^^^^^^^^^^^ Prefer `receive` for setting message expectations.
       RUBY
     end
 
     it 'flags expect(...).to have_received at_most' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         expect(foo).to have_received(:bar).at_most(42).times
                        ^^^^^^^^^^^^^ Prefer `receive` for setting message expectations.
       RUBY
     end
 
     it 'approves of expect(...).to receive' do
-      expect_no_violations('expect(foo).to receive(:bar)')
+      expect_no_offenses('expect(foo).to receive(:bar)')
     end
 
     include_examples 'detects style', 'expect(foo).to receive(:bar)', 'receive'

data/spec/rubocop/cop/rspec/multiple_describes_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe RuboCop::Cop::RSpec::MultipleDescribes do
   subject(:cop) { described_class.new }
 
   it 'finds multiple top level describes with class and method' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe MyClass, '.do_something' do; end
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use multiple top level describes - try to nest them.
       describe MyClass, '.do_something_else' do; end
@@ -10,7 +10,7 @@ RSpec.describe RuboCop::Cop::RSpec::MultipleDescribes do
   end
 
   it 'finds multiple top level describes only with class' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe MyClass do; end
       ^^^^^^^^^^^^^^^^ Do not use multiple top level describes - try to nest them.
       describe MyOtherClass do; end
@@ -18,7 +18,7 @@ RSpec.describe RuboCop::Cop::RSpec::MultipleDescribes do
   end
 
   it 'skips single top level describe' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       require 'spec_helper'
 
       describe MyClass do