rubocop-rspec 1.15.1 → 1.16.0

data/spec/rubocop/cop/rspec/expect_actual_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
   subject(:cop) { described_class.new(config) }
 
   it 'flags numeric literal values within expect(...)' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         it 'uses expect incorrectly' do
           expect(123).to eq(bar)
@@ -21,7 +21,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
   end
 
   it 'flags boolean literal values within expect(...)' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         it 'uses expect incorrectly' do
           expect(true).to eq(bar)
@@ -34,7 +34,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
   end
 
   it 'flags string and symbol literal values within expect(...)' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         it 'uses expect incorrectly' do
           expect("foo").to eq(bar)
@@ -47,7 +47,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
   end
 
   it 'flags literal nil value within expect(...)' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         it 'uses expect incorrectly' do
           expect(nil).to eq(bar)
@@ -58,7 +58,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
   end
 
   it 'does not flag dynamic values within expect(...)' do
-    expect_no_violations(<<-'RUBY')
+    expect_no_offenses(<<-'RUBY')
       describe Foo do
         it 'uses expect correctly' do
           expect(foo).to eq(bar)
@@ -70,7 +70,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
   end
 
   it 'flags arrays containing only literal values within expect(...)' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         it 'uses expect incorrectly' do
           expect([123]).to eq(bar)
@@ -83,7 +83,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
   end
 
   it 'flags hashes containing only literal values within expect(...)' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         it 'uses expect incorrectly' do
           expect(foo: 1, bar: 2).to eq(bar)
@@ -96,7 +96,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
   end
 
   it 'flags ranges containing only literal values within expect(...)' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         it 'uses expect incorrectly' do
           expect(1..2).to eq(bar)
@@ -109,7 +109,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
   end
 
   it 'flags regexps containing only literal values within expect(...)' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         it 'uses expect incorrectly' do
           expect(/foo|bar/).to eq(bar)
@@ -120,7 +120,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectActual, :config do
   end
 
   it 'does not flag complex values with dynamic parts within expect(...)' do
-    expect_no_violations(<<-'RUBY')
+    expect_no_offenses(<<-'RUBY')
       describe Foo do
         it 'uses expect incorrectly' do
           expect.to eq(bar)

data/spec/rubocop/cop/rspec/expect_in_hook_spec.rb

@@ -0,0 +1,79 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::RSpec::ExpectInHook do
+  subject(:cop) { described_class.new }
+
+  it 'adds an offense for `expect` in `before` hook' do
+    expect_offense(<<-RUBY)
+      before do
+        expect(something).to eq('foo')
+        ^^^^^^ Do not use `expect` in `before` hook
+        is_expected.to eq('foo')
+        ^^^^^^^^^^^ Do not use `is_expected` in `before` hook
+        expect_any_instance_of(Something).to receive(:foo)
+        ^^^^^^^^^^^^^^^^^^^^^^ Do not use `expect_any_instance_of` in `before` hook
+      end
+    RUBY
+  end
+
+  it 'adds an offense for `expect` in `after` hook' do
+    expect_offense(<<-RUBY)
+      after do
+        expect(something).to eq('foo')
+        ^^^^^^ Do not use `expect` in `after` hook
+        is_expected.to eq('foo')
+        ^^^^^^^^^^^ Do not use `is_expected` in `after` hook
+        expect_any_instance_of(Something).to receive(:foo)
+        ^^^^^^^^^^^^^^^^^^^^^^ Do not use `expect_any_instance_of` in `after` hook
+      end
+    RUBY
+  end
+
+  it 'adds an offense for `expect` in `around` hook' do
+    expect_offense(<<-RUBY)
+      around do
+        expect(something).to eq('foo')
+        ^^^^^^ Do not use `expect` in `around` hook
+        is_expected(something).to eq('foo')
+        ^^^^^^^^^^^ Do not use `is_expected` in `around` hook
+        expect_any_instance_of(Something).to receive(:foo)
+        ^^^^^^^^^^^^^^^^^^^^^^ Do not use `expect_any_instance_of` in `around` hook
+      end
+    RUBY
+  end
+
+  it 'adds an offense for `expect` with block in `before` hook' do
+    expect_offense(<<-RUBY)
+      before do
+        expect { something }.to eq('foo')
+        ^^^^^^ Do not use `expect` in `before` hook
+      end
+    RUBY
+  end
+
+  it 'accepts an empty `before` hook' do
+    expect_no_offenses(<<-RUBY)
+      before do
+      end
+    RUBY
+  end
+
+  it 'accepts `allow` in `before` hook' do
+    expect_no_offenses(<<-RUBY)
+      before do
+        allow(something).to receive(:foo)
+        allow_any_instance_of(something).to receive(:foo)
+      end
+    RUBY
+  end
+
+  it 'accepts `expect` in `it`' do
+    expect_no_offenses(<<-RUBY)
+      it do
+        expect(something).to eq('foo')
+        is_expected.to eq('foo')
+        expect_any_instance_of(something).to receive(:foo)
+      end
+    RUBY
+  end
+end

data/spec/rubocop/cop/rspec/expect_output_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectOutput do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for overwriting $stdout within an example' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       specify do
         $stdout = StringIO.new
         ^^^^^^^ Use `expect { ... }.to output(...).to_stdout` instead of mutating $stdout.
@@ -16,7 +16,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectOutput do
 
   it 'registers an offense for overwriting $stderr ' \
      'within an example scoped hook' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       before(:each) do
         $stderr = StringIO.new
         ^^^^^^^ Use `expect { ... }.to output(...).to_stderr` instead of mutating $stderr.
@@ -25,7 +25,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectOutput do
   end
 
   it 'does not register an offense for interacting with $stdout' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       specify do
         $stdout.puts("hi")
       end
@@ -33,7 +33,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectOutput do
   end
 
   it 'does not flag assignments to other global variables' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       specify do
         $blah = StringIO.new
       end
@@ -41,7 +41,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectOutput do
   end
 
   it 'does not flag assignments to $stdout outside of example scope' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       before(:suite) do
         $stderr = StringIO.new
       end
@@ -49,7 +49,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectOutput do
   end
 
   it 'does not flag assignments to $stdout in example_group scope' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         $stderr = StringIO.new
       end
@@ -57,6 +57,6 @@ RSpec.describe RuboCop::Cop::RSpec::ExpectOutput do
   end
 
   it 'does not flag assigns to $stdout when in the root scope' do
-    expect_no_violations('$stderr = StringIO.new')
+    expect_no_offenses('$stderr = StringIO.new')
   end
 end

data/spec/rubocop/cop/rspec/factory_girl/dynamic_attribute_defined_statically_spec.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/LineLength
+RSpec.describe RuboCop::Cop::RSpec::FactoryGirl::DynamicAttributeDefinedStatically do
+  subject(:cop) { described_class.new(config) }
+
+  let(:config) { RuboCop::Config.new }
+
+  it 'registers an offense for offending code' do
+    expect_offense(<<-RUBY)
+      FactoryGirl.define do
+        factory :post do
+          published_at 1.day.from_now
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
+          status [:draft, :published].sample
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
+          created_at 1.day.ago
+          ^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
+        end
+      end
+    RUBY
+  end
+
+  it 'registers an offense in a trait' do
+    expect_offense(<<-RUBY)
+      FactoryGirl.define do
+        factory :post do
+          title "Something"
+          trait :published do
+            published_at 1.day.from_now
+            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
+          end
+        end
+      end
+    RUBY
+  end
+
+  it 'accepts' do
+    expect_no_offenses(<<-RUBY)
+      FactoryGirl.define do
+        factory :post do
+          trait :published do
+            published_at { 1.day.from_now }
+          end
+          created_at { 1.day.ago }
+          status :draft
+          comments_count 0
+          title "Static"
+          description { FFaker::Lorem.paragraph(10) }
+          tag Tag::MAGIC
+        end
+      end
+    RUBY
+  end
+
+  it 'does not add offense if out of factory girl block' do
+    expect_no_offenses(<<-RUBY)
+      status [:draft, :published].sample
+      published_at 1.day.from_now
+      created_at 1.day.ago
+    RUBY
+  end
+
+  bad = <<-RUBY
+    FactoryGirl.define do
+      factory :post do
+        status([:draft, :published].sample)
+        published_at 1.day.from_now
+        created_at(1.day.ago)
+        updated_at Time.current
+      end
+    end
+  RUBY
+
+  corrected = <<-RUBY
+    FactoryGirl.define do
+      factory :post do
+        status { [:draft, :published].sample }
+        published_at { 1.day.from_now }
+        created_at { 1.day.ago }
+        updated_at { Time.current }
+      end
+    end
+  RUBY
+
+  include_examples 'autocorrect', bad, corrected
+end

data/spec/rubocop/cop/rspec/file_path_spec.rb

@@ -2,170 +2,170 @@ RSpec.describe RuboCop::Cop::RSpec::FilePath, :config do
   subject(:cop) { described_class.new(config) }
 
   it 'registers an offense for a bad path' do
-    expect_violation(<<-RUBY, filename: 'wrong_path_foo_spec.rb')
+    expect_offense(<<-RUBY, 'wrong_path_foo_spec.rb')
       describe MyClass, 'foo' do; end
       ^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*foo*_spec.rb`.
     RUBY
   end
 
   it 'registers an offense for a wrong class but a correct method' do
-    expect_violation(<<-RUBY, filename: 'wrong_class_foo_spec.rb')
+    expect_offense(<<-RUBY, 'wrong_class_foo_spec.rb')
       describe MyClass, '#foo' do; end
       ^^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*foo*_spec.rb`.
     RUBY
   end
 
   it 'registers an offense for a repeated .rb' do
-    expect_violation(<<-RUBY, filename: 'my_class/foo_spec.rb.rb')
+    expect_offense(<<-RUBY, 'my_class/foo_spec.rb.rb')
       describe MyClass, '#foo' do; end
       ^^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*foo*_spec.rb`.
     RUBY
   end
 
   it 'registers an offense for a file missing a .rb' do
-    expect_violation(<<-RUBY, filename: 'my_class/foo_specorb')
+    expect_offense(<<-RUBY, 'my_class/foo_specorb')
       describe MyClass, '#foo' do; end
       ^^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*foo*_spec.rb`.
     RUBY
   end
 
   it 'registers an offense for a wrong class and highlights metadata' do
-    expect_violation(<<-RUBY, filename: 'wrong_class_foo_spec.rb')
+    expect_offense(<<-RUBY, 'wrong_class_foo_spec.rb')
       describe MyClass, '#foo', blah: :blah do; end
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*foo*_spec.rb`.
     RUBY
   end
 
   it 'registers an offense for a wrong class name' do
-    expect_violation(<<-RUBY, filename: 'wrong_class_spec.rb')
+    expect_offense(<<-RUBY, 'wrong_class_spec.rb')
       describe MyClass do; end
       ^^^^^^^^^^^^^^^^ Spec path should end with `my_class*_spec.rb`.
     RUBY
   end
 
   it 'registers an offense for a wrong class name with a symbol argument' do
-    expect_violation(<<-RUBY, filename: 'wrong_class_spec.rb')
+    expect_offense(<<-RUBY, 'wrong_class_spec.rb')
       describe MyClass, :foo do; end
       ^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*_spec.rb`.
     RUBY
   end
 
   it 'registers an offense for a file missing _spec' do
-    expect_violation(<<-RUBY, filename: 'user.rb')
+    expect_offense(<<-RUBY, 'user.rb')
       describe User do; end
       ^^^^^^^^^^^^^ Spec path should end with `user*_spec.rb`.
     RUBY
   end
 
   it 'skips specs that do not describe a class / method' do
-    expect_no_violations(<<-RUBY, filename: 'some/class/spec.rb')
+    expect_no_offenses(<<-RUBY, 'some/class/spec.rb')
       describe 'Test something' do; end
     RUBY
   end
 
   it 'skips specs that do have multiple top level describes' do
-    expect_no_violations(<<-RUBY, filename: 'some/class/spec.rb')
+    expect_no_offenses(<<-RUBY, 'some/class/spec.rb')
       describe MyClass, 'do_this' do; end
       describe MyClass, 'do_that' do; end
     RUBY
   end
 
   it 'checks class specs' do
-    expect_no_violations(<<-RUBY, filename: 'some/class_spec.rb')
+    expect_no_offenses(<<-RUBY, 'some/class_spec.rb')
       describe Some::Class do; end
     RUBY
   end
 
   it 'allows different parent directories' do
-    expect_no_violations(<<-RUBY, filename: 'parent_dir/some/class_spec.rb')
+    expect_no_offenses(<<-RUBY, 'parent_dir/some/class_spec.rb')
       describe Some::Class do; end
     RUBY
   end
 
   it 'handles CamelCaps class names' do
-    expect_no_violations(<<-RUBY, filename: 'my_class_spec.rb')
+    expect_no_offenses(<<-RUBY, 'my_class_spec.rb')
       describe MyClass do; end
     RUBY
   end
 
   it 'handles ACRONYMClassNames' do
-    expect_no_violations(<<-RUBY, filename: 'abc_one/two_spec.rb')
+    expect_no_offenses(<<-RUBY, 'abc_one/two_spec.rb')
       describe ABCOne::Two do; end
     RUBY
   end
 
   it 'handles ALLCAPS class names' do
-    expect_no_violations(<<-RUBY, filename: 'allcaps_spec.rb')
+    expect_no_offenses(<<-RUBY, 'allcaps_spec.rb')
       describe ALLCAPS do; end
     RUBY
   end
 
   it 'handles alphanumeric class names' do
-    expect_no_violations(<<-RUBY, filename: 'ipv4_and_ipv6_spec.rb')
+    expect_no_offenses(<<-RUBY, 'ipv4_and_ipv6_spec.rb')
       describe IPV4AndIPV6 do; end
     RUBY
   end
 
   it 'checks instance methods' do
-    expect_no_violations(<<-RUBY, filename: 'some/class/inst_spec.rb')
+    expect_no_offenses(<<-RUBY, 'some/class/inst_spec.rb')
       describe Some::Class, '#inst' do; end
     RUBY
   end
 
   it 'checks class methods' do
-    expect_no_violations(<<-RUBY, filename: 'some/class/inst_spec.rb')
+    expect_no_offenses(<<-RUBY, 'some/class/inst_spec.rb')
       describe Some::Class, '.inst' do; end
     RUBY
   end
 
   it 'allows flat hierarchies for instance methods' do
-    expect_no_violations(<<-RUBY, filename: 'some/class_inst_spec.rb')
+    expect_no_offenses(<<-RUBY, 'some/class_inst_spec.rb')
       describe Some::Class, '#inst' do; end
     RUBY
   end
 
   it 'allows flat hierarchies for class methods' do
-    expect_no_violations(<<-RUBY, filename: 'some/class_inst_spec.rb')
+    expect_no_offenses(<<-RUBY, 'some/class_inst_spec.rb')
       describe Some::Class, '.inst' do; end
     RUBY
   end
 
   it 'allows subdirs for instance methods' do
     filename = 'some/class/instance_methods/inst_spec.rb'
-    expect_no_violations(<<-RUBY, filename: filename)
+    expect_no_offenses(<<-RUBY, filename)
       describe Some::Class, '#inst' do; end
     RUBY
   end
 
   it 'allows subdirs for class methods' do
     filename = 'some/class/class_methods/inst_spec.rb'
-    expect_no_violations(<<-RUBY, filename: filename)
+    expect_no_offenses(<<-RUBY, filename)
       describe Some::Class, '.inst' do; end
     RUBY
   end
 
   it 'ignores non-alphanumeric characters' do
-    expect_no_violations(<<-RUBY, filename: 'some/class/pred_spec.rb')
+    expect_no_offenses(<<-RUBY, 'some/class/pred_spec.rb')
       describe Some::Class, '#pred?' do; end
     RUBY
   end
 
   it 'allows bang method' do
-    expect_no_violations(<<-RUBY, filename: 'some/class/bang_spec.rb')
+    expect_no_offenses(<<-RUBY, 'some/class/bang_spec.rb')
       describe Some::Class, '#bang!' do; end
     RUBY
   end
 
   it 'allows flexibility with predicates' do
     filename = 'some/class/thing_predicate_spec.rb'
-    expect_no_violations(<<-RUBY, filename: filename)
+    expect_no_offenses(<<-RUBY, filename)
       describe Some::Class, '#thing?' do; end
     RUBY
   end
 
   it 'allows flexibility with operators' do
     filename = 'my_little_class/spaceship_operator_spec.rb'
-    expect_no_violations(<<-RUBY, filename: filename)
+    expect_no_offenses(<<-RUBY, filename)
       describe MyLittleClass, '#<=>' do; end
     RUBY
   end
@@ -174,13 +174,13 @@ RSpec.describe RuboCop::Cop::RSpec::FilePath, :config do
     let(:cop_config) { { 'CustomTransform' => { 'FooFoo' => 'foofoo' } } }
 
     it 'respects custom module name transformation' do
-      expect_no_violations(<<-RUBY, filename: 'foofoo/some/class/bar_spec.rb')
+      expect_no_offenses(<<-RUBY, 'foofoo/some/class/bar_spec.rb')
         describe FooFoo::Some::Class, '#bar' do; end
       RUBY
     end
 
     it 'ignores routing specs' do
-      expect_no_violations(<<-RUBY, filename: 'foofoo/some/class/bar_spec.rb')
+      expect_no_offenses(<<-RUBY, 'foofoo/some/class/bar_spec.rb')
         describe MyController, "#foo", type: :routing do; end
       RUBY
     end
@@ -190,7 +190,7 @@ RSpec.describe RuboCop::Cop::RSpec::FilePath, :config do
     let(:cop_config) { { 'IgnoreMethods' => true } }
 
     it 'does not care about the described method' do
-      expect_no_violations(<<-RUBY, filename: 'my_class_spec.rb')
+      expect_no_offenses(<<-RUBY, 'my_class_spec.rb')
         describe MyClass, '#look_here_a_method' do; end
       RUBY
     end