rubocop-rspec 1.15.1 → 1.16.0

data/spec/rubocop/cop/rspec/repeated_description_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe RuboCop::Cop::RSpec::RepeatedDescription do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for repeated descriptions' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe 'doing x' do
         it "does x" do
         ^^^^^^^^^^^ Don't repeat descriptions within an example group.
@@ -18,7 +18,7 @@ RSpec.describe RuboCop::Cop::RSpec::RepeatedDescription do
   end
 
   it 'registers offense for repeated descriptions separated by a context' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe 'doing x' do
         it "does x" do
         ^^^^^^^^^^^ Don't repeat descriptions within an example group.
@@ -38,7 +38,7 @@ RSpec.describe RuboCop::Cop::RSpec::RepeatedDescription do
   end
 
   it 'ignores descriptions repeated in a shared context' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'doing x' do
         it "does x" do
         end
@@ -52,7 +52,7 @@ RSpec.describe RuboCop::Cop::RSpec::RepeatedDescription do
   end
 
   it 'ignores repeated descriptions in a nested context' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'doing x' do
         it "does x" do
         end
@@ -66,7 +66,7 @@ RSpec.describe RuboCop::Cop::RSpec::RepeatedDescription do
   end
 
   it 'does not flag tests which do not contain description strings' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'doing x' do
         it { foo }
         it { bar }

data/spec/rubocop/cop/rspec/repeated_example_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe RuboCop::Cop::RSpec::RepeatedExample do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for repeated example' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe 'doing x' do
         it "does x" do
         ^^^^^^^^^^^^^^ Don't repeat examples within an example group.
@@ -20,7 +20,7 @@ RSpec.describe RuboCop::Cop::RSpec::RepeatedExample do
   end
 
   it 'does not register a violation if rspec tag magic is involved' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'doing x' do
         it "does x" do
           expect(foo).to be(bar)
@@ -34,7 +34,7 @@ RSpec.describe RuboCop::Cop::RSpec::RepeatedExample do
   end
 
   it 'does not flag examples with different implementations' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'doing x' do
         it "does x" do
           expect(foo).to have_attribute(foo: 1)
@@ -48,7 +48,7 @@ RSpec.describe RuboCop::Cop::RSpec::RepeatedExample do
   end
 
   it 'does not flag examples when different its arguments are used' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'doing x' do
         its(:x) { is_expected.to be_present }
         its(:y) { is_expected.to be_present }
@@ -57,7 +57,7 @@ RSpec.describe RuboCop::Cop::RSpec::RepeatedExample do
   end
 
   it 'does not flag repeated examples in different scopes' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'doing x' do
         it "does x" do
           expect(foo).to be(bar)

data/spec/rubocop/cop/rspec/return_from_stub_spec.rb

@@ -0,0 +1,85 @@
+RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
+  subject(:cop) { described_class.new(config) }
+
+  let(:cop_config) do
+    { 'EnforcedStyle' => enforced_style }
+  end
+
+  context 'with EnforcedStyle `and_return`' do
+    let(:enforced_style) { 'and_return' }
+
+    it 'finds static values returned from block' do
+      expect_offense(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar) { 42 }
+                        ^^^^^^^^^^^^^^^^^^^^ Use `and_return` for static values.
+        end
+      RUBY
+    end
+
+    it 'finds array with only static values returned from block' do
+      expect_offense(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar) { [42, 43] }
+                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `and_return` for static values.
+        end
+      RUBY
+    end
+
+    it 'ignores dynamic values returned from block' do
+      expect_no_offenses(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar) { baz }
+        end
+      RUBY
+    end
+
+    it 'ignores variables return from block' do
+      expect_no_offenses(<<-RUBY)
+        it do
+          $bar = 42
+          baz = 123
+          allow(Foo).to receive(:bar) { $bar }
+          allow(Foo).to receive(:baz) { baz }
+        end
+      RUBY
+    end
+
+    it 'ignores array with dynamic values returned from block' do
+      expect_no_offenses(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar) { [42, baz] }
+        end
+      RUBY
+    end
+  end
+
+  context 'with EnforcedStyle `block`' do
+    let(:enforced_style) { 'block' }
+
+    it 'finds static values returned from method' do
+      expect_offense(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return(42)
+                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use block for static values.
+        end
+      RUBY
+    end
+
+    it 'ignores dynamic values returned from method' do
+      expect_no_offenses(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return(baz)
+        end
+      RUBY
+    end
+
+    it 'ignores multiple values being returned from method' do
+      expect_no_offenses(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return(42, 43, 44)
+        end
+      RUBY
+    end
+  end
+end

data/spec/rubocop/cop/rspec/scattered_let_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredLet do
   subject(:cop) { described_class.new }
 
   it 'flags `let` after the first different node ' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       RSpec.describe User do
         let(:a) { a }
         subject { User }
@@ -13,7 +13,7 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredLet do
   end
 
   it 'doesnt flag `let!` in the middle of multiple `let`s' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         subject { User }
 

data/spec/rubocop/cop/rspec/scattered_setup_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
   subject(:cop) { described_class.new }
 
   it 'flags multiple hooks in the same example group' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         before { bar }
         ^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
@@ -13,7 +13,7 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
   end
 
   it 'flags multiple hooks of the same scope with different symbols' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         before { bar }
         ^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
@@ -26,7 +26,7 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
   end
 
   it 'flags multiple before(:all) hooks in the same example group' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         before(:all) { bar }
         ^^^^^^^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
@@ -37,7 +37,7 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
   end
 
   it 'does not flag different hooks' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         before { bar }
         after { baz }
@@ -47,7 +47,7 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
   end
 
   it 'does not flag different hook types' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         before { bar }
         before(:all) { baz }
@@ -57,7 +57,7 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
   end
 
   it 'does not flag hooks in different example groups' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         before { bar }
 
@@ -69,7 +69,7 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
   end
 
   it 'does not flag hooks in different shared contexts' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         shared_context 'one' do
           before { bar }
@@ -83,7 +83,7 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
   end
 
   it 'does not flag similar method names inside of examples' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         before { bar }
 

data/spec/rubocop/cop/rspec/shared_context_spec.rb

@@ -3,14 +3,14 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
 
   context 'shared_context' do
     it 'does not register an offense for empty contexts' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         shared_context 'empty' do
         end
       RUBY
     end
 
     it 'registers an offense for shared_context with only examples' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         shared_context 'foo' do
         ^^^^^^^^^^^^^^^^^^^^ Use `shared_examples` when you don't define context.
           it 'performs actions' do
@@ -20,7 +20,7 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
     end
 
     it 'does not register an offense for `shared_context` with let' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         shared_context 'foo' do
           let(:foo) { :bar }
 
@@ -31,7 +31,7 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
     end
 
     it 'does not register an offense for `shared_context` with subject' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         shared_context 'foo' do
           subject(:foo) { :bar }
 
@@ -42,7 +42,7 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
     end
 
     it 'does not register an offense for `shared_context` with before' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         shared_context 'foo' do
           before do
             something
@@ -57,14 +57,14 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
 
   context 'shared_examples' do
     it 'does not register an offense for empty examples' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         shared_examples 'empty' do
         end
       RUBY
     end
 
     it 'registers an offense for shared_examples with only let' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         shared_examples 'foo' do
         ^^^^^^^^^^^^^^^^^^^^^ Use `shared_context` when you don't define examples.
           let(:foo) { :bar }
@@ -73,7 +73,7 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
     end
 
     it 'registers an offense for shared_examples with only subject' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         shared_examples 'foo' do
         ^^^^^^^^^^^^^^^^^^^^^ Use `shared_context` when you don't define examples.
           subject(:foo) { :bar }
@@ -82,7 +82,7 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
     end
 
     it 'registers an offense for shared_examples with only hooks' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         shared_examples 'foo' do
         ^^^^^^^^^^^^^^^^^^^^^ Use `shared_context` when you don't define examples.
           before do
@@ -93,7 +93,7 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
     end
 
     it 'does not register an offense for `shared_examples` with it' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         shared_examples 'foo' do
           subject(:foo) { 'foo' }
           let(:bar) { :baz }

data/spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb

@@ -3,7 +3,7 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
 
   describe 'receive_message_chain' do
     it 'reports single-argument calls' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         before do
           allow(foo).to receive_message_chain(:one) { :two }
                         ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
@@ -18,7 +18,7 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
     )
 
     it 'accepts multi-argument calls' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         before do
           allow(foo).to receive_message_chain(:one, :two) { :three }
         end
@@ -26,7 +26,7 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
     end
 
     it 'reports single-argument string calls' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         before do
           allow(foo).to receive_message_chain("one") { :two }
                         ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
@@ -41,7 +41,7 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
     )
 
     it 'accepts multi-argument string calls' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         before do
           allow(foo).to receive_message_chain("one.two") { :three }
         end
@@ -50,7 +50,7 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
 
     context 'with single-key hash argument' do
       it 'reports an offence' do
-        expect_violation(<<-RUBY)
+        expect_offense(<<-RUBY)
           before do
             allow(foo).to receive_message_chain(bar: 42)
                           ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
@@ -79,7 +79,7 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
 
     context 'with multiple keys hash argument' do
       it "doesn't report an offence" do
-        expect_no_violations(<<-RUBY)
+        expect_no_offenses(<<-RUBY)
           before do
             allow(foo).to receive_message_chain(bar: 42, baz: 42)
           end
@@ -90,7 +90,7 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
 
   describe 'stub_chain' do
     it 'reports single-argument calls' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         before do
           foo.stub_chain(:one) { :two }
               ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument.
@@ -105,7 +105,7 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
     )
 
     it 'accepts multi-argument calls' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         before do
           foo.stub_chain(:one, :two) { :three }
         end
@@ -113,7 +113,7 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
     end
 
     it 'reports single-argument string calls' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         before do
           foo.stub_chain("one") { :two }
               ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument.
@@ -128,7 +128,7 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
     )
 
     it 'accepts multi-argument string calls' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         before do
           foo.stub_chain("one.two") { :three }
         end

data/spec/rubocop/cop/rspec/subject_stub_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
   subject(:cop) { described_class.new }
 
   it 'complains when subject is stubbed' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         subject(:foo) { described_class.new }
 
@@ -21,7 +21,7 @@ RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
   end
 
   it 'complains when subject is mocked' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         subject(:foo) { described_class.new }
 
@@ -44,7 +44,7 @@ RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
   end
 
   it 'ignores stub within context where subject name changed' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         subject(:foo) { described_class.new }
 
@@ -60,7 +60,7 @@ RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
   end
 
   it 'flags nested subject stubs when nested subject uses same name' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         subject(:foo) { described_class.new }
 
@@ -81,7 +81,7 @@ RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
   end
 
   it 'ignores nested stubs when nested subject is anonymous' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         subject(:foo) { described_class.new }
 
@@ -101,7 +101,7 @@ RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
   end
 
   it 'flags nested subject stubs when example group does not define subject' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         subject(:foo) { described_class.new }
 
@@ -120,7 +120,7 @@ RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
   end
 
   it 'flags nested subject stubs' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         subject(:foo) { described_class.new }
 
@@ -142,7 +142,7 @@ RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
   end
 
   it 'flags nested subject stubs when adjacent context redefines' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         subject(:foo) { described_class.new }
 
@@ -159,7 +159,7 @@ RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
   end
 
   it 'flags deeply nested subject stubs' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         subject(:foo) { described_class.new }