rubocop-rspec 1.15.1 → 1.16.0

data/spec/rubocop/cop/rspec/described_class_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
 
   shared_examples 'SkipBlocks enabled' do
     it 'does not flag violations within non-rspec blocks' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         describe MyClass do
           controller(ApplicationController) do
             bar = MyClass
@@ -28,7 +28,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
 
   shared_examples 'SkipBlocks disabled' do
     it 'flags violations within all blocks' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         describe MyClass do
           controller(ApplicationController) do
             bar = MyClass
@@ -77,7 +77,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     let(:enforced_style) { :described_class }
 
     it 'checks for the use of the described class' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         describe MyClass do
           include MyClass
                   ^^^^^^^ Use `described_class` instead of `MyClass`.
@@ -92,7 +92,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'ignores described class as string' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe MyClass do
           subject { "MyClass" }
         end
@@ -100,7 +100,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'ignores describe that do not reference to a class' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe "MyClass" do
           subject { "MyClass" }
         end
@@ -108,7 +108,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'ignores class if the scope is changing' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe MyClass do
           Class.new  { foo = MyClass }
           Module.new { bar = MyClass }
@@ -129,7 +129,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'only takes class from top level describes' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         describe MyClass do
           describe MyClass::Foo do
             subject { MyClass::Foo }
@@ -142,7 +142,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'ignores subclasses' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe MyClass do
           subject { MyClass::SubClass }
         end
@@ -150,7 +150,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'ignores if namespace is not matching' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe MyNamespace::MyClass do
           subject { ::MyClass }
           let(:foo) { MyClass }
@@ -159,7 +159,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'checks for the use of described class with namespace' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         describe MyNamespace::MyClass do
           subject { MyNamespace::MyClass }
                     ^^^^^^^^^^^^^^^^^^^^ Use `described_class` instead of `MyNamespace::MyClass`.
@@ -168,7 +168,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'does not flag violations within a class scope change' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe MyNamespace::MyClass do
           before do
             class Foo
@@ -180,7 +180,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'does not flag violations within a hook scope change' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe do
           before do
             MyNamespace::MyClass.new
@@ -192,7 +192,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     it 'checks for the use of described class with module' do
       skip
 
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         module MyNamespace
           describe MyClass do
             subject { MyNamespace::MyClass }
@@ -219,7 +219,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     let(:enforced_style) { :explicit }
 
     it 'checks for the use of the described_class' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         describe MyClass do
           include described_class
                   ^^^^^^^^^^^^^^^ Use `MyClass` instead of `described_class`.
@@ -234,7 +234,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'ignores described_class as string' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe MyClass do
           subject { "described_class" }
         end
@@ -242,7 +242,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'ignores describe that do not reference to a class' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe "MyClass" do
           subject { described_class }
         end
@@ -250,7 +250,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'does not flag violations within a class scope change' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe MyNamespace::MyClass do
           before do
             class Foo
@@ -262,7 +262,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
     end
 
     it 'does not flag violations within a hook scope change' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe do
           before do
             described_class.new

data/spec/rubocop/cop/rspec/empty_example_group_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyExampleGroup, :config do
   subject(:cop) { described_class.new(config) }
 
   it 'flags an empty context' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
         context 'when bar' do
         ^^^^^^^^^^^^^^^^^^ Empty example group detected.
@@ -24,7 +24,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyExampleGroup, :config do
   end
 
   it 'flags an empty top level describe' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
       ^^^^^^^^^^^^ Empty example group detected.
       end
@@ -32,7 +32,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyExampleGroup, :config do
   end
 
   it 'does not flag include_examples' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Foo do
         context "when something is true" do
           include_examples "some expectations"
@@ -50,7 +50,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyExampleGroup, :config do
   end
 
   it 'does not recognize custom include methods by default' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Foo do
       ^^^^^^^^^^^^ Empty example group detected.
         context "when I do something clever" do
@@ -67,7 +67,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyExampleGroup, :config do
     end
 
     it 'does not flag an otherwise empty example group' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe Foo do
           context "when I do something clever" do
             it_has_special_behavior

data/spec/rubocop/cop/rspec/empty_line_after_final_let_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterFinalLet do
   subject(:cop) { described_class.new }
 
   it 'checks for empty line after last let' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       RSpec.describe User do
         let(:a) { a }
         let(:b) { b }
@@ -15,7 +15,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterFinalLet do
   end
 
   it 'check for empty line after the last `let!`' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       RSpec.describe User do
         let(:a) { a }
         let!(:b) do
@@ -28,7 +28,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterFinalLet do
   end
 
   it 'approves empty line after let' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
     RSpec.describe User do
       let(:a) { a }
       let(:b) { b }
@@ -39,7 +39,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterFinalLet do
   end
 
   it 'ignores empty lines between the lets' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       RSpec.describe User do
         let(:a) { a }
 
@@ -53,7 +53,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterFinalLet do
   end
 
   it 'handles let in tests' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         # This shouldn't really ever happen in a sane codebase but I still
         # want to avoid false positives
@@ -66,7 +66,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterFinalLet do
   end
 
   it 'handles multiline let block' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         let(:a) { a }
         let(:b) do
@@ -79,7 +79,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterFinalLet do
   end
 
   it 'handles let being the latest node' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         let(:a) { a }
         let(:b) { b }
@@ -88,7 +88,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterFinalLet do
   end
 
   it 'handles HEREDOC for let' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         let(:foo) do
           <<-BAR
@@ -105,7 +105,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterFinalLet do
   end
 
   it 'handles silly HEREDOC syntax for let' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe 'silly heredoc syntax' do
         let(:foo) { <<-BAR }
         hello

data/spec/rubocop/cop/rspec/empty_line_after_subject_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterSubject do
   subject(:cop) { described_class.new }
 
   it 'checks for empty line after subject' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       RSpec.describe User do
         subject { described_class.new }
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Add empty line after `subject`.
@@ -14,7 +14,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterSubject do
   end
 
   it 'approves empty line after subject' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         subject { described_class.new }
 
@@ -24,7 +24,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterSubject do
   end
 
   it 'handles subjects in tests' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         # This shouldn't really ever happen in a sane codebase but I still
         # want to avoid false positives
@@ -37,7 +37,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterSubject do
   end
 
   it 'handles multiline subject block' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         subject do
           described_class.new
@@ -49,7 +49,7 @@ RSpec.describe RuboCop::Cop::RSpec::EmptyLineAfterSubject do
   end
 
   it 'handles let being the latest node' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe User do
         subject { described_user }
       end

data/spec/rubocop/cop/rspec/example_length_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleLength, :config do
   let(:cop_config) { { 'Max' => 3 } }
 
   it 'ignores non-spec blocks' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       foo do
         line 1
         line 2
@@ -15,14 +15,14 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleLength, :config do
   end
 
   it 'allows an empty example' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it do
       end
     RUBY
   end
 
   it 'allows a short example' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it do
         line 1
         line 2
@@ -32,7 +32,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleLength, :config do
   end
 
   it 'ignores comments' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it do
         line 1
         line 2
@@ -44,7 +44,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleLength, :config do
 
   context 'when inspecting large examples' do
     it 'flags the example' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it do
         ^^^^^ Example has too many lines [4/3].
           line 1
@@ -62,7 +62,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleLength, :config do
     end
 
     it 'flags the example' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it do
         ^^^^^ Example has too many lines [4/3].
           line 1

data/spec/rubocop/cop/rspec/example_wording_spec.rb

@@ -10,11 +10,11 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleWording, :config do
     end
 
     it 'ignores non-example blocks' do
-      expect_no_violations('foo "should do something" do; end')
+      expect_no_offenses('foo "should do something" do; end')
     end
 
     it 'finds description with `should` at the beginning' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it 'should do something' do
             ^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
         end
@@ -22,7 +22,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleWording, :config do
     end
 
     it 'finds description with `Should` at the beginning' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it 'Should do something' do
             ^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
         end
@@ -30,7 +30,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleWording, :config do
     end
 
     it 'finds description with `shouldn\'t` at the beginning' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it "shouldn't do something" do
             ^^^^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
         end
@@ -38,7 +38,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleWording, :config do
     end
 
     it 'flags a lone should' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it 'should' do
             ^^^^^^ Do not use should when describing your tests.
         end
@@ -46,7 +46,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleWording, :config do
     end
 
     it 'flags a lone should not' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it 'should not' do
             ^^^^^^^^^^ Do not use should when describing your tests.
         end
@@ -54,7 +54,7 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleWording, :config do
     end
 
     it 'finds leading its' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it "it does something" do
             ^^^^^^^^^^^^^^^^^ Do not repeat 'it' when describing your tests.
         end
@@ -62,21 +62,21 @@ RSpec.describe RuboCop::Cop::RSpec::ExampleWording, :config do
     end
 
     it "skips words beginning with 'it'" do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         it 'itemizes items' do
         end
       RUBY
     end
 
     it 'skips descriptions without `should` at the beginning' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         it 'finds no should here' do
         end
       RUBY
     end
 
     it 'skips descriptions starting with words that begin with `should`' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         it 'shoulders the burden' do
         end
       RUBY