rubocop-rspec 1.15.1 → 1.16.0

data/spec/rubocop/cop/rspec/verified_doubles_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
   subject(:cop) { described_class.new(config) }
 
   it 'finds a `double` instead of an `instance_double`' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       it do
         foo = double("Widget")
               ^^^^^^^^^^^^^^^^ Prefer using verifying doubles over normal doubles.
@@ -14,7 +14,7 @@ RSpec.describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
     let(:cop_config) { {} }
 
     it 'find doubles whose name is a symbol' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it do
           foo = double(:widget)
                 ^^^^^^^^^^^^^^^ Prefer using verifying doubles over normal doubles.
@@ -23,7 +23,7 @@ RSpec.describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
     end
 
     it 'finds a `spy` instead of an `instance_spy`' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it do
           foo = spy("Widget")
                 ^^^^^^^^^^^^^ Prefer using verifying doubles over normal doubles.
@@ -36,7 +36,7 @@ RSpec.describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
     let(:cop_config) { { 'IgnoreSymbolicNames' => true } }
 
     it 'ignores doubles whose name is a symbol' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         it do
           foo = double(:widget)
         end
@@ -44,7 +44,7 @@ RSpec.describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
     end
 
     it 'still flags doubles whose name is a string' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it do
           foo = double("widget")
                 ^^^^^^^^^^^^^^^^ Prefer using verifying doubles over normal doubles.
@@ -54,7 +54,7 @@ RSpec.describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
   end
 
   it 'ignores doubles without a name' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it do
         foo = double
       end
@@ -62,7 +62,7 @@ RSpec.describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
   end
 
   it 'ignores instance_doubles' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it do
         foo = instance_double("Foo")
       end

data/spec/rubocop/cop/rspec/void_expect_spec.rb

@@ -0,0 +1,47 @@
+RSpec.describe RuboCop::Cop::RSpec::VoidExpect do
+  subject(:cop) { described_class.new }
+
+  it 'registers offenses to void `expect`' do
+    expect_offense(<<-RUBY)
+      it 'something' do
+        something = 1
+        expect(something)
+        ^^^^^^^^^^^^^^^^^ Do not use `expect()` without `.to` or `.not_to`. Chain the methods or remove it.
+      end
+    RUBY
+  end
+
+  it 'registers offenses to void `expect` when block has one expression' do
+    expect_offense(<<-RUBY)
+      it 'something' do
+        expect(something)
+        ^^^^^^^^^^^^^^^^^ Do not use `expect()` without `.to` or `.not_to`. Chain the methods or remove it.
+      end
+    RUBY
+  end
+
+  it 'registers offenses to void `expect` with block' do
+    expect_offense(<<-RUBY)
+      it 'something' do
+        expect{something}
+        ^^^^^^^^^^^^^^^^^ Do not use `expect()` without `.to` or `.not_to`. Chain the methods or remove it.
+      end
+    RUBY
+  end
+
+  it 'accepts non-void `expect`' do
+    expect_no_offenses(<<-RUBY)
+      it 'something' do
+        expect(something).to be 1
+      end
+    RUBY
+  end
+
+  it 'accepts non-void `expect` with block' do
+    expect_no_offenses(<<-RUBY)
+      it 'something' do
+        expect{something}.to raise_error(StandardError)
+      end
+    RUBY
+  end
+end

data/spec/rubocop/rspec/config_formatter_spec.rb

@@ -39,10 +39,12 @@ RSpec.describe RuboCop::RSpec::ConfigFormatter do
       |  Config: 2
       |  Enabled: true
       |  Description: Blah
+      |  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Foo
       |
       |RSpec/Bar:
       |  Enabled: true
       |  Description: Wow
+      |  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Bar
     YAML
   end
 end

data/spec/spec_helper.rb

@@ -35,7 +35,7 @@ RSpec.configure do |config|
   # We should take their advice!
   config.raise_on_warning = true
 
-  config.include(ExpectViolation)
+  config.include(ExpectOffense)
 end
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))

data/spec/support/expect_offense.rb

@@ -0,0 +1,17 @@
+# rubocop-rspec gem extension of RuboCop's ExpectOffense module.
+#
+# This mixin is the same as rubocop's ExpectOffense except the default
+# filename ends with `_spec.rb`
+module ExpectOffense
+  include RuboCop::RSpec::ExpectOffense
+
+  DEFAULT_FILENAME = 'example_spec.rb'.freeze
+
+  def expect_offense(source, filename = DEFAULT_FILENAME)
+    super
+  end
+
+  def expect_no_offenses(source, filename = DEFAULT_FILENAME)
+    super
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.15.1
+  version: 1.16.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-01 00:00:00.000000000 Z
+date: 2017-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.42.0
+        version: 0.49.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.42.0
+        version: 0.49.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -68,48 +68,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: anima
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: concord
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: adamantium
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -144,6 +102,8 @@ files:
 - Rakefile
 - config/default.yml
 - lib/rubocop-rspec.rb
+- lib/rubocop/cop/rspec/align_left_let_brace.rb
+- lib/rubocop/cop/rspec/align_right_let_brace.rb
 - lib/rubocop/cop/rspec/any_instance.rb
 - lib/rubocop/cop/rspec/around_block.rb
 - lib/rubocop/cop/rspec/be_eql.rb
@@ -159,40 +119,50 @@ files:
 - lib/rubocop/cop/rspec/example_length.rb
 - lib/rubocop/cop/rspec/example_wording.rb
 - lib/rubocop/cop/rspec/expect_actual.rb
+- lib/rubocop/cop/rspec/expect_in_hook.rb
 - lib/rubocop/cop/rspec/expect_output.rb
+- lib/rubocop/cop/rspec/factory_girl/dynamic_attribute_defined_statically.rb
 - lib/rubocop/cop/rspec/file_path.rb
 - lib/rubocop/cop/rspec/focus.rb
 - lib/rubocop/cop/rspec/hook_argument.rb
 - lib/rubocop/cop/rspec/implicit_expect.rb
 - lib/rubocop/cop/rspec/instance_spy.rb
 - lib/rubocop/cop/rspec/instance_variable.rb
+- lib/rubocop/cop/rspec/invalid_predicate_matcher.rb
 - lib/rubocop/cop/rspec/it_behaves_like.rb
 - lib/rubocop/cop/rspec/iterated_expectation.rb
 - lib/rubocop/cop/rspec/leading_subject.rb
+- lib/rubocop/cop/rspec/let_before_examples.rb
 - lib/rubocop/cop/rspec/let_setup.rb
 - lib/rubocop/cop/rspec/message_chain.rb
 - lib/rubocop/cop/rspec/message_expectation.rb
 - lib/rubocop/cop/rspec/message_spies.rb
 - lib/rubocop/cop/rspec/multiple_describes.rb
 - lib/rubocop/cop/rspec/multiple_expectations.rb
+- lib/rubocop/cop/rspec/multiple_subjects.rb
 - lib/rubocop/cop/rspec/named_subject.rb
 - lib/rubocop/cop/rspec/nested_groups.rb
 - lib/rubocop/cop/rspec/not_to_not.rb
 - lib/rubocop/cop/rspec/overwriting_setup.rb
+- lib/rubocop/cop/rspec/predicate_matcher.rb
 - lib/rubocop/cop/rspec/repeated_description.rb
 - lib/rubocop/cop/rspec/repeated_example.rb
+- lib/rubocop/cop/rspec/return_from_stub.rb
 - lib/rubocop/cop/rspec/scattered_let.rb
 - lib/rubocop/cop/rspec/scattered_setup.rb
 - lib/rubocop/cop/rspec/shared_context.rb
 - lib/rubocop/cop/rspec/single_argument_message_chain.rb
 - lib/rubocop/cop/rspec/subject_stub.rb
 - lib/rubocop/cop/rspec/verified_doubles.rb
+- lib/rubocop/cop/rspec/void_expect.rb
 - lib/rubocop/rspec.rb
+- lib/rubocop/rspec/align_let_brace.rb
 - lib/rubocop/rspec/concept.rb
 - lib/rubocop/rspec/config_formatter.rb
 - lib/rubocop/rspec/description_extractor.rb
 - lib/rubocop/rspec/example.rb
 - lib/rubocop/rspec/example_group.rb
+- lib/rubocop/rspec/factory_girl.rb
 - lib/rubocop/rspec/hook.rb
 - lib/rubocop/rspec/inject.rb
 - lib/rubocop/rspec/language.rb
@@ -202,10 +172,11 @@ files:
 - lib/rubocop/rspec/version.rb
 - lib/rubocop/rspec/wording.rb
 - rubocop-rspec.gemspec
-- spec/expect_violation/expectation_spec.rb
 - spec/project/changelog_spec.rb
 - spec/project/default_config_spec.rb
 - spec/project/project_requires_spec.rb
+- spec/rubocop/cop/rspec/align_left_let_brace_spec.rb
+- spec/rubocop/cop/rspec/align_right_let_brace_spec.rb
 - spec/rubocop/cop/rspec/any_instance_spec.rb
 - spec/rubocop/cop/rspec/around_block_spec.rb
 - spec/rubocop/cop/rspec/be_eql_spec.rb
@@ -221,34 +192,42 @@ files:
 - spec/rubocop/cop/rspec/example_length_spec.rb
 - spec/rubocop/cop/rspec/example_wording_spec.rb
 - spec/rubocop/cop/rspec/expect_actual_spec.rb
+- spec/rubocop/cop/rspec/expect_in_hook_spec.rb
 - spec/rubocop/cop/rspec/expect_output_spec.rb
+- spec/rubocop/cop/rspec/factory_girl/dynamic_attribute_defined_statically_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
 - spec/rubocop/cop/rspec/implicit_expect_spec.rb
 - spec/rubocop/cop/rspec/instance_spy_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
+- spec/rubocop/cop/rspec/invalid_predicate_matcher_spec.rb
 - spec/rubocop/cop/rspec/it_behaves_like_spec.rb
 - spec/rubocop/cop/rspec/iterated_expectation_spec.rb
 - spec/rubocop/cop/rspec/leading_subject_spec.rb
+- spec/rubocop/cop/rspec/let_before_examples_spec.rb
 - spec/rubocop/cop/rspec/let_setup_spec.rb
 - spec/rubocop/cop/rspec/message_chain_spec.rb
 - spec/rubocop/cop/rspec/message_expectation_spec.rb
 - spec/rubocop/cop/rspec/message_spies_spec.rb
 - spec/rubocop/cop/rspec/multiple_describes_spec.rb
 - spec/rubocop/cop/rspec/multiple_expectations_spec.rb
+- spec/rubocop/cop/rspec/multiple_subjects_spec.rb
 - spec/rubocop/cop/rspec/named_subject_spec.rb
 - spec/rubocop/cop/rspec/nested_groups_spec.rb
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
 - spec/rubocop/cop/rspec/overwriting_setup_spec.rb
+- spec/rubocop/cop/rspec/predicate_matcher_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
 - spec/rubocop/cop/rspec/repeated_example_spec.rb
+- spec/rubocop/cop/rspec/return_from_stub_spec.rb
 - spec/rubocop/cop/rspec/scattered_let_spec.rb
 - spec/rubocop/cop/rspec/scattered_setup_spec.rb
 - spec/rubocop/cop/rspec/shared_context_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
 - spec/rubocop/cop/rspec/subject_stub_spec.rb
 - spec/rubocop/cop/rspec/verified_doubles_spec.rb
+- spec/rubocop/cop/rspec/void_expect_spec.rb
 - spec/rubocop/rspec/config_formatter_spec.rb
 - spec/rubocop/rspec/description_extractor_spec.rb
 - spec/rubocop/rspec/example_group_spec.rb
@@ -260,7 +239,7 @@ files:
 - spec/shared/autocorrect_behavior.rb
 - spec/shared/detects_style_behavior.rb
 - spec/spec_helper.rb
-- spec/support/expect_violation.rb
+- spec/support/expect_offense.rb
 homepage: http://github.com/backus/rubocop-rspec
 licenses:
 - MIT
@@ -281,15 +260,16 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Code style checking for RSpec files
 test_files:
-- spec/expect_violation/expectation_spec.rb
 - spec/project/changelog_spec.rb
 - spec/project/default_config_spec.rb
 - spec/project/project_requires_spec.rb
+- spec/rubocop/cop/rspec/align_left_let_brace_spec.rb
+- spec/rubocop/cop/rspec/align_right_let_brace_spec.rb
 - spec/rubocop/cop/rspec/any_instance_spec.rb
 - spec/rubocop/cop/rspec/around_block_spec.rb
 - spec/rubocop/cop/rspec/be_eql_spec.rb
@@ -305,34 +285,42 @@ test_files:
 - spec/rubocop/cop/rspec/example_length_spec.rb
 - spec/rubocop/cop/rspec/example_wording_spec.rb
 - spec/rubocop/cop/rspec/expect_actual_spec.rb
+- spec/rubocop/cop/rspec/expect_in_hook_spec.rb
 - spec/rubocop/cop/rspec/expect_output_spec.rb
+- spec/rubocop/cop/rspec/factory_girl/dynamic_attribute_defined_statically_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
 - spec/rubocop/cop/rspec/implicit_expect_spec.rb
 - spec/rubocop/cop/rspec/instance_spy_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
+- spec/rubocop/cop/rspec/invalid_predicate_matcher_spec.rb
 - spec/rubocop/cop/rspec/it_behaves_like_spec.rb
 - spec/rubocop/cop/rspec/iterated_expectation_spec.rb
 - spec/rubocop/cop/rspec/leading_subject_spec.rb
+- spec/rubocop/cop/rspec/let_before_examples_spec.rb
 - spec/rubocop/cop/rspec/let_setup_spec.rb
 - spec/rubocop/cop/rspec/message_chain_spec.rb
 - spec/rubocop/cop/rspec/message_expectation_spec.rb
 - spec/rubocop/cop/rspec/message_spies_spec.rb
 - spec/rubocop/cop/rspec/multiple_describes_spec.rb
 - spec/rubocop/cop/rspec/multiple_expectations_spec.rb
+- spec/rubocop/cop/rspec/multiple_subjects_spec.rb
 - spec/rubocop/cop/rspec/named_subject_spec.rb
 - spec/rubocop/cop/rspec/nested_groups_spec.rb
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
 - spec/rubocop/cop/rspec/overwriting_setup_spec.rb
+- spec/rubocop/cop/rspec/predicate_matcher_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
 - spec/rubocop/cop/rspec/repeated_example_spec.rb
+- spec/rubocop/cop/rspec/return_from_stub_spec.rb
 - spec/rubocop/cop/rspec/scattered_let_spec.rb
 - spec/rubocop/cop/rspec/scattered_setup_spec.rb
 - spec/rubocop/cop/rspec/shared_context_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
 - spec/rubocop/cop/rspec/subject_stub_spec.rb
 - spec/rubocop/cop/rspec/verified_doubles_spec.rb
+- spec/rubocop/cop/rspec/void_expect_spec.rb
 - spec/rubocop/rspec/config_formatter_spec.rb
 - spec/rubocop/rspec/description_extractor_spec.rb
 - spec/rubocop/rspec/example_group_spec.rb
@@ -344,4 +332,4 @@ test_files:
 - spec/shared/autocorrect_behavior.rb
 - spec/shared/detects_style_behavior.rb
 - spec/spec_helper.rb
-- spec/support/expect_violation.rb
+- spec/support/expect_offense.rb

data/spec/expect_violation/expectation_spec.rb

@@ -1,85 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe ExpectViolation::Expectation do
-  subject(:expectation) { described_class.new(string) }
-
-  context 'when given a single assertion on class end' do
-    let(:string) do
-      <<-SRC
-        class Foo
-        end
-        ^^^ The end of `Foo` should be annotated.
-      SRC
-    end
-
-    let(:assertion) { expectation.assertions.first }
-
-    it 'has one assertion' do
-      expect(expectation.assertions.size).to be(1)
-    end
-
-    it 'has an assertion on line 2' do
-      expect(assertion.line_number).to be(2)
-    end
-
-    it 'has an assertion on column range 1-3' do
-      expect(assertion.column_range).to eql(8...11)
-    end
-
-    it 'has an assertion with correct violation message' do
-      expect(assertion.message).to eql('The end of `Foo` should be annotated.')
-    end
-
-    it 'recreates source' do
-      expect(expectation.source).to eql(<<-RUBY)
-        class Foo
-        end
-      RUBY
-    end
-  end
-
-  context 'when given many assertions on two lines' do
-    let(:string) do
-      <<-SRC
-        foo bar
-            ^ Charlie
-           ^^ Charlie
-            ^^ Bronco
-            ^^ Alpha
-        baz
-        ^ Delta
-      SRC
-    end
-
-    let(:assertions) { expectation.assertions.sort }
-
-    it 'has two assertions' do
-      expect(expectation.assertions.size).to be(5)
-    end
-
-    it 'has assertions on lines 1 and 2' do
-      expect(assertions.map(&:line_number)).to eql(
-        [1, 1, 1, 1, 2]
-      )
-    end
-
-    it 'has assertions on column range 1-3' do
-      expect(assertions.map(&:column_range)).to eql(
-        [11...13, 12...13, 12...14, 12...14, 8...9]
-      )
-    end
-
-    it 'has an assertion with correct violation message' do
-      expect(assertions.map(&:message)).to eql(
-        %w[Charlie Charlie Alpha Bronco Delta]
-      )
-    end
-
-    it 'recreates source' do
-      expect(expectation.source).to eql(<<-RUBY)
-        foo bar
-        baz
-      RUBY
-    end
-  end
-end