rubocop-rspec 1.15.1 → 1.16.0

data/spec/rubocop/cop/rspec/focus_spec.rb

@@ -3,7 +3,7 @@ RSpec.describe RuboCop::Cop::RSpec::Focus do
 
   # rubocop:disable RSpec/ExampleLength
   it 'flags all rspec example blocks with that include `focus: true`' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       example 'test', meta: true, focus: true do; end
                                   ^^^^^^^^^^^ Focused spec found.
       xit 'test', meta: true, focus: true do; end
@@ -38,7 +38,7 @@ RSpec.describe RuboCop::Cop::RSpec::Focus do
   end
 
   it 'flags all rspec example blocks that include `:focus`' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       example_group 'test', :focus do; end
                             ^^^^^^ Focused spec found.
       feature 'test', :focus do; end
@@ -73,7 +73,7 @@ RSpec.describe RuboCop::Cop::RSpec::Focus do
   end
 
   it 'does not flag unfocused specs' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       xcontext      'test' do; end
       xscenario     'test' do; end
       xspecify      'test' do; end
@@ -93,7 +93,7 @@ RSpec.describe RuboCop::Cop::RSpec::Focus do
   end
 
   it 'does not flag a method that is focused twice' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       fit "foo", :focus do
       ^^^^^^^^^^^^^^^^^ Focused spec found.
       end
@@ -101,14 +101,14 @@ RSpec.describe RuboCop::Cop::RSpec::Focus do
   end
 
   it 'ignores non-rspec code with :focus blocks' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       some_method "foo", focus: true do
       end
     RUBY
   end
 
   it 'flags focused block types' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       fdescribe 'test' do; end
       ^^^^^^^^^^^^^^^^ Focused spec found.
       ffeature 'test' do; end

data/spec/rubocop/cop/rspec/hook_argument_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe RuboCop::Cop::RSpec::HookArgument, :config do
 
   shared_examples 'ignored hooks' do
     it 'ignores :context and :suite' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         before(:suite) { true }
         after(:suite) { true }
         before(:context) { true }
@@ -18,13 +18,13 @@ RSpec.describe RuboCop::Cop::RSpec::HookArgument, :config do
     end
 
     it 'ignores hooks with more than one argument' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         before(:each, :something_custom) { true }
       RUBY
     end
 
     it 'ignores non-rspec hooks' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         setup(:each) { true }
       RUBY
     end
@@ -34,6 +34,13 @@ RSpec.describe RuboCop::Cop::RSpec::HookArgument, :config do
     include_examples 'autocorrect', 'before(:each) { }', output
     include_examples 'autocorrect', 'before(:example) { }', output
     include_examples 'autocorrect', 'before { }', output
+
+    include_examples 'autocorrect', 'config.before(:each) { }',
+                     'config.' + output
+    include_examples 'autocorrect', 'config.before(:example) { }',
+                     'config.' + output
+    include_examples 'autocorrect', 'config.before { }',
+                     'config.' + output
   end
 
   shared_examples 'an example hook' do
@@ -47,33 +54,36 @@ RSpec.describe RuboCop::Cop::RSpec::HookArgument, :config do
     let(:enforced_style) { :implicit }
 
     it 'detects :each for hooks' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         before(:each) { true }
         ^^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
         after(:each)  { true }
         ^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
         around(:each) { true }
         ^^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
+        config.after(:each)  { true }
+        ^^^^^^^^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
       RUBY
     end
 
     it 'detects :example for hooks' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         before(:example) { true }
         ^^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
         after(:example)  { true }
         ^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
         around(:example) { true }
         ^^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
+        config.before(:example) { true }
+        ^^^^^^^^^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
       RUBY
     end
 
     it 'does not flag hooks without default scopes' do
-      expect_no_violations(<<-RUBY)
-        before { true }
-        after { true }
+      expect_no_offenses(<<-RUBY)
         before { true }
         after { true }
+        config.before { true }
       RUBY
     end
 
@@ -85,34 +95,35 @@ RSpec.describe RuboCop::Cop::RSpec::HookArgument, :config do
     let(:enforced_style) { :each }
 
     it 'detects :each for hooks' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         before(:each) { true }
         after(:each)  { true }
         around(:each) { true }
+        config.before(:each) { true }
       RUBY
     end
 
     it 'detects :example for hooks' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         before(:example) { true }
         ^^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
         after(:example)  { true }
         ^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
         around(:example) { true }
         ^^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
+        config.before(:example) { true }
+        ^^^^^^^^^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
       RUBY
     end
 
-    it 'does not flag hooks without default scopes' do
-      expect_violation(<<-RUBY)
-        before { true }
-        ^^^^^^ Use `:each` for RSpec hooks.
-        after { true }
-        ^^^^^ Use `:each` for RSpec hooks.
+    it 'detects hooks without default scopes' do
+      expect_offense(<<-RUBY)
         before { true }
         ^^^^^^ Use `:each` for RSpec hooks.
         after { true }
         ^^^^^ Use `:each` for RSpec hooks.
+        config.before { true }
+               ^^^^^^ Use `:each` for RSpec hooks.
       RUBY
     end
 
@@ -124,34 +135,35 @@ RSpec.describe RuboCop::Cop::RSpec::HookArgument, :config do
     let(:enforced_style) { :example }
 
     it 'detects :example for hooks' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         before(:example) { true }
         after(:example)  { true }
         around(:example) { true }
+        config.before(:example) { true }
       RUBY
     end
 
     it 'detects :each for hooks' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         before(:each) { true }
         ^^^^^^^^^^^^^ Use `:example` for RSpec hooks.
         after(:each)  { true }
         ^^^^^^^^^^^^ Use `:example` for RSpec hooks.
         around(:each) { true }
         ^^^^^^^^^^^^^ Use `:example` for RSpec hooks.
+        config.before(:each) { true }
+        ^^^^^^^^^^^^^^^^^^^^ Use `:example` for RSpec hooks.
       RUBY
     end
 
     it 'does not flag hooks without default scopes' do
-      expect_violation(<<-RUBY)
-        before { true }
-        ^^^^^^ Use `:example` for RSpec hooks.
-        after { true }
-        ^^^^^ Use `:example` for RSpec hooks.
+      expect_offense(<<-RUBY)
         before { true }
         ^^^^^^ Use `:example` for RSpec hooks.
         after { true }
         ^^^^^ Use `:example` for RSpec hooks.
+        config.before { true }
+               ^^^^^^ Use `:example` for RSpec hooks.
       RUBY
     end
 

data/spec/rubocop/cop/rspec/implicit_expect_spec.rb

@@ -9,29 +9,29 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
     end
 
     it 'flags it { should }' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it { should be_truthy }
              ^^^^^^ Prefer `is_expected.to` over `should`.
       RUBY
     end
 
     it 'flags it { should_not }' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it { should_not be_truthy }
              ^^^^^^^^^^ Prefer `is_expected.to_not` over `should_not`.
       RUBY
     end
 
     it 'approves of is_expected.to' do
-      expect_no_violations('it { is_expected.to be_truthy }')
+      expect_no_offenses('it { is_expected.to be_truthy }')
     end
 
     it 'approves of is_expected.to_not' do
-      expect_no_violations('it { is_expected.to_not be_truthy }')
+      expect_no_offenses('it { is_expected.to_not be_truthy }')
     end
 
     it 'approves of is_expected.not_to' do
-      expect_no_violations('it { is_expected.not_to be_truthy }')
+      expect_no_offenses('it { is_expected.not_to be_truthy }')
     end
 
     include_examples 'detects style', 'it { should be_truthy }', 'should'
@@ -50,32 +50,32 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
     end
 
     it 'flags it { is_expected.to }' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it { is_expected.to be_truthy }
              ^^^^^^^^^^^^^^ Prefer `should` over `is_expected.to`.
       RUBY
     end
 
     it 'flags it { is_expected.to_not }' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it { is_expected.to_not be_truthy }
              ^^^^^^^^^^^^^^^^^^ Prefer `should_not` over `is_expected.to_not`.
       RUBY
     end
 
     it 'flags it { is_expected.not_to }' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it { is_expected.not_to be_truthy }
              ^^^^^^^^^^^^^^^^^^ Prefer `should_not` over `is_expected.not_to`.
       RUBY
     end
 
     it 'approves of should' do
-      expect_no_violations('it { should be_truthy }')
+      expect_no_offenses('it { should be_truthy }')
     end
 
     it 'approves of should_not' do
-      expect_no_violations('it { should_not be_truthy }')
+      expect_no_offenses('it { should_not be_truthy }')
     end
 
     include_examples 'detects style',

data/spec/rubocop/cop/rspec/instance_spy_spec.rb

@@ -3,7 +3,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceSpy do
 
   context 'when used with `have_received`' do
     it 'adds an offense for an instance_double with single argument' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it do
           foo = instance_double(Foo).as_null_object
                 ^^^^^^^^^^^^^^^^^^^^ Use `instance_spy` when you check your double with `have_received`.
@@ -13,7 +13,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceSpy do
     end
 
     it 'adds an offense for an instance_double with multiple arguments' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it do
           foo = instance_double(Foo, :name).as_null_object
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `instance_spy` when you check your double with `have_received`.
@@ -23,7 +23,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceSpy do
     end
 
     it 'ignores instance_double when it is not used with as_null_object' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         it do
           foo = instance_double(Foo)
           expect(bar).to have_received(:bar)
@@ -34,7 +34,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceSpy do
 
   context 'when not used with `have_received`' do
     it 'does not add an offence' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         it do
           foo = instance_double(Foo).as_null_object
           expect(bar).to have_received(:bar)

data/spec/rubocop/cop/rspec/instance_variable_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceVariable do
   subject(:cop) { described_class.new }
 
   it 'finds an instance variable inside a describe' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe MyClass do
         before { @foo = [] }
         it { expect(@foo).to be_empty }
@@ -12,7 +12,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceVariable do
   end
 
   it 'ignores non-spec blocks' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       not_rspec do
         before { @foo = [] }
         it { expect(@foo).to be_empty }
@@ -21,7 +21,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceVariable do
   end
 
   it 'finds an instance variable inside a shared example' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       shared_examples 'shared example' do
         it { expect(@foo).to be_empty }
                     ^^^^ Use `let` instead of an instance variable.
@@ -30,7 +30,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceVariable do
   end
 
   it 'ignores an instance variable without describe' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       @foo = []
       @foo.empty?
     RUBY
@@ -38,7 +38,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceVariable do
 
   # Regression test for nevir/rubocop-rspec#115
   it 'ignores instance variables outside of specs' do
-    expect_no_violations(<<-RUBY, filename: 'lib/source_code.rb')
+    expect_no_offenses(<<-RUBY, 'lib/source_code.rb')
       feature do
         @foo = bar
 
@@ -55,7 +55,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceVariable do
     end
 
     it 'flags an instance variable when it is also assigned' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         describe MyClass do
           before { @foo = [] }
           it { expect(@foo).to be_empty }
@@ -65,7 +65,7 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceVariable do
     end
 
     it 'ignores an instance variable when it is not assigned' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         describe MyClass do
           it { expect(@foo).to be_empty }
         end

data/spec/rubocop/cop/rspec/invalid_predicate_matcher_spec.rb

@@ -0,0 +1,37 @@
+RSpec.describe RuboCop::Cop::RSpec::InvalidPredicateMatcher do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offense for double question' do
+    expect_offense(<<-RUBY)
+      expect(foo).to be_something?
+                     ^^^^^^^^^^^^^ Omit `?` from `be_something?`.
+    RUBY
+  end
+
+  it 'registers an offense for double question with `not_to`' do
+    expect_offense(<<-RUBY)
+      expect(foo).not_to be_something?
+                         ^^^^^^^^^^^^^ Omit `?` from `be_something?`.
+    RUBY
+  end
+
+  it 'registers an offense for double question with `to_not`' do
+    expect_offense(<<-RUBY)
+      expect(foo).to_not be_something?
+                         ^^^^^^^^^^^^^ Omit `?` from `be_something?`.
+    RUBY
+  end
+
+  it 'registers an offense for double question with `have_something?`' do
+    expect_offense(<<-RUBY)
+      expect(foo).to have_something?
+                     ^^^^^^^^^^^^^^^ Omit `?` from `have_something?`.
+    RUBY
+  end
+
+  it 'accepts valid predicate matcher' do
+    expect_no_offenses(<<-RUBY)
+      expect(foo).to be_something
+    RUBY
+  end
+end

data/spec/rubocop/cop/rspec/it_behaves_like_spec.rb

@@ -11,14 +11,14 @@ RSpec.describe RuboCop::Cop::RSpec::ItBehavesLike, :config do
     let(:enforced_style) { :it_behaves_like }
 
     it 'flags a violation for it_should_behave_like' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it_should_behave_like 'a foo'
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `it_behaves_like` over `it_should_behave_like` when including examples in a nested context.
       RUBY
     end
 
     it 'does not flag a violation for it_behaves_like' do
-      expect_no_violations("it_behaves_like 'a foo'")
+      expect_no_offenses("it_behaves_like 'a foo'")
     end
 
     include_examples(
@@ -32,14 +32,14 @@ RSpec.describe RuboCop::Cop::RSpec::ItBehavesLike, :config do
     let(:enforced_style) { :it_should_behave_like }
 
     it 'flags a violation for it_behaves_like' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         it_behaves_like 'a foo'
         ^^^^^^^^^^^^^^^^^^^^^^^ Prefer `it_should_behave_like` over `it_behaves_like` when including examples in a nested context.
       RUBY
     end
 
     it 'does not flag a violation for it_behaves_like' do
-      expect_no_violations("it_should_behave_like 'a foo'")
+      expect_no_offenses("it_should_behave_like 'a foo'")
     end
 
     include_examples(