rubocop-rspec 1.15.1 → 1.16.0

data/spec/rubocop/cop/rspec/around_block_spec.rb

@@ -3,7 +3,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when no value is yielded' do
     it 'registers an offense' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         around do
         ^^^^^^^^^ Test object should be passed to around block.
           do_something
@@ -14,7 +14,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when the hook is scoped with a symbol' do
     it 'registers an offense' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         around(:each) do
         ^^^^^^^^^^^^^^^^ Test object should be passed to around block.
           do_something
@@ -25,7 +25,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when the yielded value is unused' do
     it 'registers an offense' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         around do |test|
                    ^^^^ You should call `test.call` or `test.run`.
           do_something
@@ -36,7 +36,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when two values are yielded and the first is unused' do
     it 'registers an offense for the first argument' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         around do |test, unused|
                    ^^^^ You should call `test.call` or `test.run`.
           unused.run
@@ -47,7 +47,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when the yielded value is referenced but not used' do
     it 'registers an offense' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         around do |test|
                    ^^^^ You should call `test.call` or `test.run`.
           test
@@ -58,7 +58,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when a method other than #run or #call is called' do
     it 'registers an offense' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         around do |test|
                    ^^^^ You should call `test.call` or `test.run`.
           test.inspect
@@ -69,7 +69,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when #run is called' do
     it 'does not register an offense' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         around do |test|
           test.run
         end
@@ -79,7 +79,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when #call is called' do
     it 'does not register an offense' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         around do |test|
           test.call
         end
@@ -89,7 +89,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when used as a block arg' do
     it 'does not register an offense' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         around do |test|
           1.times(&test)
         end
@@ -99,7 +99,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when passed to another method' do
     it 'does not register an offense' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         around do |test|
           something_that_might_run_test(test, another_arg)
         end
@@ -109,7 +109,7 @@ RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
 
   context 'when yielded to another block' do
     it 'does not register an offense' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         around do |test|
           foo { yield(some_arg, test) }
         end

data/spec/rubocop/cop/rspec/be_eql_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe RuboCop::Cop::RSpec::BeEql do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for `eql` when argument is a boolean' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       it { expect(foo).to eql(true) }
                           ^^^ Prefer `be` over `eql`.
       it { expect(foo).to eql(false) }
@@ -11,7 +11,7 @@ RSpec.describe RuboCop::Cop::RSpec::BeEql do
   end
 
   it 'registers an offense for `eql` when argument is an integer' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       it { expect(foo).to eql(0) }
                           ^^^ Prefer `be` over `eql`.
       it { expect(foo).to eql(123) }
@@ -20,7 +20,7 @@ RSpec.describe RuboCop::Cop::RSpec::BeEql do
   end
 
   it 'registers an offense for `eql` when argument is a float' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       it { expect(foo).to eql(1.0) }
                           ^^^ Prefer `be` over `eql`.
       it { expect(foo).to eql(1.23) }
@@ -29,27 +29,27 @@ RSpec.describe RuboCop::Cop::RSpec::BeEql do
   end
 
   it 'registers an offense for `eql` when argument is a symbol' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       it { expect(foo).to eql(:foo) }
                           ^^^ Prefer `be` over `eql`.
     RUBY
   end
 
   it 'registers an offense for `eql` when argument is nil' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       it { expect(foo).to eql(nil) }
                           ^^^ Prefer `be` over `eql`.
     RUBY
   end
 
   it 'does not register an offense for `eql` when argument is a string' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it { expect(foo).to eql('foo') }
     RUBY
   end
 
   it 'does not register an offense for `eql` when expectation is negated' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       it { expect(foo).to_not eql(1) }
     RUBY
   end

data/spec/rubocop/cop/rspec/before_after_all_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe RuboCop::Cop::RSpec::BeforeAfterAll, :config do
 
   context 'when using before all' do
     it 'registers an offense' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         before(:all) { do_something }
         ^^^^^^^^^^^^ #{message('before(:all)')}
         before(:context) { do_something }
@@ -21,7 +21,7 @@ RSpec.describe RuboCop::Cop::RSpec::BeforeAfterAll, :config do
 
   context 'when using after all' do
     it 'registers an offense' do
-      expect_violation(<<-RUBY)
+      expect_offense(<<-RUBY)
         after(:all) { do_something }
         ^^^^^^^^^^^ #{message('after(:all)')}
         after(:context) { do_something }
@@ -32,7 +32,7 @@ RSpec.describe RuboCop::Cop::RSpec::BeforeAfterAll, :config do
 
   context 'when using before each' do
     it 'does not register an offense' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         before(:each) { do_something }
         before(:example) { do_something }
       RUBY
@@ -41,7 +41,7 @@ RSpec.describe RuboCop::Cop::RSpec::BeforeAfterAll, :config do
 
   context 'when using after each' do
     it 'does not register an offense' do
-      expect_no_violations(<<-RUBY)
+      expect_no_offenses(<<-RUBY)
         after(:each) { do_something }
         after(:example) { do_something }
       RUBY

data/spec/rubocop/cop/rspec/cop_spec.rb

@@ -38,14 +38,14 @@ RSpec.describe RuboCop::Cop::RSpec::Cop do
 
   context 'when the source path ends with `_spec.rb`' do
     it 'registers an offense' do
-      expect_violation(<<-RUBY, filename: 'foo_spec.rb')
+      expect_offense(<<-RUBY, 'foo_spec.rb')
         foo(1)
         ^^^^^^ I flag everything
       RUBY
     end
 
     it 'ignores the file if it is ignored' do
-      expect_no_violations(<<-RUBY, filename: 'bar_spec.rb')
+      expect_no_offenses(<<-RUBY, 'bar_spec.rb')
         foo(1)
       RUBY
     end
@@ -53,7 +53,7 @@ RSpec.describe RuboCop::Cop::RSpec::Cop do
 
   context 'when the source path contains `/spec/`' do
     it 'registers an offense' do
-      expect_violation(<<-RUBY, filename: '/spec/support/thing.rb')
+      expect_offense(<<-RUBY, '/spec/support/thing.rb')
         foo(1)
         ^^^^^^ I flag everything
       RUBY
@@ -62,7 +62,7 @@ RSpec.describe RuboCop::Cop::RSpec::Cop do
 
   context 'when the source path starts with `spec/`' do
     it 'registers an offense' do
-      expect_violation(<<-RUBY, filename: 'spec/support/thing.rb')
+      expect_offense(<<-RUBY, 'spec/support/thing.rb')
         foo(1)
         ^^^^^^ I flag everything
       RUBY
@@ -71,13 +71,13 @@ RSpec.describe RuboCop::Cop::RSpec::Cop do
 
   context 'when the file is a source file without "spec" in the name' do
     it 'ignores the source when the path is not a spec file' do
-      expect_no_violations(<<-RUBY, filename: 'foo.rb')
+      expect_no_offenses(<<-RUBY, 'foo.rb')
         foo(1)
       RUBY
     end
 
     it 'ignores the source when the path is not a specified pattern' do
-      expect_no_violations(<<-RUBY, filename: 'foo_test.rb')
+      expect_no_offenses(<<-RUBY, 'foo_test.rb')
         foo(1)
       RUBY
     end
@@ -89,7 +89,7 @@ RSpec.describe RuboCop::Cop::RSpec::Cop do
     end
 
     it 'registers offenses when the path matches a custom specified pattern' do
-      expect_violation(<<-RUBY, filename: 'foo_test.rb')
+      expect_offense(<<-RUBY, 'foo_test.rb')
         foo(1)
         ^^^^^^ I flag everything
       RUBY

data/spec/rubocop/cop/rspec/describe_class_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeClass do
   subject(:cop) { described_class.new }
 
   it 'checks first-line describe statements' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe "bad describe" do
                ^^^^^^^^^^^^^^ The first argument to describe should be the class or module being tested.
       end
@@ -10,14 +10,14 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it 'supports RSpec.describe' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe Foo do
       end
     RUBY
   end
 
   it 'checks describe statements after a require' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       require 'spec_helper'
       describe "bad describe" do
                ^^^^^^^^^^^^^^ The first argument to describe should be the class or module being tested.
@@ -26,7 +26,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it 'checks highlights the first argument of a describe' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe "bad describe", "blah blah" do
                ^^^^^^^^^^^^^^ The first argument to describe should be the class or module being tested.
       end
@@ -34,7 +34,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it 'ignores nested describe statements' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Some::Class do
         describe "bad describe" do
         end
@@ -43,28 +43,28 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it 'ignores request specs' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'my new feature', type: :request do
       end
     RUBY
   end
 
   it 'ignores feature specs' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'my new feature', type: :feature do
       end
     RUBY
   end
 
   it 'ignores feature specs when RSpec.describe is used' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.describe 'my new feature', type: :feature do
       end
     RUBY
   end
 
   it 'flags specs with non :type metadata' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe 'my new feature', foo: :feature do
                ^^^^^^^^^^^^^^^^ The first argument to describe should be the class or module being tested.
       end
@@ -72,7 +72,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it 'flags normal metadata in describe' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe 'my new feature', blah, type: :wow do
                ^^^^^^^^^^^^^^^^ The first argument to describe should be the class or module being tested.
       end
@@ -80,39 +80,39 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it 'ignores feature specs - also with complex options' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'my new feature', :test, :type => :feature, :foo => :bar do
       end
     RUBY
   end
 
   it 'ignores an empty describe' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe do
       end
     RUBY
   end
 
   it 'ignores routing specs' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'my new route', type: :routing do
       end
     RUBY
   end
 
   it 'ignores view specs' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe 'widgets/index', type: :view do
       end
     RUBY
   end
 
   it "doesn't blow up on single-line describes" do
-    expect_no_violations('describe Some::Class')
+    expect_no_offenses('describe Some::Class')
   end
 
   it "doesn't flag top level describe in a shared example" do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       shared_examples 'Common::Interface' do
         describe '#public_interface' do
           it 'conforms to interface' do
@@ -124,7 +124,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it "doesn't flag top level describe in a shared context" do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       RSpec.shared_context 'Common::Interface' do
         describe '#public_interface' do
           it 'conforms to interface' do
@@ -136,7 +136,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it "doesn't flag top level describe in an unnamed shared context" do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       shared_context do
         describe '#public_interface' do
           it 'conforms to interface' do

data/spec/rubocop/cop/rspec/describe_method_spec.rb

@@ -2,11 +2,11 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeMethod do
   subject(:cop) { described_class.new }
 
   it 'ignores describes with only a class' do
-    expect_no_violations('describe Some::Class do; end')
+    expect_no_offenses('describe Some::Class do; end')
   end
 
   it 'enforces non-method names' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe Some::Class, 'nope', '.incorrect_usage' do
                             ^^^^^^ The second argument to describe should be the method being tested. '#instance' or '.class'.
       end
@@ -14,7 +14,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeMethod do
   end
 
   it 'skips methods starting with a . or #' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Some::Class, '.asdf' do
       end
 
@@ -24,7 +24,7 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeMethod do
   end
 
   it 'skips specs not having a string second argument' do
-    expect_no_violations(<<-RUBY)
+    expect_no_offenses(<<-RUBY)
       describe Some::Class, :config do
       end
     RUBY

data/spec/rubocop/cop/rspec/describe_symbol_spec.rb

@@ -2,28 +2,28 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeSymbol do
   subject(:cop) { described_class.new }
 
   it 'flags violations for `describe :symbol`' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe(:some_method) { }
                ^^^^^^^^^^^^ Avoid describing symbols.
     RUBY
   end
 
   it 'flags violations for `describe :symbol` with multiple arguments' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       describe(:some_method, "description") { }
                ^^^^^^^^^^^^ Avoid describing symbols.
     RUBY
   end
 
   it 'flags violations for `RSpec.describe :symbol`' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       RSpec.describe(:some_method, "description") { }
                      ^^^^^^^^^^^^ Avoid describing symbols.
     RUBY
   end
 
   it 'flags violations for a nested `describe`' do
-    expect_violation(<<-RUBY)
+    expect_offense(<<-RUBY)
       RSpec.describe Foo do
         describe :to_s do
                  ^^^^^ Avoid describing symbols.
@@ -33,10 +33,10 @@ RSpec.describe RuboCop::Cop::RSpec::DescribeSymbol do
   end
 
   it 'does not flag non-Symbol arguments' do
-    expect_no_violations('describe("#some_method") { }')
+    expect_no_offenses('describe("#some_method") { }')
   end
 
   it 'does not flag `context :symbol`' do
-    expect_no_violations('context(:some_method) { }')
+    expect_no_offenses('context(:some_method) { }')
   end
 end