rails_best_practices 1.19.1 → 1.19.2

data/spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -7,7 +9,7 @@ module RailsBestPractices
                                       reviews: ProtectMassAssignmentReview.new) }
 
       it 'should protect mass assignment' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
         end
         EOF
@@ -17,7 +19,7 @@ module RailsBestPractices
       end
 
       it 'should not protect mass assignment if attr_accessible is used with arguments and user set config.active_record.whitelist_attributes' do
-        content =<<-EOF
+        content = <<-EOF
         module RailsBestPracticesCom
           class Application < Rails::Application
             config.active_record.whitelist_attributes = true
@@ -25,7 +27,7 @@ module RailsBestPractices
         end
         EOF
         runner.prepare('config/application.rb', content)
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           attr_accessible :email, :password, :password_confirmation
         end
@@ -35,7 +37,7 @@ module RailsBestPractices
       end
 
       it 'should not protect mass assignment if attr_accessible is used without arguments and user set config.active_record.whitelist_attributes' do
-        content =<<-EOF
+        content = <<-EOF
         module RailsBestPracticesCom
           class Application < Rails::Application
             config.active_record.whitelist_attributes = true
@@ -43,7 +45,7 @@ module RailsBestPractices
         end
         EOF
         runner.prepare('config/application.rb', content)
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           attr_accessible
         end
@@ -53,7 +55,7 @@ module RailsBestPractices
       end
 
       it 'should not protect mass assignment with attr_protected if user set config.active_record.whitelist_attributes' do
-        content =<<-EOF
+        content = <<-EOF
         module RailsBestPracticesCom
           class Application < Rails::Application
             config.active_record.whitelist_attributes = true
@@ -61,7 +63,7 @@ module RailsBestPractices
         end
         EOF
         runner.prepare('config/application.rb', content)
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           attr_protected :role
         end
@@ -71,7 +73,7 @@ module RailsBestPractices
       end
 
       it 'should not protect mass assignment if using devise' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           devise :database_authenticatable, :registerable, :confirmable, :recoverable, stretches: 20
         end
@@ -81,7 +83,7 @@ module RailsBestPractices
       end
 
       it 'should not protect mass assignment if using authlogic with configuration' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           acts_as_authentic do |c|
             c.my_config_option = my_value
@@ -93,7 +95,7 @@ module RailsBestPractices
       end
 
       it 'should not protect mass assignment if using authlogic without configuration' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           acts_as_authentic
         end
@@ -103,7 +105,7 @@ module RailsBestPractices
       end
 
       it 'should not protect mass assignment if checking non ActiveRecord::Base inherited model' do
-        content =<<-EOF
+        content = <<-EOF
         class User < Person
         end
         EOF
@@ -113,7 +115,7 @@ module RailsBestPractices
 
       context 'strong_parameters' do
         it 'should not protect mass assignment for strong_parameters' do
-          content =<<-EOF
+          content = <<-EOF
           class User < ActiveRecord::Base
             include ActiveModel::ForbiddenAttributesProtection
           end
@@ -123,13 +125,13 @@ module RailsBestPractices
         end
 
         it 'should not protect mass assignment for strong_parameters' do
-          content =<<-EOF
+          content = <<-EOF
           class AR
             ActiveRecord::Base.send(:include, ActiveModel::ForbiddenAttributesProtection)
           end
           EOF
           runner.prepare('config/initializers/ar.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class User < ActiveRecord::Base
           end
           EOF
@@ -140,14 +142,14 @@ module RailsBestPractices
 
       context 'activerecord 4' do
         it 'should not protect mass assignment for activerecord 4' do
-          content =<<-EOF
+          content = <<-EOF
   GEM
     remote: https://rubygems.org
     specs:
       activerecord (4.0.0)
           EOF
           runner.prepare('Gemfile.lock', content)
-          content =<<-EOF
+          content = <<-EOF
           class User < ActiveRecord::Base
           end
           EOF
@@ -156,14 +158,14 @@ module RailsBestPractices
         end
 
         it 'should protect mass assignment for activerecord 3' do
-          content =<<-EOF
+          content = <<-EOF
   GEM
     remote: https://rubygems.org
     specs:
       activerecord (3.2.13)
           EOF
           runner.prepare('Gemfile.lock', content)
-          content =<<-EOF
+          content = <<-EOF
           class User < ActiveRecord::Base
           end
           EOF
@@ -175,7 +177,7 @@ module RailsBestPractices
       it 'should not check ignored files' do
         runner = Core::Runner.new(prepares: [Prepares::GemfilePrepare.new, Prepares::ConfigPrepare.new, Prepares::InitializerPrepare.new],
                                   reviews: ProtectMassAssignmentReview.new(ignored_files: /app\/models\/user\.rb/))
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
         end
         EOF

data/spec/rails_best_practices/reviews/remove_empty_helpers_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -6,7 +8,7 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(reviews: RemoveEmptyHelpersReview.new) }
 
       it 'should remove empty helpers' do
-        content =<<-EOF
+        content = <<-EOF
         module PostsHelper
         end
         EOF
@@ -16,7 +18,7 @@ module RailsBestPractices
       end
 
       it 'should not remove empty helpers' do
-        content =<<-EOF
+        content = <<-EOF
         module PostsHelper
           def post_link(post)
             post_path(post)
@@ -28,7 +30,7 @@ module RailsBestPractices
       end
 
       it 'should not remove empty application_helper' do
-        content =<<-EOF
+        content = <<-EOF
         module ApplicationHelper
         end
         EOF
@@ -38,7 +40,7 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: RemoveEmptyHelpersReview.new(ignored_files: /posts_helper/))
-        content =<<-EOF
+        content = <<-EOF
         module PostsHelper
         end
         EOF

data/spec/rails_best_practices/reviews/remove_unused_methods_in_controllers_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -5,12 +7,12 @@ module RailsBestPractices
     describe RemoveUnusedMethodsInControllersReview do
       let(:runner) { Core::Runner.new(
         prepares: [Prepares::ControllerPrepare.new, Prepares::RoutePrepare.new],
-        reviews: RemoveUnusedMethodsInControllersReview.new({'except_methods' => ['ExceptableController#*']})
+        reviews: RemoveUnusedMethodsInControllersReview.new('except_methods' => ['ExceptableController#*'])
       ) }
 
       context 'private/protected' do
         it 'should remove unused methods' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts do
               member do
@@ -21,7 +23,7 @@ module RailsBestPractices
           end
           EOF
           runner.prepare('config/routes.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ActiveRecord::Base
             def show; end
             def extra_update; end
@@ -41,13 +43,13 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods for before_filter' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
           end
           EOF
           runner.prepare('config/routes.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ActiveRecord::Base
             before_filter :load_post, :load_user
             def show; end
@@ -63,13 +65,13 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods for around_filter' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
           end
           EOF
           runner.prepare('config/routes.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ActiveRecord::Base
             around_filter :set_timestamp
             protected
@@ -88,13 +90,13 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods for layout' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
           end
           EOF
           runner.prepare('config/routes.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ActiveRecord::Base
             layout :choose_layout
             private
@@ -110,13 +112,13 @@ module RailsBestPractices
         end
 
         it 'should not remove inherited_resources methods' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
           end
           EOF
           runner.prepare('config/routes.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < InheritedResources::Base
             def show; end
             protected
@@ -134,13 +136,13 @@ module RailsBestPractices
 
       context 'public' do
         it 'should remove unused methods' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
           end
           EOF
           runner.prepare('config/routes.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def show; end
             def list; end
@@ -154,7 +156,7 @@ module RailsBestPractices
         end
 
         it 'should not remove inline routes' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: :none do
               get :display, :list, on: :member
@@ -162,7 +164,7 @@ module RailsBestPractices
           end
           EOF
           runner.prepare('config/routes.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def display; end
             def list; end
@@ -175,13 +177,13 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods if all actions are used in route' do
-          content =<<-EOF
+          content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.connect 'internal/:action/*whatever', controller: "internal"
           end
           EOF
           runner.prepare('config/routes.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class InternalController < ApplicationController
             def list; end
             def delete; end
@@ -195,7 +197,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods if they are except_methods' do
-          content =<<-EOF
+          content = <<-EOF
           class ExceptableController < ApplicationController
             def list; end
           end
@@ -209,19 +211,19 @@ module RailsBestPractices
 
       context 'assignment' do
         it 'should not remove unused methods if call in base class' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :user, only: :show do; end
           end
           EOF
           runner.prepare('config/routes.rb', content)
-          application_content =<<-EOF
+          application_content = <<-EOF
           class ApplicationController
             def current_user=(user); end
           end
           EOF
           runner.prepare('app/controllers/application_controller.rb', application_content)
-          users_content =<<-EOF
+          users_content = <<-EOF
           class UsersController < ApplicationController
             def show
               current_user = @user
@@ -340,7 +342,7 @@ module RailsBestPractices
 
       context 'cells' do
         it 'should remove unused methods' do
-          content =<<-EOF
+          content = <<-EOF
           class PostsCell < Cell::Rails
             def list; end
           end
@@ -353,7 +355,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods if render_cell' do
-          content =<<-EOF
+          content = <<-EOF
           class PostsCell < Cell::Rails
             def list; end
             def display; end
@@ -361,7 +363,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/cells/posts_cell.rb', content)
           runner.review('app/cells/posts_cell.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           <%= render_cell :posts, :list %>
           <%= render_cell(:posts, :display) %>
           EOF
@@ -371,7 +373,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods if render with state' do
-          content =<<-EOF
+          content = <<-EOF
           class PostsCell < Cell::Rails
             def list
               render state: :show
@@ -384,7 +386,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/cells/posts_cell.rb', content)
           runner.review('app/cells/posts_cell.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           <%= render_cell :posts, :list %>
           EOF
           runner.review('app/views/posts/index.html.erb', content)
@@ -394,14 +396,14 @@ module RailsBestPractices
       end
 
       it 'should not remove unused methods' do
-        route_content =<<-EOF
+        route_content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           namespace :admin do
             resources :users, only: :index
           end
         end
         EOF
-        app_controller_content =<<-EOF
+        app_controller_content = <<-EOF
         module Admin
           class AppController < ApplicationController
             def index
@@ -410,7 +412,7 @@ module RailsBestPractices
           end
         end
         EOF
-        users_controller_content =<<-EOF
+        users_controller_content = <<-EOF
         module Admin
           class UsersController < AppController
             private
@@ -433,7 +435,7 @@ module RailsBestPractices
       it 'should not check ignored files' do
         runner = Core::Runner.new(prepares: [Prepares::ControllerPrepare.new, Prepares::RoutePrepare.new],
                                   reviews: RemoveUnusedMethodsInControllersReview.new(ignored_files: /posts_controller/, except_methods: []))
-        content =<<-EOF
+        content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts do
               member do
@@ -444,7 +446,7 @@ module RailsBestPractices
           end
         EOF
         runner.prepare('config/routes.rb', content)
-        content =<<-EOF
+        content = <<-EOF
           class PostsController < ActiveRecord::Base
             def show; end
             def extra_update; end