rails_best_practices 1.19.1 → 1.19.2

data/spec/rails_best_practices/reviews/use_parentheses_in_method_def_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -123,7 +125,7 @@ module RailsBestPractices
       end
 
       it 'should not use query attribute for number' do
-        content =<<-EOF
+        content = <<-EOF
         <% unless @user.age.blank? %>
           <%= @user.age %>
         <% end %>

data/spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -6,7 +8,7 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(reviews: UseSayWithTimeInMigrationsReview.new) }
 
       it 'should use say with time in migrations' do
-        content =<<-EOF
+        content = <<-EOF
         def self.up
           User.find_each do |user|
             user.first_name, user.last_name = user.full_name.split(' ')
@@ -20,7 +22,7 @@ module RailsBestPractices
       end
 
       it 'should use say with time in migrations with create_table' do
-        content =<<-EOF
+        content = <<-EOF
         def self.up
           create_table :users do |t|
             t.string :login
@@ -39,7 +41,7 @@ module RailsBestPractices
       end
 
       it 'should not use say with time in migrations' do
-        content =<<-EOF
+        content = <<-EOF
         def self.up
           say_with_time("Initialize first_name and last_name for users") do
             User.find_each do |user|
@@ -55,7 +57,7 @@ module RailsBestPractices
       end
 
       it 'should not use say with time in migrations when not first code line' do
-        content =<<-EOF
+        content = <<-EOF
         def self.up
           User.find_each do |user|
             say_with_time 'Updating user with latest data' do
@@ -69,7 +71,7 @@ module RailsBestPractices
       end
 
       it 'should not use say with time when default migration message' do
-        content =<<-EOF
+        content = <<-EOF
         def self.up
           create_table :users do |t|
             t.string :login
@@ -83,7 +85,7 @@ module RailsBestPractices
       end
 
       it 'should not raise an error' do
-        content =<<-EOF
+        content = <<-EOF
         class AddAdmin < ActiveRecord::Migration
 
           class Person < ActiveRecord::Base
@@ -120,7 +122,7 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: UseSayWithTimeInMigrationsReview.new(ignored_files: /20101010080658_update_users/))
-        content =<<-EOF
+        content = <<-EOF
         def self.up
           User.find_each do |user|
             user.first_name, user.last_name = user.full_name.split(' ')

data/spec/rails_best_practices/reviews/use_scope_access_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/use_turbo_sprockets_rails3_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.19.1
+  version: 1.19.2
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-07 00:00:00.000000000 Z
+date: 2018-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -67,35 +67,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: require_all
+  name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: ruby-progressbar
+  name: require_all
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: json
+  name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,21 +109,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: awesome_print
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -151,21 +151,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: slim
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '11.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '11.0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -179,7 +179,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: awesome_print
+  name: slim
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="