rails_best_practices 1.19.1 → 1.19.2

data/spec/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/restrict_auto_generated_routes_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -7,7 +9,7 @@ module RailsBestPractices
 
       describe 'resources' do
         before :each do
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def show; end
             def new; end
@@ -21,7 +23,7 @@ module RailsBestPractices
         end
 
         it 'should restrict auto-generated routes' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
           end
@@ -32,7 +34,7 @@ module RailsBestPractices
         end
 
         it 'should not restrict auto-generated routes with only' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: %w(show new create edit update destroy)
           end
@@ -42,7 +44,7 @@ module RailsBestPractices
         end
 
         it 'should not restrict auto-generated routes with except' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, except: :index
           end
@@ -53,7 +55,7 @@ module RailsBestPractices
 
         describe 'specify a controller' do
           it 'should restrict auto-generated routes' do
-            content =<<-EOF
+            content = <<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               resources :articles, controller: "posts"
             end
@@ -66,7 +68,7 @@ module RailsBestPractices
 
         describe 'namespace' do
           before do
-            content =<<-EOF
+            content = <<-EOF
             class Admin::CommentsController < ApplicationController
               def show; end
               def new; end
@@ -80,7 +82,7 @@ module RailsBestPractices
           end
 
           it 'should restrict auto-generated routes' do
-            content =<<-EOF
+            content = <<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               namespace :admin do
                 resources :comments
@@ -93,7 +95,7 @@ module RailsBestPractices
           end
 
           it 'should restrict auto-generated routes with scope :module' do
-            content =<<-EOF
+            content = <<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               scope module: :admin do
                 resources :comments
@@ -106,7 +108,7 @@ module RailsBestPractices
           end
 
           it 'should restrict auto-generated routes with resources :module' do
-            content =<<-EOF
+            content = <<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               resources :comments, module: :admin
             end
@@ -119,7 +121,7 @@ module RailsBestPractices
 
         describe 'nested routes' do
           before :each do
-            content =<<-EOF
+            content = <<-EOF
             class CommentsController < ApplicationController
               def index; end
               def show; end
@@ -134,7 +136,7 @@ module RailsBestPractices
           end
 
           it 'should restrict auto-generated routes' do
-            content =<<-EOF
+            content = <<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               resources :posts do
                 resources :comments
@@ -147,7 +149,7 @@ module RailsBestPractices
           end
 
           it 'should not restrict auto-generated routes with only' do
-            content =<<-EOF
+            content = <<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               resources :posts, only: %w(show new create edit update destroy) do
                 resources :comments
@@ -159,7 +161,7 @@ module RailsBestPractices
           end
 
           it 'should not restrict auto-generated routes with except' do
-            content =<<-EOF
+            content = <<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               resources :posts, except: :index do
                 resources :comments
@@ -174,7 +176,7 @@ module RailsBestPractices
 
       describe 'resource' do
         before :each do
-          content =<<-EOF
+          content = <<-EOF
           class AccountsController < ApplicationController
             def show; end
             def new; end
@@ -187,7 +189,7 @@ module RailsBestPractices
         end
 
         it 'should restrict auto-generated routes' do
-          content =<<-EOF
+          content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.resource :account
           end
@@ -198,7 +200,7 @@ module RailsBestPractices
         end
 
         it 'should not restrict auto-generated routes with only' do
-          content =<<-EOF
+          content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.resource :account, only: %w(show new create edit update)
           end
@@ -208,7 +210,7 @@ module RailsBestPractices
         end
 
         it 'should not restrict auto-generated routes with except' do
-          content =<<-EOF
+          content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.resource :account, except: :destroy
           end
@@ -221,7 +223,7 @@ module RailsBestPractices
           runner = Core::Runner.new(prepares: Prepares::ControllerPrepare.new,
                                     reviews: RestrictAutoGeneratedRoutesReview.new(ignored_files: /config\/routes\.rb/))
 
-          content =<<-EOF
+          content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.resource :account
           end
@@ -235,7 +237,7 @@ module RailsBestPractices
         let(:runner) { Core::Runner.new(prepares: [Prepares::ConfigPrepare.new, Prepares::ControllerPrepare.new], reviews: RestrictAutoGeneratedRoutesReview.new) }
 
         before do
-          content =<<-EOF
+          content = <<-EOF
           module RailsBestPracticesCom
             class Application < Rails::Application
               config.api_only = true
@@ -243,7 +245,7 @@ module RailsBestPractices
           end
           EOF
           runner.prepare('config/application.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def show; end
             def create; end
@@ -255,7 +257,7 @@ module RailsBestPractices
         end
 
         it 'should restrict auto-generated routes' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
           end
@@ -266,7 +268,7 @@ module RailsBestPractices
         end
 
         it 'should not restrict auto-generated routes with only' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: %w(show create update destroy)
           end

data/spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -6,7 +8,7 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(reviews: SimplifyRenderInControllersReview.new) }
 
       it 'should simplify render action view' do
-        content =<<-EOF
+        content = <<-EOF
         def edit
           render action: :edit
         end
@@ -17,7 +19,7 @@ module RailsBestPractices
       end
 
       it "should simplify render actions's template" do
-        content =<<-EOF
+        content = <<-EOF
         def edit
           render template: 'books/edit'
         end
@@ -28,7 +30,7 @@ module RailsBestPractices
       end
 
       it 'should simplify render an arbitrary file' do
-        content =<<-EOF
+        content = <<-EOF
         def edit
           render file: '/path/to/rails/app/views/books/edit'
         end
@@ -39,7 +41,7 @@ module RailsBestPractices
       end
 
       it 'should not simplify render action view' do
-        content =<<-EOF
+        content = <<-EOF
         render :edit
         EOF
         runner.review('app/controllers/posts_controller', content)
@@ -47,7 +49,7 @@ module RailsBestPractices
       end
 
       it "should not simplify render actions's template" do
-        content =<<-EOF
+        content = <<-EOF
         def edit
           render 'books/edit'
         end
@@ -57,7 +59,7 @@ module RailsBestPractices
       end
 
       it 'should not simplify render an arbitrary file' do
-        content =<<-EOF
+        content = <<-EOF
         def edit
           render '/path/to/rails/app/views/books/edit'
         end
@@ -68,7 +70,7 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: SimplifyRenderInControllersReview.new(ignored_files: /posts_controller/))
-        content =<<-EOF
+        content = <<-EOF
         def edit
           render action: :edit
         end

data/spec/rails_best_practices/reviews/simplify_render_in_views_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -6,7 +8,7 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(reviews: SimplifyRenderInViewsReview.new) }
 
       it 'should simplify render simple partial' do
-        content =<<-EOF
+        content = <<-EOF
         <%= render partial: 'sidebar' %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
@@ -15,7 +17,7 @@ module RailsBestPractices
       end
 
       it 'should simplify render partial with object' do
-        content =<<-EOF
+        content = <<-EOF
         <%= render partial: 'post', object: @post %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
@@ -24,7 +26,7 @@ module RailsBestPractices
       end
 
       it 'should simplify render partial with collection' do
-        content =<<-EOF
+        content = <<-EOF
         <%= render partial: 'posts', collection: @posts %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
@@ -33,7 +35,7 @@ module RailsBestPractices
       end
 
       it 'should simplify render partial with local variables' do
-        content =<<-EOF
+        content = <<-EOF
         <%= render partial: 'comment', locals: { parent: post } %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
@@ -42,7 +44,7 @@ module RailsBestPractices
       end
 
       it 'should not simplify render simple partial' do
-        content =<<-EOF
+        content = <<-EOF
         <%= render 'sidebar' %>
         <%= render 'shared/sidebar' %>
         EOF
@@ -51,7 +53,7 @@ module RailsBestPractices
       end
 
       it 'should not simplify render partial with object' do
-        content =<<-EOF
+        content = <<-EOF
         <%= render @post %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
@@ -59,7 +61,7 @@ module RailsBestPractices
       end
 
       it 'should not simplify render partial with collection' do
-        content =<<-EOF
+        content = <<-EOF
         <%= render @posts %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
@@ -67,7 +69,7 @@ module RailsBestPractices
       end
 
       it 'should not simplify render partial with local variables' do
-        content =<<-EOF
+        content = <<-EOF
         <%= render 'comment', parent: post %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
@@ -75,7 +77,7 @@ module RailsBestPractices
       end
 
       it 'should not simplify render partial with complex partial' do
-        content =<<-EOF
+        content = <<-EOF
         <%= render partial: 'shared/post', object: @post %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
@@ -83,7 +85,7 @@ module RailsBestPractices
       end
 
       it 'should not simplify render partial with layout option' do
-        content =<<-EOF
+        content = <<-EOF
         <%= render partial: 'post', layout: 'post' %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
@@ -92,7 +94,7 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: SimplifyRenderInViewsReview.new(ignored_files: /views\/posts\/index/))
-        content =<<-EOF
+        content = <<-EOF
         <%= render partial: 'sidebar' %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)

data/spec/rails_best_practices/reviews/use_before_filter_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -85,7 +87,7 @@ module RailsBestPractices
       end
 
       it 'should not use before_filter for protected/private methods' do
-        content =<<-EOF
+        content = <<-EOF
         class PostsController < ApplicationController
           protected
           def load_comments

data/spec/rails_best_practices/reviews/use_model_association_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/use_observer_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -6,7 +8,7 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(prepares: Prepares::MailerPrepare.new, reviews: UseObserverReview.new) }
 
       before :each do
-        content =<<-EOF
+        content = <<-EOF
         class ProjectMailer < ActionMailer::Base
         end
         EOF
@@ -14,7 +16,7 @@ module RailsBestPractices
       end
 
       it 'should use observer' do
-        content =<<-EOF
+        content = <<-EOF
         class Project < ActiveRecord::Base
           after_create :send_create_notification
 
@@ -32,7 +34,7 @@ module RailsBestPractices
       end
 
       it 'should not use observer without callback' do
-        content =<<-EOF
+        content = <<-EOF
         class Project < ActiveRecord::Base
           private
           def send_create_notification
@@ -47,7 +49,7 @@ module RailsBestPractices
       end
 
       it 'should use observer with two after_create' do
-        content =<<-EOF
+        content = <<-EOF
         class Project < ActiveRecord::Base
           after_create :send_create_notification, :update_author
 
@@ -68,7 +70,7 @@ module RailsBestPractices
       end
 
       it 'should not raise when initiate an object in callback' do
-        content =<<-EOF
+        content = <<-EOF
         class Project < ActiveRecord::Base
           after_create ProjectMailer.new
         end