rails_best_practices 1.19.1 → 1.19.2

data/spec/rails_best_practices/prepares/route_prepare_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -7,7 +9,7 @@ module RailsBestPractices
 
       context 'resources' do
         it 'should add resources route' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
           end
@@ -19,7 +21,7 @@ module RailsBestPractices
         end
 
         it 'should add multiple resources route' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, :users
           end
@@ -30,7 +32,7 @@ module RailsBestPractices
         end
 
         it 'should add resources route with explict controller' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, controller: :blog_posts
           end
@@ -42,7 +44,7 @@ module RailsBestPractices
         end
 
         it 'should add resources route with only option' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: [:index, :show, :new, :create]
           end
@@ -54,7 +56,7 @@ module RailsBestPractices
         end
 
         it 'should add resources route with except option' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, except: [:edit, :update, :destroy]
           end
@@ -66,7 +68,7 @@ module RailsBestPractices
         end
 
         it 'should not add resources routes with only: :none' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: :none
           end
@@ -77,7 +79,7 @@ module RailsBestPractices
         end
 
         it 'should not add resources routes with except: :all' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, except: :all
           end
@@ -88,7 +90,7 @@ module RailsBestPractices
         end
 
         it 'should add resources routes with members' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             namespace :admin do
               resources :posts, :only => [:edit, :update] do
@@ -110,7 +112,7 @@ module RailsBestPractices
         end
 
         it 'should add resources routes with members inline' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             namespace :admin do
               resources :posts, :only => [:edit, :update] do
@@ -130,7 +132,7 @@ module RailsBestPractices
         end
 
         it 'should add connect route' do
-          content =<<-EOF
+          content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.connect 'vote', controller: "votes", action: "create", method: :post
           end
@@ -141,7 +143,7 @@ module RailsBestPractices
         end
 
         it 'should add named route' do
-          content =<<-EOF
+          content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.login '/player/login', controller: 'sessions', action: 'new', conditions: { method: :get }
           end
@@ -154,7 +156,7 @@ module RailsBestPractices
 
       context 'resource' do
         it 'should add resource route' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts
           end
@@ -166,7 +168,7 @@ module RailsBestPractices
         end
 
         it 'should add multiple resource route' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, :users
           end
@@ -177,7 +179,7 @@ module RailsBestPractices
         end
 
         it 'should add resource route with only option' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, only: [:show, :new, :create]
           end
@@ -189,7 +191,7 @@ module RailsBestPractices
         end
 
         it 'should add resource route with except option' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, except: [:edit, :update, :destroy]
           end
@@ -201,7 +203,7 @@ module RailsBestPractices
         end
 
         it 'should not add resource routes with only: :none' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, only: :none
           end
@@ -212,7 +214,7 @@ module RailsBestPractices
         end
 
         it 'should not add resource routes with except: :all' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resource :posts, except: :all
           end
@@ -223,7 +225,7 @@ module RailsBestPractices
         end
 
         it 'should add resource routes with get/post/put/patch/delete routes' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: [:show] do
               get :list, on: :collection
@@ -246,7 +248,7 @@ module RailsBestPractices
         end
 
         it 'should add custom resources routes with {}' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: [:show] { get :inactive, on: :collection }
           end
@@ -258,7 +260,7 @@ module RailsBestPractices
         end
 
         it 'should add resources routes with get %w() routes' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: [:show] do
               collection do
@@ -274,7 +276,7 @@ module RailsBestPractices
         end
 
         it 'should add route with nested routes' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
               resources :comments
@@ -287,7 +289,7 @@ module RailsBestPractices
         end
 
         it 'should add route with namespace' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             namespace :admin do
               namespace :test do
@@ -302,7 +304,7 @@ module RailsBestPractices
         end
 
         it 'should add route with namespace, but without resources' do
-          content =<<-EOF
+          content = <<-EOF
           RailsBestPracticesCom::Appllication.routes.draw do
             namespace :something do
               get *%w(route_one route_two)
@@ -316,7 +318,7 @@ module RailsBestPractices
         end
 
         it 'should add route with scope' do
-          content =<<-EOF
+          content = <<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               scope module: "admin" do
                 resources :posts, only: [:index]
@@ -346,7 +348,7 @@ module RailsBestPractices
       end
 
       it 'should add route for direct get/post' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           get 'posts/show'
           post '/posts' => 'posts#create'
@@ -362,7 +364,7 @@ module RailsBestPractices
       end
 
       it 'should add routes for another get/post' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw
           get "/login", to: 'sessions#new', as: :login
         end
@@ -374,7 +376,7 @@ module RailsBestPractices
       end
 
       it 'should add match route' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match '/auth/:provider/callback' => 'authentications#create'
         end
@@ -385,7 +387,7 @@ module RailsBestPractices
       end
 
       it 'should add match route with all actions' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match 'internal/:action/*whatever', controller: "internal"
         end
@@ -396,7 +398,7 @@ module RailsBestPractices
       end
 
       it 'should add root route' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           root to: 'home#index'
         end
@@ -407,7 +409,7 @@ module RailsBestPractices
       end
 
       it 'should add root shortcut route' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           root 'home#index'
         end
@@ -418,7 +420,7 @@ module RailsBestPractices
       end
 
       it 'should do nothing for default route' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match ':controller(/:action(/:id(.:format)))'
         end
@@ -429,7 +431,7 @@ module RailsBestPractices
       end
 
       it 'should do nothing for redirect' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match "/stories/:name" => redirect("/posts/%{name}")
           match "/stories" => redirect {|p, req| "/posts/\#{req.subdomain}" }
@@ -441,7 +443,7 @@ module RailsBestPractices
       end
 
       it 'should parse customize route in nested resources' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts do
             resources :comments
@@ -455,7 +457,7 @@ module RailsBestPractices
       end
 
       it 'should parse custom route for resource with explicit to and different action name' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts do
             get :halt, to: 'posts#stop'
@@ -468,7 +470,7 @@ module RailsBestPractices
       end
 
       it 'should parse custom route for resource with symbol action name' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts do
             get :halt, to: :stop
@@ -481,7 +483,7 @@ module RailsBestPractices
       end
 
       it 'should not take former resources for direct get/post' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           resources :posts
           post "sprints/stop"
@@ -493,7 +495,7 @@ module RailsBestPractices
       end
 
       it 'should not parse wrong route' do
-        content =<<-EOF
+        content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           match ':controller/:action' => '#index', as: :auto_complete
         end

data/spec/rails_best_practices/prepares/schema_prepare_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -6,7 +8,7 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(prepares: SchemaPrepare.new) }
 
       it 'should parse model attributes' do
-        content =<<-EOF
+        content = <<-EOF
         ActiveRecord::Schema.define(version: 20110319172136) do
           create_table "posts", force: true do |t|
             t.string   "title"

data/spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -219,7 +221,7 @@ module RailsBestPractices
       end
 
       it 'should not always add db index if two indexes for polymorphic association' do
-        content =<<-EOF
+        content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "taggings", force: true do |t|
             t.integer "tagger_id"
@@ -237,7 +239,7 @@ module RailsBestPractices
       end
 
       it 'should not always add db index if table does not exist' do
-        content =<<-EOF
+        content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "comments", force: true do |t|
             t.integer "post_id"
@@ -250,18 +252,18 @@ module RailsBestPractices
       end
 
       it 'should always add db index if association_name is different to foreign_key' do
-        content =<<-EOF
+        content = <<-EOF
         class Comment < ActiveRecord::Base
           belongs_to :commentor, class_name: "User"
         end
         EOF
         runner.prepare('app/models/comment.rb', content)
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
         end
         EOF
         runner.prepare('app/models/user.rb', content)
-        content =<<-EOF
+        content = <<-EOF
         ActiveRecord::Schema.define(version: 20100603080629) do
           create_table "comments", force: true do |t|
             t.integer "commentor_id"

data/spec/rails_best_practices/reviews/check_destroy_return_value_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -7,7 +9,7 @@ module RailsBestPractices
 
       describe 'check_destroy_return_value' do
         it 'should warn you if you fail to check the destroy return value' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.create do |p|
               p.title = "foo"
@@ -21,7 +23,7 @@ module RailsBestPractices
         end
 
         it 'should allow destroy return value if assigned to a var' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.create do |p|
               p.title = "foo"
@@ -34,7 +36,7 @@ module RailsBestPractices
         end
 
         it 'should allow destroy return value used in if' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.create do |p|
               p.title = "foo"
@@ -51,7 +53,7 @@ module RailsBestPractices
         end
 
         it 'should allow destroy return value used in elsif' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.create do |p|
               p.title = "foo"
@@ -70,7 +72,7 @@ module RailsBestPractices
         end
 
         it 'should allow destroy return value used in unless' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             unless @post.destroy
               raise "could not destroy"
@@ -82,7 +84,7 @@ module RailsBestPractices
         end
 
         it 'should allow destroy return value used in if_mod' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.create do |p|
               p.title = "foo"
@@ -95,7 +97,7 @@ module RailsBestPractices
         end
 
         it 'should allow destroy return value used in unless_mod' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.create do |p|
               p.title = "foo"
@@ -108,7 +110,7 @@ module RailsBestPractices
         end
 
         it 'should allow destroy return value used in unless with &&' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             unless some_method(1) && other_method(2) && @post.destroy
               raise "could not destroy"
@@ -120,7 +122,7 @@ module RailsBestPractices
         end
 
         it 'should allow destroy!' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.create do |p|
               p.title = "foo"
@@ -135,7 +137,7 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: CheckDestroyReturnValueReview.new(ignored_files: /helpers/))
-        content =<<-EOF
+        content = <<-EOF
           def my_method
             post = Posts.create do |p|
               p.title = "foo"