rails_best_practices 1.19.1 → 1.19.2

data/spec/fixtures/lib/rails_best_practices/plugins/reviews/not_use_rails_root_review.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require 'rails_best_practices/reviews/review'
 
 module RailsBestPractices
@@ -8,4 +9,4 @@ module RailsBestPractices
       end
     end
   end
-end
+end

data/spec/rails_best_practices/analyzer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'tmpdir'
 
@@ -83,7 +85,6 @@ module RailsBestPractices
           expect(subject).to have_received(:output_xml_errors)
         end
       end
-
     end
 
     describe 'output_terminal_errors' do
@@ -94,7 +95,7 @@ module RailsBestPractices
         check1.add_error 'law of demeter', 'app/models/user.rb', 10
         check2.add_error 'use query attribute', 'app/models/post.rb', 100
         subject.runner = runner
-        subject.instance_variable_set('@options', {'without-color' => false})
+        subject.instance_variable_set('@options', 'without-color' => false)
 
         $origin_stdout = $stdout
         $stdout = StringIO.new
@@ -113,10 +114,10 @@ module RailsBestPractices
       let(:output_file) { 'rails_best_practices_output.json' }
 
       subject do
-        described_class.new('.', {
+        described_class.new('.',
           'format' => 'json',
           'output-file' => output_file
-        })
+        )
       end
 
       let(:check1) { Reviews::LawOfDemeterReview.new }
@@ -132,7 +133,7 @@ module RailsBestPractices
       end
 
       after do
-        File.delete(output_file) if File.exists?(output_file)
+        File.delete(output_file) if File.exist?(output_file)
       end
 
       it 'saves output as json into output file' do
@@ -141,7 +142,6 @@ module RailsBestPractices
     end
 
     describe 'parse_files' do
-
       it 'should not filter out all files when the path contains "vendor"' do
         Dir.mktmpdir { |random_dir|
           Dir.mkdir(File.join(random_dir, 'vendor'))
@@ -191,8 +191,6 @@ module RailsBestPractices
           expect(analyzer.parse_files).to be_include File.join(random_dir, 'tmp', 'my_project', 'my_file.rb')
         }
       end
-
     end
-
   end
 end

data/spec/rails_best_practices/core/check_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/checks_loader_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/configs_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/controllers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/error_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/except_methods_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/gems_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/helpers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/klasses_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/mailers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/methods_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core
@@ -13,8 +15,8 @@ module RailsBestPractices::Core
     end
 
     it 'should get_methods' do
-      expect(methods.get_methods('Post').map(&:method_name)).to eq(['create', 'destroy', 'save_or_update', 'find_by_sql'])
-      expect(methods.get_methods('Post', 'public').map(&:method_name)).to eq(['create', 'destroy'])
+      expect(methods.get_methods('Post').map(&:method_name)).to eq(%w[create destroy save_or_update find_by_sql])
+      expect(methods.get_methods('Post', 'public').map(&:method_name)).to eq(%w[create destroy])
       expect(methods.get_methods('Post', 'protected').map(&:method_name)).to eq(['save_or_update'])
       expect(methods.get_methods('Post', 'private').map(&:method_name)).to eq(['find_by_sql'])
       expect(methods.get_methods('Comment').map(&:method_name)).to eq(['create'])
@@ -37,10 +39,10 @@ module RailsBestPractices::Core
 
     it 'should get_all_unused_methods' do
       methods.get_method('Comment', 'create').mark_used
-      expect(methods.get_all_unused_methods('public').map(&:method_name)).to eq(['create', 'destroy'])
+      expect(methods.get_all_unused_methods('public').map(&:method_name)).to eq(%w[create destroy])
       expect(methods.get_all_unused_methods('protected').map(&:method_name)).to eq(['save_or_update'])
       expect(methods.get_all_unused_methods('private').map(&:method_name)).to eq(['find_by_sql'])
-      expect(methods.get_all_unused_methods.map(&:method_name)).to eq(['create', 'destroy', 'save_or_update', 'find_by_sql'])
+      expect(methods.get_all_unused_methods.map(&:method_name)).to eq(%w[create destroy save_or_update find_by_sql])
     end
   end
 end

data/spec/rails_best_practices/core/model_associations_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core
@@ -10,8 +12,8 @@ module RailsBestPractices::Core
     end
 
     it 'should get model associations' do
-      expect(model_associations.get_association('Project', 'project_manager')).to eq({'meta' => 'belongs_to', 'class_name' => 'ProjectManager'})
-      expect(model_associations.get_association('Project', 'people')).to eq({'meta' => 'has_many', 'class_name' => 'Person'})
+      expect(model_associations.get_association('Project', 'project_manager')).to eq('meta' => 'belongs_to', 'class_name' => 'ProjectManager')
+      expect(model_associations.get_association('Project', 'people')).to eq('meta' => 'has_many', 'class_name' => 'Person')
       expect(model_associations.get_association('Project', 'unknown')).to be_nil
     end
 

data/spec/rails_best_practices/core/model_attributes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/models_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/modules_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core/routes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core
@@ -5,13 +7,13 @@ module RailsBestPractices::Core
     let(:routes) { Routes.new }
 
     it 'should add route' do
-      routes.add_route(['admin', 'test'], 'posts', 'new')
+      routes.add_route(%w[admin test], 'posts', 'new')
       expect(routes.map(&:to_s)).to eq(['Admin::Test::PostsController#new'])
     end
 
     context 'route' do
       it 'should add namesapces, controller name and action name' do
-        route = Route.new(['admin', 'test'], 'posts', 'new')
+        route = Route.new(%w[admin test], 'posts', 'new')
         expect(route.to_s).to eq('Admin::Test::PostsController#new')
       end
 

data/spec/rails_best_practices/core/runner_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices::Core

data/spec/rails_best_practices/core_ext/erubis_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Erubis::OnlyRuby do
   subject {
-    content =<<-EOF
+    content = <<-EOF
     <h1>Title</h1>
     <% if current_user %>
       <%= link_to 'account', edit_user_path(current_user) %>

data/spec/rails_best_practices/lexicals/long_line_check_spec.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
   module Lexicals
     describe LongLineCheck do
-
       it 'should find long lines' do
         runner = Core::Runner.new(lexicals: LongLineCheck.new)
-        content =<<-EOF
+        content = <<-EOF
 class User < ActiveRecord::Base
 # 81 Chars
 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
@@ -14,14 +15,14 @@ xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
 end
 EOF
-        content.gsub!("\n", "\t\n")
+        content = content.gsub("\n", "\t\n")
         runner.lexical('app/models/user.rb', content)
         expect(runner.errors.size).to eq(1)
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:3 - line is longer than 80 characters (81 characters)')
       end
       it 'should find long lines with own max size' do
         runner = Core::Runner.new(lexicals: LongLineCheck.new('max_line_length' => 90))
-        content =<<-EOF
+        content = <<-EOF
 class User < ActiveRecord::Base
 # 91 Chars
 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
@@ -29,7 +30,7 @@ xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
 end
 EOF
-        content.gsub!("\n", "\t\n")
+        content = content.gsub("\n", "\t\n")
         runner.lexical('app/models/user.rb', content)
         expect(runner.errors.size).to eq(1)
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:3 - line is longer than 90 characters (91 characters)')
@@ -44,13 +45,13 @@ xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
       end
       it 'should not check ignored files' do
         runner = Core::Runner.new(lexicals: LongLineCheck.new(max_line_length: 80, ignored_files: /user/))
-        content =<<-EOF
+        content = <<-EOF
 class User < ActiveRecord::Base
 # 81 Chars
 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
 end
         EOF
-        content.gsub!("\n", "\t\n")
+        content = content.gsub("\n", "\t\n")
         runner.lexical('app/models/user.rb', content)
         expect(runner.errors.size).to eq(0)
       end

data/spec/rails_best_practices/lexicals/remove_tab_check_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -6,19 +8,19 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(lexicals: RemoveTabCheck.new) }
 
       it 'should remove tab' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           has_many :projects
         end
         EOF
-        content.gsub!("\n", "\t\n")
+        content = content.gsub("\n", "\t\n")
         runner.lexical('app/models/user.rb', content)
         expect(runner.errors.size).to eq(1)
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:1 - remove tab, use spaces instead')
       end
 
       it 'should remove tab with third line' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           has_many :projects
   \t
@@ -30,7 +32,7 @@ module RailsBestPractices
       end
 
       it 'should not remove trailing whitespace' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           has_many :projects
         end
@@ -40,14 +42,14 @@ module RailsBestPractices
       end
       it 'should not check ignored files' do
         runner = Core::Runner.new(lexicals: RemoveTabCheck.new(ignored_files: /user/))
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           has_many :projects
 
   \t
         end
         EOF
-        content.gsub!("\n", "\t\n")
+        content = content.gsub("\n", "\t\n")
         runner.lexical('app/models/user.rb', content)
         expect(runner.errors.size).to eq(0)
       end

data/spec/rails_best_practices/lexicals/remove_trailing_whitespace_check_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -6,31 +8,31 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(lexicals: RemoveTrailingWhitespaceCheck.new) }
 
       it 'should remove trailing whitespace' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           has_many :projects
         end
         EOF
-        content.gsub!("\n", "  \n")
+        content = content.gsub("\n", "  \n")
         runner.lexical('app/models/user.rb', content)
         expect(runner.errors.size).to eq(1)
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:1 - remove trailing whitespace')
       end
 
       it 'should remove whitespace with third line' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           has_many :projects
         end
         EOF
-        content.gsub!("d\n", "d  \n")
+        content = content.gsub("d\n", "d  \n")
         runner.lexical('app/models/user.rb', content)
         expect(runner.errors.size).to eq(1)
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:3 - remove trailing whitespace')
       end
 
       it 'should not remove trailing whitespace' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           has_many :projects
         end
@@ -41,12 +43,12 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(lexicals: RemoveTrailingWhitespaceCheck.new(ignored_files: /user/))
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           has_many :projects
         end
         EOF
-        content.gsub!("\n", "  \n")
+        content = content.gsub("\n", "  \n")
         runner.lexical('app/models/user.rb', content)
         expect(runner.errors.size).to eq(0)
       end

data/spec/rails_best_practices/prepares/config_prepare_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -7,7 +9,7 @@ module RailsBestPractices
 
       context 'configs' do
         it 'should parse configs' do
-          content =<<-EOF
+          content = <<-EOF
           module RailsBestPracticesCom
             class Application < Rails::Application
               config.active_record.whitelist_attributes = true

data/spec/rails_best_practices/prepares/controller_prepare_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -7,7 +9,7 @@ module RailsBestPractices
 
       context 'methods' do
         it 'should parse controller methods' do
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def index; end
             def show; end
@@ -15,11 +17,11 @@ module RailsBestPractices
           EOF
           runner.prepare('app/controllers/posts_controller.rb', content)
           methods = Prepares.controller_methods
-          expect(methods.get_methods('PostsController').map(&:method_name)).to eq(['index', 'show'])
+          expect(methods.get_methods('PostsController').map(&:method_name)).to eq(%w[index show])
         end
 
         it 'should parse model methods with access control' do
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def index; end
             def show; end
@@ -31,14 +33,14 @@ module RailsBestPractices
           EOF
           runner.prepare('app/controllers/posts_controller.rb', content)
           methods = Prepares.controller_methods
-          expect(methods.get_methods('PostsController').map(&:method_name)).to eq(['index', 'show', 'resources', 'resource'])
-          expect(methods.get_methods('PostsController', 'public').map(&:method_name)).to eq(['index', 'show'])
+          expect(methods.get_methods('PostsController').map(&:method_name)).to eq(%w[index show resources resource])
+          expect(methods.get_methods('PostsController', 'public').map(&:method_name)).to eq(%w[index show])
           expect(methods.get_methods('PostsController', 'protected').map(&:method_name)).to eq(['resources'])
           expect(methods.get_methods('PostsController', 'private').map(&:method_name)).to eq(['resource'])
         end
 
         it 'should parse controller methods with module ::' do
-          content =<<-EOF
+          content = <<-EOF
           class Admin::Blog::PostsController < ApplicationController
             def index; end
             def show; end
@@ -46,11 +48,11 @@ module RailsBestPractices
           EOF
           runner.prepare('app/controllers/admin/posts_controller.rb', content)
           methods = Prepares.controller_methods
-          expect(methods.get_methods('Admin::Blog::PostsController').map(&:method_name)).to eq(['index', 'show'])
+          expect(methods.get_methods('Admin::Blog::PostsController').map(&:method_name)).to eq(%w[index show])
         end
 
         it 'should parse controller methods with module' do
-          content =<<-EOF
+          content = <<-EOF
           module Admin
             module Blog
               class PostsController < ApplicationController
@@ -62,74 +64,74 @@ module RailsBestPractices
           EOF
           runner.prepare('app/controllers/admin/posts_controller.rb', content)
           methods = Prepares.controller_methods
-          expect(methods.get_methods('Admin::Blog::PostsController').map(&:method_name)).to eq(['index', 'show'])
+          expect(methods.get_methods('Admin::Blog::PostsController').map(&:method_name)).to eq(%w[index show])
         end
 
         context 'inherited_resources' do
           it 'extend inherited_resources' do
-            content =<<-EOF
+            content = <<-EOF
             class PostsController < InheritedResources::Base
             end
             EOF
             runner.prepare('app/controllers/posts_controller.rb', content)
             methods = Prepares.controller_methods
-            expect(methods.get_methods('PostsController').map(&:method_name)).to eq(['index', 'show', 'new', 'create', 'edit', 'update', 'destroy'])
+            expect(methods.get_methods('PostsController').map(&:method_name)).to eq(%w[index show new create edit update destroy])
           end
 
           it 'extend inherited_resources with actions' do
-            content =<<-EOF
+            content = <<-EOF
             class PostsController < InheritedResources::Base
               actions :index, :show
             end
             EOF
             runner.prepare('app/controllers/posts_controller.rb', content)
             methods = Prepares.controller_methods
-            expect(methods.get_methods('PostsController').map(&:method_name)).to eq(['index', 'show'])
+            expect(methods.get_methods('PostsController').map(&:method_name)).to eq(%w[index show])
           end
 
           it 'extend inherited_resources with all actions' do
-            content =<<-EOF
+            content = <<-EOF
             class PostsController < InheritedResources::Base
               actions :all, except: [:show]
             end
             EOF
             runner.prepare('app/controllers/posts_controller.rb', content)
             methods = Prepares.controller_methods
-            expect(methods.get_methods('PostsController').map(&:method_name)).to eq(['index', 'new', 'create', 'edit', 'update', 'destroy'])
+            expect(methods.get_methods('PostsController').map(&:method_name)).to eq(%w[index new create edit update destroy])
           end
 
           it 'extend inherited_resources with all actions with no arguments' do
-            content =<<-EOF
+            content = <<-EOF
             class PostsController < InheritedResources::Base
               actions :all
             end
             EOF
             runner.prepare('app/controllers/posts_controller.rb', content)
             methods = Prepares.controller_methods
-            expect(methods.get_methods('PostsController').map(&:method_name)).to eq(['index', 'show', 'new', 'create', 'edit', 'update', 'destroy'])
+            expect(methods.get_methods('PostsController').map(&:method_name)).to eq(%w[index show new create edit update destroy])
           end
 
           it 'DSL inherit_resources' do
-            content =<<-EOF
+            content = <<-EOF
             class PostsController
               inherit_resources
             end
             EOF
             runner.prepare('app/controllers/posts_controller.rb', content)
             methods = Prepares.controller_methods
-            expect(methods.get_methods('PostsController').map(&:method_name)).to eq(['index', 'show', 'new', 'create', 'edit', 'update', 'destroy'])
+            expect(methods.get_methods('PostsController').map(&:method_name)).to eq(%w[index show new create edit update destroy])
           end
         end
       end
 
       context 'helpers' do
         it 'should add helper descendant' do
-          content =<<-EOF
+          content = <<-EOF
           module PostsHelper
           end
           EOF
           runner.prepare('app/helpers/posts_helper.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController
             include PostsHelper
           end