rails_best_practices 1.19.1 → 1.19.2

data/spec/rails_best_practices/reviews/check_save_return_value_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -7,7 +9,7 @@ module RailsBestPractices
 
       describe 'check_save_return_value' do
         it 'should warn you if you fail to check save return value' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.new do |p|
               p.title = "foo"
@@ -21,7 +23,7 @@ module RailsBestPractices
         end
 
         it 'should allow save return value assigned to var' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.new do |p|
               p.title = "foo"
@@ -34,7 +36,7 @@ module RailsBestPractices
         end
 
         it 'should allow save return value used in if' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.new do |p|
               p.title = "foo"
@@ -51,7 +53,7 @@ module RailsBestPractices
         end
 
         it 'should allow save return value used in elsif' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.new do |p|
               p.title = "foo"
@@ -70,7 +72,7 @@ module RailsBestPractices
         end
 
         it 'should allow save return value used in unless' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             unless @post.save
               raise "could not save"
@@ -82,7 +84,7 @@ module RailsBestPractices
         end
 
         it 'should allow save return value used in if_mod' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.new do |p|
               p.title = "foo"
@@ -95,7 +97,7 @@ module RailsBestPractices
         end
 
         it 'should allow save return value used in unless_mod' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.new do |p|
               p.title = "foo"
@@ -108,7 +110,7 @@ module RailsBestPractices
         end
 
         it 'should allow save return value used in unless with &&' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             unless some_method(1) && other_method(2) && @post.save
               raise "could not save"
@@ -120,7 +122,7 @@ module RailsBestPractices
         end
 
         it 'should allow save!' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             post = Posts.new do |p|
               p.title = "foo"
@@ -133,7 +135,7 @@ module RailsBestPractices
         end
 
         it 'should warn you if you fail to check update_attributes return value' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             @post.update_attributes params
           end
@@ -144,7 +146,7 @@ module RailsBestPractices
         end
 
         it 'should allow update_attributes if return value is checked' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             @post.update_attributes(params) or raise "failed to save"
           end
@@ -156,7 +158,7 @@ module RailsBestPractices
         it 'is not clever enough to allow update_attributes if value is returned from method' do
           # This review is not clever enough to do a full liveness analysis
           # of whether the returned value is used in all cases.
-          content =<<-EOF
+          content = <<-EOF
           class PostsController
             def update
               @post = Post.find params(:id)
@@ -178,12 +180,12 @@ module RailsBestPractices
         end
 
         it 'should warn you if you use create which is always unsafe' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
           end
           EOF
           runner.prepare('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             if post = Post.create(params)
               # post may or may not be saved here!
@@ -197,14 +199,14 @@ module RailsBestPractices
         end
 
         it 'should warn you if you use create with a block which is always unsafe' do
-          content =<<-EOF
+          content = <<-EOF
           module Blog
             class Post < ActiveRecord::Base
             end
           end
           EOF
           runner.prepare('app/models/blog/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           module Blog
             class PostsHelper
               def my_method
@@ -225,7 +227,7 @@ module RailsBestPractices
         end
 
         it 'allows create called on non-model classes' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             pk12 = OpenSSL::PKCS12.create(
               "", # password
@@ -241,7 +243,7 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: CheckSaveReturnValueReview.new(ignored_files: /helpers/))
-        content =<<-EOF
+        content = <<-EOF
           def my_method
             post = Posts.new do |p|
               p.title = "foo"

data/spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/hash_syntax_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -6,7 +8,7 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(reviews: HashSyntaxReview.new) }
 
       it 'should find 1.8 Hash with symbol' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { :foo => :bar }
         end
@@ -17,7 +19,7 @@ module RailsBestPractices
       end
 
       it 'should not find 1.8 Hash with string' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { "foo" => "bar" }
         end
@@ -27,7 +29,7 @@ module RailsBestPractices
       end
 
       it 'should not alert on 1.9 Syntax' do
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { foo: :bar }
         end
@@ -37,7 +39,7 @@ module RailsBestPractices
       end
 
       it 'should ignore haml_out' do
-        content =<<-EOF
+        content = <<-EOF
 %div{ class: "foo1" }
 .div{ class: "foo2" }
 #div{ class: "foo3" }
@@ -47,7 +49,7 @@ module RailsBestPractices
       end
 
       it 'should not consider hash with array key' do
-        content =<<-EOF
+        content = <<-EOF
         transition [:unverified, :verified] => :deleted
         EOF
         runner.review('app/models/post.rb', content)
@@ -55,7 +57,7 @@ module RailsBestPractices
       end
 
       it 'should not consider hash with charaters not valid for symbol' do
-        content =<<-EOF
+        content = <<-EOF
         receiver.stub(:` => 'Error')
         EOF
         runner.review('app/models/post.rb', content)
@@ -64,7 +66,7 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: HashSyntaxReview.new(ignored_files: /user/))
-        content =<<-EOF
+        content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { :foo => :bar }
         end

data/spec/rails_best_practices/reviews/isolate_seed_data_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/keep_finders_on_their_own_model_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/law_of_demeter_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/move_code_into_controller_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/move_code_into_model_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -6,7 +8,7 @@ module RailsBestPractices
       let(:runner) { Core::Runner.new(reviews: MoveCodeIntoModelReview.new) }
 
       it 'should move code into model' do
-        content =<<-EOF
+        content = <<-EOF
         <% if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>
         <% end %>
@@ -17,7 +19,7 @@ module RailsBestPractices
       end
 
       it 'should move code into model with haml' do
-        content =<<-EOF
+        content = <<-EOF
 - if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
   = link_to 'Edit this post', edit_post_url(@post)
         EOF
@@ -27,7 +29,7 @@ module RailsBestPractices
       end
 
       it 'should move code into model with slim' do
-        content =<<-EOF
+        content = <<-EOF
 - if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
   = link_to 'Edit this post', edit_post_url(@post)
         EOF
@@ -37,7 +39,7 @@ module RailsBestPractices
       end
 
       it 'should move code into model with if in one line' do
-        content =<<-EOF
+        content = <<-EOF
         <%= link_to 'Edit this post', edit_post_url(@post) if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
@@ -46,7 +48,7 @@ module RailsBestPractices
       end
 
       it "should move code into model with '? :'" do
-        content =<<-EOF
+        content = <<-EOF
         <%= current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) ? link_to('Edit this post', edit_post_url(@post)) : '' %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
@@ -55,7 +57,7 @@ module RailsBestPractices
       end
 
       it 'should move code into model only review for current if conditional statement' do
-        content =<<-EOF
+        content = <<-EOF
         <% if @post.title %>
           <% if @post.user %>
             <% if @post.description %>
@@ -68,7 +70,7 @@ module RailsBestPractices
       end
 
       it 'should not move code into model' do
-        content =<<-EOF
+        content = <<-EOF
         <% if @post.editable_by?(current_user) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>
         <% end %>
@@ -78,7 +80,7 @@ module RailsBestPractices
       end
 
       it 'should not move code into model for multiple calls on same variable node' do
-        content =<<-EOF
+        content = <<-EOF
         <% if !job.company.blank? && job.company.title? %>
         <% end %>
         EOF
@@ -88,7 +90,7 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: MoveCodeIntoModelReview.new(ignored_files: /app\/views\/post/))
-        content =<<-EOF
+        content = <<-EOF
         <% if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>
         <% end %>

data/spec/rails_best_practices/reviews/move_finder_to_named_scope_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/move_model_logic_into_model_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/not_rescue_exception_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -7,7 +9,7 @@ module RailsBestPractices
 
       describe 'not_rescue_exception' do
         it 'should not rescue exception in method rescue with named var' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             do_something
           rescue Exception => e
@@ -20,7 +22,7 @@ module RailsBestPractices
         end
 
         it 'should not rescue exception in method rescue without named var' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             do_something
           rescue Exception
@@ -33,7 +35,7 @@ module RailsBestPractices
         end
 
         it 'should not rescue exception in block rescue with named var' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             begin
               do_something
@@ -48,7 +50,7 @@ module RailsBestPractices
         end
 
         it 'should not rescue exception in block rescue without named var' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             begin
               do_something
@@ -63,7 +65,7 @@ module RailsBestPractices
         end
 
         it 'should allow rescue implicit StandardError in block rescue without named var' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             begin
               do_something
@@ -77,7 +79,7 @@ module RailsBestPractices
         end
 
         it 'should allow rescue explicit StandardError in block rescue without named var' do
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             begin
               do_something
@@ -92,7 +94,7 @@ module RailsBestPractices
 
         it 'should not check ignored files' do
           runner = Core::Runner.new(reviews: NotRescueExceptionReview.new(ignored_files: /posts_helper/))
-          content =<<-EOF
+          content = <<-EOF
           def my_method
             do_something
           rescue Exception => e

data/spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices

data/spec/rails_best_practices/reviews/not_use_time_ago_in_words_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -7,7 +9,7 @@ module RailsBestPractices
 
       describe 'time_ago_in_words' do
         it 'should not use in views' do
-          content =<<-EOF
+          content = <<-EOF
           <%= time_ago_in_words(post.created_at) %>
           EOF
           runner.review('app/views/posts/show.html.erb', content)
@@ -16,7 +18,7 @@ module RailsBestPractices
         end
 
         it 'should not use in helpers' do
-          content =<<-EOF
+          content = <<-EOF
           def timeago
             content_tag(:p, time_ago_in_words(post.created_at))
           end
@@ -29,7 +31,7 @@ module RailsBestPractices
 
       describe 'distance_of_time_in_words_to_now' do
         it 'should not use in views' do
-          content =<<-EOF
+          content = <<-EOF
           <%= distance_of_time_in_words_to_now(post.created_at) %>
           EOF
           runner.review('app/views/posts/show.html.erb', content)
@@ -38,7 +40,7 @@ module RailsBestPractices
         end
 
         it 'should not use in helpers' do
-          content =<<-EOF
+          content = <<-EOF
           def timeago
             content_tag(:p, distance_of_time_in_words_to_now(post.created_at))
           end
@@ -51,7 +53,7 @@ module RailsBestPractices
 
       it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: NotUseTimeAgoInWordsReview.new(ignored_files: /posts_helper/))
-        content =<<-EOF
+        content = <<-EOF
           def timeago
             content_tag(:p, time_ago_in_words(post.created_at))
           end