rails_best_practices 1.19.1 → 1.19.2

data/spec/rails_best_practices/reviews/remove_unused_methods_in_helpers_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -9,7 +11,7 @@ module RailsBestPractices
       ) }
 
       it 'should remove unused methods' do
-        content =<<-EOF
+        content = <<-EOF
         module PostsHelper
           def unused; end
         end
@@ -22,14 +24,14 @@ module RailsBestPractices
       end
 
       it 'should not remove unused methods if called on views' do
-        content =<<-EOF
+        content = <<-EOF
         module PostsHelper
           def used?(post); end
         end
         EOF
         runner.prepare('app/helpers/posts_helper.rb', content)
         runner.review('app/helpers/posts_helper.rb', content)
-        content =<<-EOF
+        content = <<-EOF
         <% if used?(@post) %>
         <% end %>
         EOF
@@ -39,7 +41,7 @@ module RailsBestPractices
       end
 
       it 'should not remove unused methods if called on helpers' do
-        content =<<-EOF
+        content = <<-EOF
         module PostsHelper
           def used?(post)
             test?(post)
@@ -50,7 +52,7 @@ module RailsBestPractices
         EOF
         runner.prepare('app/helpers/posts_helper.rb', content)
         runner.review('app/helpers/posts_helper.rb', content)
-        content =<<-EOF
+        content = <<-EOF
         <% if used?(@post) %>
         <% end %>
         EOF
@@ -60,12 +62,12 @@ module RailsBestPractices
       end
 
       it 'should not remove unused methods if called on controllers' do
-        helper_content =<<-EOF
+        helper_content = <<-EOF
         module PostsHelper
           def used?(post); end
         end
         EOF
-        controller_content =<<-EOF
+        controller_content = <<-EOF
         class PostsController < InheritedResources::Base
           include PostsHelper
 
@@ -85,17 +87,17 @@ module RailsBestPractices
       end
 
       it 'should not remove unused methods if called in descendant controllers' do
-        application_helper_content =<<-EOF
+        application_helper_content = <<-EOF
         module ApplicationHelper
           def admin?; end
         end
         EOF
-        application_controller_content =<<-EOF
+        application_controller_content = <<-EOF
         class ApplicationController
           include ApplicationHelper
         end
         EOF
-        controller_content =<<-EOF
+        controller_content = <<-EOF
         class PostsController < ApplicationController
 
           def show
@@ -118,7 +120,7 @@ module RailsBestPractices
         runner = Core::Runner.new(prepares: [Prepares::ControllerPrepare.new, Prepares::HelperPrepare.new],
                                   reviews: RemoveUnusedMethodsInHelpersReview.new(ignored_files: /posts_helper/, except_methods: []))
 
-        content =<<-EOF
+        content = <<-EOF
         module PostsHelper
           def unused; end
         end

data/spec/rails_best_practices/reviews/remove_unused_methods_in_models_review_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module RailsBestPractices
@@ -5,12 +7,12 @@ module RailsBestPractices
     describe RemoveUnusedMethodsInModelsReview do
       let(:runner) { Core::Runner.new(
         prepares: Prepares::ModelPrepare.new,
-        reviews: RemoveUnusedMethodsInModelsReview.new({'except_methods' => ['*#set_cache']})
+        reviews: RemoveUnusedMethodsInModelsReview.new('except_methods' => ['*#set_cache'])
       ) }
 
       context 'private' do
         it 'should remove unused methods' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def find; end
             private
@@ -19,7 +21,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def get
               Post.new.find
@@ -33,7 +35,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods with except_methods' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def set_cache; end
           end
@@ -45,7 +47,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods with var_ref' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def find
               find_by_sql
@@ -56,7 +58,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def get
               Post.new.find
@@ -69,7 +71,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods with callback' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             after_save :expire_cache
             private
@@ -83,7 +85,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method with command' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def fetch
               get(position: 'first')
@@ -94,7 +96,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def get
               Post.new.fetch
@@ -107,7 +109,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method with call' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def conditions
               self.build_conditions({})
@@ -118,7 +120,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def get
               Post.new.conditions
@@ -131,7 +133,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method with message' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def save
               transaction true do
@@ -144,7 +146,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def create
               Post.new.save
@@ -157,7 +159,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method with validation condition' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             validates_uniqueness_of :login, if: :email_blank?
             private
@@ -171,7 +173,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method with aasm' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             aasm_state :accepted, enter: [:update_datetime]
             private
@@ -185,7 +187,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method with initialize' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             private
             def initialize; end
@@ -200,7 +202,7 @@ module RailsBestPractices
 
       context 'public' do
         it 'should remove unused methods' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def fetch; end
           end
@@ -212,13 +214,13 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def fetch; end
           end
           EOF
           runner.prepare('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def show
               @post.fetch
@@ -231,7 +233,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods for attribute assignment' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def user=(user); end
           end
@@ -243,14 +245,14 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods for try' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def find(user_id); end
           end
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def find
               Post.new.try(:find, current_user.id)
@@ -263,14 +265,14 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods for send' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def find(user_id); end
           end
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def find
               Post.new.send(:find, current_user.id)
@@ -283,14 +285,14 @@ module RailsBestPractices
         end
 
         it 'should remove unused methods for send string_embexpre' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def find_first; end
           end
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def find
               type = "first"
@@ -304,14 +306,14 @@ module RailsBestPractices
         end
 
         it 'should remove unused methods for send variable' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def first; end
           end
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def find
               type = "first"
@@ -327,7 +329,7 @@ module RailsBestPractices
 
       context 'protected' do
         it 'should not remove unused methods' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             protected
             def test; end
@@ -335,7 +337,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def test
               Post.new.test
@@ -349,13 +351,13 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods' do
-          post_content =<<-EOF
+          post_content = <<-EOF
           class Post < ActiveRecord::Base
             protected
             def test; end
           end
           EOF
-          blog_post_content =<<-EOF
+          blog_post_content = <<-EOF
           class BlogPost < Post
             def play
               test
@@ -366,7 +368,7 @@ module RailsBestPractices
           runner.prepare('app/models/blog_post.rb', blog_post_content)
           runner.review('app/models/post.rb', post_content)
           runner.review('app/models/blog_post.rb', blog_post_content)
-          content =<<-EOF
+          content = <<-EOF
           class BlogPostsController < ApplicationController
             def play
               BlogPost.new.play
@@ -381,14 +383,14 @@ module RailsBestPractices
 
       context 'named_scope' do
         it 'should not remove unused named_scope' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             named_scope :active, conditions: {active: true}
           end
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def index
               @posts = Post.active
@@ -401,7 +403,7 @@ module RailsBestPractices
         end
 
         it 'should remove unused named_scope' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             named_scope :active, conditions: {active: true}
           end
@@ -416,14 +418,14 @@ module RailsBestPractices
 
       context 'scope' do
         it 'should not remove unused scope' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             scope :active, where(active: true)
           end
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def index
               @posts = Post.active
@@ -436,7 +438,7 @@ module RailsBestPractices
         end
 
         it 'should remove unused named_scope' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             scope :active, where(active: true)
           end
@@ -451,7 +453,7 @@ module RailsBestPractices
 
       context 'alias' do
         it 'should not remove unused method with alias' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def old; end
             alias new old
@@ -459,7 +461,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def show
               @post.new
@@ -472,7 +474,7 @@ module RailsBestPractices
         end
 
          it 'should not remove unused method with symbol alias' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def old; end
             alias :new :old
@@ -480,7 +482,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def show
               @post.new
@@ -493,7 +495,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method with alias_method' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def old; end
             alias_method :new, :old
@@ -501,7 +503,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def show
               @post.new
@@ -514,7 +516,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method with alias_method_chain' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def method_with_feature; end
             alias_method_chain :method, :feature
@@ -522,7 +524,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def show
               @post.method
@@ -537,7 +539,7 @@ module RailsBestPractices
 
       context 'methods hash' do
         it 'should not remove unused method with methods hash' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def to_xml(options = {})
               super options.merge(exclude: :visible, methods: [:is_discussion_conversation])
@@ -555,7 +557,7 @@ module RailsBestPractices
 
       context 'callbacks' do
         it 'should not remove unused method' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             before_save :init_columns
             after_destroy :remove_dependencies
@@ -574,7 +576,7 @@ module RailsBestPractices
 
       context 'validates' do
         it 'should not remove unused method' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             validate :valid_birth_date
 
@@ -589,7 +591,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method for validate_on_create and validate_on_update' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             validate_on_create :valid_email
             validate_on_update :valid_birth_date
@@ -606,7 +608,7 @@ module RailsBestPractices
         end
 
         it 'should not remove unused methods for to_param' do
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def to_param
               id
@@ -622,14 +624,14 @@ module RailsBestPractices
 
       context 'helper method' do
         it 'should not remove unused method for coommand_call collection_select' do
-          content =<<-EOF
+          content = <<-EOF
           class Category < ActiveRecord::Base
             def indented_name; end
           end
           EOF
           runner.prepare('app/models/category.rb', content)
           runner.review('app/models/category.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           <%= f.collection_select :parent_id, Category.all_hierarchic(except: @category), :id, :indented_name, {include_blank: true} %>
           EOF
           runner.review('app/views/categories/_form.html.erb', content)
@@ -638,14 +640,14 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method for command collection_select' do
-          content =<<-EOF
+          content = <<-EOF
           class Category < ActiveRecord::Base
             def indented_name; end
           end
           EOF
           runner.prepare('app/models/category.rb', content)
           runner.review('app/models/category.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           <%= collection_select :category, :parent_id, Category.all_hierarchic(except: @category), :id, :indented_name, {include_blank: true} %>
           EOF
           runner.review('app/views/categories/_form.html.erb', content)
@@ -654,14 +656,14 @@ module RailsBestPractices
         end
 
         it 'should not remove unused method for options_from_collection_for_select' do
-          content =<<-EOF
+          content = <<-EOF
           class Category < ActiveRecord::Base
             def indented_name; end
           end
           EOF
           runner.prepare('app/models/category.rb', content)
           runner.review('app/models/category.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           <%= select_tag 'category', options_from_collection_for_select(Category.all_hierachic(except: @category), :id, :indented_name) %>
           EOF
           runner.review('app/views/categories/_form.html.erb', content)
@@ -671,7 +673,7 @@ module RailsBestPractices
       end
 
       it 'should not remove unused methods for rabl view' do
-        content =<<-EOF
+        content = <<-EOF
         class User
           def first_name; end
           def last_name; end
@@ -679,7 +681,7 @@ module RailsBestPractices
         EOF
         runner.prepare('app/models/user.rb', content)
         runner.review('app/models/user.rb', content)
-        content =<<-EOF
+        content = <<-EOF
         node :full_name do |u|
           u.first_name + " " + u.last_name
         end
@@ -690,7 +692,7 @@ module RailsBestPractices
       end
 
       it 'should not skip :call as call message' do
-        content =<<-EOF
+        content = <<-EOF
         module DateRange
           RANGES = lambda {
             last_month = {
@@ -708,7 +710,7 @@ module RailsBestPractices
         runner = Core::Runner.new(prepares: Prepares::ModelPrepare.new,
                                   reviews: RemoveUnusedMethodsInModelsReview.new(except_methods: [], ignored_files: /post/))
 
-          content =<<-EOF
+          content = <<-EOF
           class Post < ActiveRecord::Base
             def find; end
             private
@@ -717,7 +719,7 @@ module RailsBestPractices
           EOF
           runner.prepare('app/models/post.rb', content)
           runner.review('app/models/post.rb', content)
-          content =<<-EOF
+          content = <<-EOF
           class PostsController < ApplicationController
             def get
               Post.new.find