openstudio-standards 0.8.4 → 0.8.5.rc1

data/lib/openstudio-standards/prototypes/common/objects/Prototype.AirTerminalSingleDuctVAVReheat.rb

@@ -16,4 +16,37 @@ class Standard
 
     return true
   end
+
+  # Sets VAV reheat and VAV no reheat terminals on an air loop to control for outdoor air
+  #
+  # @param model [OpenStudio::Model::Model] OpenStudio model object
+  # @param air_loop [<OpenStudio::Model::AirLoopHVAC>] air loop to enable DCV on.
+  #   Default is nil, which will apply to all air loops
+  # @return [OpenStudio::Model::Model] OpenStudio model object
+  def model_set_vav_terminals_to_control_for_outdoor_air(model, air_loop: nil)
+    vav_reheats = model.getAirTerminalSingleDuctVAVReheats
+    vav_no_reheats = model.getAirTerminalSingleDuctVAVNoReheats
+
+    if air_loop.nil?
+      # all terminals
+      vav_reheats.each do |vav_reheat|
+        vav_reheat.setControlForOutdoorAir(true)
+      end
+      vav_no_reheats.each do |vav_no_reheat|
+        vav_no_reheat.setControlForOutdoorAir(true)
+      end
+    else
+      vav_reheats.each do |vav_reheat|
+        next if vav_reheat.airLoopHVAC.get.name.to_s != air_loop.name.to_s
+
+        vav_reheat.setControlForOutdoorAir(true)
+      end
+      vav_no_reheats.each do |vav_no_reheat|
+        next if vav_no_reheat.airLoopHVAC.get.name.to_s != air_loop.name.to_s
+
+        vav_no_reheat.setControlForOutdoorAir(true)
+      end
+    end
+    return model
+  end
 end

data/lib/openstudio-standards/prototypes/common/objects/Prototype.Fan.rb

@@ -63,144 +63,4 @@ module PrototypeFan
 
     return true
   end
-
-  # fan class method to apply fan variables
-  #
-  # @param fan [OpenStudio::Model::StraightComponent] fan object of type:
-  #   FanConstantVolume, FanOnOff, FanVariableVolume, and FanZoneExhaust
-  # @param fan_name [String] fan name
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  # @param end_use_subcategory [String] end use subcategory name
-  # @return [OpenStudio::Model::StraightComponent] fan object
-  def self.apply_base_fan_variables(fan,
-                                    fan_name: nil,
-                                    fan_efficiency: nil,
-                                    pressure_rise: nil,
-                                    end_use_subcategory: nil)
-    fan.setName(fan_name) unless fan_name.nil?
-    fan.setFanEfficiency(fan_efficiency) unless fan_efficiency.nil?
-    fan.setPressureRise(pressure_rise) unless pressure_rise.nil?
-    fan.setEndUseSubcategory(end_use_subcategory) unless end_use_subcategory.nil?
-    return fan
-  end
-
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  def get_fan_from_standards(standards_name: nil,
-                             type: nil,
-                             fan_efficiency: nil,
-                             pressure_rise: nil,
-                             motor_efficiency: nil,
-                             motor_in_airstream_fraction: nil,
-                             fan_power_minimum_flow_rate_input_method: nil,
-                             fan_power_coefficient_1: nil,
-                             fan_power_coefficient_2: nil,
-                             fan_power_coefficient_3: nil,
-                             fan_power_coefficient_4: nil,
-                             fan_power_coefficient_5: nil,
-                             system_availability_manager_coupling_mode: nil,
-                             end_use_subcategory: nil)
-    search_criteria = {}
-    standards_name ? search_criteria['name'] = standards_name : search_criteria['name'] = 'default'
-    if type then search_criteria['type'] = type end
-    if fan_efficiency then search_criteria['fan_efficiency'] = fan_efficiency end
-    if pressure_rise then search_criteria['pressure_rise'] = pressure_rise end
-    if motor_efficiency then search_criteria['motor_efficiency'] = motor_efficiency end
-    if motor_in_airstream_fraction then search_criteria['motor_in_airstream_fraction'] = motor_in_airstream_fraction end
-    if fan_power_minimum_flow_rate_input_method then search_criteria['fan_power_minimum_flow_rate_input_method'] = fan_power_minimum_flow_rate_input_method end
-    if fan_power_coefficient_1 then search_criteria['fan_power_coefficient_1'] = fan_power_coefficient_1 end
-    if fan_power_coefficient_2 then search_criteria['fan_power_coefficient_2'] = fan_power_coefficient_2 end
-    if fan_power_coefficient_3 then search_criteria['fan_power_coefficient_3'] = fan_power_coefficient_3 end
-    if fan_power_coefficient_4 then search_criteria['fan_power_coefficient_4'] = fan_power_coefficient_4 end
-    if fan_power_coefficient_5 then search_criteria['fan_power_coefficient_5'] = fan_power_coefficient_5 end
-    if system_availability_manager_coupling_mode then search_criteria['system_availability_manager_coupling_mode'] = system_availability_manager_coupling_mode end
-    if end_use_subcategory then search_criteria['end_use_subcategory'] = end_use_subcategory end
-
-    model_find_object(@standards_data['fans'], search_criteria)
-  end
-
-  # create a fan with properties for a fan name in the standards data
-  #
-  # @param fan_name [String] fan name
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  # @param end_use_subcategory [String] end use subcategory name
-  # @return [OpenStudio::Model::StraightComponent] fan object
-  def create_fan_by_name(model,
-                         standards_name,
-                         fan_name: nil,
-                         fan_efficiency: nil,
-                         pressure_rise: nil,
-                         motor_efficiency: nil,
-                         motor_in_airstream_fraction: nil,
-                         fan_power_minimum_flow_rate_input_method: nil,
-                         fan_power_minimum_flow_rate_fraction: nil,
-                         fan_power_coefficient_1: nil,
-                         fan_power_coefficient_2: nil,
-                         fan_power_coefficient_3: nil,
-                         fan_power_coefficient_4: nil,
-                         fan_power_coefficient_5: nil,
-                         system_availability_manager_coupling_mode: nil,
-                         end_use_subcategory: nil)
-
-    fan_json = get_fan_from_standards(standards_name: standards_name)
-
-    case fan_json['type']
-    when 'ConstantVolume'
-      create_fan_constant_volume_from_json(model,
-                                           fan_json,
-                                           fan_name: fan_name,
-                                           fan_efficiency: fan_efficiency,
-                                           pressure_rise: pressure_rise,
-                                           motor_efficiency: motor_efficiency,
-                                           motor_in_airstream_fraction: motor_in_airstream_fraction,
-                                           end_use_subcategory: end_use_subcategory)
-    when 'OnOff'
-      create_fan_on_off_from_json(model,
-                                  fan_json,
-                                  fan_name: fan_name,
-                                  fan_efficiency: fan_efficiency,
-                                  pressure_rise: pressure_rise,
-                                  motor_efficiency: motor_efficiency,
-                                  motor_in_airstream_fraction: motor_in_airstream_fraction,
-                                  end_use_subcategory: end_use_subcategory)
-    when 'VariableVolume'
-      fan_power_coefficient_1, fan_power_coefficient_2, fan_power_coefficient_3, fan_power_coefficient_4, fan_power_coefficient_5 = lookup_fan_curve_coefficients_from_json(fan_json['fan_curve']) if fan_json['fan_curve']
-      create_fan_variable_volume_from_json(model,
-                                           fan_json,
-                                           fan_name: fan_name,
-                                           fan_efficiency: fan_efficiency,
-                                           pressure_rise: pressure_rise,
-                                           motor_efficiency: motor_efficiency,
-                                           motor_in_airstream_fraction: motor_in_airstream_fraction,
-                                           fan_power_minimum_flow_rate_input_method: fan_power_minimum_flow_rate_input_method,
-                                           fan_power_minimum_flow_rate_fraction: fan_power_minimum_flow_rate_fraction,
-                                           fan_power_coefficient_1: fan_power_coefficient_1,
-                                           fan_power_coefficient_2: fan_power_coefficient_2,
-                                           fan_power_coefficient_3: fan_power_coefficient_3,
-                                           fan_power_coefficient_4: fan_power_coefficient_4,
-                                           fan_power_coefficient_5: fan_power_coefficient_5,
-                                           end_use_subcategory: end_use_subcategory)
-    when 'ZoneExhaust'
-      create_fan_zone_exhaust_from_json(model,
-                                        fan_json,
-                                        fan_name: fan_name,
-                                        fan_efficiency: fan_efficiency,
-                                        pressure_rise: pressure_rise,
-                                        system_availability_manager_coupling_mode: system_availability_manager_coupling_mode,
-                                        end_use_subcategory: end_use_subcategory)
-    end
-  end
-
-  # Lookup fan curve coefficients
-  #
-  # @param fan_curve [String] name of the fan curve
-  # @return [Array] an array of fan curve coefficients
-  def lookup_fan_curve_coefficients_from_json(fan_curve)
-    search_criteria = {}
-    search_criteria['name'] = fan_curve
-    fan_curve = model_find_object(@standards_data['curves'], search_criteria)
-    return [fan_curve['coeff_1'], fan_curve['coeff_2'], fan_curve['coeff_3'], fan_curve['coeff_4'], fan_curve['coeff_5']]
-  end
 end

data/lib/openstudio-standards/prototypes/common/objects/Prototype.FanConstantVolume.rb

@@ -9,9 +9,6 @@ class Standard
   # @param fan_constant_volume [OpenStudio::Model::FanConstantVolume] constant volume fan object
   # @return [Boolean] returns true if successful, false if not
   def fan_constant_volume_apply_prototype_fan_pressure_rise(fan_constant_volume)
-    # Don't modify unit heater fans
-    return true if fan_constant_volume.name.to_s.include?('UnitHeater Fan')
-
     # Get the max flow rate from the fan.
     maximum_flow_rate_m3_per_s = nil
     if fan_constant_volume.maximumFlowRate.is_initialized
@@ -26,8 +23,7 @@ class Standard
     # Convert max flow rate to cfm
     maximum_flow_rate_cfm = OpenStudio.convert(maximum_flow_rate_m3_per_s, 'm^3/s', 'cfm').get
 
-    # Pressure rise will be determined based on the
-    # following logic.
+    # Pressure rise will be determined based on the following logic.
     pressure_rise_in_h2o = 0.0
 
     # If the fan lives inside of a zone hvac equipment
@@ -85,72 +81,4 @@ class Standard
 
     return pressure_rise_in_h2o
   end
-
-  # creates a constant volume fan
-  #
-  # @param model [OpenStudio::Model::Model] OpenStudio model object
-  # @param fan_name [String] fan name
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  # @param motor_efficiency [Double] fan motor efficiency
-  # @param motor_in_airstream_fraction [Double] fraction of motor heat in airstream
-  # @param end_use_subcategory [String] end use subcategory name
-  # @return [OpenStudio::Model::FanConstantVolume] constant volume fan object
-  def create_fan_constant_volume(model,
-                                 fan_name: nil,
-                                 fan_efficiency: nil,
-                                 pressure_rise: nil,
-                                 motor_efficiency: nil,
-                                 motor_in_airstream_fraction: nil,
-                                 end_use_subcategory: nil)
-    fan = OpenStudio::Model::FanConstantVolume.new(model)
-    PrototypeFan.apply_base_fan_variables(fan,
-                                          fan_name: fan_name,
-                                          fan_efficiency: fan_efficiency,
-                                          pressure_rise: pressure_rise,
-                                          end_use_subcategory: end_use_subcategory)
-    fan.setMotorEfficiency(motor_efficiency) unless motor_efficiency.nil?
-    fan.setMotorInAirstreamFraction(motor_in_airstream_fraction) unless motor_in_airstream_fraction.nil?
-    return fan
-  end
-
-  # creates a constant volume fan from a json
-  #
-  # @param model [OpenStudio::Model::Model] OpenStudio model object
-  # @param fan_json [Hash] hash of fan properties
-  # @param fan_name [String] fan name
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  # @param motor_efficiency [Double] fan motor efficiency
-  # @param motor_in_airstream_fraction [Double] fraction of motor heat in airstream
-  # @param end_use_subcategory [String] end use subcategory name
-  # @return [OpenStudio::Model::FanConstantVolume] constant volume fan object
-  def create_fan_constant_volume_from_json(model,
-                                           fan_json,
-                                           fan_name: nil,
-                                           fan_efficiency: nil,
-                                           pressure_rise: nil,
-                                           motor_efficiency: nil,
-                                           motor_in_airstream_fraction: nil,
-                                           end_use_subcategory: nil)
-    # check values to use
-    fan_efficiency ||= fan_json['fan_efficiency']
-    pressure_rise ||= fan_json['pressure_rise']
-    motor_efficiency ||= fan_json['motor_efficiency']
-    motor_in_airstream_fraction ||= fan_json['motor_in_airstream_fraction']
-    end_use_subcategory ||= fan_json['end_use_subcategory']
-
-    # convert values
-    pressure_rise = pressure_rise ? OpenStudio.convert(pressure_rise, 'inH_{2}O', 'Pa').get : nil
-
-    # create fan
-    fan = create_fan_constant_volume(model,
-                                     fan_name: fan_name,
-                                     fan_efficiency: fan_efficiency,
-                                     pressure_rise: pressure_rise,
-                                     motor_efficiency: motor_efficiency,
-                                     motor_in_airstream_fraction: motor_in_airstream_fraction,
-                                     end_use_subcategory: end_use_subcategory)
-    return fan
-  end
 end

data/lib/openstudio-standards/prototypes/common/objects/Prototype.FanOnOff.rb

@@ -24,8 +24,7 @@ class Standard
     # Convert max flow rate to cfm
     maximum_flow_rate_cfm = OpenStudio.convert(maximum_flow_rate_m3_per_s, 'm^3/s', 'cfm').get
 
-    # Pressure rise will be determined based on the
-    # following logic.
+    # Pressure rise will be determined based on the following logic.
     pressure_rise_in_h2o = 0.0
 
     # If the fan lives inside of a zone hvac equipment
@@ -92,71 +91,4 @@ class Standard
 
     return pressure_rise_in_h2o
   end
-
-  # creates an on off fan
-  #
-  # @param model [OpenStudio::Model::Model] OpenStudio model object
-  # @param fan_name [String] fan name
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  # @param motor_efficiency [Double] fan motor efficiency
-  # @param motor_in_airstream_fraction [Double] fraction of motor heat in airstream
-  # @param end_use_subcategory [String] end use subcategory name
-  # @return [OpenStudio::Model::FanOnOff] on off fan object
-  def create_fan_on_off(model,
-                        fan_name: nil,
-                        fan_efficiency: nil,
-                        pressure_rise: nil,
-                        motor_efficiency: nil,
-                        motor_in_airstream_fraction: nil,
-                        end_use_subcategory: nil)
-    fan = OpenStudio::Model::FanOnOff.new(model)
-    PrototypeFan.apply_base_fan_variables(fan,
-                                          fan_name: fan_name,
-                                          fan_efficiency: fan_efficiency,
-                                          pressure_rise: pressure_rise,
-                                          end_use_subcategory: end_use_subcategory)
-    fan.setMotorEfficiency(motor_efficiency) unless motor_efficiency.nil?
-    fan.setMotorInAirstreamFraction(motor_in_airstream_fraction) unless motor_in_airstream_fraction.nil?
-    return fan
-  end
-
-  # creates a on off fan from a json
-  #
-  # @param model [OpenStudio::Model::Model] OpenStudio model object
-  # @param fan_json [Hash] hash of fan properties
-  # @param fan_name [String] fan name
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  # @param motor_efficiency [Double] fan motor efficiency
-  # @param motor_in_airstream_fraction [Double] fraction of motor heat in airstream
-  # @param end_use_subcategory [String] end use subcategory name
-  # @return [OpenStudio::Model::FanOnOff] on off fan object
-  def create_fan_on_off_from_json(model,
-                                  fan_json,
-                                  fan_name: nil,
-                                  fan_efficiency: nil,
-                                  pressure_rise: nil,
-                                  motor_efficiency: nil,
-                                  motor_in_airstream_fraction: nil,
-                                  end_use_subcategory: nil)
-    # check values to use
-    fan_efficiency ||= fan_json['fan_efficiency']
-    pressure_rise ||= fan_json['pressure_rise']
-    motor_efficiency ||= fan_json['motor_efficiency']
-    motor_in_airstream_fraction ||= fan_json['motor_in_airstream_fraction']
-
-    # convert values
-    pressure_rise = pressure_rise ? OpenStudio.convert(pressure_rise, 'inH_{2}O', 'Pa').get : nil
-
-    # create fan
-    fan = create_fan_on_off(model,
-                            fan_name: fan_name,
-                            fan_efficiency: fan_efficiency,
-                            pressure_rise: pressure_rise,
-                            motor_efficiency: motor_efficiency,
-                            motor_in_airstream_fraction: motor_in_airstream_fraction,
-                            end_use_subcategory: end_use_subcategory)
-    return fan
-  end
 end

data/lib/openstudio-standards/prototypes/common/objects/Prototype.FanVariableVolume.rb

@@ -83,120 +83,4 @@ class Standard
 
     return pressure_rise_in_h2o
   end
-
-  # creates a variable volume fan
-  #
-  # @param model [OpenStudio::Model::Model] OpenStudio model object
-  # @param fan_name [String] fan name
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  # @param motor_efficiency [Double] fan motor efficiency
-  # @param motor_in_airstream_fraction [Double] fraction of motor heat in airstream
-  # @param fan_power_minimum_flow_rate_input_method [String] options are Fraction, FixedFlowRate
-  # @param fan_power_minimum_flow_rate_fraction [Double] minimum flow rate fraction
-  # @param end_use_subcategory [String] end use subcategory name
-  # @param fan_power_coefficient_1 [Double] fan power coefficient 1
-  # @param fan_power_coefficient_2 [Double] fan power coefficient 2
-  # @param fan_power_coefficient_3 [Double] fan power coefficient 3
-  # @param fan_power_coefficient_4 [Double] fan power coefficient 4
-  # @param fan_power_coefficient_5 [Double] fan power coefficient 5
-  # @return [OpenStudio::Model::FanVariableVolume] variable volume fan object
-  def create_fan_variable_volume(model,
-                                 fan_name: nil,
-                                 fan_efficiency: nil,
-                                 pressure_rise: nil,
-                                 motor_efficiency: nil,
-                                 motor_in_airstream_fraction: nil,
-                                 fan_power_minimum_flow_rate_input_method: nil,
-                                 fan_power_minimum_flow_rate_fraction: nil,
-                                 fan_power_coefficient_1: nil,
-                                 fan_power_coefficient_2: nil,
-                                 fan_power_coefficient_3: nil,
-                                 fan_power_coefficient_4: nil,
-                                 fan_power_coefficient_5: nil,
-                                 end_use_subcategory: nil)
-    fan = OpenStudio::Model::FanVariableVolume.new(model)
-    PrototypeFan.apply_base_fan_variables(fan,
-                                          fan_name: fan_name,
-                                          fan_efficiency: fan_efficiency,
-                                          pressure_rise: pressure_rise,
-                                          end_use_subcategory: end_use_subcategory)
-    fan.setMotorEfficiency(motor_efficiency) unless motor_efficiency.nil?
-    fan.setMotorInAirstreamFraction(motor_in_airstream_fraction) unless motor_in_airstream_fraction.nil?
-    fan.setFanPowerMinimumFlowRateInputMethod(fan_power_minimum_flow_rate_input_method) unless fan_power_minimum_flow_rate_input_method.nil?
-    fan.setFanPowerMinimumFlowFraction(fan_power_minimum_flow_rate_fraction) unless fan_power_minimum_flow_rate_fraction.nil?
-    fan.setFanPowerCoefficient1(fan_power_coefficient_1) unless fan_power_coefficient_1.nil?
-    fan.setFanPowerCoefficient2(fan_power_coefficient_2) unless fan_power_coefficient_2.nil?
-    fan.setFanPowerCoefficient3(fan_power_coefficient_3) unless fan_power_coefficient_3.nil?
-    fan.setFanPowerCoefficient4(fan_power_coefficient_4) unless fan_power_coefficient_4.nil?
-    fan.setFanPowerCoefficient5(fan_power_coefficient_5) unless fan_power_coefficient_5.nil?
-    return fan
-  end
-
-  # creates a variable volume fan from a json
-  #
-  # @param model [OpenStudio::Model::Model] OpenStudio model object
-  # @param fan_json [Hash] hash of fan properties
-  # @param fan_name [String] fan name
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  # @param motor_efficiency [Double] fan motor efficiency
-  # @param motor_in_airstream_fraction [Double] fraction of motor heat in airstream
-  # @param fan_power_minimum_flow_rate_input_method [String] options are Fraction, FixedFlowRate
-  # @param fan_power_minimum_flow_rate_fraction [Double] minimum flow rate fraction
-  # @param end_use_subcategory [String] end use subcategory name
-  # @param fan_power_coefficient_1 [Double] fan power coefficient 1
-  # @param fan_power_coefficient_2 [Double] fan power coefficient 2
-  # @param fan_power_coefficient_3 [Double] fan power coefficient 3
-  # @param fan_power_coefficient_4 [Double] fan power coefficient 4
-  # @param fan_power_coefficient_5 [Double] fan power coefficient 5
-  # @return [OpenStudio::Model::FanVariableVolume] variable volume fan object
-  def create_fan_variable_volume_from_json(model,
-                                           fan_json,
-                                           fan_name: nil,
-                                           fan_efficiency: nil,
-                                           pressure_rise: nil,
-                                           motor_efficiency: nil,
-                                           motor_in_airstream_fraction: nil,
-                                           fan_power_minimum_flow_rate_input_method: nil,
-                                           fan_power_minimum_flow_rate_fraction: nil,
-                                           end_use_subcategory: nil,
-                                           fan_power_coefficient_1: nil,
-                                           fan_power_coefficient_2: nil,
-                                           fan_power_coefficient_3: nil,
-                                           fan_power_coefficient_4: nil,
-                                           fan_power_coefficient_5: nil)
-    # check values to use
-    fan_efficiency ||= fan_json['fan_efficiency']
-    pressure_rise ||= fan_json['pressure_rise']
-    motor_efficiency ||= fan_json['motor_efficiency']
-    motor_in_airstream_fraction ||= fan_json['motor_in_airstream_fraction']
-    fan_power_minimum_flow_rate_input_method ||= fan_json['fan_power_minimum_flow_rate_input_method']
-    fan_power_minimum_flow_rate_fraction ||= fan_json['fan_power_minimum_flow_rate_fraction']
-    fan_power_coefficient_1 ||= fan_json['fan_power_coefficient_1']
-    fan_power_coefficient_2 ||= fan_json['fan_power_coefficient_2']
-    fan_power_coefficient_3 ||= fan_json['fan_power_coefficient_3']
-    fan_power_coefficient_4 ||= fan_json['fan_power_coefficient_4']
-    fan_power_coefficient_5 ||= fan_json['fan_power_coefficient_5']
-
-    # convert values
-    pressure_rise_pa = OpenStudio.convert(pressure_rise, 'inH_{2}O', 'Pa').get unless pressure_rise.nil?
-
-    # create fan
-    fan = create_fan_variable_volume(model,
-                                     fan_name: fan_name,
-                                     fan_efficiency: fan_efficiency,
-                                     pressure_rise: pressure_rise_pa,
-                                     motor_efficiency: motor_efficiency,
-                                     motor_in_airstream_fraction: motor_in_airstream_fraction,
-                                     fan_power_minimum_flow_rate_input_method: fan_power_minimum_flow_rate_input_method,
-                                     fan_power_minimum_flow_rate_fraction: fan_power_minimum_flow_rate_fraction,
-                                     end_use_subcategory: end_use_subcategory,
-                                     fan_power_coefficient_1: fan_power_coefficient_1,
-                                     fan_power_coefficient_2: fan_power_coefficient_2,
-                                     fan_power_coefficient_3: fan_power_coefficient_3,
-                                     fan_power_coefficient_4: fan_power_coefficient_4,
-                                     fan_power_coefficient_5: fan_power_coefficient_5)
-    return fan
-  end
 end

data/lib/openstudio-standards/prototypes/common/objects/Prototype.FanZoneExhaust.rb

@@ -23,65 +23,4 @@ class Standard
 
     return true
   end
-
-  # creates a FanZoneExhaust from a json
-  #
-  # @param model [OpenStudio::Model::Model] OpenStudio model object
-  # @param fan_json [Hash] hash of fan properties
-  # @param fan_name [String] fan name
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  # @param system_availability_manager_coupling_mode [String] coupling mode, options are Coupled, Decoupled
-  # @param end_use_subcategory [String] end use subcategory name
-  # @return [OpenStudio::Model::FanZoneExhaust] the exhaust fan
-  def create_fan_zone_exhaust_from_json(model,
-                                        fan_json,
-                                        fan_name: nil,
-                                        fan_efficiency: nil,
-                                        pressure_rise: nil,
-                                        system_availability_manager_coupling_mode: nil,
-                                        end_use_subcategory: nil)
-
-    # check values to use
-    fan_efficiency ||= fan_json['fan_efficiency']
-    pressure_rise ||= fan_json['pressure_rise']
-    system_availability_manager_coupling_mode ||= fan_json['system_availability_manager_coupling_mode']
-
-    # convert values
-    pressure_rise = pressure_rise ? OpenStudio.convert(pressure_rise, 'inH_{2}O', 'Pa').get : nil
-
-    # create fan
-    fan = create_fan_zone_exhaust(model,
-                                  fan_name: fan_name,
-                                  fan_efficiency: fan_efficiency,
-                                  pressure_rise: pressure_rise,
-                                  system_availability_manager_coupling_mode: system_availability_manager_coupling_mode,
-                                  end_use_subcategory: end_use_subcategory)
-    return fan
-  end
-
-  # creates a FanZoneExhaust
-  #
-  # @param model [OpenStudio::Model::Model] OpenStudio model object
-  # @param fan_name [String] fan name
-  # @param fan_efficiency [Double] fan efficiency
-  # @param pressure_rise [Double] fan pressure rise in Pa
-  # @param system_availability_manager_coupling_mode [String] coupling mode, options are Coupled, Decoupled
-  # @param end_use_subcategory [String] end use subcategory name
-  # @return [OpenStudio::Model::FanZoneExhaust] the exhaust fan
-  def create_fan_zone_exhaust(model,
-                              fan_name: nil,
-                              fan_efficiency: nil,
-                              pressure_rise: nil,
-                              system_availability_manager_coupling_mode: nil,
-                              end_use_subcategory: nil)
-    fan = OpenStudio::Model::FanZoneExhaust.new(model)
-    PrototypeFan.apply_base_fan_variables(fan,
-                                          fan_name: fan_name,
-                                          fan_efficiency: fan_efficiency,
-                                          pressure_rise: pressure_rise,
-                                          end_use_subcategory: end_use_subcategory)
-    fan.setSystemAvailabilityManagerCouplingMode(system_availability_manager_coupling_mode) unless system_availability_manager_coupling_mode.nil?
-    return fan
-  end
 end

data/lib/openstudio-standards/prototypes/common/objects/Prototype.Model.hvac.rb

@@ -267,12 +267,12 @@ class Standard
         htg_dsgn_sup_air_temp = system['heating_design_supply_air_temperature'] || 70.0
 
         # for boolean input, this makes sure we get the correct input translation
-        if system['include_exhaust_fan'].nil? || true?(system['include_exhaust_fan'])
+        if system['include_exhaust_fan'].nil? || (system['include_exhaust_fan'].to_s.downcase == 'true')
           include_exhaust_fan = true
         else
           include_exhaust_fan = false
         end
-        if true?(system['demand_control_ventilation'])
+        if (system['demand_control_ventilation'].to_s.downcase == 'true')
           demand_control_ventilation = true
         else
           demand_control_ventilation = false