decidim 0.5.1 → 0.6.0

data/decidim-participatory_processes/spec/forms/participatory_process_group_form_spec.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module ParticipatoryProcesses
+    module Admin
+      describe ParticipatoryProcessGroupForm do
+        let(:organization) { create :organization }
+        let(:participatory_processes) { create_list :participatory_process, 3, organization: organization }
+        let(:name) do
+          {
+            en: "Title",
+            es: "Título",
+            ca: "Títol"
+          }
+        end
+        let(:description) do
+          {
+            en: "Description",
+            es: "Descripción",
+            ca: "Descripció"
+          }
+        end
+        let(:attachment) { Decidim::Dev.test_file("city.jpeg", "image/jpeg") }
+
+        let(:attributes) do
+          {
+            "name_en" => name[:en],
+            "name_es" => name[:es],
+            "name_ca" => name[:ca],
+            "description_en" => description[:en],
+            "description_es" => description[:es],
+            "description_ca" => description[:ca],
+            "hero_image" => attachment,
+            "participatory_processes" => participatory_processes
+          }
+        end
+
+        subject { described_class.from_params(attributes).with_context(current_organization: organization) }
+
+        context "when everything is OK" do
+          it { is_expected.to be_valid }
+        end
+
+        context "when hero_image is too big" do
+          before do
+            allow(Decidim).to receive(:maximum_attachment_size).and_return(5.megabytes)
+            expect(subject.hero_image).to receive(:size).and_return(6.megabytes)
+          end
+
+          it { is_expected.not_to be_valid }
+        end
+
+        context "when images are not the expected type" do
+          let(:attachment) { Decidim::Dev.test_file("Exampledocument.pdf", "application/pdf") }
+
+          it { is_expected.not_to be_valid }
+        end
+
+        context "when some language in title is missing" do
+          let(:name) do
+            {
+              en: "Title",
+              ca: "Títol"
+            }
+          end
+
+          it { is_expected.to be_invalid }
+        end
+
+        context "when some language in description is missing" do
+          let(:description) do
+            {
+              ca: "Descripció"
+            }
+          end
+
+          it { is_expected.to be_invalid }
+        end
+      end
+    end
+  end
+end

data/decidim-participatory_processes/spec/forms/participatory_process_step_form_spec.rb

@@ -0,0 +1,106 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module ParticipatoryProcesses
+    module Admin
+      describe ParticipatoryProcessStepForm do
+        let(:title) do
+          {
+            en: "Title",
+            es: "Título",
+            ca: "Títol"
+          }
+        end
+        let(:description) do
+          {
+            en: "Description",
+            es: "Descripción",
+            ca: "Descripció"
+          }
+        end
+        let(:start_date) {}
+        let(:end_date) {}
+        let(:attributes) do
+          {
+            "participatory_process_step" => {
+              "title_en" => title[:en],
+              "title_es" => title[:es],
+              "title_ca" => title[:ca],
+              "description_en" => description[:en],
+              "description_es" => description[:es],
+              "description_ca" => description[:ca],
+              "start_date" => start_date,
+              "end_date" => end_date
+            }
+          }
+        end
+        let(:organization) { build(:organization) }
+
+        subject { described_class.from_params(attributes).with_context(current_organization: organization) }
+
+        describe "dates" do
+          context "when the dates are set" do
+            let(:start_date) { Time.new(2016, 1, 1, 15, 0) }
+            let(:end_date) { Time.new(2016, 1, 1, 15, 0) }
+
+            it "returns them at midnight" do
+              expect(subject.start_date).to eq(Time.new(2016, 1, 1, 0, 0))
+              expect(subject.end_date).to eq(Time.new(2016, 1, 1, 0, 0))
+            end
+          end
+
+          context "when no dates" do
+            it "returns nil" do
+              expect(subject.start_date).to eq(nil)
+              expect(subject.end_date).to eq(nil)
+            end
+          end
+        end
+
+        context "when everything is OK" do
+          it { is_expected.to be_valid }
+        end
+
+        context "when some language in title is missing" do
+          let(:title) do
+            {
+              en: "Title",
+              ca: "Títol"
+            }
+          end
+
+          it { is_expected.to be_invalid }
+        end
+
+        context "when the start_date is later than end_date" do
+          let(:start_date) { 1.month.from_now }
+          let(:end_date) { 2.months.ago }
+
+          it { is_expected.to be_invalid }
+
+          it "has an error" do
+            subject.valid?
+
+            expect(subject.errors).not_to be_empty
+            expect(subject.errors[:end_date]).not_to be_empty
+            expect(subject.errors[:start_date]).not_to be_empty
+          end
+        end
+
+        context "when start_date is present" do
+          let(:start_date) { 1.month.from_now }
+
+          it { is_expected.to be_valid }
+        end
+
+        context "when end_date is present" do
+          let(:end_date) { 2.months.ago }
+
+          it { is_expected.to be_valid }
+        end
+      end
+    end
+  end
+end

data/decidim-participatory_processes/spec/forms/participatory_process_user_role_form_spec.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module ParticipatoryProcesses
+    module Admin
+      describe ParticipatoryProcessUserRoleForm do
+        let(:email) { "my_email@example.org" }
+        let(:name) { "John Wayne" }
+        let(:role) { "admin" }
+        let(:attributes) do
+          {
+            "participatory_process_user_role" => {
+              "email" => email,
+              "name" => name,
+              "role" => role
+            }
+          }
+        end
+
+        subject { described_class.from_params(attributes) }
+
+        context "when everything is OK" do
+          it { is_expected.to be_valid }
+        end
+
+        context "when email is missing" do
+          let(:email) {}
+
+          it { is_expected.to be_invalid }
+        end
+      end
+    end
+  end
+end

data/decidim-participatory_processes/spec/helpers/decidim/participatory_processes/participatory_process_helper_spec.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module ParticipatoryProcesses
+    describe ParticipatoryProcessHelper do
+      describe "#participatory_process_step_dates" do
+        let(:participatory_process) do
+          double(start_date: start_date, end_date: end_date)
+        end
+
+        let(:start_date) { Date.civil(2016, 1, 1) }
+        let(:end_date) { Date.civil(2016, 2, 5) }
+
+        describe "when both dates are present" do
+          it "returns the formatted dates" do
+            result = helper.participatory_process_step_dates(participatory_process)
+            expect(result).to eq("2016-01-01 - 2016-02-05")
+          end
+        end
+
+        describe "when the start date isn't present" do
+          let(:start_date) { nil }
+
+          it "fills it in with an interrogation mark" do
+            result = helper.participatory_process_step_dates(participatory_process)
+            expect(result).to eq("? - 2016-02-05")
+          end
+        end
+
+        describe "when the end date isn't present" do
+          let(:end_date) { nil }
+
+          it "fills it in with an interrogation mark" do
+            result = helper.participatory_process_step_dates(participatory_process)
+            expect(result).to eq("2016-01-01 - ?")
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-participatory_processes/spec/helpers/decidim/scopes_helper_spec.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "provides valid scope helpers" do
+  let(:participatory_space) do
+    create(
+      :participatory_process,
+      organization: organization,
+      scopes_enabled: scopes_enabled,
+      scope: participatory_space_scope
+    )
+  end
+
+  include_examples "scope helpers"
+end

data/decidim-participatory_processes/spec/lib/features/participatory_processes/current_feature_spec.rb

@@ -0,0 +1,90 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module ParticipatoryProcesses
+    describe CurrentFeature do
+      let(:request) { double(params: params, env: env) }
+      let(:subject) { described_class.new(manifest) }
+      let(:params) { {} }
+      let(:manifest) { Decidim.find_feature_manifest("dummy") }
+
+      let(:organization) do
+        create(:organization)
+      end
+
+      let(:participatory_processes) do
+        create_list(:participatory_process, 2, organization: organization)
+      end
+
+      let(:current_participatory_process) { participatory_processes.first }
+
+      let(:env) do
+        { "decidim.current_organization" => organization }
+      end
+
+      context "when the params contain a participatory_process id" do
+        before do
+          params["participatory_process_id"] = current_participatory_process.id.to_s
+        end
+
+        context "when the params don't contain a feature id" do
+          it "doesn't match" do
+            expect(subject.matches?(request)).to eq(false)
+          end
+        end
+
+        context "when the params contain a feature id" do
+          before do
+            params["feature_id"] = feature.id.to_s
+          end
+
+          context "when the feature doesn't belong to the participatory process" do
+            let(:feature) { create(:feature) }
+
+            it "matches" do
+              expect(subject.matches?(request)).to eq(false)
+            end
+          end
+
+          context "when the feature belongs to the participatory process" do
+            let(:feature) { create(:feature, participatory_space: current_participatory_process) }
+
+            it "matches" do
+              expect(subject.matches?(request)).to eq(true)
+            end
+          end
+        end
+      end
+
+      context "when the params don't contain a participatory process id" do
+        it "doesn't match" do
+          expect(subject.matches?(request)).to eq(false)
+        end
+      end
+
+      context "when the params contain a non existing participatory process id" do
+        before do
+          params["participatory_process_id"] = "99999999"
+        end
+
+        context "when there's no feature" do
+          it "doesn't match" do
+            expect(subject.matches?(request)).to eq(false)
+          end
+        end
+
+        context "when there's feature" do
+          before do
+            params["feature_id"] = "1"
+          end
+
+          it "doesn't match" do
+            expect(subject.matches?(request)).to eq(false)
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-participatory_processes/spec/models/abilities/admin/admin_ability_spec.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Decidim::ParticipatoryProcesses::Abilities::Admin::AdminAbility do
+  let(:user) { build(:user, :admin) }
+
+  subject { described_class.new(user, {}) }
+
+  it { is_expected.to be_able_to(:manage, Decidim::ParticipatoryProcess) }
+  it { is_expected.to be_able_to(:manage, Decidim::ParticipatoryProcessStep) }
+end

data/decidim-participatory_processes/spec/models/abilities/admin_ability_spec.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Decidim::ParticipatoryProcesses::Abilities::AdminAbility do
+  let(:user) { build(:user, :admin) }
+  let(:context) { {} }
+
+  subject { described_class.new(user, context) }
+
+  it { is_expected.to be_able_to(:read, Decidim::ParticipatoryProcess) }
+end

data/decidim-participatory_processes/spec/models/abilities/everyone_ability_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Decidim::ParticipatoryProcesses::Abilities::EveryoneAbility do
+  let(:user) { build(:user) }
+
+  subject { described_class.new(user, {}) }
+
+  it "lets the user read processes" do
+    expect(subject.permissions[:can][:read]).to include("Decidim::ParticipatoryProcess")
+  end
+end

data/{decidim-core/spec/presenters/decidim → decidim-participatory_processes/spec/presenters/decidim/participatory_processes}/participatory_process_stats_presenter.spec.rb

@@ -7,9 +7,9 @@ module Decidim
     let!(:organization) { create(:organization) }
     let!(:user) { create(:user, :confirmed, organization: organization) }
     let!(:process) { create(:participatory_process, organization: organization) }
-    let!(:feature) { create(:feature, participatory_process: process) }
-    let!(:feature2) { create(:feature, participatory_process: process) }
-    let!(:feature3) { create(:feature, participatory_process: process) }
+    let!(:feature) { create(:feature, participatory_space: process) }
+    let!(:feature2) { create(:feature, participatory_space: process) }
+    let!(:feature3) { create(:feature, participatory_space: process) }
 
     subject { described_class.new(participatory_process: process) }
 

data/{decidim-admin/spec/queries → decidim-participatory_processes/spec/queries/admin}/process_admins_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe Decidim::Admin::ProcessAdmins do
+describe Decidim::ParticipatoryProcesses::Admin::AdminUsers do
   let(:organization) { create :organization }
   let(:participatory_process) { create :participatory_process, organization: organization }
   let!(:admin) { create(:user, :admin, :confirmed, organization: organization) }