decidim 0.5.1 → 0.6.0

data/{decidim-admin → decidim-participatory_processes}/spec/commands/reorder_participatory_process_steps_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe Decidim::Admin::ReorderParticipatoryProcessSteps do
+describe Decidim::ParticipatoryProcesses::Admin::ReorderParticipatoryProcessSteps do
   let(:process) { create :participatory_process }
   let!(:process_step1) do
     create(

data/{decidim-admin → decidim-participatory_processes}/spec/commands/unpublish_participatory_process_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe Decidim::Admin::UnpublishParticipatoryProcess do
+describe Decidim::ParticipatoryProcesses::Admin::UnpublishParticipatoryProcess do
   let(:my_process) { create :participatory_process }
 
   subject { described_class.new(my_process) }

data/decidim-participatory_processes/spec/commands/update_category_spec.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "decidim/admin/test/commands/update_category_examples"
+
+describe Decidim::Admin::UpdateCategory do
+  include_examples "UpdateCategory command" do
+    let(:participatory_space) { create(:participatory_process, organization: organization) }
+  end
+end

data/decidim-participatory_processes/spec/commands/update_participatory_process_spec.rb

@@ -0,0 +1,121 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module ParticipatoryProcesses
+    module Admin
+      describe UpdateParticipatoryProcess do
+        describe "call" do
+          let(:my_process) { create :participatory_process }
+          let(:params) do
+            {
+              participatory_process: {
+                id: my_process.id,
+                title_en: "Foo title",
+                title_ca: "Foo title",
+                title_es: "Foo title",
+                subtitle_en: my_process.subtitle,
+                subtitle_ca: my_process.subtitle,
+                subtitle_es: my_process.subtitle,
+                slug: my_process.slug,
+                hashtag: my_process.hashtag,
+                meta_scope: my_process.meta_scope,
+                hero_image: nil,
+                banner_image: nil,
+                promoted: my_process.promoted,
+                description_en: my_process.description,
+                description_ca: my_process.description,
+                description_es: my_process.description,
+                short_description_en: my_process.short_description,
+                short_description_ca: my_process.short_description,
+                short_description_es: my_process.short_description,
+                current_organization: my_process.organization,
+                scopes_enabled: my_process.scopes_enabled,
+                scope: my_process.scope,
+                errors: my_process.errors,
+                participatory_process_group: my_process.participatory_process_group,
+                show_statistics: my_process.show_statistics
+              }
+            }
+          end
+          let(:context) do
+            { current_organization: my_process.organization }
+          end
+          let(:form) do
+            ParticipatoryProcessForm.from_params(params).with_context(context)
+          end
+          let(:command) { described_class.new(my_process, form) }
+
+          describe "when the form is not valid" do
+            before do
+              expect(form).to receive(:invalid?).and_return(true)
+            end
+
+            it "broadcasts invalid" do
+              expect { command.call }.to broadcast(:invalid)
+            end
+
+            it "doesn't update the participatory process" do
+              command.call
+              my_process.reload
+
+              expect(my_process.title["en"]).not_to eq("Foo title")
+            end
+          end
+
+          describe "when the participatory process is not valid" do
+            before do
+              expect(form).to receive(:invalid?).and_return(false)
+              expect(my_process).to receive(:valid?).at_least(:once).and_return(false)
+              my_process.errors.add(:hero_image, "Image too big")
+              my_process.errors.add(:banner_image, "Image too big")
+            end
+
+            it "broadcasts invalid" do
+              expect { command.call }.to broadcast(:invalid)
+            end
+
+            it "adds errors to the form" do
+              command.call
+
+              expect(form.errors[:hero_image]).not_to be_empty
+              expect(form.errors[:banner_image]).not_to be_empty
+            end
+          end
+
+          describe "when the form is valid" do
+            it "broadcasts ok" do
+              expect { command.call }.to broadcast(:ok)
+            end
+
+            it "updates the participatory process" do
+              expect { command.call }.to broadcast(:ok)
+              my_process.reload
+
+              expect(my_process.title["en"]).to eq("Foo title")
+            end
+
+            context "when no homepage image is set" do
+              it "does not replace the homepage image" do
+                command.call
+                my_process.reload
+
+                expect(my_process.hero_image).to be_present
+              end
+            end
+
+            context "when no banner image is set" do
+              it "does not replace the banner image" do
+                command.call
+                my_process.reload
+
+                expect(my_process.banner_image).to be_present
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-participatory_processes/spec/controllers/exports_controller_spec.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module ParticipatoryProcesses
+    module Admin
+      describe ExportsController, type: :controller do
+        routes { Decidim::ParticipatoryProcesses::AdminEngine.routes }
+
+        let!(:organization) { create(:organization) }
+        let!(:participatory_process) { create :participatory_process, organization: organization }
+        let!(:user) { create(:user, :admin, :confirmed, organization: organization) }
+        let!(:feature) { create(:feature, participatory_space: participatory_process, manifest_name: "dummy") }
+
+        before do
+          @request.env["decidim.current_organization"] = organization
+          sign_in user, scope: :user
+        end
+
+        let(:params) do
+          {
+            id: "dummies",
+            feature_id: feature.id,
+            participatory_process_id: participatory_process.id
+          }
+        end
+
+        describe "POST create" do
+          context "when a format is provided" do
+            it "enqueues a job with the provided format" do
+              params[:format] = "csv"
+
+              expect(ExportJob).to receive(:perform_later)
+                .with(user, feature, "dummies", "csv")
+
+              post(:create, params: params)
+            end
+          end
+
+          context "when a format is not provided" do
+            it "enqueues a job with the default format" do
+              expect(ExportJob).to receive(:perform_later)
+                .with(user, feature, "dummies", "json")
+
+              post(:create, params: params)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-participatory_processes/spec/controllers/participatory_processes_controller_spec.rb

@@ -0,0 +1,122 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "decidim/dev/test/promoted_participatory_processes_shared_examples"
+
+module Decidim
+  module ParticipatoryProcesses
+    describe ParticipatoryProcessesController, type: :controller do
+      routes { Decidim::ParticipatoryProcesses::Engine.routes }
+
+      let(:organization) { create(:organization) }
+      let!(:unpublished_process) do
+        create(
+          :participatory_process,
+          :unpublished,
+          organization: organization
+        )
+      end
+
+      describe "participatory_processes" do
+        before do
+          @request.env["decidim.current_organization"] = organization
+        end
+
+        it "orders them by end_date" do
+          unpublished = create(
+            :participatory_process,
+            :with_steps,
+            :unpublished,
+            organization: organization
+          )
+
+          last = create(
+            :participatory_process,
+            :with_steps,
+            :published,
+            organization: organization,
+            end_date: nil
+          )
+          last.active_step.update_attribute(:end_date, nil)
+
+          first = create(
+            :participatory_process,
+            :with_steps,
+            :published,
+            organization: organization,
+            end_date: Time.current.advance(days: 10)
+          )
+          first.active_step.update_attribute(:end_date, Time.current.advance(days: 2))
+
+          second = create(
+            :participatory_process,
+            :with_steps,
+            :published,
+            organization: organization,
+            end_date: Time.current.advance(days: 20)
+          )
+          second.active_step.update_attribute(:end_date, Time.current.advance(days: 4))
+
+          expect(controller.helpers.participatory_processes.count).to eq(3)
+          expect(controller.helpers.participatory_processes).not_to include(unpublished)
+          expect(controller.helpers.participatory_processes.first).to eq(first)
+          expect(controller.helpers.participatory_processes.to_a[1]).to eq(second)
+          expect(controller.helpers.participatory_processes.to_a.last).to eq(last)
+        end
+      end
+
+      include_examples "with promoted participatory processes"
+
+      describe "collection" do
+        before do
+          @request.env["decidim.current_organization"] = organization
+        end
+
+        let(:other_organization) { create(:organization) }
+
+        it "includes a heterogeneous array of processes and groups" do
+          published = create_list(
+            :participatory_process,
+            2,
+            :published,
+            organization: organization
+          )
+
+          _unpublished = create_list(
+            :participatory_process,
+            2,
+            :unpublished,
+            organization: organization
+          )
+
+          organization_groups = create_list(
+            :participatory_process_group,
+            2,
+            :with_participatory_processes,
+            organization: organization
+          )
+
+          _other_groups = create_list(
+            :participatory_process_group,
+            2,
+            :with_participatory_processes,
+            organization: other_organization
+          )
+
+          expect(controller.helpers.collection)
+            .to match_array([*published, *organization_groups, *organization_groups.map(&:participatory_processes).flatten])
+        end
+      end
+
+      describe "GET show" do
+        context "when the process is unpublished" do
+          it "redirects to root path" do
+            get :show, params: { id: unpublished_process.id }
+
+            expect(response).to redirect_to("/")
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-participatory_processes/spec/factories.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+require "decidim/core/test/factories"
+require "decidim/proposals/test/factories"
+
+require "decidim/participatory_processes/test/factories"

data/{decidim-admin/spec/features → decidim-participatory_processes/spec/features/admin}/admin_copy_participatory_process_spec.rb

@@ -6,18 +6,18 @@ describe "Admin copies participatory process", type: :feature do
   include_context "participatory process administration by admin"
 
   let!(:participatory_process) { create(:participatory_process, :with_steps, organization: organization) }
-  let!(:feature) { create :feature, manifest_name: :dummy, participatory_process: participatory_process }
+  let!(:feature) { create :feature, manifest_name: :dummy, participatory_space: participatory_process }
   let!(:category) do
     create(
       :category,
-      participatory_process: participatory_process
+      participatory_space: participatory_process
     )
   end
 
   before do
     switch_to_host(organization.host)
     login_as user, scope: :user
-    visit decidim_admin.participatory_processes_path
+    visit decidim_admin_participatory_processes.participatory_processes_path
   end
 
   context "without any context" do

data/{decidim-admin/spec/features → decidim-participatory_processes/spec/features/admin}/admin_manages_participatory_process_categories_spec.rb

@@ -8,7 +8,7 @@ describe "Admin manages participatory process categories", type: :feature do
   let!(:category) do
     create(
       :category,
-      participatory_process: participatory_process
+      participatory_space: participatory_process
     )
   end
 

data/decidim-participatory_processes/spec/features/admin/admin_manages_participatory_process_feature_permissions_spec.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "decidim/admin/test/manage_feature_permissions_examples"
+
+describe "Admin manages participatory process feature permissions", type: :feature do
+  include_examples "Managing feature permissions" do
+    let(:participatory_space_engine) { decidim_admin_participatory_processes }
+
+    let!(:participatory_space) do
+      create(:participatory_process, organization: organization)
+    end
+  end
+end

data/{decidim-admin/spec/features/admin_manages_features_spec.rb → decidim-participatory_processes/spec/features/admin/admin_manages_participatory_process_features_spec.rb}

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe "Admin manages features", type: :feature do
+describe "Admin manages participatory process features", type: :feature do
   let(:organization) { create(:organization) }
   let(:user) { create(:user, :admin, :confirmed, organization: organization) }
 
@@ -17,52 +17,70 @@ describe "Admin manages features", type: :feature do
 
   describe "add a feature" do
     before do
-      visit decidim_admin.features_path(participatory_process)
+      visit decidim_admin_participatory_processes.features_path(participatory_process)
     end
 
-    it "adds a feature" do
-      find("button[data-toggle=add-feature-dropdown]").click
+    context "when the process has active steps" do
+      before do
+        find("button[data-toggle=add-feature-dropdown]").click
 
-      within "#add-feature-dropdown" do
-        find(".dummy").click
-      end
+        within "#add-feature-dropdown" do
+          find(".dummy").click
+        end
 
-      within ".new_feature" do
-        fill_in_i18n(
-          :feature_name,
-          "#feature-name-tabs",
-          en: "My feature",
-          ca: "La meva funcionalitat",
-          es: "Mi funcionalitat"
-        )
+        within ".new_feature" do
+          fill_in_i18n(
+            :feature_name,
+            "#feature-name-tabs",
+            en: "My feature",
+            ca: "La meva funcionalitat",
+            es: "Mi funcionalitat"
+          )
 
-        within ".global-settings" do
-          all("input[type=checkbox]").last.click
+          within ".global-settings" do
+            all("input[type=checkbox]").last.click
+          end
+
+          within ".step-settings" do
+            all("input[type=checkbox]").first.click
+          end
+
+          click_button "Add feature"
         end
+      end
 
-        within ".step-settings" do
-          all("input[type=checkbox]").first.click
+      it "is successfully created" do
+        within ".callout-wrapper" do
+          expect(page).to have_content("successfully")
         end
 
-        find("*[type=submit]").click
+        expect(page).to have_content("My feature")
       end
 
-      within ".callout-wrapper" do
-        expect(page).to have_content("successfully")
-      end
+      context "and then edit it" do
+        before do
+          within find("tr", text: "My feature") do
+            page.find(".action-icon--configure").click
+          end
+        end
 
-      expect(page).to have_content("My feature")
+        it "sucessfully displays initial values in the form" do
+          within ".global-settings" do
+            expect(all("input[type=checkbox]").last).to be_checked
+          end
 
-      within find("tr", text: "My feature") do
-        page.find(".action-icon--configure").click
-      end
+          within ".step-settings" do
+            expect(all("input[type=checkbox]").first).to be_checked
+          end
+        end
 
-      within ".global-settings" do
-        expect(all("input[type=checkbox]").last).to be_checked
-      end
+        it "successfully edits it" do
+          click_button "Update"
 
-      within ".step-settings" do
-        expect(all("input[type=checkbox]").first).to be_checked
+          within ".callout-wrapper" do
+            expect(page).to have_content("successfully")
+          end
+        end
       end
     end
 
@@ -71,7 +89,7 @@ describe "Admin manages features", type: :feature do
         create(:participatory_process, organization: organization)
       end
 
-      it "saves the default step settings" do
+      before do
         find("button[data-toggle=add-feature-dropdown]").click
 
         within "#add-feature-dropdown" do
@@ -95,25 +113,41 @@ describe "Admin manages features", type: :feature do
             all("input[type=checkbox]").first.click
           end
 
-          find("*[type=submit]").click
+          click_button "Add feature"
         end
+      end
 
+      it "is successfully created" do
         within ".callout-wrapper" do
           expect(page).to have_content("successfully")
         end
 
         expect(page).to have_content("My feature")
+      end
 
-        within find("tr", text: "My feature") do
-          page.find(".action-icon--configure").click
+      context "and then edit it" do
+        before do
+          within find("tr", text: "My feature") do
+            page.find(".action-icon--configure").click
+          end
         end
 
-        within ".global-settings" do
-          expect(all("input[type=checkbox]").last).to be_checked
+        it "sucessfully displays initial values in the form" do
+          within ".global-settings" do
+            expect(all("input[type=checkbox]").last).to be_checked
+          end
+
+          within ".default-step-settings" do
+            expect(all("input[type=checkbox]").first).to be_checked
+          end
         end
 
-        within ".default-step-settings" do
-          expect(all("input[type=checkbox]").first).to be_checked
+        it "successfully edits it" do
+          click_button "Update"
+
+          within ".callout-wrapper" do
+            expect(page).to have_content("successfully")
+          end
         end
       end
     end
@@ -129,11 +163,11 @@ describe "Admin manages features", type: :feature do
     end
 
     let!(:feature) do
-      create(:feature, name: feature_name, participatory_process: participatory_process)
+      create(:feature, name: feature_name, participatory_space: participatory_process)
     end
 
     before do
-      visit decidim_admin.features_path(participatory_process)
+      visit decidim_admin_participatory_processes.features_path(participatory_process)
     end
 
     it "updates the feature" do
@@ -158,7 +192,7 @@ describe "Admin manages features", type: :feature do
           all("input[type=checkbox]").first.click
         end
 
-        find("*[type=submit]").click
+        click_button "Update"
       end
 
       within ".callout-wrapper" do
@@ -181,9 +215,7 @@ describe "Admin manages features", type: :feature do
     end
 
     context "when the process doesn't have active steps" do
-      let!(:participatory_process) do
-        create(:participatory_process, organization: organization)
-      end
+      before { participatory_process.steps.destroy_all }
 
       it "updates the default step settings" do
         within ".feature-#{feature.id}" do
@@ -195,7 +227,7 @@ describe "Admin manages features", type: :feature do
             all("input[type=checkbox]").first.click
           end
 
-          find("*[type=submit]").click
+          click_button "Update"
         end
 
         within ".callout-wrapper" do
@@ -223,11 +255,11 @@ describe "Admin manages features", type: :feature do
     end
 
     let!(:feature) do
-      create(:feature, name: feature_name, participatory_process: participatory_process)
+      create(:feature, name: feature_name, participatory_space: participatory_process)
     end
 
     before do
-      visit decidim_admin.features_path(participatory_process)
+      visit decidim_admin_participatory_processes.features_path(participatory_process)
     end
 
     it "removes the feature" do
@@ -241,13 +273,13 @@ describe "Admin manages features", type: :feature do
 
   describe "publish and unpublish a feature" do
     let!(:feature) do
-      create(:feature, participatory_process: participatory_process, published_at: published_at)
+      create(:feature, participatory_space: participatory_process, published_at: published_at)
     end
 
     let(:published_at) { nil }
 
     before do
-      visit decidim_admin.features_path(participatory_process)
+      visit decidim_admin_participatory_processes.features_path(participatory_process)
     end
 
     context "when the feature is unpublished" do