decidim 0.5.1 → 0.6.0

data/{decidim-admin/spec/features → decidim-participatory_processes/spec/features/admin}/admin_manages_participatory_process_groups_spec.rb

@@ -9,7 +9,7 @@ describe "Admin manages participatory process groups", type: :feature do
     switch_to_host(organization.host)
     login_as user, scope: :user
     @participatory_processes = create_list(:participatory_process, 3, organization: organization)
-    visit decidim_admin.participatory_process_groups_path
+    visit decidim_admin_participatory_processes.participatory_process_groups_path
   end
 
   it "creates a new participatory process group" do

data/decidim-participatory_processes/spec/features/admin/admin_manages_participatory_processes_spec.rb

@@ -0,0 +1,119 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Admin manages participatory processes", type: :feature do
+  include_context "participatory process administration by admin"
+  it_behaves_like "manage processes examples"
+  it_behaves_like "manage processes announcements"
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+    @participatory_process_groups = create_list(:participatory_process_group, 3, organization: organization)
+    visit decidim_admin_participatory_processes.participatory_processes_path
+  end
+
+  context "creating a participatory process" do
+    before do
+      within ".secondary-nav__actions" do
+        page.find("a.button").click
+      end
+    end
+
+    it "creates a new participatory process" do
+      within ".new_participatory_process" do
+        fill_in_i18n(
+          :participatory_process_title,
+          "#participatory_process-title-tabs",
+          en: "My participatory process",
+          es: "Mi proceso participativo",
+          ca: "El meu procés participatiu"
+        )
+        fill_in_i18n(
+          :participatory_process_subtitle,
+          "#participatory_process-subtitle-tabs",
+          en: "Subtitle",
+          es: "Subtítulo",
+          ca: "Subtítol"
+        )
+        fill_in_i18n_editor(
+          :participatory_process_short_description,
+          "#participatory_process-short_description-tabs",
+          en: "Short description",
+          es: "Descripción corta",
+          ca: "Descripció curta"
+        )
+        fill_in_i18n_editor(
+          :participatory_process_description,
+          "#participatory_process-description-tabs",
+          en: "A longer description",
+          es: "Descripción más larga",
+          ca: "Descripció més llarga"
+        )
+
+        @group_name = @participatory_process_groups.first.name["en"]
+        select @group_name, from: :participatory_process_participatory_process_group_id
+
+        fill_in :participatory_process_slug, with: "slug"
+        fill_in :participatory_process_hashtag, with: "#hashtag"
+        attach_file :participatory_process_hero_image, image1_path
+        attach_file :participatory_process_banner_image, image2_path
+
+        find("*[type=submit]").click
+      end
+
+      within ".callout-wrapper" do
+        expect(page).to have_content("successfully")
+      end
+
+      within ".container" do
+        expect(current_path).to eq decidim_admin_participatory_processes.participatory_process_steps_path(Decidim::ParticipatoryProcess.last)
+        expect(page).to have_content("STEPS")
+        expect(page).to have_content("Introduction")
+      end
+    end
+  end
+
+  context "updating a participatory process" do
+    let!(:participatory_process3) { create(:participatory_process, organization: organization) }
+
+    before do
+      visit decidim_admin_participatory_processes.participatory_processes_path
+    end
+
+    it "update a participatory process without images does not delete them" do
+      click_link translated(participatory_process3.title)
+      click_submenu_link "Info"
+      click_button "Update"
+
+      within ".callout-wrapper" do
+        expect(page).to have_content("successfully")
+      end
+
+      expect(page).to have_css("img[src*='#{participatory_process3.hero_image.url}']")
+      expect(page).to have_css("img[src*='#{participatory_process3.banner_image.url}']")
+    end
+  end
+
+  context "deleting a participatory process" do
+    let!(:participatory_process2) { create(:participatory_process, organization: organization) }
+
+    before do
+      visit decidim_admin_participatory_processes.participatory_processes_path
+    end
+
+    it "deletes a participatory_process" do
+      click_link translated(participatory_process2.title)
+      click_link "Destroy"
+
+      within ".callout-wrapper" do
+        expect(page).to have_content("successfully")
+      end
+
+      within "table" do
+        expect(page).to have_no_content(translated(participatory_process2.title))
+      end
+    end
+  end
+end

data/{decidim-admin/spec/features → decidim-participatory_processes/spec/features/admin}/participatory_process_admin_manages_participatory_process_admins_spec.rb

@@ -11,7 +11,7 @@ describe "Participatory process admin manages participatory process admins", typ
     before do
       switch_to_host(organization.host)
       login_as user, scope: :user
-      visit decidim_admin.edit_participatory_process_path(participatory_process)
+      visit decidim_admin_participatory_processes.edit_participatory_process_path(participatory_process)
       click_link "Process users"
     end
 

data/{decidim-admin/spec/features → decidim-participatory_processes/spec/features/admin}/participatory_process_admin_manages_participatory_process_categories_spec.rb

@@ -8,7 +8,7 @@ describe "Participatory process admin manages participatory process categories",
   let!(:category) do
     create(
       :category,
-      participatory_process: participatory_process
+      participatory_space: participatory_process
     )
   end
 

data/{decidim-admin/spec/features → decidim-participatory_processes/spec/features/admin}/participatory_process_admin_manages_participatory_processes_spec.rb

@@ -11,7 +11,7 @@ describe "Participatory process admin manages participatory processes", type: :f
   before do
     switch_to_host(organization.host)
     login_as user, scope: :user
-    visit decidim_admin.participatory_processes_path
+    visit decidim_admin_participatory_processes.participatory_processes_path
   end
 
   it "cannot create a new participatory_process" do
@@ -23,7 +23,7 @@ describe "Participatory process admin manages participatory processes", type: :f
     let!(:process_user_role2) { create :participatory_process_user_role, user: user, participatory_process: participatory_process2 }
 
     before do
-      visit decidim_admin.participatory_processes_path
+      visit decidim_admin_participatory_processes.participatory_processes_path
     end
 
     it "cannot delete a participatory_process" do

data/{decidim-core → decidim-participatory_processes}/spec/features/participatory_process_groups_spec.rb

@@ -8,10 +8,12 @@ describe "Participatory Process Groups", type: :feature do
   let!(:participatory_process_group) do
     create(
       :participatory_process_group,
+      :with_participatory_processes,
       organization: organization,
       name: { en: "Name", ca: "Nom", es: "Nombre" }
     )
   end
+  let(:group_processes) { participatory_process_group.participatory_processes }
 
   before do
     switch_to_host(organization.host)
@@ -21,13 +23,13 @@ describe "Participatory Process Groups", type: :feature do
     let!(:other_group) { create(:participatory_process_group, organization: other_organization) }
 
     before do
-      visit decidim.participatory_processes_path
+      visit decidim_participatory_processes.participatory_processes_path
     end
 
-    it "lists all the groups" do
+    it "lists all the groups among the processes" do
       within "#processes-grid" do
         expect(page).to have_content(translated(participatory_process_group.name, locale: :en))
-        expect(page).to have_selector("article.card", count: 1)
+        expect(page).to have_selector("article.card", count: 3)
 
         expect(page).to have_no_content(translated(other_group.name, locale: :en))
       end
@@ -36,26 +38,23 @@ describe "Participatory Process Groups", type: :feature do
     it "links to the individual group page" do
       click_link(translated(participatory_process_group.name, locale: :en))
 
-      expect(current_path).to eq decidim.participatory_process_group_path(participatory_process_group)
+      expect(current_path).to eq decidim_participatory_processes.participatory_process_group_path(participatory_process_group)
     end
   end
 
   context "when the group does not exist" do
     it_behaves_like "a 404 page" do
-      let(:target_path) { decidim.participatory_process_group_path(99_999_999) }
+      let(:target_path) { decidim_participatory_processes.participatory_process_group_path(99_999_999) }
     end
   end
 
   describe "show" do
-    let!(:participatory_process_group) { create(:participatory_process_group, organization: organization) }
-    let!(:group_processes) { create_list(:participatory_process, 2, :published, organization: organization, participatory_process_group: participatory_process_group) }
-
     let!(:unpublished_group_processes) do
       create_list(:participatory_process, 2, :unpublished, organization: organization, participatory_process_group: participatory_process_group)
     end
 
     before do
-      visit decidim.participatory_process_group_path(participatory_process_group)
+      visit decidim_participatory_processes.participatory_process_group_path(participatory_process_group)
     end
 
     it "lists all the processes" do
@@ -74,7 +73,7 @@ describe "Participatory Process Groups", type: :feature do
     it "links to the individual process page" do
       click_link(translated(group_processes.first.title, locale: :en))
 
-      expect(current_path).to eq decidim.participatory_process_path(group_processes.first)
+      expect(current_path).to eq decidim_participatory_processes.participatory_process_path(group_processes.first)
     end
   end
 end

data/{decidim-core → decidim-participatory_processes}/spec/features/participatory_process_steps_spec.rb

@@ -21,7 +21,7 @@ describe "Participatory Process Steps", type: :feature do
     before do
       @steps = create_list(:participatory_process_step, 3, participatory_process: participatory_process)
       participatory_process.steps.first.update_attribute(:active, true)
-      visit decidim.participatory_process_participatory_process_steps_path(participatory_process)
+      visit decidim_participatory_processes.participatory_process_participatory_process_steps_path(participatory_process)
     end
 
     it "lists all the steps" do

data/{decidim-core → decidim-participatory_processes}/spec/features/participatory_processes_spec.rb

@@ -21,7 +21,7 @@ describe "Participatory Processes", type: :feature do
 
   context "when there are no processes" do
     before do
-      visit decidim.participatory_processes_path
+      visit decidim_participatory_processes.participatory_processes_path
     end
 
     it "shows a message about the lack of processes" do
@@ -31,7 +31,7 @@ describe "Participatory Processes", type: :feature do
 
   context "when the process does not exist" do
     it_behaves_like "a 404 page" do
-      let(:target_path) { decidim.participatory_process_path(99_999_999) }
+      let(:target_path) { decidim_participatory_processes.participatory_process_path(99_999_999) }
     end
   end
 
@@ -41,7 +41,7 @@ describe "Participatory Processes", type: :feature do
     let!(:unpublished_process) { create(:participatory_process, :unpublished, organization: organization) }
 
     before do
-      visit decidim.participatory_processes_path
+      visit decidim_participatory_processes.participatory_processes_path
     end
 
     it "lists all the highlighted processes" do
@@ -68,7 +68,49 @@ describe "Participatory Processes", type: :feature do
     it "links to the individual process page" do
       click_link(translated(participatory_process.title, locale: :en))
 
-      expect(current_path).to eq decidim.participatory_process_path(participatory_process)
+      expect(current_path).to eq decidim_participatory_processes.participatory_process_path(participatory_process)
+    end
+
+    context "filtering processes" do
+      let!(:past_process) { create :participatory_process, :past, organization: organization }
+      let!(:upcoming_process) { create :participatory_process, :upcoming, organization: organization }
+
+      it "list the active processes by default" do
+        expect(page).to have_no_content(translated(past_process.title, locale: :en))
+        expect(page).to have_no_content(translated(upcoming_process.title, locale: :en))
+      end
+
+      context "choosing 'past' processes" do
+        before do
+          within ".order-by__tabs" do
+            click_link "Past"
+          end
+        end
+
+        it "list the past processes" do
+          within "#processes-grid h2" do
+            expect(page).to have_content("1")
+          end
+
+          expect(page).to have_content(translated(past_process.title, locale: :en))
+        end
+      end
+
+      context "choosing 'upcoming' processes" do
+        before do
+          within ".order-by__tabs" do
+            click_link "Upcoming"
+          end
+        end
+
+        it "list the past processes" do
+          within "#processes-grid h2" do
+            expect(page).to have_content("1")
+          end
+
+          expect(page).to have_content(translated(upcoming_process.title, locale: :en))
+        end
+      end
     end
 
     context "with active steps" do
@@ -81,7 +123,7 @@ describe "Participatory Processes", type: :feature do
       end
 
       it "links to the active step" do
-        visit decidim.participatory_processes_path
+        visit decidim_participatory_processes.participatory_processes_path
 
         within find("#processes-grid .column", text: translated(participatory_process.title)) do
           within ".card__footer" do
@@ -94,14 +136,14 @@ describe "Participatory Processes", type: :feature do
 
   describe "when going to the participatory process page" do
     let!(:participatory_process) { base_process }
-    let!(:proposals_feature) { create(:feature, :published, participatory_process: participatory_process, manifest_name: :proposals) }
-    let!(:meetings_feature) { create(:feature, :unpublished, participatory_process: participatory_process, manifest_name: :meetings) }
+    let!(:proposals_feature) { create(:feature, :published, participatory_space: participatory_process, manifest_name: :proposals) }
+    let!(:meetings_feature) { create(:feature, :unpublished, participatory_space: participatory_process, manifest_name: :meetings) }
 
     before do
       create_list(:proposal, 3, feature: proposals_feature)
       allow(Decidim).to receive(:feature_manifests).and_return([proposals_feature.manifest, meetings_feature.manifest])
 
-      visit decidim.participatory_process_path(participatory_process)
+      visit decidim_participatory_processes.participatory_process_path(participatory_process)
     end
 
     it "shows the details of the given process" do

data/decidim-participatory_processes/spec/forms/category_form_spec.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "decidim/admin/test/forms/category_form_examples"
+
+module Decidim
+  module Admin
+    describe CategoryForm do
+      include_examples "category form" do
+        let(:participatory_space) do
+          create :participatory_process, organization: organization
+        end
+      end
+    end
+  end
+end

data/decidim-participatory_processes/spec/forms/participatory_process_form_spec.rb

@@ -0,0 +1,167 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module ParticipatoryProcesses
+    module Admin
+      describe ParticipatoryProcessForm do
+        let(:organization) { create :organization }
+        let(:title) do
+          {
+            en: "Title",
+            es: "Título",
+            ca: "Títol"
+          }
+        end
+        let(:subtitle) do
+          {
+            en: "Subtitle",
+            es: "Subtítulo",
+            ca: "Subtítol"
+          }
+        end
+        let(:description) do
+          {
+            en: "Description",
+            es: "Descripción",
+            ca: "Descripció"
+          }
+        end
+        let(:short_description) do
+          {
+            en: "Short description",
+            es: "Descripción corta",
+            ca: "Descripció curta"
+          }
+        end
+        let(:slug) { "slug" }
+        let(:attachment) { Decidim::Dev.test_file("city.jpeg", "image/jpeg") }
+        let(:show_statistics) { true }
+        let(:attributes) do
+          {
+            "participatory_process" => {
+              "title_en" => title[:en],
+              "title_es" => title[:es],
+              "title_ca" => title[:ca],
+              "subtitle_en" => subtitle[:en],
+              "subtitle_es" => subtitle[:es],
+              "subtitle_ca" => subtitle[:ca],
+              "description_en" => description[:en],
+              "description_es" => description[:es],
+              "description_ca" => description[:ca],
+              "short_description_en" => short_description[:en],
+              "short_description_es" => short_description[:es],
+              "short_description_ca" => short_description[:ca],
+              "hero_image" => attachment,
+              "banner_image" => attachment,
+              "slug" => slug,
+              "show_statistics" => show_statistics
+            }
+          }
+        end
+
+        subject { described_class.from_params(attributes).with_context(current_organization: organization) }
+
+        context "when everything is OK" do
+          it { is_expected.to be_valid }
+        end
+
+        context "when hero_image is too big" do
+          before do
+            allow(Decidim).to receive(:maximum_attachment_size).and_return(5.megabytes)
+            expect(subject.hero_image).to receive(:size).twice.and_return(6.megabytes)
+          end
+
+          it { is_expected.not_to be_valid }
+        end
+
+        context "when banner_image is too big" do
+          before do
+            allow(Decidim).to receive(:maximum_attachment_size).and_return(5.megabytes)
+            expect(subject.banner_image).to receive(:size).twice.and_return(6.megabytes)
+          end
+
+          it { is_expected.not_to be_valid }
+        end
+
+        context "when images are not the expected type" do
+          let(:attachment) { Decidim::Dev.test_file("Exampledocument.pdf", "application/pdf") }
+
+          it { is_expected.not_to be_valid }
+        end
+
+        context "when some language in title is missing" do
+          let(:title) do
+            {
+              en: "Title",
+              ca: "Títol"
+            }
+          end
+
+          it { is_expected.to be_invalid }
+        end
+
+        context "when some language in subtitle is missing" do
+          let(:subtitle) do
+            {
+              en: "Subtitle",
+              ca: "Subtítol"
+            }
+          end
+
+          it { is_expected.to be_invalid }
+        end
+
+        context "when some language in description is missing" do
+          let(:description) do
+            {
+              ca: "Descripció"
+            }
+          end
+
+          it { is_expected.to be_invalid }
+        end
+
+        context "when some language in short_description is missing" do
+          let(:short_description) do
+            {
+              en: "Short description"
+            }
+          end
+
+          it { is_expected.to be_invalid }
+        end
+
+        context "when slug is missing" do
+          let(:slug) { nil }
+
+          it { is_expected.to be_invalid }
+        end
+
+        context "when slug is not unique" do
+          context "in the same organization" do
+            before do
+              create(:participatory_process, slug: slug, organization: organization)
+            end
+
+            it "is not valid" do
+              expect(subject).not_to be_valid
+              expect(subject.errors[:slug]).not_to be_empty
+            end
+          end
+
+          context "in another organization" do
+            before do
+              create(:participatory_process, slug: slug)
+            end
+
+            it "is valid" do
+              expect(subject).to be_valid
+            end
+          end
+        end
+      end
+    end
+  end
+end