capybara 2.18.0 → 3.40.0

data/spec/rspec/views_spec.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 
-RSpec.describe "capybara/rspec", type: :view do
-  it "allows matchers to be used on strings" do
-    expect(%{<h1>Test header</h1>}).to have_css("h1", text: "Test header")
+RSpec.describe 'capybara/rspec', type: :view do
+  it 'allows matchers to be used on strings' do
+    html = %(<h1>Test header</h1>)
+    expect(html).to have_css('h1', text: 'Test header')
   end
 
   it "doesn't include RSpecMatcherProxies" do

data/spec/rspec_matchers_spec.rb

@@ -1,25 +1,37 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 
-RSpec.describe 'Capybara RSpec Matchers', :type => :feature do
-  context "after called on session" do
-    it "HaveSelector should allow getting a description of the matcher" do
+RSpec.describe 'Capybara RSpec Matchers', type: :feature do
+  context 'after called on session' do
+    it 'HaveSelector should allow getting a description of the matcher' do
       visit('/with_html')
       matcher = have_selector(:css, 'h2.head', minimum: 3)
       expect(page).to matcher
       expect { matcher.description }.not_to raise_error
     end
 
-    it "HaveText should allow getting a description" do
+    it 'HaveText should allow getting a description' do
       visit('/with_html')
-      matcher = have_text("Lorem")
+      matcher = have_text('Lorem')
       expect(page).to matcher
       expect { matcher.description }.not_to raise_error
     end
+
+    it 'should produce the same error for .to have_no_xxx and .not_to have_xxx' do
+      visit('/with_html')
+      not_to_msg = error_msg_for { expect(page).not_to have_selector(:css, '#referrer') }
+      have_no_msg = error_msg_for { expect(page).to have_no_selector(:css, '#referrer') }
+      expect(not_to_msg).to eq have_no_msg
+
+      not_to_msg = error_msg_for { expect(page).not_to have_text('This is a test') }
+      have_no_msg = error_msg_for { expect(page).to have_no_text('This is a test') }
+      expect(not_to_msg).to eq have_no_msg
+    end
   end
 
-  context "after called on element" do
-    it "HaveSelector should allow getting a description" do
+  context 'after called on element' do
+    it 'HaveSelector should allow getting a description' do
       visit('/with_html')
       el = find(:css, '#first')
       matcher = have_selector(:css, 'a#foo')
@@ -27,7 +39,7 @@ RSpec.describe 'Capybara RSpec Matchers', :type => :feature do
       expect { matcher.description }.not_to raise_error
     end
 
-    it "MatchSelector should allow getting a description" do
+    it 'MatchSelector should allow getting a description' do
       visit('/with_html')
       el = find(:css, '#first')
       matcher = match_selector(:css, '#first')
@@ -35,12 +47,41 @@ RSpec.describe 'Capybara RSpec Matchers', :type => :feature do
       expect { matcher.description }.not_to raise_error
     end
 
-    it "HaveText should allow getting a description" do
+    it 'HaveText should allow getting a description' do
       visit('/with_html')
       el = find(:css, '#first')
-      matcher = have_text("Lorem")
+      matcher = have_text('Lorem')
       expect(el).to matcher
       expect { matcher.description }.not_to raise_error
     end
   end
-end
+
+  context 'with a filter block' do
+    it 'applies the filter' do
+      visit('/with_html')
+      expect(page).to have_selector(:css, 'input#test_field')
+
+      expect(page).to have_selector(:css, 'input', count: 1) { |input| input.value == 'monkey' }
+      expect(page).to have_selector(:css, 'input', count: 1) do |input|
+        input.value == 'monkey'
+      end
+      expect(page).to have_no_selector(:css, 'input#test_field') { |input| input.value == 'not a monkey' }
+      expect(page).to have_no_selector(:css, 'input#test_field') do |input|
+        input.value == 'not a monkey'
+      end
+
+      expect(page).not_to have_selector(:css, 'input#test_field') { |input| input.value == 'not a monkey' }
+      expect(page).not_to have_selector(:css, 'input#test_field') do |input|
+        input.value == 'not a monkey'
+      end
+      expect(page).not_to have_no_selector(:css, 'input', count: 1) { |input| input.value == 'monkey' }
+      expect(page).not_to have_no_selector(:css, 'input#test_field', count: 1) do |input|
+        input.value == 'monkey'
+      end
+    end
+  end
+
+  def error_msg_for(&block)
+    expect(&block).to(raise_error { |e| return e.message })
+  end
+end

data/spec/rspec_spec.rb

@@ -1,129 +1,149 @@
 # frozen_string_literal: true
-require 'spec_helper'
 
-RSpec.describe 'capybara/rspec', :type => :feature do
-  it "should include Capybara in rspec" do
-    visit('/foo')
-    expect(page.body).to include('Another World')
-  end
+# rubocop:disable RSpec/MultipleDescribes
 
-  it "should include RSpec matcher proxies" do
-    expect(self.class.ancestors).to include Capybara::RSpecMatcherProxies
-  end
+require 'spec_helper'
 
-  context "resetting session" do
-    it "sets a cookie in one example..." do
-      visit('/set_cookie')
-      expect(page.body).to include('Cookie set to test_cookie')
+RSpec.describe 'capybara/rspec' do
+  context 'Feature', type: :feature do
+    it 'should include Capybara in rspec' do
+      visit('/foo')
+      expect(page.body).to include('Another World')
     end
 
-    it "...then it is not available in the next" do
-      visit('/get_cookie')
-      expect(page.body).not_to include('test_cookie')
+    it 'should include RSpec matcher proxies' do
+      expect(self.class.ancestors).to include Capybara::RSpecMatcherProxies
     end
-  end
 
-  context "setting the current driver" do
-    it "sets the current driver in one example..." do
-      Capybara.current_driver = :selenium
-    end
+    context 'resetting session', order: :defined do
+      it 'sets a cookie in one example...' do
+        visit('/set_cookie')
+        expect(page.body).to include('Cookie set to test_cookie')
+      end
 
-    it "...then it has returned to the default in the next example" do
-      expect(Capybara.current_driver).to eq(:rack_test)
+      it '...then it is not available in the next' do
+        visit('/get_cookie')
+        expect(page.body).not_to include('test_cookie')
+      end
     end
-  end
-
-  it "switches to the javascript driver when giving it as metadata", js: true do
-    expect(Capybara.current_driver).to eq(Capybara.javascript_driver)
-  end
 
-  it "switches to the given driver when giving it as metadata", :driver => :culerity do
-    expect(Capybara.current_driver).to eq(:culerity)
-  end
+    context 'setting the current driver', order: :defined do
+      it 'sets the current driver in one example...' do
+        Capybara.current_driver = :selenium
+      end
 
-  context "#all" do
-    it "allows access to the Capybara finder" do
-      visit('/with_html')
-      expect(all(:css, 'h2.head').size).to eq(5)
+      it '...then it has returned to the default in the next example' do
+        expect(Capybara.current_driver).to eq(:rack_test)
+      end
     end
 
-    it "allows access to the RSpec matcher" do
-      skip "RSpec < 3 doesn't have an `all` matcher" if rspec2?
-
-      visit('/with_html')
-      expect(["test1", "test2"]).to all(be_a(String))
+    it 'switches to the javascript driver when giving it as metadata', :js do
+      expect(Capybara.current_driver).to eq(Capybara.javascript_driver)
     end
-  end
 
-  context "#within" do
-    it "allows access to the Capybara scoper" do
-      visit('/with_html')
-      expect do
-        within(:css, "#does_not_exist") { click_link "Go to simple" }
-      end.to raise_error(Capybara::ElementNotFound)
+    it 'switches to the given driver when giving it as metadata', driver: :culerity do
+      expect(Capybara.current_driver).to eq(:culerity)
     end
 
-    it "allows access to the RSpec matcher" do
-      skip "RSpec version doesn't have a 'within' matcher" unless ::RSpec::Matchers.instance_methods.include?(:within)
-      visit('/with_html')
-      # This reads terribly, but must call #within
-      expect(find(:css, 'span.number').text.to_i).to within(1).of(41)
+    describe '#all' do
+      it 'allows access to the Capybara finder' do
+        visit('/with_html')
+        found = all(:css, 'h2') { |element| element[:class] == 'head' }
+        expect(found.size).to eq(5)
+      end
+
+      it 'allows access to the RSpec matcher' do
+        visit('/with_html')
+        strings = %w[test1 test2]
+        expect(strings).to all(be_a(String))
+      end
     end
-  end
-end
 
-RSpec.describe 'capybara/rspec', :type => :other do
-  context "when RSpec::Matchers is included after Capybara::DSL" do
-    before do
-      class DSL_MatchersTest
-        include Capybara::DSL
-        include RSpec::Matchers
+    describe '#within' do
+      it 'allows access to the Capybara scoper' do
+        visit('/with_html')
+        expect do
+          within(:css, '#does_not_exist') { click_link 'Go to simple' }
+        end.to raise_error(Capybara::ElementNotFound)
       end
 
-      @test_class_instance = DSL_MatchersTest.new
+      it 'allows access to the RSpec matcher' do
+        visit('/with_html')
+        # This reads terribly, but must call #within
+        expect(find(:css, 'span.number').text.to_i).to within(1).of(41)
+      end
     end
+  end
 
-    context "#all" do
-      it "allows access to the Capybara finder" do
-        @test_class_instance.visit('/with_html')
-        expect(@test_class_instance.all(:css, 'h2.head').size).to eq(5)
+  context 'Type: Other', type: :other do
+    context 'when RSpec::Matchers is included after Capybara::DSL' do
+      let(:test_class_instance) do
+        Class.new do
+          include Capybara::DSL
+          include RSpec::Matchers
+        end.new
       end
 
-      it "allows access to the RSpec matcher" do
-        skip "RSpec < 3 doesn't have an `all` matcher" if rspec2?
-
-        @test_class_instance.visit('/with_html')
-        expect(["test1", "test2"]).to @test_class_instance.all(be_a(String))
+      describe '#all' do
+        it 'allows access to the Capybara finder' do
+          test_class_instance.visit('/with_html')
+          expect(test_class_instance.all(:css, 'h2.head').size).to eq(5)
+        end
+
+        it 'allows access to the RSpec matcher' do
+          test_class_instance.visit('/with_html')
+          strings = %w[test1 test2]
+          expect(strings).to test_class_instance.all(be_a(String))
+        end
       end
-    end
 
-    context "#within" do
-      it "allows access to the Capybara scoper" do
-        @test_class_instance.visit('/with_html')
-        expect do
-          @test_class_instance.within(:css, "#does_not_exist") { @test_class_instance.click_link "Go to simple" }
-        end.to raise_error(Capybara::ElementNotFound)
+      describe '#within' do
+        it 'allows access to the Capybara scoper' do
+          test_class_instance.visit('/with_html')
+          expect do
+            test_class_instance.within(:css, '#does_not_exist') { test_class_instance.click_link 'Go to simple' }
+          end.to raise_error(Capybara::ElementNotFound)
+        end
+
+        it 'allows access to the RSpec matcher' do
+          test_class_instance.visit('/with_html')
+          # This reads terribly, but must call #within
+          expect(test_class_instance.find(:css, 'span.number').text.to_i).to test_class_instance.within(1).of(41)
+        end
       end
 
-      it "allows access to the RSpec matcher" do
-        skip "RSpec version doesn't have a 'within' matcher" unless ::RSpec::Matchers.instance_methods.include?(:within)
-        @test_class_instance.visit('/with_html')
-        # This reads terribly, but must call #within
-        expect(@test_class_instance.find(:css, 'span.number').text.to_i).to @test_class_instance.within(1).of(41)
+      context 'when `match_when_negated` is not defined in a matcher' do
+        before do
+          RSpec::Matchers.define :only_match_matcher do |expected|
+            match do |actual|
+              !(actual ^ expected)
+            end
+          end
+        end
+
+        it 'can be called with `not_to`' do
+          # This test is for a bug in jruby where `super` isn't defined correctly - https://github.com/jruby/jruby/issues/4678
+          # Reported in https://github.com/teamcapybara/capybara/issues/2115
+          test_class_instance.instance_eval do
+            expect do
+              expect(true).not_to only_match_matcher(false) # rubocop:disable RSpec/ExpectActual
+            end.not_to raise_error
+          end
+        end
       end
     end
-  end
-end
 
-RSpec.describe 'capybara/rspec', :type => :other do
-  it "should not include Capybara" do
-    expect { visit('/') }.to raise_error(NoMethodError)
+    it 'should not include Capybara' do
+      expect { visit('/') }.to raise_error(NoMethodError)
+    end
   end
 end
 
-feature "Feature DSL" do
-  scenario "is pulled in" do
+feature 'Feature DSL' do
+  scenario 'is pulled in' do
     visit('/foo')
     expect(page.body).to include('Another World')
   end
 end
+
+# rubocop:enable RSpec/MultipleDescribes

data/spec/sauce_spec_chrome.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'selenium-webdriver'
+
+require 'sauce_whisk'
+# require 'shared_selenium_session'
+# require 'shared_selenium_node'
+# require 'rspec/shared_spec_matchers'
+
+Capybara.register_driver :sauce_chrome do |app|
+  options = {
+    selenium_version: '4.8.0',
+    platform: 'macOS 10.12',
+    browser_name: 'chrome',
+    version: '65.0',
+    name: 'Capybara test',
+    build: ENV.fetch('TRAVIS_REPO_SLUG', "Ruby-RSpec-Selenium: Local-#{Time.now.to_i}"),
+    username: ENV.fetch('SAUCE_USERNAME', nil),
+    access_key: ENV.fetch('SAUCE_ACCESS_KEY', nil)
+  }
+
+  options.delete(:browser_name)
+
+  capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(options)
+  url = 'https://ondemand.saucelabs.com:443/wd/hub'
+
+  Capybara::Selenium::Driver.new(app,
+                                 browser: :remote, url: url,
+                                 capabilities: capabilities,
+                                 options: Selenium::WebDriver::Chrome::Options.new(args: ['']))
+end
+
+CHROME_REMOTE_DRIVER = :sauce_chrome
+
+module TestSessions
+  Chrome = Capybara::Session.new(CHROME_REMOTE_DRIVER, TestApp)
+end
+
+skipped_tests = %i[response_headers status_code trigger download]
+
+Capybara::SpecHelper.run_specs TestSessions::Chrome, CHROME_REMOTE_DRIVER.to_s, capybara_skip: skipped_tests do |example|
+end