capybara 2.18.0 → 3.40.0

data/lib/capybara/spec/session/has_current_path_spec.rb

@@ -1,108 +1,105 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#has_current_path?' do
   before do
     @session.visit('/with_js')
   end
 
-  it "should be true if the page has the given current path" do
+  it 'should be true if the page has the given current path' do
     expect(@session).to have_current_path('/with_js')
   end
 
-  it "should allow regexp matches" do
+  it 'should allow regexp matches' do
     expect(@session).to have_current_path(/w[a-z]{3}_js/)
     expect(@session).not_to have_current_path(/monkey/)
   end
 
-  it "should not raise an error when non-http" do
+  it 'should not raise an error when non-http' do
     @session.reset_session!
-    expect(@session.has_current_path?(/monkey/)).to eq false
-    expect(@session.has_current_path?("/with_js")).to eq false
+    expect(@session.has_current_path?(/monkey/)).to be false
+    expect(@session.has_current_path?('/with_js')).to be false
   end
 
-  it "should handle non-escaped query options" do
-    @session.click_link("Non-escaped query options")
-    expect(@session).to have_current_path("/with_html?options[]=things")
+  it 'should handle non-escaped query options' do
+    @session.click_link('Non-escaped query options')
+    expect(@session).to have_current_path('/with_html?options[]=things')
   end
 
-  it "should handle escaped query options" do
-    @session.click_link("Escaped query options")
-    expect(@session).to have_current_path("/with_html?options%5B%5D=things")
+  it 'should handle escaped query options' do
+    @session.click_link('Escaped query options')
+    expect(@session).to have_current_path('/with_html?options%5B%5D=things')
   end
 
-  it "should wait for current_path", requires: [:js] do
-    @session.click_link("Change page")
-    expect(@session).to have_current_path("/with_html", wait: 3)
+  it 'should wait for current_path', requires: [:js] do
+    @session.click_link('Change page')
+    expect(@session).to have_current_path('/with_html', wait: 3)
   end
 
-  it "should be false if the page has not the given current_path" do
+  it 'should be false if the page has not the given current_path' do
     expect(@session).not_to have_current_path('/with_html')
   end
 
-  it "should check query options" do
+  it 'should check query options' do
     @session.visit('/with_js?test=test')
     expect(@session).to have_current_path('/with_js?test=test')
   end
 
-  it "should compare the full url if url: true is used" do
+  it 'should compare the full url if url: true is used' do
     expect(@session).to have_current_path(%r{\Ahttp://[^/]*/with_js\Z}, url: true)
     domain_port = if @session.respond_to?(:server) && @session.server
       "#{@session.server.host}:#{@session.server.port}"
     else
-      "www.example.com"
+      'www.example.com'
     end
     expect(@session).to have_current_path("http://#{domain_port}/with_js", url: true)
   end
 
-  it "should not compare the full url if url: true is not passed" do
+  it 'should not compare the full url if url: true is not passed' do
     expect(@session).to have_current_path(%r{^/with_js\Z})
     expect(@session).to have_current_path('/with_js')
   end
 
-  it "should not compare the full url if url: false is passed" do
+  it 'should not compare the full url if url: false is passed' do
     expect(@session).to have_current_path(%r{^/with_js\Z}, url: false)
     expect(@session).to have_current_path('/with_js', url: false)
   end
 
-  it "should default to full url if value is a url" do
+  it 'should default to full url if value is a url' do
     url = @session.current_url
-    expect(url).to match /with_js$/
+    expect(url).to match(/with_js$/)
     expect(@session).to have_current_path(url)
-    expect(@session).not_to have_current_path("http://www.not_example.com/with_js")
+    expect(@session).not_to have_current_path('http://www.not_example.com/with_js')
   end
 
-  it "should ignore the query" do
+  it 'should ignore the query' do
     @session.visit('/with_js?test=test')
     expect(@session).to have_current_path('/with_js?test=test')
-    expect(@session).to have_current_path('/with_js', only_path: true)
     expect(@session).to have_current_path('/with_js', ignore_query: true)
-    uri = ::Addressable::URI.parse(@session.current_url)
+    uri = Addressable::URI.parse(@session.current_url)
     uri.query = nil
     expect(@session).to have_current_path(uri.to_s, ignore_query: true)
   end
 
-  it "should not allow url and only_path at the same time" do
-    expect {
-      expect(@session).to have_current_path('/with_js', url: true, only_path: true)
-    }.to raise_error ArgumentError
-  end
-
-  it "should not raise an exception if the current_url is nil" do
-    allow_any_instance_of(Capybara::Session).to receive(:current_url) { nil }
+  it 'should not raise an exception if the current_url is nil' do
+    allow(@session).to receive(:current_url).and_return(nil)
+    allow(@session.page).to receive(:current_url).and_return(nil) if @session.respond_to? :page
 
-    # Without only_path option
-    expect {
+    # Without ignore_query option
+    expect do
       expect(@session).to have_current_path(nil)
-    }.not_to raise_exception
-
-    # With only_path option
-    expect {
-      expect(@session).to have_current_path(nil, only_path: true)
-    }.not_to raise_exception
+    end.not_to raise_exception
 
     # With ignore_query option
-    expect {
+    expect do
       expect(@session).to have_current_path(nil, ignore_query: true)
-    }.not_to raise_exception
+    end.not_to raise_exception
+  end
+
+  it 'should accept a filter block that receives Addressable::URL' do
+    @session.visit('/with_js?a=3&b=defgh')
+    expect(@session).to have_current_path('/with_js', ignore_query: true) { |url|
+      url.query_values.keys == %w[a b]
+    }
   end
 end
 
@@ -111,42 +108,44 @@ Capybara::SpecHelper.spec '#has_no_current_path?' do
     @session.visit('/with_js')
   end
 
-  it "should be false if the page has the given current_path" do
+  it 'should be false if the page has the given current_path' do
     expect(@session).not_to have_no_current_path('/with_js')
   end
 
-  it "should allow regexp matches" do
+  it 'should allow regexp matches' do
     expect(@session).not_to have_no_current_path(/w[a-z]{3}_js/)
     expect(@session).to have_no_current_path(/monkey/)
   end
 
-  it "should wait for current_path to disappear", requires: [:js] do
+  it 'should wait for current_path to disappear', requires: [:js] do
     Capybara.using_wait_time(3) do
-      @session.click_link("Change page")
+      @session.click_link('Change page')
       expect(@session).to have_no_current_path('/with_js')
     end
   end
 
-  it "should be true if the page has not the given current_path" do
+  it 'should be true if the page has not the given current_path' do
     expect(@session).to have_no_current_path('/with_html')
   end
 
-  it "should not raise an exception if the current_url is nil" do
-    allow_any_instance_of(Capybara::Session).to receive(:current_url) { nil }
+  it 'should not raise an exception if the current_url is nil' do
+    allow(@session).to receive(:current_url).and_return(nil)
+    allow(@session.page).to receive(:current_url).and_return(nil) if @session.respond_to? :page
 
-    # Without only_path option
-    expect {
+    # Without ignore_query option
+    expect do
       expect(@session).not_to have_current_path('/with_js')
-    }. not_to raise_exception
-
-    # With only_path option
-    expect {
-      expect(@session).not_to have_current_path('/with_js', only_path: true)
-    }. not_to raise_exception
+    end.not_to raise_exception
 
     # With ignore_query option
-    expect {
+    expect do
       expect(@session).not_to have_current_path('/with_js', ignore_query: true)
-    }. not_to raise_exception
+    end.not_to raise_exception
+  end
+
+  it 'should accept a filter block that receives Addressable::URL' do
+    expect(@session).to have_no_current_path('/with_js', ignore_query: true) { |url|
+      !url.query.nil?
+    }
   end
 end

data/lib/capybara/spec/session/has_element_spec.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+Capybara::SpecHelper.spec '#has_element?' do
+  before do
+    @session.visit('/with_html')
+  end
+
+  it 'should be true if the given element is on the page' do
+    expect(@session).to have_element('a', id: 'foo')
+    expect(@session).to have_element('a', text: 'A link', href: '/with_simple_html')
+    expect(@session).to have_element('a', text: :'A link', href: :'/with_simple_html')
+    expect(@session).to have_element('a', text: 'A link', href: %r{/with_simple_html})
+    expect(@session).to have_element('a', text: 'labore', target: '_self')
+  end
+
+  it 'should be false if the given element is not on the page' do
+    expect(@session).not_to have_element('a', text: 'monkey')
+    expect(@session).not_to have_element('a', text: 'A link', href: '/nonexistent-href')
+    expect(@session).not_to have_element('a', text: 'A link', href: /nonexistent/)
+    expect(@session).not_to have_element('a', text: 'labore', target: '_blank')
+  end
+
+  it 'should notify if an invalid locator is specified' do
+    allow(Capybara::Helpers).to receive(:warn).and_return(nil)
+    @session.has_element?(@session)
+    expect(Capybara::Helpers).to have_received(:warn).with(/Called from: .+/)
+  end
+end
+
+Capybara::SpecHelper.spec '#has_no_element?' do
+  before do
+    @session.visit('/with_html')
+  end
+
+  it 'should be false if the given element is on the page' do
+    expect(@session).not_to have_no_element('a', id: 'foo')
+    expect(@session).not_to have_no_element('a', text: 'A link', href: '/with_simple_html')
+    expect(@session).not_to have_no_element('a', text: 'labore', target: '_self')
+  end
+
+  it 'should be true if the given element is not on the page' do
+    expect(@session).to have_no_element('a', text: 'monkey')
+    expect(@session).to have_no_element('a', text: 'A link', href: '/nonexistent-href')
+    expect(@session).to have_no_element('a', text: 'A link', href: %r{/nonexistent-href})
+    expect(@session).to have_no_element('a', text: 'labore', target: '_blank')
+  end
+end