capybara 2.18.0 → 3.40.0

data/lib/capybara/spec/session/has_text_spec.rb

@@ -1,44 +1,59 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#has_text?' do
-  it "should be true if the given text is on the page at least once" do
+  it 'should be true if the given text is on the page at least once' do
     @session.visit('/with_html')
     expect(@session).to have_text('est')
     expect(@session).to have_text('Lorem')
     expect(@session).to have_text('Redirect')
-    expect(@session).to have_text(:'Redirect')
+    expect(@session).to have_text(:Redirect)
   end
 
-  it "should be true if scoped to an element which has the text" do
+  it 'should be true if scoped to an element which has the text' do
     @session.visit('/with_html')
     @session.within("//a[@title='awesome title']") do
       expect(@session).to have_text('labore')
     end
   end
 
-  it "should be false if scoped to an element which does not have the text" do
+  it 'should be false if scoped to an element which does not have the text' do
     @session.visit('/with_html')
     @session.within("//a[@title='awesome title']") do
       expect(@session).not_to have_text('monkey')
     end
   end
 
-  it "should ignore tags" do
+  it 'should ignore tags' do
     @session.visit('/with_html')
     expect(@session).not_to have_text('exercitation <a href="/foo" id="foo">ullamco</a> laboris')
     expect(@session).to have_text('exercitation ullamco laboris')
   end
 
-  it "should ignore extra whitespace and newlines" do
+  it 'should search correctly normalized text' do
     @session.visit('/with_html')
-    expect(@session).to have_text('text with whitespace')
+    expect(@session).to have_text('text with   whitespace')
   end
 
-  it "should ignore whitespace and newlines in the search string" do
+  it 'should search whitespace collapsed text' do
     @session.visit('/with_html')
-    expect(@session).to have_text("text     with \n\n whitespace")
+    expect(@session).to have_text('text with whitespace', normalize_ws: true)
+  end
+
+  context 'with enabled default collapsing whitespace' do
+    before { Capybara.default_normalize_ws = true }
+
+    it 'should search unnormalized text' do
+      @session.visit('/with_html')
+      expect(@session).to have_text('text with   whitespace', normalize_ws: false)
+    end
+
+    it 'should search whitespace collapsed text' do
+      @session.visit('/with_html')
+      expect(@session).to have_text('text with whitespace')
+    end
   end
 
-  it "should be false if the given text is not on the page" do
+  it 'should be false if the given text is not on the page' do
     @session.visit('/with_html')
     expect(@session).not_to have_text('xxxxyzzz')
     expect(@session).not_to have_text('monkey')
@@ -51,12 +66,12 @@ Capybara::SpecHelper.spec '#has_text?' do
 
   it 'should handle double quotes in the text' do
     @session.visit('/with-quotes')
-    expect(@session).to have_text(%q{"No," he said})
+    expect(@session).to have_text('"No," he said')
   end
 
   it 'should handle mixed single and double quotes in the text' do
     @session.visit('/with-quotes')
-    expect(@session).to have_text(%q{"you can't do that."})
+    expect(@session).to have_text(%q("you can't do that."))
   end
 
   it 'should be false if text is in the title tag in the head' do
@@ -70,23 +85,23 @@ Capybara::SpecHelper.spec '#has_text?' do
     expect(@session).not_to have_text('aVar')
   end
 
-  it "should be false if the given text is on the page but not visible" do
+  it 'should be false if the given text is on the page but not visible' do
     @session.visit('/with_html')
     expect(@session).not_to have_text('Inside element with hidden ancestor')
   end
 
-  it "should be true if :all given and text is invisible." do
+  it 'should be true if :all given and text is invisible.' do
     @session.visit('/with_html')
     expect(@session).to have_text(:all, 'Some of this text is hidden!')
   end
 
-  it "should be true if `Capybara.ignore_hidden_elements = false` and text is invisible." do
+  it 'should be true if `Capybara.ignore_hidden_elements = false` and text is invisible.' do
     Capybara.ignore_hidden_elements = false
     @session.visit('/with_html')
     expect(@session).to have_text('Some of this text is hidden!')
   end
 
-  it "should be true if the text in the page matches given regexp" do
+  it 'should be true if the text in the page matches given regexp' do
     @session.visit('/with_html')
     expect(@session).to have_text(/Lorem/)
   end
@@ -96,50 +111,72 @@ Capybara::SpecHelper.spec '#has_text?' do
     expect(@session).not_to have_text(/xxxxyzzz/)
   end
 
-  context "with exact: true option" do
-    it "should be true if text matches exactly" do
+  context 'with object implementing to_s and to_hash' do
+    it 'should work if the object is passed alone' do
+      with_to_hash = Class.new do
+        def to_s; '42' end
+        def to_hash; { value: 'Other hash' } end
+      end.new
       @session.visit('/with_html')
-      expect(@session.find(:id, "h2one")).to have_text("Header Class Test One", exact: true)
+      expect(@session).to have_text(with_to_hash)
+    end
+
+    it 'should work if passed with empty options' do
+      with_to_hash = Class.new do
+        def to_s; '42' end
+        def to_hash; { value: 'Other hash' } end
+      end.new
+      @session.visit('/with_html')
+      expect(@session).to have_text(:visible, with_to_hash, **{})
+    end
+  end
+
+  context 'with exact: true option' do
+    it 'should be true if text matches exactly' do
+      @session.visit('/with_html')
+      expect(@session.find(:id, 'h2one')).to have_text('Header Class Test One', exact: true)
     end
 
     it "should be false if text doesn't match exactly" do
       @session.visit('/with_html')
-      expect(@session.find(:id, "h2one")).not_to have_text("Header Class Test On", exact: true)
+      expect(@session.find(:id, 'h2one')).not_to have_text('Header Class Test On', exact: true)
     end
   end
 
-  it "should escape any characters that would have special meaning in a regexp" do
+  it 'should escape any characters that would have special meaning in a regexp' do
     @session.visit('/with_html')
     expect(@session).not_to have_text('.orem')
   end
 
-  it "should accept non-string parameters" do
+  it 'should accept non-string parameters' do
     @session.visit('/with_html')
     expect(@session).to have_text(42)
   end
 
-  it "should be true when passed nil" do
+  it 'should be true when passed nil, and warn about it' do
     # nil is converted to '' when to_s is invoked
     @session.visit('/with_html')
-    expect(@session).to have_text(nil)
+    expect do
+      expect(@session).to have_text(nil)
+    end.to output(/Checking for expected text of nil is confusing/).to_stderr
   end
 
-  it "should wait for text to appear", requires: [:js] do
+  it 'should wait for text to appear', requires: [:js] do
     Capybara.using_wait_time(3) do
       @session.visit('/with_js')
       @session.click_link('Click me')
-      expect(@session).to have_text("Has been clicked")
+      expect(@session).to have_text('Has been clicked')
     end
   end
 
-  context "with between" do
-    it "should be true if the text occurs within the range given" do
+  context 'with between' do
+    it 'should be true if the text occurs within the range given' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', between: 1..3)
       expect(@session).to have_text(/count/, between: 2..2)
     end
 
-    it "should be false if the text occurs more or fewer times than range" do
+    it 'should be false if the text occurs more or fewer times than range' do
       @session.visit('/with_count')
       expect(@session).not_to have_text('count', between: 0..1)
       expect(@session).not_to have_text('count', between: 3..10)
@@ -147,76 +184,82 @@ Capybara::SpecHelper.spec '#has_text?' do
     end
   end
 
-  context "with count" do
-    it "should be true if the text occurs the given number of times" do
+  context 'with count' do
+    it 'should be true if the text occurs the given number of times' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', count: 2)
+      expect(@session).to have_text('count').exactly(2).times
     end
 
-    it "should be false if the text occurs a different number of times than the given" do
+    it 'should be false if the text occurs a different number of times than the given' do
       @session.visit('/with_count')
       expect(@session).not_to have_text('count', count: 0)
       expect(@session).not_to have_text('count', count: 1)
+      expect(@session).not_to have_text('count').once
       expect(@session).not_to have_text(/count/, count: 3)
     end
 
-    it "should coerce count to an integer" do
+    it 'should coerce count to an integer' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', count: '2')
       expect(@session).not_to have_text('count', count: '3')
     end
   end
 
-  context "with maximum" do
-    it "should be true when text occurs same or fewer times than given" do
+  context 'with maximum' do
+    it 'should be true when text occurs same or fewer times than given' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', maximum: 2)
+      expect(@session).to have_text('count').at_most(2).times
       expect(@session).to have_text(/count/, maximum: 3)
     end
 
-    it "should be false when text occurs more times than given" do
+    it 'should be false when text occurs more times than given' do
       @session.visit('/with_count')
       expect(@session).not_to have_text('count', maximum: 1)
+      expect(@session).not_to have_text('count').at_most(1).times
       expect(@session).not_to have_text('count', maximum: 0)
     end
 
-    it "should coerce maximum to an integer" do
+    it 'should coerce maximum to an integer' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', maximum: '2')
       expect(@session).not_to have_text('count', maximum: '1')
     end
   end
 
-  context "with minimum" do
-    it "should be true when text occurs same or more times than given" do
+  context 'with minimum' do
+    it 'should be true when text occurs same or more times than given' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', minimum: 2)
+      expect(@session).to have_text('count').at_least(2).times
       expect(@session).to have_text(/count/, minimum: 0)
     end
 
-    it "should be false when text occurs fewer times than given" do
+    it 'should be false when text occurs fewer times than given' do
       @session.visit('/with_count')
       expect(@session).not_to have_text('count', minimum: 3)
+      expect(@session).not_to have_text('count').at_least(3).times
     end
 
-    it "should coerce minimum to an integer" do
+    it 'should coerce minimum to an integer' do
       @session.visit('/with_count')
       expect(@session).to have_text('count', minimum: '2')
       expect(@session).not_to have_text('count', minimum: '3')
     end
   end
 
-  context "with wait", requires: [:js] do
-    it "should find element if it appears before given wait duration" do
+  context 'with wait', requires: [:js] do
+    it 'should find element if it appears before given wait duration' do
       Capybara.using_wait_time(0.1) do
         @session.visit('/with_js')
         @session.click_link('Click me')
-        expect(@session).to have_text('Has been clicked', wait: 0.9)
+        expect(@session).to have_text('Has been clicked', wait: 3)
       end
     end
   end
 
-  it "should raise an error if an invalid option is passed" do
+  it 'should raise an error if an invalid option is passed' do
     @session.visit('/with_html')
     expect do
       expect(@session).to have_text('Lorem', invalid: true)
@@ -225,34 +268,34 @@ Capybara::SpecHelper.spec '#has_text?' do
 end
 
 Capybara::SpecHelper.spec '#has_no_text?' do
-  it "should be false if the given text is on the page at least once" do
+  it 'should be false if the given text is on the page at least once' do
     @session.visit('/with_html')
     expect(@session).not_to have_no_text('est')
     expect(@session).not_to have_no_text('Lorem')
     expect(@session).not_to have_no_text('Redirect')
   end
 
-  it "should be false if scoped to an element which has the text" do
+  it 'should be false if scoped to an element which has the text' do
     @session.visit('/with_html')
     @session.within("//a[@title='awesome title']") do
       expect(@session).not_to have_no_text('labore')
     end
   end
 
-  it "should be true if scoped to an element which does not have the text" do
+  it 'should be true if scoped to an element which does not have the text' do
     @session.visit('/with_html')
     @session.within("//a[@title='awesome title']") do
       expect(@session).to have_no_text('monkey')
     end
   end
 
-  it "should ignore tags" do
+  it 'should ignore tags' do
     @session.visit('/with_html')
     expect(@session).to have_no_text('exercitation <a href="/foo" id="foo">ullamco</a> laboris')
     expect(@session).not_to have_no_text('exercitation ullamco laboris')
   end
 
-  it "should be true if the given text is not on the page" do
+  it 'should be true if the given text is not on the page' do
     @session.visit('/with_html')
     expect(@session).to have_no_text('xxxxyzzz')
     expect(@session).to have_no_text('monkey')
@@ -265,12 +308,12 @@ Capybara::SpecHelper.spec '#has_no_text?' do
 
   it 'should handle double quotes in the text' do
     @session.visit('/with-quotes')
-    expect(@session).not_to have_no_text(%q{"No," he said})
+    expect(@session).not_to have_no_text('"No," he said')
   end
 
   it 'should handle mixed single and double quotes in the text' do
     @session.visit('/with-quotes')
-    expect(@session).not_to have_no_text(%q{"you can't do that."})
+    expect(@session).not_to have_no_text(%q("you can't do that."))
   end
 
   it 'should be true if text is in the title tag in the head' do
@@ -284,17 +327,17 @@ Capybara::SpecHelper.spec '#has_no_text?' do
     expect(@session).to have_no_text('aVar')
   end
 
-  it "should be true if the given text is on the page but not visible" do
+  it 'should be true if the given text is on the page but not visible' do
     @session.visit('/with_html')
     expect(@session).to have_no_text('Inside element with hidden ancestor')
   end
 
-  it "should be false if :all given and text is invisible." do
+  it 'should be false if :all given and text is invisible.' do
     @session.visit('/with_html')
     expect(@session).not_to have_no_text(:all, 'Some of this text is hidden!')
   end
 
-  it "should be false if `Capybara.ignore_hidden_elements = false` and text is invisible." do
+  it 'should be false if `Capybara.ignore_hidden_elements = false` and text is invisible.' do
     Capybara.ignore_hidden_elements = false
     @session.visit('/with_html')
     expect(@session).not_to have_no_text('Some of this text is hidden!')
@@ -305,27 +348,28 @@ Capybara::SpecHelper.spec '#has_no_text?' do
     expect(@session).to have_no_text(/xxxxyzzz/)
   end
 
-  it "should be false if the text in the page  matches given regexp" do
+  it 'should be false if the text in the page matches given regexp' do
     @session.visit('/with_html')
     expect(@session).not_to have_no_text(/Lorem/)
   end
 
-  it "should escape any characters that would have special meaning in a regexp" do
+  it 'should escape any characters that would have special meaning in a regexp' do
     @session.visit('/with_html')
     expect(@session).to have_no_text('.orem')
   end
 
-  it "should wait for text to disappear", requires: [:js] do
+  it 'should wait for text to disappear', requires: [:js] do
+    Capybara.default_max_wait_time = 2
     @session.visit('/with_js')
     @session.click_link('Click me')
-    expect(@session).to have_no_text("I changed it")
+    expect(@session).to have_no_text('I changed it')
   end
 
-  context "with wait", requires: [:js] do
-    it "should not find element if it appears after given wait duration" do
+  context 'with wait', requires: [:js] do
+    it 'should not find element if it appears after given wait duration' do
       @session.visit('/with_js')
       @session.click_link('Click me')
-      expect(@session).to have_no_text('Has been clicked', wait: 0.1)
+      expect(@session).to have_no_text('Has been clicked', wait: 0.05)
     end
   end
 end

data/lib/capybara/spec/session/has_title_spec.rb

@@ -1,38 +1,43 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#has_title?' do
   before do
     @session.visit('/with_js')
   end
 
-  it "should be true if the page has the given title" do
+  it 'should be true if the page has the given title' do
     expect(@session).to have_title('with_js')
+    expect(@session.has_title?('with_js')).to be true
   end
 
-  it "should allow regexp matches" do
+  it 'should allow regexp matches' do
     expect(@session).to have_title(/w[a-z]{3}_js/)
     expect(@session).not_to have_title(/monkey/)
   end
 
-  it "should wait for title", requires: [:js] do
-    @session.click_link("Change title")
-    expect(@session).to have_title("changed title")
+  it 'should wait for title', requires: [:js] do
+    @session.click_link('Change title')
+    expect(@session).to have_title('changed title')
   end
 
-  it "should be false if the page has not the given title" do
+  it 'should be false if the page has not the given title' do
     expect(@session).not_to have_title('monkey')
+    expect(@session.has_title?('monkey')).to be false
   end
 
-  it "should default to exact: false matching" do
+  it 'should default to exact: false matching' do
     expect(@session).to have_title('with_js', exact: false)
     expect(@session).to have_title('with_', exact: false)
   end
 
-  it "should match exactly if exact: true option passed" do
+  it 'should match exactly if exact: true option passed' do
     expect(@session).to have_title('with_js', exact: true)
     expect(@session).not_to have_title('with_', exact: true)
+    expect(@session.has_title?('with_js', exact: true)).to be true
+    expect(@session.has_title?('with_', exact: true)).to be false
   end
 
-  it "should match partial if exact: false option passed" do
+  it 'should match partial if exact: false option passed' do
     expect(@session).to have_title('with_js', exact: false)
     expect(@session).to have_title('with_', exact: false)
   end
@@ -43,23 +48,24 @@ Capybara::SpecHelper.spec '#has_no_title?' do
     @session.visit('/with_js')
   end
 
-  it "should be false if the page has the given title" do
+  it 'should be false if the page has the given title' do
     expect(@session).not_to have_no_title('with_js')
   end
 
-  it "should allow regexp matches" do
+  it 'should allow regexp matches' do
     expect(@session).not_to have_no_title(/w[a-z]{3}_js/)
     expect(@session).to have_no_title(/monkey/)
   end
 
-  it "should wait for title to disappear", requires: [:js] do
+  it 'should wait for title to disappear', requires: [:js] do
     Capybara.using_wait_time(5) do
-      @session.click_link("Change title") # triggers title change after 400ms
+      @session.click_link('Change title') # triggers title change after 400ms
       expect(@session).to have_no_title('with_js')
     end
   end
 
-  it "should be true if the page has not the given title" do
+  it 'should be true if the page has not the given title' do
     expect(@session).to have_no_title('monkey')
+    expect(@session.has_no_title?('monkey')).to be true
   end
 end