capybara 2.18.0 → 3.40.0

data/lib/capybara/spec/session/find_field_spec.rb

@@ -1,32 +1,35 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#find_field' do
   before do
     @session.visit('/form')
   end
 
-  it "should find any field" do
+  it 'should find any field' do
+    Capybara.test_id = 'data-test-id'
     expect(@session.find_field('Dog').value).to eq('dog')
-    expect(@session.find_field('form_description').text).to eq('Descriptive text goes here')
+    expect(@session.find_field('form_description').value).to eq('Descriptive text goes here')
     expect(@session.find_field('Region')[:name]).to eq('form[region]')
-    expect(@session.find_field('With Asterisk*')).to be
+    expect(@session.find_field('With Asterisk*')).to be_truthy
+    expect(@session.find_field('my_test_id')).to be_truthy
   end
 
-  context "aria_label attribute with Capybara.enable_aria_label" do
-    it "should find when true" do
+  context 'aria_label attribute with Capybara.enable_aria_label' do
+    it 'should find when true' do
       Capybara.enable_aria_label = true
       expect(@session.find_field('Unlabelled Input')[:name]).to eq('form[which_form]')
       # expect(@session.find_field('Emergency Number')[:id]).to eq('html5_tel')
     end
 
-    it "should not find when false" do
+    it 'should not find when false' do
       Capybara.enable_aria_label = false
       expect { @session.find_field('Unlabelled Input') }.to raise_error(Capybara::ElementNotFound)
       # expect { @session.find_field('Emergency Number') }.to raise_error(Capybara::ElementNotFound)
     end
   end
 
-  it "casts to string" do
-    expect(@session.find_field(:'Dog').value).to eq('dog')
+  it 'casts to string' do
+    expect(@session.find_field(:Dog).value).to eq('dog')
   end
 
   it "should raise error if the field doesn't exist" do
@@ -35,69 +38,62 @@ Capybara::SpecHelper.spec '#find_field' do
     end.to raise_error(Capybara::ElementNotFound)
   end
 
-  it "should warn if filter option is invalid" do
-    expect_any_instance_of(Kernel).to receive(:warn).
-      with('Invalid value nil passed to filter disabled - defaulting to false')
-    @session.find_field('Dog', disabled: nil)
-  end
-
-  it "should be aliased as 'field_labeled' for webrat compatibility" do
-    expect(@session.field_labeled('Dog').value).to eq('dog')
+  it 'should raise error if filter option is invalid' do
     expect do
-      @session.field_labeled('Does not exist')
-    end.to raise_error(Capybara::ElementNotFound)
+      @session.find_field('Dog', disabled: nil)
+    end.to raise_error ArgumentError, 'Invalid value nil passed to NodeFilter disabled'
   end
 
-  context "with :exact option" do
-    it "should accept partial matches when false" do
-      expect(@session.find_field("Explanation", exact:  false)[:name]).to eq("form[name_explanation]")
+  context 'with :exact option' do
+    it 'should accept partial matches when false' do
+      expect(@session.find_field('Explanation', exact: false)[:name]).to eq('form[name_explanation]')
     end
 
-    it "should not accept partial matches when true" do
+    it 'should not accept partial matches when true' do
       expect do
-        @session.find_field("Explanation", exact:  true)
+        @session.find_field('Explanation', exact: true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
 
-  context "with :disabled option" do
-    it "should find disabled fields when true" do
-      expect(@session.find_field("Disabled Checkbox", disabled: true)[:name]).to eq("form[disabled_checkbox]")
-      expect(@session.find_field("form_disabled_fieldset_child", disabled: true)[:name]).to eq("form[disabled_fieldset_child]")
-      expect(@session.find_field("form_disabled_fieldset_descendant", disabled: true)[:name]).to eq("form[disabled_fieldset_descendant]")
+  context 'with :disabled option' do
+    it 'should find disabled fields when true' do
+      expect(@session.find_field('Disabled Checkbox', disabled: true)[:name]).to eq('form[disabled_checkbox]')
+      expect(@session.find_field('form_disabled_fieldset_child', disabled: true)[:name]).to eq('form[disabled_fieldset_child]')
+      expect(@session.find_field('form_disabled_fieldset_descendant', disabled: true)[:name]).to eq('form[disabled_fieldset_descendant]')
     end
 
-    it "should not find disabled fields when false" do
+    it 'should not find disabled fields when false' do
       expect do
-        @session.find_field("Disabled Checkbox", disabled: false)
+        @session.find_field('Disabled Checkbox', disabled: false)
       end.to raise_error(Capybara::ElementNotFound)
     end
 
-    it "should not find disabled fields by default" do
+    it 'should not find disabled fields by default' do
       expect do
-        @session.find_field("Disabled Checkbox")
+        @session.find_field('Disabled Checkbox')
       end.to raise_error(Capybara::ElementNotFound)
     end
 
-    it "should find disabled fields when :all" do
-      expect(@session.find_field("Disabled Checkbox", disabled: :all)[:name]).to eq("form[disabled_checkbox]")
+    it 'should find disabled fields when :all' do
+      expect(@session.find_field('Disabled Checkbox', disabled: :all)[:name]).to eq('form[disabled_checkbox]')
     end
 
-    it "should find enabled fields when :all" do
+    it 'should find enabled fields when :all' do
       expect(@session.find_field('Dog', disabled: :all).value).to eq('dog')
     end
   end
 
   context 'with :readonly option' do
-    it "should find readonly fields when true" do
+    it 'should find readonly fields when true' do
       expect(@session.find_field('form[readonly_test]', readonly: true)[:id]).to eq 'readonly'
     end
 
-    it "should not find readonly fields when false" do
+    it 'should not find readonly fields when false' do
       expect(@session.find_field('form[readonly_test]', readonly: false)[:id]).to eq 'not_readonly'
     end
 
-    it "should ignore readonly by default" do
+    it 'should ignore readonly by default' do
       expect do
         @session.find_field('form[readonly_test]')
       end.to raise_error(Capybara::Ambiguous, /found 2 elements/)
@@ -106,12 +102,12 @@ Capybara::SpecHelper.spec '#find_field' do
 
   context 'with no locator' do
     it 'should use options to find the field' do
-      expect(@session.find_field(with: 'dog')['id']).to eq "form_pets_dog"
+      expect(@session.find_field(type: 'checkbox', with: 'dog')['id']).to eq 'form_pets_dog'
     end
   end
 
-  it "should accept an optional filter block" do
+  it 'should accept an optional filter block' do
     # this would be better done with the :with option but this is just a test
-    expect(@session.find_field('form[pets][]'){ |node| node.value == 'dog' }[:id]).to eq "form_pets_dog"
+    expect(@session.find_field('form[pets][]') { |node| node.value == 'dog' }[:id]).to eq 'form_pets_dog'
   end
 end

data/lib/capybara/spec/session/find_link_spec.rb

@@ -1,28 +1,29 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#find_link' do
   before do
     @session.visit('/with_html')
   end
 
-  it "should find any link" do
-    expect(@session.find_link('foo').text).to eq("ullamco")
-    expect(@session.find_link('labore')[:href]).to match %r(/with_simple_html$)
+  it 'should find any link' do
+    expect(@session.find_link('foo').text).to eq('ullamco')
+    expect(@session.find_link('labore')[:href]).to match %r{/with_simple_html$}
   end
 
-  context "aria_label attribute with Capybara.enable_aria_label" do
-    it "should find when true" do
+  context 'aria_label attribute with Capybara.enable_aria_label' do
+    it 'should find when true' do
       Capybara.enable_aria_label = true
-      expect(@session.find_link('Go to simple')[:href]).to match %r(/with_simple_html$)
+      expect(@session.find_link('Go to simple')[:href]).to match %r{/with_simple_html$}
     end
 
-    it "should not find when false" do
+    it 'should not find when false' do
       Capybara.enable_aria_label = false
       expect { @session.find_link('Go to simple') }.to raise_error(Capybara::ElementNotFound)
     end
   end
 
-  it "casts to string" do
-    expect(@session.find_link(:'foo').text).to eq("ullamco")
+  it 'casts to string' do
+    expect(@session.find_link(:foo).text).to eq('ullamco')
   end
 
   it "should raise error if the field doesn't exist" do
@@ -31,21 +32,49 @@ Capybara::SpecHelper.spec '#find_link' do
     end.to raise_error(Capybara::ElementNotFound)
   end
 
-  context "with :exact option" do
-    it "should accept partial matches when false" do
-      expect(@session.find_link('abo', exact:  false).text).to eq("labore")
+  context 'with :exact option' do
+    it 'should accept partial matches when false' do
+      expect(@session.find_link('abo', exact: false).text).to eq('labore')
     end
 
-    it "should not accept partial matches when true" do
+    it 'should not accept partial matches when true' do
       expect do
-        @session.find_link('abo', exact:  true)
+        @session.find_link('abo', exact: true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
 
-  context "without locator" do
-    it "should use options" do
-      expect(@session.find_link(href: '#anchor').text).to eq "Normal Anchor"
+  context 'without locator' do
+    it 'should use options' do
+      expect(@session.find_link(href: '#anchor').text).to eq 'Normal Anchor'
+    end
+  end
+
+  context 'download filter' do
+    it 'finds a download link' do
+      expect(@session.find_link('Download Me', download: true).text).to eq 'Download Me'
+    end
+
+    it "doesn't find a download link if download is false" do
+      expect { @session.find_link('Download Me', download: false) }.to raise_error Capybara::ElementNotFound
+    end
+
+    it 'finds a renaming download link' do
+      expect(@session.find_link(download: 'other.csv').text).to eq 'Download Other'
+    end
+
+    it 'raises if passed an invalid value' do
+      expect { @session.find_link(download: 37) }.to raise_error ArgumentError
+    end
+  end
+
+  context 'with :target option' do
+    it 'should accept partial matches when false' do
+      expect(@session.find_link(target: '_self').text).to eq('labore')
+    end
+
+    it 'should not accept partial matches when true' do
+      expect { @session.find_link(target: '_blank') }.to raise_error Capybara::ElementNotFound
     end
   end
 end