capybara 2.18.0 → 3.40.0

data/lib/capybara/spec/session/has_selector_spec.rb

@@ -1,102 +1,146 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#has_selector?' do
   before do
     @session.visit('/with_html')
   end
 
-  it "should be true if the given selector is on the page" do
-    expect(@session).to have_selector(:xpath, "//p")
-    expect(@session).to have_selector(:css, "p a#foo")
+  it 'should be true if the given selector is on the page' do
+    expect(@session).to have_selector(:xpath, '//p')
+    expect(@session).to have_selector(:css, 'p a#foo')
     expect(@session).to have_selector("//p[contains(.,'est')]")
   end
 
-  it "should be false if the given selector is not on the page" do
-    expect(@session).not_to have_selector(:xpath, "//abbr")
-    expect(@session).not_to have_selector(:css, "p a#doesnotexist")
+  it 'should be false if the given selector is not on the page' do
+    expect(@session).not_to have_selector(:xpath, '//abbr')
+    expect(@session).not_to have_selector(:css, 'p a#doesnotexist')
     expect(@session).not_to have_selector("//p[contains(.,'thisstringisnotonpage')]")
   end
 
-  it "should use default selector" do
+  it 'should use default selector' do
     Capybara.default_selector = :css
-    expect(@session).not_to have_selector("p a#doesnotexist")
-    expect(@session).to have_selector("p a#foo")
+    expect(@session).not_to have_selector('p a#doesnotexist')
+    expect(@session).to have_selector('p a#foo')
   end
 
-  it "should respect scopes" do
+  it 'should respect scopes' do
     @session.within "//p[@id='first']" do
       expect(@session).to have_selector(".//a[@id='foo']")
       expect(@session).not_to have_selector(".//a[@id='red']")
     end
   end
 
-  it "should accept a filter block" do
-    expect(@session).to have_selector(:css, "a", count: 1) { |el| el[:id] == "foo" }
+  it 'should accept a filter block' do
+    expect(@session).to have_selector(:css, 'a', count: 1) { |el| el[:id] == 'foo' }
   end
 
-  context "with count" do
-    it "should be true if the content is on the page the given number of times" do
-      expect(@session).to have_selector("//p", count: 3)
+  context 'with count' do
+    it 'should be true if the content is on the page the given number of times' do
+      expect(@session).to have_selector('//p', count: 3)
       expect(@session).to have_selector("//p//a[@id='foo']", count: 1)
       expect(@session).to have_selector("//p[contains(.,'est')]", count: 1)
     end
 
-    it "should be false if the content is on the page the given number of times" do
-      expect(@session).not_to have_selector("//p", count: 6)
+    it 'should be false if the content is on the page the given number of times' do
+      expect(@session).not_to have_selector('//p', count: 6)
       expect(@session).not_to have_selector("//p//a[@id='foo']", count: 2)
       expect(@session).not_to have_selector("//p[contains(.,'est')]", count: 5)
     end
 
     it "should be false if the content isn't on the page at all" do
-      expect(@session).not_to have_selector("//abbr", count: 2)
+      expect(@session).not_to have_selector('//abbr', count: 2)
       expect(@session).not_to have_selector("//p//a[@id='doesnotexist']", count: 1)
     end
   end
 
-  context "with text" do
-    it "should discard all matches where the given string is not contained" do
-      expect(@session).to have_selector("//p//a", text: "Redirect", count: 1)
-      expect(@session).not_to have_selector("//p", text: "Doesnotexist")
+  context 'with text' do
+    it 'should discard all matches where the given string is not contained' do
+      expect(@session).to have_selector('//p//a', text: 'Redirect', count: 1)
+      expect(@session).to have_selector(:css, 'p a', text: 'Redirect', count: 1)
+      expect(@session).not_to have_selector('//p', text: 'Doesnotexist')
     end
 
-    it "should respect visibility setting" do
-      expect(@session).to have_selector(:id, "hidden-text", text: "Some of this text is hidden!", visible: false)
-      expect(@session).not_to have_selector(:id, "hidden-text", text: "Some of this text is hidden!", visible: true)
+    it 'should respect visibility setting' do
+      expect(@session).to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: :all)
+      expect(@session).not_to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: :visible)
       Capybara.ignore_hidden_elements = false
-      expect(@session).to have_selector(:id, "hidden-text", text: "Some of this text is hidden!", visible: false)
+      expect(@session).to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: :all)
       Capybara.visible_text_only = true
-      expect(@session).not_to have_selector(:id, "hidden-text", text: "Some of this text is hidden!", visible: true)
+      expect(@session).not_to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: :visible)
+    end
+
+    it 'should discard all matches where the given regexp is not matched' do
+      expect(@session).to have_selector('//p//a', text: /re[dab]i/i, count: 1)
+      expect(@session).not_to have_selector('//p//a', text: /Red$/)
     end
 
-    it "should discard all matches where the given regexp is not matched" do
-      expect(@session).to have_selector("//p//a", text: /re[dab]i/i, count: 1)
-      expect(@session).not_to have_selector("//p//a", text: /Red$/)
+    it 'should raise when extra parameters passed' do
+      expect do
+        expect(@session).to have_selector(:css, 'p a#foo', 'extra')
+      end.to raise_error ArgumentError, /extra/
     end
 
-    it "should warn when extra parameters passed" do
-      expect_any_instance_of(Kernel).to receive(:warn).with(/extra/)
-      expect(@session).to have_selector(:css, "p a#foo", 'extra')
+    context 'with whitespace normalization' do
+      context 'Capybara.default_normalize_ws = false' do
+        it 'should support normalize_ws option' do
+          Capybara.default_normalize_ws = false
+          expect(@session).not_to have_selector(:id, 'second', text: 'text with whitespace')
+          expect(@session).to have_selector(:id, 'second', text: 'text with whitespace', normalize_ws: true)
+        end
+      end
+
+      context 'Capybara.default_normalize_ws = true' do
+        it 'should support normalize_ws option' do
+          Capybara.default_normalize_ws = true
+          expect(@session).to have_selector(:id, 'second', text: 'text with whitespace')
+          expect(@session).not_to have_selector(:id, 'second', text: 'text with whitespace', normalize_ws: false)
+        end
+      end
     end
   end
 
-  context "with exact_text" do
-    context "string" do
-      it "should only match elements that match exactly" do
-        expect(@session).to have_selector(:id, "h2one", exact_text: "Header Class Test One")
-        expect(@session).to have_no_selector(:id, "h2one", exact_text: "Header Class Test")
+  context 'with exact_text' do
+    context 'string' do
+      it 'should only match elements that match exactly' do
+        expect(@session).to have_selector(:id, 'h2one', exact_text: 'Header Class Test One')
+        expect(@session).to have_no_selector(:id, 'h2one', exact_text: 'Header Class Test')
       end
     end
 
-    context "boolean" do
-      it "should only match elements that match exactly when true" do
-        expect(@session).to have_selector(:id, "h2one", text: "Header Class Test One", exact_text: true)
-        expect(@session).to have_no_selector(:id, "h2one", text: "Header Class Test", exact_text: true)
+    context 'boolean' do
+      it 'should only match elements that match exactly when true' do
+        expect(@session).to have_selector(:id, 'h2one', text: 'Header Class Test One', exact_text: true)
+        expect(@session).to have_no_selector(:id, 'h2one', text: 'Header Class Test', exact_text: true)
+      end
+
+      it 'should match substrings when false' do
+        expect(@session).to have_selector(:id, 'h2one', text: 'Header Class Test One', exact_text: false)
+        expect(@session).to have_selector(:id, 'h2one', text: 'Header Class Test', exact_text: false)
       end
 
-      it "should match substrings when false" do
-        expect(@session).to have_selector(:id, "h2one", text: "Header Class Test One", exact_text: false)
-        expect(@session).to have_selector(:id, "h2one", text: "Header Class Test", exact_text: false)
+      it 'should warn if text option is a regexp that it is ignoring exact_text' do
+        allow(Capybara::Helpers).to receive(:warn)
+        expect(@session).to have_selector(:id, 'h2one', text: /Class Test/, exact_text: true)
+        expect(Capybara::Helpers).to have_received(:warn).with(/'exact_text' option is not supported/)
       end
     end
+
+    context 'regexp' do
+      it 'should only match when it fully matches' do
+        expect(@session).to have_selector(:id, 'h2one', exact_text: /Header Class Test One/)
+        expect(@session).to have_no_selector(:id, 'h2one', exact_text: /Header Class Test/)
+        expect(@session).to have_no_selector(:id, 'h2one', exact_text: /Class Test One/)
+        expect(@session).to have_no_selector(:id, 'h2one', exact_text: /Class Test/)
+      end
+    end
+  end
+
+  context 'datalist' do
+    it 'should match options' do
+      @session.visit('/form')
+      expect(@session).to have_selector(:datalist_input, with_options: %w[Jaguar Audi Mercedes])
+      expect(@session).not_to have_selector(:datalist_input, with_options: %w[Ford Chevy])
+    end
   end
 end
 
@@ -105,64 +149,69 @@ Capybara::SpecHelper.spec '#has_no_selector?' do
     @session.visit('/with_html')
   end
 
-  it "should be false if the given selector is on the page" do
-    expect(@session).not_to have_no_selector(:xpath, "//p")
-    expect(@session).not_to have_no_selector(:css, "p a#foo")
+  it 'should be false if the given selector is on the page' do
+    expect(@session).not_to have_no_selector(:xpath, '//p')
+    expect(@session).not_to have_no_selector(:css, 'p a#foo')
     expect(@session).not_to have_no_selector("//p[contains(.,'est')]")
   end
 
-  it "should be true if the given selector is not on the page" do
-    expect(@session).to have_no_selector(:xpath, "//abbr")
-    expect(@session).to have_no_selector(:css, "p a#doesnotexist")
+  it 'should be true if the given selector is not on the page' do
+    expect(@session).to have_no_selector(:xpath, '//abbr')
+    expect(@session).to have_no_selector(:css, 'p a#doesnotexist')
     expect(@session).to have_no_selector("//p[contains(.,'thisstringisnotonpage')]")
   end
 
-  it "should use default selector" do
+  it 'should use default selector' do
     Capybara.default_selector = :css
-    expect(@session).to have_no_selector("p a#doesnotexist")
-    expect(@session).not_to have_no_selector("p a#foo")
+    expect(@session).to have_no_selector('p a#doesnotexist')
+    expect(@session).not_to have_no_selector('p a#foo')
   end
 
-  it "should respect scopes" do
+  it 'should respect scopes' do
     @session.within "//p[@id='first']" do
       expect(@session).not_to have_no_selector(".//a[@id='foo']")
       expect(@session).to have_no_selector(".//a[@id='red']")
     end
   end
 
-  it "should accept a filter block" do
-    skip "RSpec < 3 doesn't pass the block along to the matcher for the Builtin::Has matcher" if rspec2?
-    expect(@session).to have_no_selector(:css, "a#foo") { |el| el[:id] != "foo" }
+  it 'should accept a filter block' do
+    expect(@session).to have_no_selector(:css, 'a#foo') { |el| el[:id] != 'foo' }
   end
 
-  context "with count" do
-    it "should be false if the content is on the page the given number of times" do
-      expect(@session).not_to have_no_selector("//p", count: 3)
+  context 'with count' do
+    it 'should be false if the content is on the page the given number of times' do
+      expect(@session).not_to have_no_selector('//p', count: 3)
       expect(@session).not_to have_no_selector("//p//a[@id='foo']", count: 1)
       expect(@session).not_to have_no_selector("//p[contains(.,'est')]", count: 1)
     end
 
-    it "should be true if the content is on the page the wrong number of times" do
-      expect(@session).to have_no_selector("//p", count: 6)
+    it 'should be true if the content is on the page the wrong number of times' do
+      expect(@session).to have_no_selector('//p', count: 6)
       expect(@session).to have_no_selector("//p//a[@id='foo']", count: 2)
       expect(@session).to have_no_selector("//p[contains(.,'est')]", count: 5)
     end
 
     it "should be true if the content isn't on the page at all" do
-      expect(@session).to have_no_selector("//abbr", count: 2)
+      expect(@session).to have_no_selector('//abbr', count: 2)
       expect(@session).to have_no_selector("//p//a[@id='doesnotexist']", count: 1)
     end
   end
 
-  context "with text" do
-    it "should discard all matches where the given string is contained" do
-      expect(@session).not_to have_no_selector("//p//a", text: "Redirect", count: 1)
-      expect(@session).to have_no_selector("//p", text: "Doesnotexist")
+  context 'with text' do
+    it 'should discard all matches where the given string is contained' do
+      expect(@session).not_to have_no_selector('//p//a', text: 'Redirect', count: 1)
+      expect(@session).to have_no_selector('//p', text: 'Doesnotexist')
+    end
+
+    it 'should discard all matches where the given regexp is matched' do
+      expect(@session).not_to have_no_selector('//p//a', text: /re[dab]i/i, count: 1)
+      expect(@session).to have_no_selector('//p//a', text: /Red$/)
     end
 
-    it "should discard all matches where the given regexp is matched" do
-      expect(@session).not_to have_no_selector("//p//a", text: /re[dab]i/i, count: 1)
-      expect(@session).to have_no_selector("//p//a", text: /Red$/)
+    it 'should error when matching element exists' do
+      expect do
+        expect(@session).to have_no_selector('//h2', text: 'Header Class Test Five')
+      end.to raise_error RSpec::Expectations::ExpectationNotMetError
     end
   end
 end

data/lib/capybara/spec/session/has_sibling_spec.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+Capybara::SpecHelper.spec '#have_sibling' do
+  before do
+    @session.visit('/with_html')
+  end
+
+  it 'should assert a prior sibling element using the given locator' do
+    el = @session.find(:css, '#mid_sibling')
+    expect(el).to have_sibling(:css, '#pre_sibling')
+  end
+
+  it 'should assert a following sibling element using the given locator' do
+    el = @session.find(:css, '#mid_sibling')
+    expect(el).to have_sibling(:css, '#post_sibling')
+  end
+
+  it 'should not raise an error if there are multiple matches' do
+    el = @session.find(:css, '#mid_sibling')
+    expect(el).to have_sibling(:css, 'div')
+  end
+
+  it 'should allow counts to be specified' do
+    el = @session.find(:css, '#mid_sibling')
+
+    expect(el).to have_sibling(:css, 'div').exactly(2).times
+    expect do
+      expect(el).to have_sibling(:css, 'div').once
+    end.to raise_error(RSpec::Expectations::ExpectationNotMetError)
+  end
+end
+
+Capybara::SpecHelper.spec '#have_no_sibling' do
+  before do
+    @session.visit('/with_html')
+  end
+
+  it 'should assert no matching sibling' do
+    el = @session.find(:css, '#mid_sibling')
+    expect(el).to have_no_sibling(:css, '#not_a_sibling')
+    expect(el).not_to have_sibling(:css, '#not_a_sibling')
+  end
+
+  it 'should raise if there are matching siblings' do
+    el = @session.find(:css, '#mid_sibling')
+    expect do
+      expect(el).to have_no_sibling(:css, '#pre_sibling')
+    end.to raise_error(RSpec::Expectations::ExpectationNotMetError)
+  end
+end

data/lib/capybara/spec/session/has_table_spec.rb

@@ -1,18 +1,136 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#has_table?' do
   before do
     @session.visit('/tables')
   end
 
-  it "should be true if the table is on the page" do
+  it 'should be true if the table is on the page' do
     expect(@session).to have_table('Villain')
     expect(@session).to have_table('villain_table')
-    expect(@session).to have_table(:'villain_table')
+    expect(@session).to have_table(:villain_table)
+  end
+
+  it 'should accept rows with column header hashes' do
+    expect(@session).to have_table('Horizontal Headers', with_rows:
+      [
+        { 'First Name' => 'Vern', 'Last Name' => 'Konopelski', 'City' => 'Everette' },
+        { 'First Name' => 'Palmer', 'Last Name' => 'Sawayn', 'City' => 'West Trinidad' }
+      ])
+  end
+
+  it 'should accept rows with partial column header hashes' do
+    expect(@session).to have_table('Horizontal Headers', with_rows:
+      [
+        { 'First Name' => 'Thomas' },
+        { 'Last Name' => 'Sawayn', 'City' => 'West Trinidad' }
+      ])
+
+    expect(@session).not_to have_table('Horizontal Headers', with_rows:
+      [
+        { 'Unmatched Header' => 'Thomas' }
+      ])
+  end
+
+  it 'should accept rows with array of cell values' do
+    expect(@session).to have_table('Horizontal Headers', with_rows:
+      [
+        %w[Thomas Walpole Oceanside],
+        ['Ratke', 'Lawrence', 'East Sorayashire']
+      ])
+  end
+
+  it 'should consider order of cells in each row' do
+    expect(@session).not_to have_table('Horizontal Headers', with_rows:
+      [
+        %w[Thomas Walpole Oceanside],
+        ['Lawrence', 'Ratke', 'East Sorayashire']
+      ])
   end
 
-  it "should be false if the table is not on the page" do
+  it 'should accept all rows with array of cell values' do
+    expect(@session).to have_table('Horizontal Headers', rows:
+      [
+        %w[Thomas Walpole Oceanside],
+        %w[Danilo Wilkinson Johnsonville],
+        %w[Vern Konopelski Everette],
+        ['Ratke', 'Lawrence', 'East Sorayashire'],
+        ['Palmer', 'Sawayn', 'West Trinidad']
+      ])
+  end
+
+  it 'should match with vertical headers' do
+    expect(@session).to have_table('Vertical Headers', with_cols:
+      [
+        { 'First Name' => 'Thomas' },
+        { 'First Name' => 'Danilo', 'Last Name' => 'Wilkinson', 'City' => 'Johnsonville' },
+        { 'Last Name' => 'Sawayn', 'City' => 'West Trinidad' }
+      ])
+  end
+
+  it 'should match col with array of cell values' do
+    expect(@session).to have_table('Vertical Headers', with_cols:
+      [
+        %w[Vern Konopelski Everette]
+      ])
+  end
+
+  it 'should match cols with array of cell values' do
+    expect(@session).to have_table('Vertical Headers', with_cols:
+      [
+        %w[Danilo Wilkinson Johnsonville],
+        %w[Vern Konopelski Everette]
+      ])
+  end
+
+  it 'should match all cols with array of cell values' do
+    expect(@session).to have_table('Vertical Headers', cols:
+      [
+        %w[Thomas Walpole Oceanside],
+        %w[Danilo Wilkinson Johnsonville],
+        %w[Vern Konopelski Everette],
+        ['Ratke', 'Lawrence', 'East Sorayashire'],
+        ['Palmer', 'Sawayn', 'West Trinidad']
+      ])
+  end
+
+  it "should not match if the order of cell values doesn't match" do
+    expect(@session).not_to have_table('Vertical Headers', with_cols:
+      [
+        %w[Vern Everette Konopelski]
+      ])
+  end
+
+  it "should not match with vertical headers if the columns don't match" do
+    expect(@session).not_to have_table('Vertical Headers', with_cols:
+      [
+        { 'First Name' => 'Thomas' },
+        { 'First Name' => 'Danilo', 'Last Name' => 'Walpole', 'City' => 'Johnsonville' },
+        { 'Last Name' => 'Sawayn', 'City' => 'West Trinidad' }
+      ])
+
+    expect(@session).not_to have_table('Vertical Headers', with_cols:
+      [
+        { 'Unmatched Header' => 'Thomas' }
+      ])
+  end
+
+  it 'should be false if the table is not on the page' do
     expect(@session).not_to have_table('Monkey')
   end
+
+  it 'should find row by header and cell values' do
+    expect(@session.find(:table, 'Horizontal Headers')).to have_selector(:table_row, 'First Name' => 'Thomas', 'Last Name' => 'Walpole')
+    expect(@session.find(:table, 'Horizontal Headers')).to have_selector(:table_row, 'Last Name' => 'Walpole')
+    expect(@session.find(:table, 'Horizontal Headers')).not_to have_selector(:table_row, 'First Name' => 'Walpole')
+    expect(@session.find(:table, 'Horizontal Headers')).not_to have_selector(:table_row, 'Unmatched Header' => 'Thomas')
+  end
+
+  it 'should find row by cell values' do
+    expect(@session.find(:table, 'Horizontal Headers')).to have_selector(:table_row, %w[Thomas Walpole Oceanside])
+    expect(@session.find(:table, 'Horizontal Headers')).not_to have_selector(:table_row, %w[Walpole Thomas])
+    expect(@session.find(:table, 'Horizontal Headers')).not_to have_selector(:table_row, %w[Other])
+  end
 end
 
 Capybara::SpecHelper.spec '#has_no_table?' do
@@ -20,12 +138,72 @@ Capybara::SpecHelper.spec '#has_no_table?' do
     @session.visit('/tables')
   end
 
-  it "should be false if the table is on the page" do
+  it 'should be false if the table is on the page' do
     expect(@session).not_to have_no_table('Villain')
     expect(@session).not_to have_no_table('villain_table')
   end
 
-  it "should be true if the table is not on the page" do
+  it 'should be true if the table is not on the page' do
     expect(@session).to have_no_table('Monkey')
   end
+
+  it 'should consider rows' do
+    expect(@session).to have_no_table('Horizontal Headers', with_rows:
+     [
+       { 'First Name' => 'Thomas', 'City' => 'Los Angeles' }
+     ])
+  end
+
+  context 'using :with_cols' do
+    it 'should consider a single column' do
+      expect(@session).to have_no_table('Vertical Headers', with_cols:
+        [
+          { 'First Name' => 'Joe' }
+        ])
+    end
+
+    it 'should be true even if the last column does exist' do
+      expect(@session).to have_no_table('Vertical Headers', with_cols:
+        [
+          {
+            'First Name' => 'What?',
+            'What?' => 'Walpole',
+            'City' => 'Oceanside' # This line makes the example fail
+          }
+        ])
+    end
+
+    it 'should be true if none of the columns exist' do
+      expect(@session).to have_no_table('Vertical Headers', with_cols:
+        [
+          {
+            'First Name' => 'What?',
+            'What?' => 'Walpole',
+            'City' => 'What?'
+          }
+        ])
+    end
+
+    it 'should be true if the first column does match' do
+      expect(@session).to have_no_table('Vertical Headers', with_cols:
+        [
+          {
+            'First Name' => 'Thomas',
+            'Last Name' => 'What',
+            'City' => 'What'
+          }
+        ])
+    end
+
+    it 'should be true if none of the columns match' do
+      expect(@session).to have_no_table('Vertical Headers', with_cols:
+        [
+          {
+            'First Name' => 'What',
+            'Last Name' => 'What',
+            'City' => 'What'
+          }
+        ])
+    end
+  end
 end