capybara 2.18.0 → 3.40.0

data/lib/capybara/spec/session/execute_script_spec.rb

@@ -1,26 +1,28 @@
 # frozen_string_literal: true
-Capybara::SpecHelper.spec "#execute_script", requires: [:js] do
-  it "should execute the given script and return nothing" do
+
+Capybara::SpecHelper.spec '#execute_script', requires: [:js] do
+  it 'should execute the given script and return nothing' do
     @session.visit('/with_js')
     expect(@session.execute_script("document.getElementById('change').textContent = 'Funky Doodle'")).to be_nil
     expect(@session).to have_css('#change', text: 'Funky Doodle')
   end
 
-  it "should be able to call functions defined in the page" do
+  it 'should be able to call functions defined in the page' do
     @session.visit('/with_js')
-    expect{ @session.execute_script("$('#change').text('Funky Doodle')") }.not_to raise_error
+    expect { @session.execute_script("$('#change').text('Funky Doodle')") }.not_to raise_error
   end
 
-  it "should pass arguments to the script", requires: [:js, :es_args] do
+  it 'should pass arguments to the script', requires: %i[js es_args] do
     @session.visit('/with_js')
-    @session.execute_script("document.getElementById('change').textContent = arguments[0]", "Doodle Funk")
+    expect(@session).to have_css('#change')
+    @session.execute_script("document.getElementById('change').textContent = arguments[0]", 'Doodle Funk')
     expect(@session).to have_css('#change', text: 'Doodle Funk')
   end
 
-  it "should support passing elements as arguments to the script", requires: [:js, :es_args] do
+  it 'should support passing elements as arguments to the script', requires: %i[js es_args] do
     @session.visit('/with_js')
     el = @session.find(:css, '#change')
-    @session.execute_script("arguments[1].textContent = arguments[0]", "Doodle Funk", el)
+    @session.execute_script('arguments[1].textContent = arguments[0]', 'Doodle Funk', el)
     expect(@session).to have_css('#change', text: 'Doodle Funk')
   end
 end

data/lib/capybara/spec/session/fill_in_spec.rb

@@ -1,145 +1,228 @@
 # frozen_string_literal: true
-Capybara::SpecHelper.spec "#fill_in" do
+
+Capybara::SpecHelper.spec '#fill_in' do
   before do
     @session.visit('/form')
   end
 
-  it "should fill in a text field by id" do
+  it 'should fill in a text field by id' do
     @session.fill_in('form_first_name', with: 'Harry')
     @session.click_button('awesome')
     expect(extract_results(@session)['first_name']).to eq('Harry')
   end
 
-  it "should fill in a text field by name" do
+  it 'should fill in a text field by name' do
     @session.fill_in('form[last_name]', with: 'Green')
     @session.click_button('awesome')
     expect(extract_results(@session)['last_name']).to eq('Green')
   end
 
-  it "should fill in a text field by label without for" do
+  it 'should fill in a text field by label without for' do
     @session.fill_in('First Name', with: 'Harry')
     @session.click_button('awesome')
     expect(extract_results(@session)['first_name']).to eq('Harry')
   end
 
-  it "should fill in a url field by label without for" do
+  it 'should fill in a url field by label without for' do
     @session.fill_in('Html5 Url', with: 'http://www.avenueq.com')
     @session.click_button('html5_submit')
     expect(extract_results(@session)['html5_url']).to eq('http://www.avenueq.com')
   end
 
-  it "should fill in a textarea by id" do
+  it 'should fill in a textarea by id' do
     @session.fill_in('form_description', with: 'Texty text')
     @session.click_button('awesome')
     expect(extract_results(@session)['description']).to eq('Texty text')
   end
 
-  it "should fill in a textarea by label" do
+  it 'should fill in a textarea by label' do
     @session.fill_in('Description', with: 'Texty text')
     @session.click_button('awesome')
     expect(extract_results(@session)['description']).to eq('Texty text')
   end
 
-  it "should fill in a textarea by name" do
+  it 'should fill in a textarea by name' do
     @session.fill_in('form[description]', with: 'Texty text')
     @session.click_button('awesome')
     expect(extract_results(@session)['description']).to eq('Texty text')
   end
 
-  it "should fill in a password field by id" do
+  it 'should fill in a textarea in a reasonable time by default' do
+    textarea = @session.find(:fillable_field, 'form[description]')
+    value = 'a' * 4000
+    start = Time.now
+    textarea.fill_in(with: value)
+    expect(Time.now.to_f).to be_within(0.25).of start.to_f
+    expect(textarea.value).to eq value
+  end
+
+  it 'should fill in a password field by id' do
     @session.fill_in('form_password', with: 'supasikrit')
     @session.click_button('awesome')
     expect(extract_results(@session)['password']).to eq('supasikrit')
   end
 
-  it "should handle HTML in a textarea" do
+  context 'Date/Time' do
+    it 'should fill in a date input' do
+      date = Date.today
+      @session.fill_in('form_date', with: date)
+      @session.click_button('awesome')
+      expect(Date.parse(extract_results(@session)['date'])).to eq date
+    end
+
+    it 'should fill in a time input' do
+      time = Time.new(2018, 3, 9, 15, 26)
+      @session.fill_in('form_time', with: time)
+      @session.click_button('awesome')
+      results = extract_results(@session)['time']
+      expect(Time.parse(results).strftime('%r')).to eq time.strftime('%r')
+    end
+
+    it 'should fill in a datetime input' do
+      dt = Time.new(2018, 3, 13, 9, 53)
+      @session.fill_in('form_datetime', with: dt)
+      @session.click_button('awesome')
+      expect(Time.parse(extract_results(@session)['datetime'])).to eq dt
+    end
+  end
+
+  it 'should handle HTML in a textarea' do
     @session.fill_in('form_description', with: 'is <strong>very</strong> secret!')
     @session.click_button('awesome')
     expect(extract_results(@session)['description']).to eq('is <strong>very</strong> secret!')
   end
 
-  it "should handle newlines in a textarea" do
+  it 'should handle newlines in a textarea' do
     @session.fill_in('form_description', with: "\nSome text\n")
     @session.click_button('awesome')
     expect(extract_results(@session)['description']).to eq("\r\nSome text\r\n")
   end
 
-  it "should fill in a field with a custom type" do
+  it 'should handle carriage returns with line feeds in a textarea correctly' do
+    @session.fill_in('form_description', with: "\r\nSome text\r\n")
+    @session.click_button('awesome')
+    expect(extract_results(@session)['description']).to eq("\r\nSome text\r\n")
+  end
+
+  it 'should fill in a color field' do
+    @session.fill_in('Html5 Color', with: '#112233')
+    @session.click_button('html5_submit')
+    expect(extract_results(@session)['html5_color']).to eq('#112233')
+  end
+
+  describe 'with input[type="range"]' do
+    it 'should set the range slider correctly' do
+      @session.fill_in('form_age', with: 51)
+      @session.click_button('awesome')
+      expect(extract_results(@session)['age'].to_f).to eq 51
+    end
+
+    it 'should set the range slider to valid values' do
+      @session.fill_in('form_age', with: '37.6')
+      @session.click_button('awesome')
+      expect(extract_results(@session)['age'].to_f).to eq 37.5
+    end
+
+    it 'should respect the range slider limits' do
+      @session.fill_in('form_age', with: '3')
+      @session.click_button('awesome')
+      expect(extract_results(@session)['age'].to_f).to eq 13
+    end
+  end
+
+  it 'should fill in a field with a custom type' do
     @session.fill_in('Schmooo', with: 'Schmooo is the game')
     @session.click_button('awesome')
     expect(extract_results(@session)['schmooo']).to eq('Schmooo is the game')
   end
 
-  it "should fill in a field without a type" do
+  it 'should fill in a field without a type' do
     @session.fill_in('Phone', with: '+1 555 7022')
     @session.click_button('awesome')
     expect(extract_results(@session)['phone']).to eq('+1 555 7022')
   end
 
-  it "should fill in a text field respecting its maxlength attribute" do
+  it 'should fill in a text field respecting its maxlength attribute' do
     @session.fill_in('Zipcode', with: '52071350')
     @session.click_button('awesome')
     expect(extract_results(@session)['zipcode']).to eq('52071')
   end
 
-  it "should fill in a password field by name" do
+  it 'should fill in a password field by name' do
     @session.fill_in('form[password]', with: 'supasikrit')
     @session.click_button('awesome')
     expect(extract_results(@session)['password']).to eq('supasikrit')
   end
 
-  it "should fill in a password field by label" do
+  it 'should fill in a password field by label' do
     @session.fill_in('Password', with: 'supasikrit')
     @session.click_button('awesome')
     expect(extract_results(@session)['password']).to eq('supasikrit')
   end
 
-  it "should fill in a password field by name" do
+  it 'should fill in a password field by name' do
     @session.fill_in('form[password]', with: 'supasikrit')
     @session.click_button('awesome')
     expect(extract_results(@session)['password']).to eq('supasikrit')
   end
 
-  it "should fill in a field based on current value" do
-    @session.fill_in(currently_with: 'John', with: 'Thomas')
+  it 'should fill in a field based on current value' do
+    @session.fill_in(id: /form.*name/, currently_with: 'John', with: 'Thomas')
     @session.click_button('awesome')
     expect(extract_results(@session)['first_name']).to eq('Thomas')
   end
 
-  it "should fill in a field based on type" do
+  it 'should fill in a field based on type' do
     @session.fill_in(type: 'schmooo', with: 'Schmooo for all')
     @session.click_button('awesome')
     expect(extract_results(@session)['schmooo']).to eq('Schmooo for all')
   end
 
+  it 'should be able to fill in element called on when no locator passed' do
+    field = @session.find(:fillable_field, 'form[password]')
+    field.fill_in(with: 'supasikrit')
+    @session.click_button('awesome')
+    expect(extract_results(@session)['password']).to eq('supasikrit')
+  end
+
   it "should throw an exception if a hash containing 'with' is not provided" do
-    expect {@session.fill_in 'Name', 'ignu'}.to raise_error(RuntimeError, /with/)
+    expect { @session.fill_in 'Name' }.to raise_error(ArgumentError, /with/)
   end
 
-  it "should wait for asynchronous load", requires: [:js] do
+  it 'should wait for asynchronous load', requires: [:js] do
+    Capybara.default_max_wait_time = 2
     @session.visit('/with_js')
     @session.click_link('Click me')
     @session.fill_in('new_field', with: 'Testing...')
   end
 
-  it "casts to string" do
-    @session.fill_in(:'form_first_name', with: :'Harry')
+  it 'casts to string' do
+    @session.fill_in(:form_first_name, with: :Harry)
     @session.click_button('awesome')
     expect(extract_results(@session)['first_name']).to eq('Harry')
   end
 
-  it "casts to string if field has maxlength" do
-    @session.fill_in(:'form_zipcode', with: 1234567)
+  it 'casts to string if field has maxlength' do
+    @session.fill_in(:form_zipcode, with: 1234567)
     @session.click_button('awesome')
     expect(extract_results(@session)['zipcode']).to eq('12345')
   end
 
+  it 'fills in a field if default_set_options is nil' do
+    Capybara.default_set_options = nil
+    @session.fill_in(:form_first_name, with: 'Thomas')
+    @session.click_button('awesome')
+    expect(extract_results(@session)['first_name']).to eq('Thomas')
+  end
+
   context 'on a pre-populated textfield with a reformatting onchange', requires: [:js] do
     it 'should only trigger onchange once' do
       @session.visit('/with_js')
+      # Click somewhere on the page to ensure focus is acquired. Without this FF won't generate change events for some reason???
+      @session.find(:css, 'h1', text: 'FooBar').click
       @session.fill_in('with_change_event', with: 'some value')
       # click outside the field to trigger the change event
-      @session.find(:css, 'body').click
+      @session.find(:css, 'h1', text: 'FooBar').click
       expect(@session.find(:css, '.change_event_triggered', match: :one)).to have_text 'some value'
     end
 
@@ -147,16 +230,18 @@ Capybara::SpecHelper.spec "#fill_in" do
       @session.visit('/with_js')
       @session.fill_in('with_change_event', with: '')
       # click outside the field to trigger the change event
-      @session.find(:css, 'body').click
+      @session.find(:css, 'h1', text: 'FooBar').click
       expect(@session).to have_selector(:css, '.change_event_triggered', match: :one)
     end
   end
 
-  context "with ignore_hidden_fields" do
+  context 'with ignore_hidden_fields' do
     before { Capybara.ignore_hidden_elements = true }
+
     after  { Capybara.ignore_hidden_elements = false }
-    it "should not find a hidden field" do
-      msg = "Unable to find visible field \"Super Secret\" that is not disabled"
+
+    it 'should not find a hidden field' do
+      msg = /Unable to find visible field "Super Secret"/
       expect do
         @session.fill_in('Super Secret', with: '777')
       end.to raise_error(Capybara::ElementNotFound, msg)
@@ -164,38 +249,44 @@ Capybara::SpecHelper.spec "#fill_in" do
   end
 
   context "with a locator that doesn't exist" do
-    it "should raise an error" do
-      msg = "Unable to find visible field \"does not exist\" that is not disabled"
+    it 'should raise an error' do
+      msg = /Unable to find field "does not exist"/
       expect do
         @session.fill_in('does not exist', with: 'Blah blah')
       end.to raise_error(Capybara::ElementNotFound, msg)
     end
   end
 
-  context "on a disabled field" do
-    it "should raise an error" do
+  context 'on a disabled field' do
+    it 'should raise an error' do
       expect do
         @session.fill_in('Disabled Text Field', with: 'Blah blah')
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
 
-  context "with :exact option" do
-    it "should accept partial matches when false" do
-      @session.fill_in("Explanation", with: "Dude", exact:  false)
-      @session.click_button("awesome")
-      expect(extract_results(@session)["name_explanation"]).to eq("Dude")
+  context 'with :exact option' do
+    it 'should accept partial matches when false' do
+      @session.fill_in('Explanation', with: 'Dude', exact: false)
+      @session.click_button('awesome')
+      expect(extract_results(@session)['name_explanation']).to eq('Dude')
     end
 
-    it "should not accept partial matches when true" do
+    it 'should not accept partial matches when true' do
       expect do
-        @session.fill_in("Explanation", with: "Dude", exact:  true)
+        @session.fill_in('Explanation', with: 'Dude', exact: true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
 
-  it "should return the element filled in" do
+  it 'should return the element filled in' do
     el = @session.find(:fillable_field, 'form_first_name')
     expect(@session.fill_in('form_first_name', with: 'Harry')).to eq el
   end
+
+  it 'should warn if passed what looks like a CSS id selector' do
+    expect do
+      @session.fill_in('#form_first_name', with: 'Harry')
+    end.to raise_error(/you may be passing a CSS selector or XPath expression rather than a locator/)
+  end
 end

data/lib/capybara/spec/session/find_button_spec.rb

@@ -1,28 +1,29 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#find_button' do
   before do
     @session.visit('/form')
   end
 
-  it "should find any button" do
-    expect(@session.find_button('med')[:id]).to eq("mediocre")
-    expect(@session.find_button('crap321').value).to eq("crappy")
+  it 'should find any button' do
+    expect(@session.find_button('med')[:id]).to eq('mediocre')
+    expect(@session.find_button('crap321').value).to eq('crappy')
   end
 
-  context "aria_label attribute with Capybara.enable_aria_label" do
-    it "should find when true" do
+  context 'aria_label attribute with Capybara.enable_aria_label' do
+    it 'should find when true' do
       Capybara.enable_aria_label = true
-      expect(@session.find_button('Mediocre Button')[:id]).to eq("mediocre")
+      expect(@session.find_button('Mediocre Button')[:id]).to eq('mediocre')
     end
 
-    it "should not find when false" do
+    it 'should not find when false' do
       Capybara.enable_aria_label = false
       expect { @session.find_button('Mediocre Button') }.to raise_error(Capybara::ElementNotFound)
     end
   end
 
-  it "casts to string" do
-    expect(@session.find_button(:'med')[:id]).to eq("mediocre")
+  it 'casts to string' do
+    expect(@session.find_button(:med)[:id]).to eq('mediocre')
   end
 
   it "should raise error if the button doesn't exist" do
@@ -31,43 +32,43 @@ Capybara::SpecHelper.spec '#find_button' do
     end.to raise_error(Capybara::ElementNotFound)
   end
 
-  context "with :exact option" do
-    it "should accept partial matches when false" do
-      expect(@session.find_button('What an Awesome', exact:  false).value).to eq("awesome")
+  context 'with :exact option' do
+    it 'should accept partial matches when false' do
+      expect(@session.find_button('What an Awesome', exact: false).value).to eq('awesome')
     end
 
-    it "should not accept partial matches when true" do
+    it 'should not accept partial matches when true' do
       expect do
-        @session.find_button('What an Awesome', exact:  true)
+        @session.find_button('What an Awesome', exact: true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
 
-  context "with :disabled option" do
-    it "should find disabled buttons when true" do
-      expect(@session.find_button('Disabled button', disabled: true).value).to eq("Disabled button")
+  context 'with :disabled option' do
+    it 'should find disabled buttons when true' do
+      expect(@session.find_button('Disabled button', disabled: true).value).to eq('Disabled button')
     end
 
-    it "should not find disabled buttons when false" do
+    it 'should not find disabled buttons when false' do
       expect do
         @session.find_button('Disabled button', disabled: false)
       end.to raise_error(Capybara::ElementNotFound)
     end
 
-    it "should default to not finding disabled buttons" do
+    it 'should default to not finding disabled buttons' do
       expect do
         @session.find_button('Disabled button')
       end.to raise_error(Capybara::ElementNotFound)
     end
 
-    it "should find disabled buttons when :all" do
-      expect(@session.find_button('Disabled button', disabled: :all).value).to eq("Disabled button")
+    it 'should find disabled buttons when :all' do
+      expect(@session.find_button('Disabled button', disabled: :all).value).to eq('Disabled button')
     end
   end
 
-  context "without locator" do
-    it "should use options" do
-      expect(@session.find_button(disabled: true).value).to eq("Disabled button")
+  context 'without locator' do
+    it 'should use options' do
+      expect(@session.find_button(disabled: true).value).to eq('Disabled button')
     end
   end
 end

data/lib/capybara/spec/session/find_by_id_spec.rb

@@ -1,31 +1,32 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#find_by_id' do
   before do
     @session.visit('/with_html')
   end
 
-  it "should find any element by id" do
+  it 'should find any element by id' do
     expect(@session.find_by_id('red').tag_name).to eq('a')
   end
 
-  it "casts to string" do
-    expect(@session.find_by_id(:'red').tag_name).to eq('a')
+  it 'casts to string' do
+    expect(@session.find_by_id(:red).tag_name).to eq('a')
   end
 
-  it "should raise error if no element with id is found" do
+  it 'should raise error if no element with id is found' do
     expect do
       @session.find_by_id('nothing_with_this_id')
     end.to raise_error(Capybara::ElementNotFound)
   end
 
-  context "with :visible option" do
-    it "finds invisible elements when `false`" do
-      expect(@session.find_by_id("hidden_via_ancestor", visible: false).text(:all)).to match(/with hidden ancestor/)
+  context 'with :visible option' do
+    it 'finds invisible elements when `false`' do
+      expect(@session.find_by_id('hidden_via_ancestor', visible: false).text(:all)).to match(/with hidden ancestor/)
     end
 
-    it "finds invisible elements when `false`" do
+    it "doesn't find invisible elements when `true`" do
       expect do
-        @session.find_by_id("hidden_via_ancestor", visible: true)
+        @session.find_by_id('hidden_via_ancestor', visible: true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end