blacklight-spotlight 3.4.0 → 3.4.1

data/spec/controllers/spotlight/languages_controller_spec.rb

@@ -1,70 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::LanguagesController do
-  routes { Spotlight::Engine.routes }
-
-  describe '#create' do
-    let(:exhibit) { FactoryBot.create(:exhibit) }
-
-    context 'when not signed in' do
-      it 'is not successful' do
-        post :create, params: { exhibit_id: exhibit, language: { locale: 'es' } }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    context 'when signed in as a site admin' do
-      before { sign_in user }
-
-      let(:user) { FactoryBot.create(:site_admin) }
-
-      it 'is successful' do
-        post :create, params: { exhibit_id: exhibit, language: { locale: 'es' } }
-        expect(response).to redirect_to edit_exhibit_path(exhibit, tab: 'language')
-        expect(assigns[:exhibit].languages.first.locale).to eq 'es'
-        expect(flash[:notice]).to eq 'The language was created.'
-      end
-
-      it 'validates language params' do
-        post :create, params: { exhibit_id: exhibit, language: { locale: nil } }
-        expect(response).to redirect_to edit_exhibit_path(exhibit, tab: 'language')
-        expect(flash[:alert]).to include "Language can't be blank"
-      end
-
-      it 'creates a published home page for the language' do
-        expect(Spotlight::HomePage.for_locale('es')).to be_blank
-
-        post :create, params: { exhibit_id: exhibit, language: { locale: 'es' } }
-        locale_pages = Spotlight::HomePage.for_locale('es')
-        expect(locale_pages.length).to eq 1
-        expect(locale_pages.first.exhibit).to eq exhibit
-        expect(locale_pages.first).to be_published
-      end
-    end
-  end
-
-  describe '#destroy' do
-    let(:exhibit) { FactoryBot.create(:exhibit) }
-    let(:language) { FactoryBot.create(:language, exhibit: exhibit) }
-
-    context 'when not signed in' do
-      it 'is not successful' do
-        delete :destroy, params: { exhibit_id: exhibit, id: language }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    context 'when signed in as a site admin' do
-      before { sign_in user }
-
-      let(:user) { FactoryBot.create(:site_admin) }
-
-      it 'is successful' do
-        delete :destroy, params: { exhibit_id: exhibit, id: language }
-        expect(response).to redirect_to edit_exhibit_path(exhibit, tab: 'language')
-        expect(assigns[:exhibit].languages.count).to eq 0
-        expect(flash[:notice]).to eq 'The language was deleted.'
-      end
-    end
-  end
-end

data/spec/controllers/spotlight/metadata_configurations_controller_spec.rb

@@ -1,93 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::MetadataConfigurationsController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  describe 'when the user is not authorized' do
-    before do
-      sign_in FactoryBot.create(:exhibit_visitor)
-    end
-
-    describe 'GET show' do
-      it 'denies access' do
-        get :show, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.root_path
-        expect(flash[:alert]).to be_present
-      end
-    end
-
-    describe 'GET edit' do
-      it 'denies access' do
-        get :edit, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.root_path
-        expect(flash[:alert]).to be_present
-      end
-    end
-  end
-
-  describe 'when not logged in' do
-    describe 'PATCH update' do
-      it 'denies access' do
-        patch :update, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    describe 'GET edit' do
-      it 'denies access' do
-        get :edit, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-  end
-
-  describe 'when signed in' do
-    let(:user) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-
-    before { sign_in user }
-
-    describe 'GET edit' do
-      it 'is successful' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-        expect(controller).to receive(:add_breadcrumb).with('Configuration', exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('Metadata', edit_exhibit_metadata_configuration_path(exhibit))
-        get :edit, params: { exhibit_id: exhibit }
-        expect(response).to be_successful
-      end
-    end
-
-    describe 'GET show' do
-      it 'is successful' do
-        get :show, params: { exhibit_id: exhibit, format: 'json' }
-        expect(response).to be_successful
-        expect(JSON.parse(response.body).keys).to eq exhibit.blacklight_config.index_fields.keys
-      end
-    end
-
-    describe 'PATCH update' do
-      it 'updates metadata fields' do
-        blacklight_config = Blacklight::Configuration.new
-        blacklight_config.add_index_field %w[a b c d e f]
-        allow(::CatalogController).to receive_messages(blacklight_config: blacklight_config)
-        patch :update, params: {
-          exhibit_id: exhibit,
-          blacklight_configuration: {
-            index_fields: {
-              c: { enabled: true, show: true },
-              d: { enabled: true, show: true },
-              e: { enabled: true, list: true },
-              f: { enabled: true, list: true }
-            }
-          }
-        }
-
-        expect(flash[:notice]).to eq 'The exhibit was successfully updated.'
-        expect(response).to redirect_to edit_exhibit_metadata_configuration_path(exhibit)
-        assigns[:exhibit].tap do |saved|
-          expect(saved.blacklight_configuration.index_fields).to include 'c', 'd', 'e', 'f'
-        end
-      end
-    end
-  end
-end

data/spec/controllers/spotlight/pages_controller_spec.rb

@@ -1,50 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::PagesController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit, published: false) }
-  let(:about_page) { FactoryBot.create(:about_page, exhibit: exhibit, published: false) }
-  let(:update_all_params) do
-    {
-      exhibit: {
-        pages_attributes: {
-          0 => {
-            id: feature_page.id,
-            published: 1
-          },
-          1 => {
-            id: about_page.id,
-            published: 1
-          }
-        }
-      }
-    }
-  end
-
-  describe 'when signed in as a curator' do
-    let(:user) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-    before do
-      sign_in user
-    end
-
-    it 'the feature and about pages are updated' do
-      expect(Spotlight::Page.find(feature_page.id)).not_to be_published
-      expect(Spotlight::Page.find(about_page.id)).not_to be_published
-      put :update_all, params: update_all_params.merge(exhibit_id: exhibit.id)
-      expect(Spotlight::Page.find(feature_page.id)).to be_published
-      expect(Spotlight::Page.find(about_page.id)).to be_published
-    end
-  end
-
-  describe 'when user is not authenticated' do
-    it 'does not allow publishing pages' do
-      put :update_all, params: update_all_params.merge(exhibit_id: exhibit.id)
-      expect(Spotlight::Page.find(feature_page.id)).not_to be_published
-      expect(Spotlight::Page.find(about_page.id)).not_to be_published
-      expect(flash['alert']).to eq 'You need to sign in or sign up before continuing.'
-      expect(response).to redirect_to main_app.new_user_session_path
-    end
-  end
-end

data/spec/controllers/spotlight/resources/csv_upload_controller_spec.rb

@@ -1,71 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::Resources::CsvUploadController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  describe 'when not logged in' do
-    describe 'POST create' do
-      it 'is not allowed' do
-        post :create, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-  end
-
-  describe 'when signed in as a curator' do
-    let(:user) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-    before { sign_in user }
-
-    describe 'POST create' do
-      let(:csv) { fixture_file_upload(File.expand_path(File.join('..', 'spec', 'fixtures', 'csv-upload-fixture.csv'), Rails.root), 'text/csv') }
-      let(:serialized_csv) do
-        [
-          {
-            'url' => 'http://lorempixel.com/800/500/',
-            'full_title_tesim' => 'A random image',
-            'spotlight_upload_description_tesim' => 'A random 800 by 500 image from lorempixel',
-            'spotlight_upload_attribution_tesim' => 'lorempixel.com',
-            'spotlight_upload_date_tesim' => '2015'
-          },
-          {
-            'url' => 'http://lorempixel.com/900/600/',
-            'full_title_tesim' => 'Another random image',
-            'spotlight_upload_description_tesim' => 'A random 900 by 600 image from lorempixel',
-            'spotlight_upload_attribution_tesim' => 'lorempixel.com',
-            'spotlight_upload_date_tesim' => '2014'
-          },
-          {
-            'url' => 'http://lorempixel.com/900/600/',
-            'full_title_tesim' => 'Yet another random image to test UTF8 text',
-            'spotlight_upload_description_tesim' => 'A random 900 by 600 image from lorempixel and some UTF8: Hüsker Dü',
-            'spotlight_upload_attribution_tesim' => 'lorempixel.com',
-            'spotlight_upload_date_tesim' => '2016'
-          }
-        ]
-      end
-
-      before do
-        request.env['HTTP_REFERER'] = 'http://test.host/'
-      end
-
-      it 'starts an AddUploadsFromCsv job with the serialized CSV' do
-        expect(Spotlight::AddUploadsFromCsv).to receive(:perform_later).with(serialized_csv, exhibit, user).and_return(nil)
-        post :create, params: { exhibit_id: exhibit, resources_csv_upload: { url: csv } }
-      end
-
-      it 'sets the flash message' do
-        expect(Spotlight::AddUploadsFromCsv).to receive(:perform_later).and_return(nil)
-        post :create, params: { exhibit_id: exhibit, resources_csv_upload: { url: csv } }
-        expect(flash[:notice]).to eq "'csv-upload-fixture.csv' has been uploaded.  An email will be sent to you once indexing is complete."
-      end
-
-      it 'redirects back' do
-        expect(Spotlight::AddUploadsFromCsv).to receive(:perform_later).and_return(nil)
-        post :create, params: { exhibit_id: exhibit, resources_csv_upload: { url: csv } }
-        expect(response).to redirect_to "http://test.host/spotlight/#{exhibit.slug}/catalog/admin"
-      end
-    end
-  end
-end

data/spec/controllers/spotlight/resources/upload_controller_spec.rb

@@ -1,55 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::Resources::UploadController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  describe 'when not logged in' do
-    describe 'POST create' do
-      it 'is not allowed' do
-        post :create, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-  end
-
-  describe 'when signed in as a curator' do
-    let(:user) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-    before { sign_in user }
-
-    describe 'POST create' do
-      let(:blacklight_solr) { double }
-
-      before do
-        allow_any_instance_of(Spotlight::Resource).to receive(:reindex).and_return(true)
-        allow_any_instance_of(Spotlight::Resource).to receive(:blacklight_solr).and_return blacklight_solr
-      end
-
-      it 'create a Spotlight::Resources::Upload resource' do
-        expect_any_instance_of(Spotlight::Resource).to receive(:reindex_later)
-        post :create, params: { exhibit_id: exhibit, resources_upload: { url: 'url-data' } }
-        expect(assigns[:resource]).to be_persisted
-        expect(assigns[:resource]).to be_a(Spotlight::Resources::Upload)
-      end
-
-      it 'redirects to the item admin page' do
-        post :create, params: { exhibit_id: exhibit, resources_upload: { url: 'url-data' } }
-        expect(flash[:notice]).to eq 'Object uploaded successfully.'
-        expect(response).to redirect_to admin_exhibit_catalog_path(exhibit, sort: :timestamp)
-      end
-
-      it 'redirects to the upload form when the add-and-continue parameter is present' do
-        post :create, params: { exhibit_id: exhibit, 'add-and-continue' => 'true', resources_upload: { url: 'url-data' } }
-        expect(flash[:notice]).to eq 'Object uploaded successfully.'
-        expect(response).to redirect_to new_exhibit_resource_path(exhibit, tab: 'upload')
-      end
-
-      it 'can add multivalued fields' do
-        field = FactoryBot.create(:custom_field, exhibit: exhibit, is_multiple: true)
-        post :create, params: { exhibit_id: exhibit, resources_upload: { data: { field.slug => %w[1 2 3] } } }
-        expect(assigns[:resource].sidecar.data).to include(field.slug => %w[1 2 3])
-      end
-    end
-  end
-end

data/spec/controllers/spotlight/resources_controller_spec.rb

@@ -1,85 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::ResourcesController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  describe 'when not logged in' do
-    describe 'GET new' do
-      it 'is not allowed' do
-        get :new, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    describe 'GET monitor' do
-      it 'is not allowed' do
-        get :monitor, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    describe 'POST create' do
-      it 'is not allowed' do
-        post :create, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    describe 'POST reindex_all' do
-      it 'is not allowed' do
-        post :reindex_all, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-  end
-
-  describe 'when signed in as a curator' do
-    let(:user) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-    before { sign_in user }
-
-    describe 'GET new' do
-      it 'renders form' do
-        get :new, params: { exhibit_id: exhibit }
-        expect(response).to render_template 'spotlight/resources/new'
-      end
-    end
-
-    describe 'GET monitor' do
-      it 'succesfully renders json' do
-        get :monitor, params: { exhibit_id: exhibit }
-        expect(response).to be_successful
-      end
-    end
-
-    describe 'POST create' do
-      let(:blacklight_solr) { double }
-      let(:invalid_resource) { Spotlight::Resource.new.tap { |x| x.errors.add(:url, 'is invalid') } }
-
-      it 'create a resource' do
-        expect_any_instance_of(Spotlight::Resource).to receive(:reindex_later).and_return(true)
-        allow_any_instance_of(Spotlight::Resource).to receive(:blacklight_solr).and_return blacklight_solr
-        post :create, params: { exhibit_id: exhibit, resource: { url: 'info:uri' } }
-        expect(assigns[:resource]).to be_persisted
-      end
-
-      it 'adds errors to the flash message' do
-        allow_any_instance_of(Spotlight::Resource).to receive_messages(save: false)
-        allow_any_instance_of(Spotlight::Resource).to receive(:errors).and_return invalid_resource.errors
-        post :create, params: { exhibit_id: exhibit, resource: { url: 'info:uri' } }
-        expect(assigns[:resource]).not_to be_persisted
-        expect(flash[:error]).to include 'Url is invalid'
-      end
-    end
-
-    describe 'POST reindex_all' do
-      it 'triggers a reindex' do
-        expect_any_instance_of(Spotlight::Exhibit).to receive(:reindex_later)
-        post :reindex_all, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to admin_exhibit_catalog_path(exhibit)
-        expect(flash[:notice]).to include 'Reindexing'
-      end
-    end
-  end
-end

data/spec/controllers/spotlight/roles_controller_spec.rb

@@ -1,141 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::RolesController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  describe 'when user does not have access' do
-    before { sign_in FactoryBot.create(:exhibit_visitor) }
-
-    describe 'GET index' do
-      it 'denies access' do
-        get :index, params: { exhibit_id: exhibit }
-        expect(response).to redirect_to main_app.root_path
-      end
-    end
-  end
-
-  describe 'when user is an admin' do
-    let(:admin) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-    let(:user) { FactoryBot.create(:user) }
-    let(:role) { admin.roles.first }
-
-    before { sign_in admin }
-
-    it 'allows index' do
-      expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-      expect(controller).to receive(:add_breadcrumb).with('Configuration', exhibit_dashboard_path(exhibit))
-      expect(controller).to receive(:add_breadcrumb).with('Users', exhibit_roles_path(exhibit))
-      get :index, params: { exhibit_id: exhibit }
-      expect(response).to be_successful
-      expect(assigns[:roles].to_a).to eq [admin.roles.first]
-    end
-
-    describe 'PATCH update_all' do
-      it 'creates new roles' do
-        patch :update_all, params: {
-          exhibit_id: exhibit,
-          'exhibit' => {
-            'roles_attributes' => {
-              '0' => { 'role' => 'curator', 'user_key' => user.email }
-            }
-          }
-        }
-
-        expect(exhibit.roles.last.role).to eq 'curator'
-        expect(exhibit.roles.last.user.email).to eq user.email
-        expect(flash[:notice]).to eq 'User has been updated.'
-      end
-
-      it 'invites new users' do
-        expect do
-          patch :update_all, params: {
-            exhibit_id: exhibit,
-            'exhibit' => {
-              'roles_attributes' => {
-                '0' => { 'role' => 'curator', 'user_key' => 'something@example.com' }
-              }
-            }
-          }
-        end.to change { Devise::Mailer.deliveries.count }.by(1)
-
-        expect(exhibit.roles.last.user.email).to eq 'something@example.com'
-        expect(exhibit.roles.last.user.invitation_sent_at).to be_present
-      end
-
-      it 'updates roles' do
-        patch :update_all, params: {
-          exhibit_id: exhibit,
-          'exhibit' => {
-            'roles_attributes' => {
-              '0' => { 'role' => 'curator', 'id' => role.id }
-            }
-          }
-        }
-        expect(response).to redirect_to exhibit_roles_path(exhibit)
-        expect(flash[:notice]).to eq 'User has been updated.'
-
-        admin.reload
-
-        expect(admin.roles.first.role).to eq 'curator'
-      end
-
-      it 'ignores empty roles' do
-        expect do
-          patch :update_all, params: {
-            exhibit_id: exhibit,
-            'exhibit' => {
-              'roles_attributes' => {
-                '0' => { 'user_key' => '', 'role' => '' }
-              }
-            }
-          }
-        end.not_to change { exhibit.roles.length }
-      end
-
-      it 'authorizes records' do
-        allow(controller).to receive(:authorize!).and_raise(CanCan::AccessDenied)
-        patch :update_all, params: {
-          exhibit_id: exhibit,
-          'exhibit' => {
-            'roles_attributes' => {
-              '0' => { 'role' => 'curator', 'id' => role.id }
-            }
-          }
-        }
-        expect(response).to redirect_to main_app.root_path
-        expect(flash[:alert]).to eq 'You are not authorized to access this page.'
-        expect(admin.reload.roles.first.role).to eq 'admin'
-      end
-
-      it 'destroys records' do
-        patch :update_all, params: {
-          exhibit_id: exhibit,
-          'exhibit' => {
-            'roles_attributes' => {
-              '0' => { 'role' => 'curator', 'id' => role.id, '_destroy' => '1' }
-            }
-          }
-        }
-
-        expect(response).to redirect_to exhibit_roles_path(exhibit)
-        expect(admin.reload.roles).to be_empty
-        expect(flash[:notice]).to eq 'User has been removed.'
-      end
-
-      it 'handles failure' do
-        allow_any_instance_of(Spotlight::Exhibit).to receive_messages(update: false)
-        patch :update_all, params: {
-          exhibit_id: exhibit,
-          'exhibit' => {
-            'roles_attributes' => {
-              '0' => { 'role' => 'curator', 'id' => role.id }
-            }
-          }
-        }
-        expect(response).to be_successful
-        expect(flash[:alert]).to eq 'There was a problem saving the user.'
-      end
-    end
-  end
-end