blacklight-spotlight 3.4.0 → 3.4.1

data/spec/features/exhibits/translation_editing_spec.rb

@@ -1,463 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Translation editing', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit, title: 'Sample', subtitle: 'SubSample') }
-  let(:admin) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-
-  before(:all) do
-    # mimics setting config.i18n.fallbacks = [I18n.default_locale] in the rails environment
-    I18n.fallbacks[:fr] = [:fr, I18n.default_locale]
-  end
-
-  before do
-    FactoryBot.create(:language, exhibit: exhibit, locale: 'sq')
-    FactoryBot.create(:language, exhibit: exhibit, locale: 'fr')
-    login_as admin
-  end
-
-  describe 'general' do
-    before do
-      visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr')
-    end
-
-    it 'selects the correct language' do
-      expect(page).to have_css '.nav-pills .nav-link.active', text: 'French'
-    end
-
-    describe 'basic settings' do
-      it 'successfully adds translations' do
-        within '.translation-edit-form #general' do
-          expect(page).to have_css '.form-text', text: 'Sample'
-          expect(page).to have_css '.form-text', text: 'SubSample'
-          fill_in 'Title', id: 'exhibit_translations_attributes_0_value', with: 'Titre français'
-          fill_in 'Subtitle', with: 'Sous-titre français'
-          click_button 'Save changes'
-        end
-        expect(page).to have_css '.flash_messages', text: 'The exhibit was successfully updated.'
-        within '.translation-basic-settings-title' do
-          expect(page).to have_css 'input[value="Titre français"]'
-          expect(page).to have_css '.translation-complete'
-        end
-        within '.translation-basic-settings-subtitle' do
-          expect(page).to have_css 'input[value="Sous-titre français"]'
-          expect(page).to have_css '.translation-complete'
-        end
-        within '.translation-basic-settings-description' do
-          expect(page).not_to have_css '.translation-complete'
-        end
-      end
-    end
-
-    describe 'main menu' do
-      before do
-        exhibit.searches.first.update(published: true)
-        within '.translation-edit-form #general' do
-          fill_in 'Home', with: 'Maison'
-          fill_in 'Browse', with: 'parcourir ceci!'
-          click_button 'Save changes'
-        end
-      end
-
-      it 'adds translations to exhibit navbar' do
-        within '.translation-edit-form #general' do
-          expect(page).to have_css '.form-text', text: 'Home'
-          fill_in 'Home', with: 'Maison'
-          fill_in 'Browse', with: 'parcourir ceci!'
-          click_button 'Save changes'
-        end
-        expect(page).to have_css '.flash_messages', text: 'The exhibit was successfully updated.'
-        within '.translation-main-menu-home' do
-          expect(page).to have_css 'input[value="Maison"]'
-          expect(page).to have_css '.translation-complete'
-        end
-        within '.translation-main-menu-browse' do
-          expect(page).to have_css 'input[value="parcourir ceci!"]'
-          expect(page).to have_css '.translation-complete'
-        end
-        within '.translation-main-menu-curated_features' do
-          expect(page).not_to have_css '.translation-complete'
-        end
-        within '.translation-main-menu-about' do
-          expect(page).not_to have_css '.translation-complete'
-        end
-        I18n.locale = :fr
-        expect(exhibit.main_navigations.browse.label).to eq 'parcourir ceci!'
-        expect(I18n.t(:'spotlight.curation.nav.home')).to eq 'Maison'
-        I18n.locale = I18n.default_locale
-      end
-
-      it 'adds translations to user-facing breadcrumbs' do
-        expect(page).to have_css '.flash_messages', text: 'The exhibit was successfully updated.'
-        visit spotlight.exhibit_browse_index_path(exhibit, locale: 'fr')
-        expect(page).to have_breadcrumbs 'Maison', 'parcourir ceci!'
-      end
-
-      it 'does not translate admin breadcrumbs' do
-        expect(page).to have_css '.flash_messages', text: 'The exhibit was successfully updated.'
-        visit spotlight.exhibit_searches_path(exhibit, locale: 'fr')
-        expect(page).to have_breadcrumbs 'Home', 'Curation', 'Browse'
-      end
-    end
-
-    describe 'breadcrumbs' do
-      describe 'browse categories' do
-        before do
-          exhibit.searches.first.update(published: true)
-          within '.translation-edit-form #general' do
-            fill_in 'Home', with: 'Maison'
-            fill_in 'Browse', with: 'parcourir ceci!'
-            click_button 'Save changes'
-          end
-        end
-
-        it 'adds translations to user-facing breadcrumbs' do
-          visit spotlight.exhibit_browse_index_path(exhibit, locale: 'fr')
-          expect(page).to have_breadcrumbs 'Maison', 'parcourir ceci!'
-        end
-
-        it 'does not translate admin breadcrumbs' do
-          visit spotlight.exhibit_searches_path(exhibit, locale: 'fr')
-          expect(page).to have_breadcrumbs 'Home', 'Curation', 'Browse'
-        end
-      end
-
-      describe 'pages' do
-        let!(:about_page1) { FactoryBot.create(:about_page, title: 'First Page', exhibit: exhibit, locale: 'fr') }
-        let(:about_page2) { FactoryBot.create(:about_page, title: 'Second Page', exhibit: exhibit, locale: 'fr') }
-
-        before do
-          within '.translation-edit-form #general' do
-            fill_in 'Home', with: 'Maison'
-            fill_in 'About', with: 'Sur'
-            click_button 'Save changes'
-          end
-        end
-
-        it 'adds breadcrumbs to pages' do
-          visit spotlight.exhibit_about_page_path(about_page2.exhibit, about_page2, locale: 'fr')
-          expect(page).to have_breadcrumbs 'Maison', 'Sur', about_page2.title
-        end
-
-        it 'does not translate admin breadcrumbs' do
-          visit spotlight.exhibit_about_pages_path(exhibit, locale: 'fr')
-          expect(page).to have_breadcrumbs 'Home', 'Curation', 'About'
-        end
-      end
-
-      describe 'Catalog' do
-        before do
-          within '.translation-edit-form #general' do
-            fill_in 'Home', with: 'Maison'
-            fill_in 'Search results', with: 'Résultats de la recherche'
-            click_button 'Save changes'
-          end
-        end
-
-        it 'adds breadcrumbs user facing catalog' do
-          visit spotlight.search_exhibit_catalog_path(exhibit, q: '*', locale: 'fr')
-          expect(page).to have_breadcrumbs 'Maison', 'Résultats de la recherche'
-        end
-
-        it 'does not translate admin catalog' do
-          visit spotlight.admin_exhibit_catalog_path(exhibit, locale: 'fr')
-          expect(page).to have_breadcrumbs 'Home', 'Curation', 'Items'
-        end
-      end
-    end
-  end
-
-  describe 'Metadata field labels' do
-    before { visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr') }
-
-    it 'redirects to the same form tab' do
-      click_link 'Metadata field labels'
-      within('#metadata', visible: true) do
-        fill_in 'Everything', with: 'Tout'
-        click_button 'Save changes'
-      end
-
-      expect(page).to have_css '.nav-pills .nav-link.active', text: 'French'
-      expect(page).to have_css '.nav-tabs .nav-link.active', text: 'Metadata field labels'
-    end
-
-    describe 'configured fields' do
-      it 'has a text input for each metadata field' do
-        within '#metadata' do
-          expect(page).to have_css('input[type="text"]', count: 17)
-        end
-      end
-
-      it 'allows users to translate both index and show metadata field labels', js: true do
-        click_link 'Metadata field labels'
-
-        within('#metadata', visible: true) do
-          language_label = find('label', text: 'Language', visible: true)
-          language_input = find("##{language_label['for']}", visible: true)
-          language_input.set('Langue')
-          click_button 'Save changes'
-        end
-
-        visit spotlight.search_exhibit_catalog_path(exhibit, f: { language_ssim: ['Latin'] }, locale: 'fr')
-
-        expect(page).to have_css('dt.blacklight-language_ssm', text: 'Langue')
-
-        click_link 'Orbis terrarum tabula recens emendata et in lucem edita'
-
-        expect(page).to have_css('dt.blacklight-language_ssm', text: 'Langue')
-      end
-    end
-
-    describe 'Exhibit-specific fields' do
-      let!(:custom_field) { FactoryBot.create(:custom_field, exhibit: exhibit) }
-
-      before do
-        visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr')
-      end
-
-      it 'has text inputs for the exhibit-specific fields' do
-        within '#metadata' do
-          expect(page).to have_css('input[type="text"]', count: 18)
-
-          within '.translation-exhibit-specific-fields' do
-            expect(page).to have_css('input[type="text"]', count: 1)
-          end
-        end
-      end
-
-      it 'allows users to translate exhibit-specific metadata fields' do
-        within '#metadata' do
-          fill_in custom_field.configuration['label'], with: 'French Custom Field Label'
-          click_button 'Save changes'
-        end
-
-        # Adding some data to our custom field
-        visit spotlight.exhibit_solr_document_path(exhibit, 'dq287tq6352', locale: :fr)
-        expect(page).to have_link 'Edit'
-        click_on 'Edit'
-        fill_in custom_field.configuration['label'], with: 'Custom Field Data'
-        click_on 'Save changes'
-
-        expect(page).to have_css('dt', text: 'French Custom Field Label')
-        expect(page).to have_css('dd', text: 'Custom Field Data')
-      end
-    end
-  end
-
-  describe 'Search field labels' do
-    before { visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr') }
-
-    it 'redirects to the same form tab' do
-      click_link 'Search field labels'
-      within('#search_fields', visible: true) do
-        fill_in 'Everything', with: 'Tout'
-        click_button 'Save changes'
-      end
-
-      expect(page).to have_css '.nav-pills .nav-link.active', text: 'French'
-      expect(page).to have_css '.nav-tabs .nav-link.active', text: 'Search field labels'
-    end
-
-    describe 'field-based search fields' do
-      it 'has a text input for each enabled search field' do
-        within '#search_fields .translation-field-based-search-fields' do
-          expect(page).to have_css('input[type="text"]', count: 3)
-        end
-      end
-
-      it 'allows users to translate field-based search fields', js: true do
-        click_link 'Search field labels'
-
-        within('#search_fields', visible: true) do
-          fill_in 'Everything', with: 'Tout'
-          click_button 'Save changes'
-        end
-
-        visit spotlight.exhibit_path(exhibit, locale: 'fr')
-
-        expect(page).to have_css('select#search_field option', text: 'Tout')
-      end
-    end
-
-    describe 'facet fields' do
-      it 'has a text input for each facet field' do
-        within '#search_fields .translation-facet-fields' do
-          expect(page).to have_css('input[type="text"]', count: 7)
-        end
-      end
-
-      it 'allows users to translate facet fields', js: true do
-        click_link 'Search field labels'
-
-        within('#search_fields', visible: true) do
-          fill_in 'Geographic', with: 'Géographique'
-          click_button 'Save changes'
-        end
-
-        visit spotlight.search_exhibit_catalog_path(exhibit, q: '*', locale: 'fr')
-
-        expect(page).to have_css('h3.facet-field-heading', text: 'Géographique')
-      end
-    end
-
-    describe 'sort fields' do
-      it 'has a text input for each sort field' do
-        within '#search_fields .translation-sort-fields' do
-          expect(page).to have_css('input[type="text"]', count: 6)
-        end
-      end
-
-      it 'allows users to translation sort fields', js: true do
-        click_link 'Search field labels'
-
-        within('#search_fields', visible: true) do
-          fill_in 'relevance', with: 'French Relevance'
-          click_button 'Save changes'
-        end
-
-        visit spotlight.search_exhibit_catalog_path(exhibit, q: '*', locale: 'fr')
-
-        expect(page).to have_css('#sort-dropdown', text: 'Trier par French Relevance', visible: true)
-      end
-    end
-  end
-
-  describe 'Browse categories' do
-    before do
-      FactoryBot.create(:search, exhibit: exhibit, title: 'Browse Category 1')
-
-      visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr')
-    end
-
-    it 'has a title and description for every browse category' do
-      within '#browse' do
-        expect(page).to have_css('input[type="text"]', count: 4)
-        expect(page).to have_css('textarea', count: 2)
-
-        expect(page).to have_field 'All exhibit items'
-        expect(page).to have_field 'Browse Category 1'
-        expect(page).to have_css('.form-text', text: 'All items in this exhibit.')
-      end
-    end
-
-    it 'redirects to the same form tab' do
-      click_link 'Browse categories'
-      within('#browse', visible: true) do
-        fill_in 'All exhibit items', with: "Tous les objets d'exposition"
-        click_button 'Save changes'
-      end
-
-      expect(page).to have_css '.nav-pills .nav-link.active', text: 'French'
-      expect(page).to have_css '.nav-tabs .nav-link.active', text: 'Browse categories'
-    end
-
-    it 'persists changes', js: true do
-      click_link 'Browse categories'
-
-      within('#browse', visible: true) do
-        fill_in 'All exhibit items', with: "Tous les objets d'exposition"
-
-        first('.translation-description-toggle').click
-
-        textarea = page.find('textarea')
-        textarea.set('Tous les articles de cette exposition.')
-
-        click_button 'Save changes'
-      end
-
-      expect(page).to have_css('.flash_messages', text: 'The exhibit was successfully updated.')
-
-      expect(exhibit.searches.first.title).to eq 'All exhibit items'
-      expect(exhibit.searches.first.long_description).to eq 'All items in this exhibit.'
-
-      I18n.locale = :fr
-      Translation.current_exhibit = exhibit
-      expect(exhibit.searches.first.title).to eq "Tous les objets d'exposition"
-      expect(exhibit.searches.first.long_description).to eq 'Tous les articles de cette exposition.'
-      I18n.locale = I18n.default_locale
-      Translation.current_exhibit = nil
-    end
-  end
-
-  describe 'Browse groups' do
-    before do
-      FactoryBot.create(:group, exhibit: exhibit, title: 'Browse Group 1')
-      FactoryBot.create(:group, exhibit: exhibit, title: 'Browse Group 2')
-
-      visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr')
-    end
-
-    it 'has a title browse group' do
-      within '#groups' do
-        expect(page).to have_css('input[type="text"]', count: 2)
-
-        expect(page).to have_field 'Browse Group 1'
-        expect(page).to have_field 'Browse Group 2'
-      end
-    end
-
-    it 'redirects to the same form tab' do
-      click_link 'Browse categories'
-      within('#groups', visible: true) do
-        fill_in 'Browse Group 1', with: 'parcourir le groupe 1'
-        click_button 'Save changes'
-      end
-
-      expect(page).to have_css '.nav-pills .nav-link.active', text: 'French'
-      expect(page).to have_css '.nav-tabs .nav-link.active', text: 'Browse groups'
-    end
-
-    it 'persists changes', js: true do
-      click_link 'Browse groups'
-
-      within('#groups', visible: true) do
-        fill_in 'Browse Group 1', with: 'parcourir le groupe 1'
-
-        click_button 'Save changes'
-      end
-
-      expect(page).to have_css('.flash_messages', text: 'The exhibit was successfully updated.')
-
-      expect(exhibit.groups.first.title).to eq 'Browse Group 1'
-
-      I18n.locale = :fr
-      Translation.current_exhibit = exhibit
-      expect(exhibit.groups.first.title).to eq 'parcourir le groupe 1'
-      I18n.locale = I18n.default_locale
-      Translation.current_exhibit = nil
-    end
-  end
-
-  describe 'home page translation table entry' do
-    let(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
-    let(:about_page) { FactoryBot.create(:about_page, exhibit: exhibit) }
-
-    before do
-      exhibit.home_page.clone_for_locale('fr').save
-      about_page.clone_for_locale('fr').tap { |p| p.published = true }.save
-      visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr', tab: 'pages')
-    end
-
-    it 'renders a disabled checkbox in the table' do
-      # home page should have a disabled checkbox
-      expect(page).to have_css('.translation-home-page-settings input[type="checkbox"][disabled]')
-      # feature page does not have a translation, so don't use checkbox
-      expect(page).not_to have_css('.translation-feature-page-settings input[type="checkbox"]')
-      # about page should have a checked checkbox
-      expect(page).to have_css('.translation-about-page-settings input[type="checkbox"][checked]')
-    end
-  end
-
-  describe 'translation progress counter', js: true do
-    before do
-      FactoryBot.create(:translation, exhibit: exhibit, locale: 'fr', key: "#{exhibit.slug}.title", value: 'Titre')
-    end
-
-    it 'counts existing and total available translations' do
-      visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr')
-      expect(page).to have_link('General 1/8')
-      expect(page).to have_link('Search field labels 0/16')
-      expect(page).to have_link('Browse categories 0/3')
-      expect(page).to have_link('Metadata field labels 0/17')
-    end
-  end
-end

data/spec/features/exhibits_index_spec.rb

@@ -1,55 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Exhibits index page', type: :feature do
-  context 'with multiple exhibits' do
-    let!(:exhibit) { FactoryBot.create(:exhibit, title: 'Some Exhibit Title') }
-    let!(:other_exhibit) { FactoryBot.create(:exhibit, title: 'Some Other Title') }
-
-    it 'shows some cards for each published exhibit' do
-      visit spotlight.exhibits_path
-
-      expect(page).to have_selector '.exhibit-card h2', text: 'Some Exhibit Title'
-    end
-
-    context 'with tagged exhibits' do
-      before do
-        exhibit.tag_list = %w[a]
-        other_exhibit.tag_list = %w[a b]
-
-        exhibit.save
-        other_exhibit.save
-      end
-
-      it 'shows controls to filter exhibits by tags' do
-        visit spotlight.exhibits_path
-
-        expect(page).to have_selector '.exhibit-card', count: 2
-
-        within '.tags' do
-          expect(page).to have_selector '.active', text: 'All'
-
-          click_link 'a'
-        end
-
-        expect(page).to have_selector '.exhibit-card', count: 2
-
-        within '.tags' do
-          expect(page).to have_selector '.active', text: 'a'
-          click_link 'b'
-        end
-
-        expect(page).to have_selector '.exhibit-card', count: 1
-      end
-    end
-  end
-
-  context 'with a single exhibit' do
-    let!(:exhibit) { FactoryBot.create(:exhibit, title: 'Some Exhibit Title') }
-
-    it 'redirects to the exhibit home page' do
-      visit spotlight.exhibits_path
-
-      expect(current_url).to eq spotlight.exhibit_root_url(exhibit)
-    end
-  end
-end

data/spec/features/feature_page_spec.rb

@@ -1,155 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Feature page', type: :feature, versioning: true do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  describe 'viewing the page' do
-    let!(:feature_page) do
-      FactoryBot.create(:feature_page, title: 'Parent Page', exhibit: exhibit)
-    end
-
-    it 'has <meta> tags' do
-      TopHat.current['twitter_card'] = nil
-      TopHat.current['opengraph'] = nil
-
-      visit spotlight.exhibit_feature_page_path(feature_page.exhibit, feature_page)
-
-      expect(page).to have_css "meta[name='twitter:title'][value='#{feature_page.title}']", visible: false
-      expect(page).to have_css "meta[property='og:site_name']", visible: false
-      expect(page).to have_css "meta[property='og:type'][content='article']", visible: false
-      expect(page).to have_css "meta[property='og:title'][content='#{feature_page.title}']", visible: false
-    end
-  end
-
-  describe 'sidebar' do
-    let!(:parent_feature_page) do
-      FactoryBot.create(:feature_page, title: 'Parent Page', exhibit: exhibit)
-    end
-    let!(:child_feature_page) do
-      FactoryBot.create(
-        :feature_page,
-        title: 'Child Page',
-        parent_page: parent_feature_page, exhibit: exhibit
-      )
-    end
-
-    describe 'when configured to display' do
-      before { parent_feature_page.update display_sidebar: true }
-
-      after { parent_feature_page.update display_sidebar: false }
-
-      it 'is present' do
-        visit spotlight.exhibit_feature_page_path(parent_feature_page.exhibit, parent_feature_page)
-        # the sidebar should display
-        within('#sidebar') do
-          # the current page should be the sidebar header
-          expect(page).to have_css('li', text: parent_feature_page.title)
-          # within the sidebar navigation
-          within('ol.sidenav') do
-            # there should be a link to the child page
-            expect(page).to have_css('li a', text: child_feature_page.title)
-          end
-        end
-      end
-    end
-
-    describe 'when configured to not display' do
-      before { parent_feature_page.update display_sidebar: false }
-
-      context 'with a child page' do
-        it 'is present anyway' do
-          visit spotlight.exhibit_feature_page_path(parent_feature_page.exhibit, parent_feature_page)
-          expect(page).to have_css('#sidebar')
-          expect(page).to have_content(child_feature_page.title)
-        end
-      end
-
-      context 'with an unpublished child page' do
-        before { child_feature_page.update published: false }
-
-        it 'does not be present' do
-          visit spotlight.exhibit_feature_page_path(parent_feature_page.exhibit, parent_feature_page)
-          expect(page).not_to have_css('#sidebar')
-          expect(page).not_to have_content(child_feature_page.title)
-        end
-      end
-    end
-  end
-
-  describe 'page options' do
-    before { login_as exhibit_curator }
-
-    describe 'publish' do
-      let!(:unpublished_page) { FactoryBot.create(:feature_page, published: false, exhibit: exhibit) }
-
-      it 'is updatable from the edit page' do
-        expect(unpublished_page).not_to be_published
-
-        visit spotlight.edit_exhibit_feature_page_path(unpublished_page.exhibit, unpublished_page)
-        expect(find('#feature_page_published')).not_to be_checked
-
-        check 'Publish'
-        click_button 'Save changes'
-
-        expect(unpublished_page.reload).to be_published
-
-        visit spotlight.edit_exhibit_feature_page_path(unpublished_page.exhibit, unpublished_page)
-        expect(find('#feature_page_published')).to be_checked
-      end
-    end
-
-    describe 'display_sidebar' do
-      let!(:feature_page) { FactoryBot.create(:feature_page, display_sidebar: false, exhibit: exhibit) }
-
-      before { feature_page.update display_sidebar: false }
-
-      it 'is updatable from the edit page' do
-        expect(feature_page).not_to be_display_sidebar
-
-        visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
-        expect(find('#feature_page_display_sidebar')).not_to be_checked
-
-        check 'Show sidebar'
-        click_button 'Save changes'
-
-        expect(feature_page.reload).to be_display_sidebar
-
-        visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
-        expect(find('#feature_page_display_sidebar')).to be_checked
-      end
-    end
-  end
-
-  describe 'page locking' do
-    before { login_as exhibit_curator }
-
-    let!(:feature_page) { FactoryBot.create(:feature_page, display_sidebar: false, exhibit: exhibit) }
-
-    it 'shows a lock message if someone is currently editing the page' do
-      # open the edit page
-      visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
-
-      # and then open the edit page again
-      visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
-
-      expect(page).to have_css '.alert'
-      within '.alert' do
-        expect(page).to have_content 'This page is currently being edited by ' + exhibit_curator.to_s
-      end
-    end
-
-    it 'releases the lock when the lock holder cancels edits', js: true do
-      # open the edit page
-      visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
-
-      click_on 'Cancel'
-      sleep 2
-
-      # and then open the edit page again
-      visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
-
-      expect(page).not_to have_css '.alert'
-    end
-  end
-end