blacklight-spotlight 3.4.0 → 3.4.1

data/spec/models/spotlight/browse_category_search_builder_spec.rb

@@ -1,51 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::BrowseCategorySearchBuilder do
-  class BrowseCategoryMockSearchBuilder < Blacklight::SearchBuilder
-    include Blacklight::Solr::SearchBuilderBehavior
-    include Spotlight::BrowseCategorySearchBuilder
-  end
-
-  subject { BrowseCategoryMockSearchBuilder.new(scope).with(blacklight_params) }
-
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:scope) do
-    double(blacklight_config: exhibit.blacklight_config, current_exhibit: exhibit, search_state_class: nil)
-  end
-  let(:solr_request) { Blacklight::Solr::Request.new }
-  let(:blacklight_params) { { browse_category_id: search.id } }
-  let(:search) { FactoryBot.create(:search, exhibit: exhibit, query_params: { sort: 'type', f: { genre_ssim: ['term'] }, q: 'search query' }) }
-
-  describe '#restrict_to_browse_category' do
-    it 'adds the search query parameters from the browse category' do
-      params = subject.to_hash.with_indifferent_access
-
-      expect(params).to include(
-        q: 'search query',
-        fq: ['{!term f=genre_ssim}term'],
-        sort: 'sort_type_ssi asc'
-      )
-    end
-
-    context 'with a user-provided query' do
-      let(:blacklight_params) { { browse_category_id: search.id, q: 'cats' } }
-
-      it 'uses the user-provided query to further restrict the search' do
-        params = subject.to_hash.with_indifferent_access
-        expect(params).not_to include(:q)
-        expect(params).to include(
-          json: {
-            query: {
-              bool: {
-                must: [
-                  { edismax: { query: 'cats' } },
-                  { edismax: { query: 'search query' } }
-                ]
-              }
-            }
-          }
-        )
-      end
-    end
-  end
-end

data/spec/models/spotlight/contact_email_spec.rb

@@ -1,48 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::ContactEmail, type: :model do
-  subject { described_class.new(exhibit: exhibit) }
-
-  let(:exhibit) { FactoryBot.build_stubbed(:exhibit) }
-
-  it { is_expected.not_to be_valid }
-
-  describe 'with an invalid email set' do
-    before { subject.email = '@-foo' }
-
-    it 'does not be valid' do
-      expect(subject).not_to be_valid
-      expect(subject.errors[:email]).to eq ['is not valid']
-    end
-  end
-
-  describe 'with a valid email set' do
-    before { subject.email = 'foo@example.com' }
-
-    it { is_expected.to be_valid }
-
-    describe '#send_devise_notification' do
-      it 'sends stuff' do
-        expect do
-          subject.send(:send_devise_notification, :confirmation_instructions, 'Q7PEPdLVxymsQL2_s_Rg', {})
-        end.to change { ActionMailer::Base.deliveries.count }.by(1)
-      end
-    end
-  end
-
-  describe '.confirmed' do
-    it 'scopes contacts to only confirmed contacts' do
-      a = exhibit.contact_emails.create(email: 'a@example.com')
-      if a.respond_to? :confirm
-        a.confirm
-      else
-        a.confirm!
-      end
-
-      b = exhibit.contact_emails.create(email: 'b@example.com')
-
-      expect(described_class.confirmed.to_a).to include a
-      expect(described_class.confirmed.to_a).not_to include b
-    end
-  end
-end

data/spec/models/spotlight/contact_form_spec.rb

@@ -1,94 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::ContactForm do
-  subject { described_class.new(name: 'Root', email: 'user@example.com') }
-
-  let(:exhibit) { FactoryBot.build_stubbed(:exhibit) }
-  let(:honeypot_field_name) { Spotlight::Engine.config.spambot_honeypot_email_field }
-
-  describe 'the email subject' do
-    it 'has a subject' do
-      expect(subject.headers[:subject]).to eq 'Blacklight exhibit feedback'
-    end
-
-    context 'with a current exhibit' do
-      before do
-        subject.current_exhibit = exhibit
-        exhibit.title = 'My exhibit'
-      end
-
-      it 'uses the site title in the email' do
-        expect(subject.headers[:subject]).to eq 'My exhibit exhibit feedback'
-      end
-    end
-
-    context 'with a site title' do
-      before do
-        Spotlight::Site.instance.update(title: 'Exhibits')
-      end
-
-      it 'uses the site title in the email' do
-        expect(subject.headers[:subject]).to eq 'Exhibits exhibit feedback'
-      end
-    end
-  end
-
-  context 'with a site-wide contact email' do
-    before { allow(Spotlight::Engine.config).to receive_messages default_contact_email: 'root@localhost' }
-
-    it 'sends the email to the configured contact' do
-      expect(subject.headers[:to]).to eq Spotlight::Engine.config.default_contact_email
-    end
-
-    context 'with exhibit-specific contacts' do
-      before do
-        subject.current_exhibit = exhibit
-        exhibit.contact_emails.create(email: 'curator@example.com', confirmed_at: Time.zone.now)
-      end
-
-      it 'appends exhibit-specific contacts as cc recipients' do
-        expect(subject.headers[:cc]).to eq 'curator@example.com'
-      end
-    end
-  end
-
-  context 'with exhibit-specific contacts' do
-    before do
-      subject.current_exhibit = exhibit
-      exhibit.contact_emails.create(email: 'curator@example.com', confirmed_at: Time.zone.now)
-      exhibit.contact_emails.create(email: 'addl_curator@example.com', confirmed_at: Time.zone.now)
-    end
-
-    it 'sends the email to the first contact' do
-      expect(subject.headers[:to]).to eq 'curator@example.com'
-    end
-
-    it 'appends exhibit-specific contacts as cc recipients' do
-      expect(subject.headers[:cc]).to eq 'curator@example.com, addl_curator@example.com'
-    end
-  end
-
-  context 'when validating feedback submission fields' do
-    it 'allows submissions that set a valid email address' do
-      subject.email = 'user@legitimatebusinesspersonssocialclub.biz'
-      subject.send("#{honeypot_field_name}=", '')
-      expect(subject).to be_valid
-    end
-
-    it 'rejects submissions that set an invalid email address' do
-      subject.email = 'user'
-      subject.send("#{honeypot_field_name}=", '')
-      expect(subject).not_to be_valid
-    end
-
-    it 'allows submissions that leave the spammer honeypot field blank' do
-      subject.send("#{honeypot_field_name}=", '')
-      expect(subject).to be_valid
-    end
-
-    it 'rejects submissions that set the spammer honeypot field' do
-      subject.send("#{honeypot_field_name}=", 'spam@spam.com')
-      expect(subject).not_to be_valid
-    end
-  end
-end

data/spec/models/spotlight/contact_image_spec.rb

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::ContactImage do
-  subject(:contact_image) do
-    described_class.new(iiif_tilesource: 'http://example.com/iiif/abc123/info.json')
-  end
-
-  it 'has the appropriate contact image size' do
-    expect(contact_image.iiif_url).to match(%r{/full/70,70/})
-  end
-end

data/spec/models/spotlight/contact_spec.rb

@@ -1,38 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::Contact, type: :model do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  before do
-    subject.exhibit = exhibit
-  end
-
-  describe '#show_in_sidebar' do
-    it 'is an attribute' do
-      subject.show_in_sidebar = false
-      subject.save
-      expect(subject.show_in_sidebar).to be_falsey
-    end
-
-    it 'is published by default' do
-      subject.save
-      expect(subject.show_in_sidebar).to be_truthy
-    end
-  end
-
-  describe '#fields' do
-    it 'show allow new fields to be configured' do
-      expect(subject.class.fields).not_to have_key(:new_field)
-      described_class.fields[:new_field] = {}
-      expect(subject.class.fields).to have_key(:new_field)
-    end
-  end
-
-  describe '#contact_info' do
-    it 'persisted symbolized keys' do
-      subject.contact_info = { 'some' => 'value' }
-      subject.save
-      expect(subject.contact_info).to include some: 'value'
-    end
-  end
-end

data/spec/models/spotlight/custom_field_spec.rb

@@ -1,204 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::CustomField, type: :model do
-  describe '#label' do
-    subject { described_class.new configuration: { 'label' => 'the configured label' }, field: 'foo_tesim' }
-
-    describe "when the exhibit doesn't have a config" do
-      its(:label) { is_expected.to eq 'the configured label' }
-    end
-
-    describe 'when the exhibit has a config' do
-      let(:exhibit) { FactoryBot.create(:exhibit) }
-
-      before { subject.exhibit = exhibit }
-
-      describe 'that overrides the label' do
-        before do
-          exhibit.blacklight_configuration.index_fields['foo_tesim'] = { 'label' => 'overridden' }
-        end
-
-        its(:label) { is_expected.to eq 'overridden' }
-      end
-
-      describe "that doesn't override the label" do
-        its(:label) { is_expected.to eq 'the configured label' }
-      end
-    end
-  end
-
-  describe '#label=' do
-    subject { described_class.new field: 'foo_tesim' }
-
-    describe "when the exhibit doesn't have a config" do
-      before { subject.label = 'the configured label' }
-
-      its(:configuration) { is_expected.to eq('label' => 'the configured label') }
-    end
-
-    describe 'when the exhibit has a config' do
-      let(:exhibit) { FactoryBot.create(:exhibit) }
-
-      before { subject.exhibit = exhibit }
-
-      describe 'that overrides the label' do
-        before do
-          exhibit.blacklight_configuration.index_fields['foo_tesim'] = { 'label' => 'overridden' }
-          subject.label = 'edited'
-        end
-
-        it 'has updated the exhibit' do
-          expect(subject.exhibit.blacklight_configuration.index_fields['foo_tesim']['label']).to eq 'edited'
-        end
-      end
-    end
-  end
-
-  describe '#field' do
-    let(:exhibit) { double(to_param: 'a', solr_document_sidecars: Spotlight::SolrDocumentSidecar.none) }
-
-    before do
-      subject.label = 'xyz'
-      subject.save
-
-      allow(Spotlight::RenameSidecarFieldJob).to receive(:perform_later)
-    end
-
-    it 'is auto-generated from the field label' do
-      expect(subject.field).to start_with 'xyz'
-    end
-
-    it 'ends in the text suffix if it is a text field' do
-      subject.field_type = 'text'
-      subject.save
-      expect(subject.field).to end_with '_tesim'
-    end
-
-    it 'ends in a string suffix if it is a vocab field' do
-      subject.field_type = 'vocab'
-      subject.save
-      expect(subject.field).to end_with '_ssim'
-    end
-
-    it 'begins with readonly if it is readonly' do
-      subject.readonly_field = true
-      subject.save
-      expect(subject.field).to start_with('readonly_')
-    end
-  end
-
-  describe '#solr_field' do
-    subject { custom_field.solr_field }
-
-    let(:exhibit) { FactoryBot.create(:exhibit) }
-    let(:custom_field) do
-      described_class.create(exhibit: exhibit, configuration: { 'label' => 'xyz' })
-    end
-
-    it 'is auto-generated from the field label' do
-      expect(subject).to eq "exhibit_#{exhibit.to_param}_xyz_tesim"
-    end
-
-    context 'with a solr field prefix configured' do
-      before do
-        allow(Spotlight::Engine.config.solr_fields).to receive(:prefix).and_return 'prefix_'
-      end
-
-      it 'uses the solr field prefix' do
-        expect(subject).to eq "prefix_exhibit_#{exhibit.to_param}_xyz_tesim"
-      end
-    end
-
-    context 'for a legacy solr field name' do
-      before do
-        custom_field.field = "exhibit_#{exhibit.to_param}_xyz_tesim"
-      end
-
-      it 'returns the original field name' do
-        expect(subject).to eq "exhibit_#{exhibit.to_param}_xyz_tesim"
-      end
-    end
-  end
-
-  describe '#configured_to_display?' do
-    let(:exhibit) { FactoryBot.create(:exhibit) }
-
-    before do
-      exhibit.blacklight_configuration.blacklight_config.view = { view_name: {} }
-      subject.exhibit = exhibit
-      subject.label = 'Label'
-      subject.field = 'foo_tesim'
-    end
-
-    it 'is truthy when a view has been configured true' do
-      exhibit.blacklight_configuration.blacklight_config.index_fields['foo_tesim'] =
-        Blacklight::Configuration::IndexField.new(label: 'Label', enabled: true, view_name: true)
-      subject.save
-
-      expect(subject).to be_configured_to_display
-    end
-
-    it 'is truthey for show views when enabled' do
-      exhibit.blacklight_configuration.blacklight_config.index_fields['foo_tesim'] =
-        Blacklight::Configuration::IndexField.new(label: 'Label', enabled: true, show: true)
-      subject.save
-
-      expect(subject).to be_configured_to_display
-    end
-
-    it 'is falsey when a few has not been configured true' do
-      exhibit.blacklight_configuration.blacklight_config.index_fields['foo_tesim'] =
-        Blacklight::Configuration::IndexField.new(label: 'Label', enabled: true, view_name: false)
-      subject.save
-
-      expect(subject).not_to be_configured_to_display
-    end
-
-    it 'is falsey when the field is not enabled' do
-      exhibit.blacklight_configuration.index_fields['foo_tesim'] = { 'label' => 'overridden', enabled: false, view_name: false }
-      subject.save
-
-      expect(subject).not_to be_configured_to_display
-    end
-  end
-
-  describe 'changing the field type' do
-    let(:exhibit) { FactoryBot.create(:exhibit) }
-
-    before do
-      subject.label = 'xyz'
-      subject.exhibit = exhibit
-      subject.save!
-    end
-
-    it 'changes the field name for the field' do
-      expect(subject.field).to end_with 'tesim'
-      subject.field_type = 'vocab'
-      subject.save
-      expect(subject.field).to end_with 'ssim'
-    end
-
-    it 'copies index field configuration to the new field name' do
-      subject.exhibit.blacklight_configuration.index_fields_will_change!
-      subject.exhibit.blacklight_configuration.index_fields[subject.field] = { value: true }
-      subject.exhibit.blacklight_configuration.save
-      expect(subject.exhibit.blacklight_configuration.index_fields).to have_key subject.field
-
-      subject.field_type = 'vocab'
-      subject.save
-      expect(subject.exhibit.blacklight_configuration.index_fields).to have_key subject.field
-      expect(subject.exhibit.blacklight_configuration.index_fields[subject.field]).to include value: true
-    end
-
-    it 'queues a job to reindex any documents with data in the old field' do
-      expect(Spotlight::RenameSidecarFieldJob).to receive(:perform_later).with(
-        exhibit,
-        subject.field, subject.field.sub('tesim', 'ssim'),
-        subject.slug, subject.slug
-      )
-
-      subject.field_type = 'vocab'
-      subject.save
-    end
-  end
-end

data/spec/models/spotlight/custom_search_field_spec.rb

@@ -1,56 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::CustomSearchField, type: :model do
-  describe '#label' do
-    subject { described_class.new configuration: { 'label' => 'the configured label' }, slug: 'foo' }
-
-    describe "when the exhibit doesn't have a config" do
-      its(:label) { is_expected.to eq 'the configured label' }
-    end
-
-    describe 'when the exhibit has a config' do
-      let(:exhibit) { FactoryBot.create(:exhibit) }
-
-      before { subject.exhibit = exhibit }
-
-      describe 'that overrides the label' do
-        before do
-          exhibit.blacklight_configuration.search_fields['foo'] = { 'label' => 'overridden' }
-        end
-
-        its(:label) { is_expected.to eq 'overridden' }
-      end
-
-      describe "that doesn't override the label" do
-        its(:label) { is_expected.to eq 'the configured label' }
-      end
-    end
-  end
-
-  describe '#label=' do
-    subject { described_class.new slug: 'foo' }
-
-    describe "when the exhibit doesn't have a config" do
-      before { subject.label = 'the configured label' }
-
-      its(:configuration) { is_expected.to eq('label' => 'the configured label') }
-    end
-
-    describe 'when the exhibit has a config' do
-      let(:exhibit) { FactoryBot.create(:exhibit) }
-
-      before { subject.exhibit = exhibit }
-
-      describe 'that overrides the label' do
-        before do
-          exhibit.blacklight_configuration.search_fields['foo'] = { 'label' => 'overridden' }
-          subject.label = 'edited'
-        end
-
-        it 'has updated the exhibit' do
-          expect(subject.exhibit.blacklight_configuration.search_fields['foo']['label']).to eq 'edited'
-        end
-      end
-    end
-  end
-end

data/spec/models/spotlight/custom_translation_extension_spec.rb

@@ -1,24 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::CustomTranslationExtension do
-  subject do
-    Class.new(ActiveRecord::Base) do
-      include Spotlight::CustomTranslationExtension
-    end
-  end
-
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  describe '.current_exhibit' do
-    it 'sets the current exhibit' do
-      subject.current_exhibit = exhibit
-      expect(subject.current_exhibit).to eq exhibit
-    end
-
-    it 'reloads the i18n' do
-      allow(I18n.backend).to receive(:reload!)
-
-      subject.current_exhibit = exhibit
-    end
-  end
-end