blacklight-spotlight 3.4.0 → 3.4.1

data/spec/models/spotlight/blacklight_configuration_spec.rb

@@ -1,649 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::BlacklightConfiguration, type: :model do
-  subject { described_class.new }
-
-  let(:blacklight_config) { Blacklight::Configuration.new }
-
-  before do
-    blacklight_config.configure do |config|
-      config.add_sort_field 'relevance', sort: 'score desc, sort_title_ssi asc', label: 'Relevance'
-      config.add_sort_field 'title', sort: 'sort_title_ssi asc', label: 'Title'
-      config.add_sort_field 'type', sort: 'sort_type_ssi asc', label: 'Type'
-      config.add_sort_field 'date', sort: 'sort_date_dtsi asc', label: 'Date'
-      config.add_sort_field 'source', sort: 'sort_source_ssi asc', label: 'Source'
-      config.add_sort_field 'identifier', sort: 'id asc', label: 'Identifier'
-    end
-    allow(subject).to receive_messages default_blacklight_config: blacklight_config
-    subject.exhibit = FactoryBot.create(:exhibit)
-  end
-
-  it 'is expected to be versioned' do
-    expect(subject).to be_versioned
-  end
-
-  it 'touches the exhibit' do
-    expect(subject.exhibit).to receive :touch
-    subject.save!
-  end
-
-  it 'adds a default thumbnail field' do
-    expect(subject.blacklight_config.index.thumbnail_field).to eq Spotlight::Engine.config.thumbnail_field
-  end
-
-  describe 'facet fields' do
-    it 'has facet fields' do
-      expect(subject.facet_fields).to be_empty
-      subject.facet_fields['title_facet'] = {}
-      subject.facet_fields['author_facet'] = {}
-      expect(subject.facet_fields.keys).to eq %w[title_facet author_facet]
-    end
-
-    it 'filters blank values' do
-      subject.facet_fields['title_facet'] = { something: '' }
-      subject.valid?
-      expect(subject.facet_fields['title_facet'].keys).not_to include :something
-    end
-
-    it 'filters the upstream blacklight config' do
-      subject.facet_fields['a'] = { show: true }
-      subject.facet_fields['b'] = { show: false }
-      subject.facet_fields['d'] = { show: true }
-
-      blacklight_config.add_facet_field 'a'
-      blacklight_config.add_facet_field 'b'
-      blacklight_config.add_facet_field 'c'
-
-      expect(subject.blacklight_config.facet_fields['a'].show).to be_truthy
-      expect(subject.blacklight_config.facet_fields['a'].enabled).to be_truthy
-      expect(subject.blacklight_config.facet_fields['b'].show).to be_falsey
-      expect(subject.blacklight_config.facet_fields['b'].enabled).to be_falsey
-      expect(subject.blacklight_config.facet_fields['d']).to be_nil
-    end
-
-    it 'orders the fields by weight' do
-      subject.facet_fields['a'] = { show: true, weight: 3 }
-      subject.facet_fields['b'] = { show: true, weight: 5 }
-      subject.facet_fields['c'] = { show: true, weight: 1 }
-
-      blacklight_config.add_facet_field 'a'
-      blacklight_config.add_facet_field 'b'
-      blacklight_config.add_facet_field 'c'
-
-      expect(subject.blacklight_config.facet_fields.keys).to eq %w[c a b]
-    end
-
-    it 'allows the facet sort to be configured' do
-      subject.facet_fields['a'] = { sort: 'count' }
-      subject.facet_fields['b'] = { sort: 'index' }
-
-      blacklight_config.add_facet_field 'a'
-      blacklight_config.add_facet_field 'b'
-
-      expect(subject.blacklight_config.facet_fields['a'].sort).to eq 'count'
-      expect(subject.blacklight_config.facet_fields['b'].sort).to eq 'index'
-    end
-
-    it 'respects upstream configuration that disables the field entirely' do
-      blacklight_config.add_facet_field 'a', if: false
-      expect(subject.blacklight_config.facet_fields['a'].if).to eq false
-    end
-
-    context 'custom fields' do
-      it 'includes any custom fields' do
-        allow(subject).to receive_messages(custom_facet_fields: { 'a' => double(if: nil, :if= => true, merge!: true, validate!: true, normalize!: true) })
-        expect(subject.blacklight_config.facet_fields).to include('a')
-      end
-
-      it 'defaults to not showing a custom field in the facets' do
-        field = double('field', new_record?: false, field: 'a', solr_field: 'a', configuration: {})
-        custom_fields = double('custom_fields', facetable: [field], reject: [])
-        allow(custom_fields).to receive(:map).and_yield(field)
-        allow(subject.exhibit).to receive(:custom_fields).and_return(custom_fields)
-        subject.facet_fields = { 'a' => { enabled: '1', label: 'Label' } }
-        expect(subject.blacklight_config.facet_fields).to include('a')
-        expect(subject.blacklight_config.facet_fields['a'].show).to be_falsey
-        expect(subject.blacklight_config.facet_fields['a'].if).to eq :field_enabled?
-        expect(subject.blacklight_config.facet_fields['a'].enabled).to eq false
-        expect(subject.blacklight_config.facet_fields['a'].limit).to eq true
-        expect(subject.blacklight_config.facet_fields['a'].original).to be_blank
-      end
-
-      it 'allows the application configuration to override custom field configuration' do
-        blacklight_config.add_index_field 'a', some_param: true, enabled: false
-        subject.exhibit.custom_fields.create! field: 'a'
-
-        expect(subject.blacklight_config.index_fields['a'].custom_field).to eq true
-        expect(subject.blacklight_config.index_fields['a'].some_param).to eq true
-        expect(subject.blacklight_config.index_fields['a'].enabled).to eq false
-      end
-    end
-
-    context 'exhibit fields' do
-      before do
-        # undo the stubbing we've used elsewhere..
-        allow(subject).to receive(:default_blacklight_config).and_call_original
-        allow(Spotlight::Engine).to receive_messages blacklight_config: blacklight_config
-      end
-
-      it 'injects a tags facet' do
-        expect(subject.blacklight_config.facet_fields).to include 'exhibit_tags'
-      end
-    end
-  end
-
-  describe 'index fields' do
-    it 'has index fields' do
-      expect(subject.index_fields).to be_empty
-      subject.index_fields['title'] = {}
-      subject.index_fields['author'] = {}
-      expect(subject.index_fields.keys).to eq %w[title author]
-    end
-
-    it 'defaults to displaying all index fields if no exhibit-specific configuration is set' do
-      blacklight_config.add_index_field 'a'
-      blacklight_config.add_index_field 'b'
-      blacklight_config.add_index_field 'c'
-
-      expect(subject.blacklight_config.index_fields['a'].enabled).to be_truthy
-      expect(subject.blacklight_config.index_fields['a'].list).to be_truthy
-      expect(subject.blacklight_config.index_fields['b'].enabled).to be_truthy
-      expect(subject.blacklight_config.index_fields['b'].list).to be_truthy
-      expect(subject.blacklight_config.index_fields['c'].enabled).to be_truthy
-      expect(subject.blacklight_config.index_fields['c'].list).to be_truthy
-    end
-
-    it 'honors field specfic display settings set in the field configuration' do
-      blacklight_config.add_index_field 'a'
-      blacklight_config.add_index_field 'b', list: false
-
-      expect(subject.blacklight_config.index_fields['a'].list).to be_truthy
-      expect(subject.blacklight_config.index_fields['b'].list).to be_falsey
-    end
-
-    it 'filters upstream fields that are always disabled' do
-      blacklight_config.add_index_field 'a', if: false
-      expect(subject.blacklight_config.index_fields).not_to have_key 'a'
-    end
-
-    it 'filters blank values' do
-      subject.index_fields['title'] = { something: '' }
-      subject.valid?
-      expect(subject.index_fields['title'].keys).not_to include :something
-    end
-
-    it 'filters the upstream blacklight config' do
-      subject.index_fields['a'] = { enabled: true, list: true }
-      subject.index_fields['c'] = { enabled: false, list: false }
-      subject.index_fields['d'] = { enabled: true, list: true }
-
-      blacklight_config.add_index_field 'a'
-      blacklight_config.add_index_field 'b'
-      blacklight_config.add_index_field 'c'
-
-      expect(subject.blacklight_config.index_fields['a'].enabled).to be_truthy
-      expect(subject.blacklight_config.index_fields['a'].list).to be_truthy
-      expect(subject.blacklight_config.index_fields['b'].enabled).to be_falsey
-      expect(subject.blacklight_config.index_fields['b'].list).to be_falsey
-      expect(subject.blacklight_config.index_fields['d']).to be_nil
-    end
-
-    it 'includes configured show fields, but disable them for index views' do
-      blacklight_config.add_show_field 'a'
-      expect(subject.blacklight_config.index_fields).to have_key 'a'
-      expect(subject.blacklight_config.index_fields['a'].enabled).to be_truthy
-      expect(subject.blacklight_config.index_fields['a'].show).to be_truthy
-      expect(subject.blacklight_config.index_fields['a'].list).to be_falsey
-    end
-
-    it 'filters show fields that are always disabled' do
-      blacklight_config.add_show_field 'a', if: false
-      expect(subject.blacklight_config.index_fields).not_to have_key 'a'
-    end
-
-    it 'includes persisted configurations for show fields' do
-      subject.index_fields['a'] = { enabled: true, list: true }
-      blacklight_config.add_show_field 'a'
-      expect(subject.blacklight_config.index_fields).to have_key 'a'
-      expect(subject.blacklight_config.index_fields['a'].enabled).to be_truthy
-      expect(subject.blacklight_config.index_fields['a'].list).to be_truthy
-    end
-
-    it 'applies immutable values from the configuration' do
-      blacklight_config.add_index_field 'a', immutable: { something: 'set_in_configuration', another: 'immutable' }
-      subject.index_fields['a'] = { something: 'set_in_db' }
-      expect(subject.blacklight_config.index_fields['a'].something).to eq 'set_in_configuration'
-      expect(subject.blacklight_config.index_fields['a'].another).to eq 'immutable'
-    end
-
-    context 'custom fields' do
-      it 'includes any custom fields' do
-        subject.index_fields['a'] = { enabled: true, list: true }
-        allow(subject).to receive_messages(custom_index_fields: { 'a' => Blacklight::Configuration::IndexField.new(field: 'a') })
-        expect(subject.blacklight_config.index_fields).to include('a')
-      end
-
-      it 'defaults to showing a custom field on the show view' do
-        allow(subject).to receive_messages(custom_index_fields: { 'a' => Blacklight::Configuration::IndexField.new(field: 'a') })
-        expect(subject.blacklight_config.index_fields).to include('a')
-        expect(subject.blacklight_config.index_fields['a'].show).to be_truthy
-        expect(subject.blacklight_config.index_fields['a'].enabled).to be_truthy
-      end
-
-      it 'uses explicit configuration to override custom field defaults' do
-        subject.index_fields['a'] = { show: false }
-        allow(subject).to receive_messages(custom_index_fields: { 'a' => Blacklight::Configuration::IndexField.new(field: 'a') })
-        expect(subject.blacklight_config.index_fields).to include('a')
-        expect(subject.blacklight_config.index_fields['a'].show).to be_falsey
-      end
-    end
-
-    it 'prefers the label stored in index fields' do
-      subject.index_fields['a'] = { enabled: true, list: true, label: 'updated val' }
-      allow(subject).to receive_messages(custom_index_fields: { 'a' => Blacklight::Configuration::IndexField.new(field: 'a', label: 'Initial value') })
-      expect(subject.blacklight_config.index_fields['a'].label).to eq 'updated val'
-    end
-
-    it 'filters the upstream blacklight config with respect for view types' do
-      subject.index_fields['a'] = { enabled: true, list: true, gallery: false }
-      subject.index_fields['b'] = { enabled: true, list: false, gallery: true }
-      subject.index_fields['c'] = { enabled: false, list: true, gallery: false }
-      subject.index_fields['d'] = { enabled: true, list: false, gallery: true }
-      subject.index_fields['e'] = { enabled: true, list: true, gallery: false }
-
-      blacklight_config.add_index_field 'a'
-      blacklight_config.add_index_field 'b'
-      blacklight_config.add_index_field 'c'
-      blacklight_config.add_index_field 'd'
-
-      expect(subject.blacklight_config.index_fields.select { |_k, x| x.list }).to include('a')
-      expect(subject.blacklight_config.index_fields.select { |_k, x| x.gallery }).to include('b', 'd')
-      expect(subject.blacklight_config.index_fields.select { |_k, x| x.list }).not_to include('b', 'd')
-      expect(subject.blacklight_config.index_fields.select { |_k, x| x.gallery }).not_to include('a', 'c')
-      expect(subject.blacklight_config.index_fields.select { |_k, x| x.list }).to have(2).fields
-      expect(subject.blacklight_config.index_fields.select { |_k, x| x.list && x.enabled }).to have(1).fields
-      expect(subject.blacklight_config.index_fields.select { |_k, x| x.gallery }).to have(2).fields
-    end
-
-    it 'filters the upstream blacklight config for show fields' do
-      subject.index_fields['a'] = { enabled: true, show: true }
-      subject.index_fields['c'] = { enabled: false, show: false }
-      subject.index_fields['d'] = { enabled: true, show: false }
-
-      blacklight_config.add_index_field 'a'
-      blacklight_config.add_index_field 'b'
-      blacklight_config.add_index_field 'c'
-
-      expect(subject.blacklight_config.show_fields.select { |_k, x| x.show && x.enabled }).to include('a')
-      expect(subject.blacklight_config.show_fields.select { |_k, x| x.show && x.enabled }).not_to include('b', 'd')
-      expect(subject.blacklight_config.show_fields.select { |_k, x| x.show && x.enabled }).to have(1).fields
-    end
-
-    it 'includes any custom fields' do
-      subject.index_fields['a'] = { enabled: true, show: true }
-
-      allow(subject).to receive_messages(custom_index_fields: { 'a' => Blacklight::Configuration::IndexField.new(field: 'a') })
-
-      expect(subject.blacklight_config.show_fields).to include('a')
-    end
-
-    it 'orders the fields by weight' do
-      subject.index_fields['a'] = { enabled: true, weight: 3, list: true }
-      subject.index_fields['b'] = { enabled: true, weight: 5, list: true }
-      subject.index_fields['c'] = { enabled: true, weight: 1, list: true }
-
-      blacklight_config.add_show_field 'a'
-      blacklight_config.add_index_field 'b'
-      blacklight_config.add_index_field 'c'
-
-      expect(subject.blacklight_config.index_fields.keys).to eq %w[c a b]
-    end
-
-    it 'orders the fields by weight' do
-      subject.index_fields['a'] = { enabled: true, weight: 3, show: true }
-      subject.index_fields['b'] = { enabled: true, weight: 5, show: true }
-      subject.index_fields['c'] = { enabled: true, weight: 1, show: true }
-
-      blacklight_config.add_index_field 'a'
-      blacklight_config.add_index_field 'b'
-      blacklight_config.add_index_field 'c'
-
-      expect(subject.blacklight_config.show_fields.keys).to eq %w[c a b]
-    end
-
-    context 'title only configuration' do
-      before do
-        blacklight_config.configure do |config|
-          config.view.gallery(title_only_by_default: true)
-          config.add_index_field 'a'
-        end
-      end
-
-      it 'only shows titles (i.e., no metadata) for gallery view' do
-        expect(subject.blacklight_config.index_fields['a'][:list]).to eq true
-        expect(subject.blacklight_config.index_fields['a'][:gallery]).to eq false
-      end
-    end
-  end
-
-  describe 'a newly created instance' do
-    before do
-      subject.save!
-    end
-
-    describe 'should have default values' do
-      its(:sort_fields) do
-        is_expected.to eq('identifier' => { enabled: true },
-                          'relevance' => { enabled: true },
-                          'date' => { enabled: true },
-                          'source' => { enabled: true },
-                          'title' => { enabled: true },
-                          'type' => { enabled: true })
-      end
-
-      its(:search_fields) do
-        is_expected.to eq('all_fields' => { enabled: true },
-                          'title' => { enabled: true },
-                          'author' => { enabled: true })
-      end
-
-      its(:default_per_page) { is_expected.to eq 10 }
-      its(:document_index_view_types) { is_expected.to match_array ::CatalogController.blacklight_config.view.keys.map(&:to_s) }
-    end
-  end
-
-  describe 'sort fields' do
-    it 'has sort fields' do
-      expect(subject.sort_fields).to be_empty
-      subject.sort_fields['title'] = {}
-      subject.sort_fields['author'] = {}
-      expect(subject.sort_fields.keys).to eq %w[title author]
-    end
-
-    it 'filters blank values' do
-      subject.sort_fields['title'] = { something: '' }
-      subject.valid?
-      expect(subject.sort_fields['title'].keys).not_to include :something
-    end
-
-    it 'filters the upstream blacklight config' do
-      subject.sort_fields['a'] = { enabled: true }
-      subject.sort_fields['c'] = { enabled: true }
-      subject.sort_fields['d'] = { enabled: true }
-
-      blacklight_config.add_sort_field 'a'
-      blacklight_config.add_sort_field 'b'
-      blacklight_config.add_sort_field 'c'
-
-      expect(subject.blacklight_config.sort_fields.select { |_k, v| v.enabled == true }).to include('a', 'c')
-      expect(subject.blacklight_config.sort_fields.select { |_k, v| v.enabled == true }).not_to include('b', 'd')
-    end
-
-    it 'is disabled when enabled = false' do
-      blacklight_config.add_sort_field 'a', enabled: false
-      expect(subject.blacklight_config.sort_fields['a'].enabled).to eq false
-    end
-  end
-
-  describe 'search fields' do
-    it 'has search fields' do
-      expect(subject.search_fields).to be_empty
-      subject.search_fields['title'] = {}
-      subject.search_fields['author'] = {}
-      expect(subject.search_fields.keys).to eq %w[title author]
-    end
-
-    it 'filters blank values' do
-      subject.search_fields['title'] = { something: '' }
-      subject.valid?
-      expect(subject.search_fields['title'].keys).not_to include :something
-    end
-
-    it 'filters the upstream blacklight config' do
-      subject.search_fields['a'] = { enabled: true }
-      subject.search_fields['c'] = { enabled: true }
-      subject.search_fields['d'] = { enabled: true }
-
-      blacklight_config.add_search_field 'a'
-      blacklight_config.add_search_field 'b'
-      blacklight_config.add_search_field 'c'
-
-      expect(subject.blacklight_config.search_fields.select { |_k, v| v.enabled == true }).to include('a', 'c')
-      expect(subject.blacklight_config.search_fields.select { |_k, v| v.enabled == true }).not_to include('b', 'd')
-    end
-
-    it 'respects upstream configuration that disables the field entirely' do
-      blacklight_config.add_search_field 'a', if: false
-      expect(subject.blacklight_config.search_fields['a'].if).to eq false
-    end
-
-    it 'is disabled when enabled = false' do
-      blacklight_config.add_search_field 'a', enabled: false
-      expect(subject.blacklight_config.search_fields['a'].enabled).to eq false
-    end
-
-    context 'custom fields' do
-      it 'includes any custom fields' do
-        allow(subject).to receive_messages(custom_search_fields: { 'a' => Blacklight::Configuration::SearchField.new(field: 'a') })
-        expect(subject.blacklight_config.search_fields).to include('a')
-      end
-    end
-  end
-
-  describe 'per page' do
-    it 'has per page configuration' do
-      expect(subject.per_page).to be_empty
-      subject.per_page << 10 << 50
-      expect(subject.per_page).to eq [10, 50]
-    end
-
-    it 'filters blank values' do
-      subject.per_page << ''
-      subject.valid?
-      expect(subject.per_page).not_to include ''
-    end
-
-    it 'filters the upstream blacklight config' do
-      subject.per_page = [10, 50, 1000]
-      blacklight_config.per_page = [1, 10, 50, 100]
-
-      expect(subject.blacklight_config.per_page).to eq [10, 50]
-    end
-  end
-
-  describe '#default_per_page' do
-    it 'is the first per page option by default' do
-      expect(subject.blacklight_config.default_per_page).to eq 10
-    end
-
-    it "is set from the model's default_per_page" do
-      subject.default_per_page = 50
-      expect(subject.blacklight_config.default_per_page).to eq 50
-    end
-  end
-
-  describe 'document_index_view_types' do
-    it 'has index view configuration' do
-      expect(subject.document_index_view_types).to be_empty
-      subject.document_index_view_types << 'list' << 'gallery'
-      expect(subject.document_index_view_types).to eq %w[list gallery]
-    end
-
-    it 'filters blank values' do
-      subject.document_index_view_types << ''
-      subject.valid?
-      expect(subject.document_index_view_types).not_to include ''
-    end
-
-    # rubocop:disable RSpec/PredicateMatcher
-    it 'filters the upstream blacklight config' do
-      subject.document_index_view_types = %w[list gallery unknown]
-      blacklight_config.view.list!
-      blacklight_config.view.gallery!
-      blacklight_config.view.something!
-
-      expect(subject.blacklight_config.view.keys).to include :list, :gallery, :something
-      expect(subject.blacklight_config.view.select { |k, v| v.key == k && v.if == :enabled_in_spotlight_view_type_configuration? }.any?).to be_truthy
-    end
-    # rubocop:enable RSpec/PredicateMatcher
-
-    it 'passes through the blacklight configuration when not set' do
-      blacklight_config.view.list!
-      blacklight_config.view.gallery!
-      blacklight_config.view.something!
-      expect(subject.blacklight_config.view.keys.map(&:to_s)).to include(*blacklight_config.view.keys.map(&:to_s))
-    end
-  end
-
-  describe 'default_solr_params' do
-    it 'has default solr params configuration' do
-      expect(subject.default_solr_params).to be_empty
-      subject.default_solr_params[:qt] = 'custom_request_handler'
-      expect(subject.default_solr_params[:qt]).to eq 'custom_request_handler'
-    end
-
-    it 'merges with the blacklight config' do
-      blacklight_config.default_solr_params = { qt: 'xyz', rows: 10 }
-      subject.default_solr_params[:qt] = 'abc'
-      expect(subject.blacklight_config.default_solr_params).to include(:qt, :rows)
-      expect(subject.blacklight_config.default_solr_params[:qt]).to eq 'abc'
-    end
-  end
-
-  describe 'show' do
-    it 'has show view configuration' do
-      expect(subject.show).to be_empty
-      subject.show[:key] = 'some value'
-      expect(subject.show[:key]).to eq 'some value'
-    end
-
-    it 'merges with the blacklight config' do
-      blacklight_config.show.title_field = 'xyz'
-      subject.show[:title_field] = 'abc'
-      expect(subject.blacklight_config.show.title_field).to eq 'abc'
-    end
-  end
-
-  describe 'index' do
-    it 'has index view configuration' do
-      expect(subject.index).to be_empty
-      subject.index[:key] = 'some value'
-      expect(subject.index[:key]).to eq 'some value'
-    end
-
-    it 'merges with the blacklight config' do
-      blacklight_config.index.title_field = 'xyz'
-      subject.index[:title_field] = 'abc'
-      expect(subject.blacklight_config.index.title_field).to eq 'abc'
-    end
-  end
-
-  describe '#custom_facet_fields' do
-    it 'converts exhibit-specific fields to Blacklight configurations' do
-      allow(subject.exhibit).to receive_message_chain(:custom_fields, facetable: [
-                                                        stub_model(Spotlight::CustomField, field: 'abc', configuration: { a: 1 }, exhibit: subject.exhibit),
-                                                        stub_model(Spotlight::CustomField, field: 'xyz', configuration: { x: 2 }, exhibit: subject.exhibit)
-                                                      ])
-
-      expect(subject.custom_facet_fields).to include 'abc', 'xyz'
-      expect(subject.custom_facet_fields['abc']).to be_a_kind_of Blacklight::Configuration::Field
-      expect(subject.custom_facet_fields['abc'].a).to eq 1
-      expect(subject.custom_facet_fields['abc'].custom_field).to eq true
-    end
-  end
-
-  describe '#custom_index_fields' do
-    it 'converts exhibit-specific fields to Blacklight configurations' do
-      allow(subject.exhibit).to receive_messages(custom_fields: [
-                                                   stub_model(Spotlight::CustomField, field: 'abc', configuration: { a: 1 }, exhibit: subject.exhibit),
-                                                   stub_model(Spotlight::CustomField, field: 'xyz', configuration: { x: 2 }, exhibit: subject.exhibit)
-                                                 ])
-      custom_index_fields = subject.custom_index_fields(blacklight_config)
-      expect(custom_index_fields).to include 'abc', 'xyz'
-      expect(custom_index_fields['abc']).to be_a_kind_of Blacklight::Configuration::Field
-      expect(custom_index_fields['abc'].a).to eq 1
-      expect(custom_index_fields['abc'].custom_field).to eq true
-    end
-  end
-
-  describe '#custom_search_fields' do
-    it 'converts exhibit-specific fields to Blacklight configurations' do
-      allow(subject.exhibit).to receive_messages(custom_search_fields: [
-                                                   stub_model(Spotlight::CustomSearchField, field: 'abc', slug: 'a', exhibit: subject.exhibit),
-                                                   stub_model(Spotlight::CustomSearchField, field: 'xyz', slug: 'b', exhibit: subject.exhibit)
-                                                 ])
-      custom_search_fields = subject.custom_search_fields(blacklight_config)
-      expect(custom_search_fields).to include 'a', 'b'
-      expect(custom_search_fields['a']).to be_a_kind_of Blacklight::Configuration::Field
-      expect(custom_search_fields['a'].solr_parameters).to eq(qf: 'abc')
-      expect(custom_search_fields['a'].custom_field).to eq true
-    end
-  end
-
-  describe 'autocomplete configuration' do
-    before do
-      # undo the stubbing we've used elsewhere..
-      allow(subject).to receive(:default_blacklight_config).and_call_original
-      blacklight_config.show.title_field = 'x'
-      allow(Spotlight::Engine).to receive_messages blacklight_config: blacklight_config.deep_copy
-    end
-
-    context 'with the default search field' do
-      let(:search_field) do
-        subject.blacklight_config.search_fields[Spotlight::Engine.config.autocomplete_search_field]
-      end
-
-      it 'is hidden from the search field selector' do
-        expect(search_field.if).to eq false
-      end
-
-      it "uses the engine's autocomplete parameters" do
-        expect(search_field.solr_parameters).to include Spotlight::Engine.config.default_autocomplete_params
-      end
-
-      it 'includes the relevant fields' do
-        Spotlight::Engine.blacklight_config.show.title_field = 'some_field'
-        expect(search_field.solr_parameters).to have_key :fl
-        expect(search_field.solr_parameters[:fl]).to include 'id'
-        expect(search_field.solr_parameters[:fl]).to include 'some_field'
-        expect(search_field.solr_parameters[:fl]).to include 'thumbnail_url_ssm'
-      end
-    end
-  end
-
-  describe '#document_index_view_types' do
-    it 'passes arrays through' do
-      array = [1, 2, 3]
-      subject.document_index_view_types = array
-      expect(subject.document_index_view_types).to match_array array
-    end
-
-    it 'is simplified from a hash to an array' do
-      checkboxes_from_form = { 'list' => '1', 'gallery' => '1', 'map' => '0' }
-      subject.document_index_view_types = checkboxes_from_form
-      expect(subject.document_index_view_types).to match_array %w[list gallery]
-    end
-  end
-
-  describe '#document_index_view_types_selected_hash' do
-    before do
-      subject.default_blacklight_config.view.list!
-      subject.default_blacklight_config.view.gallery!
-      subject.default_blacklight_config.view.whatever!
-      subject.default_blacklight_config.view.rss.if = false
-      subject.document_index_view_types = %w[list gallery rss]
-    end
-
-    it 'includes selected view types as the value true' do
-      expect(subject.document_index_view_types_selected_hash.to_h).to include list: true, gallery: true
-    end
-
-    it 'disabled view types use the value false' do
-      expect(subject.document_index_view_types_selected_hash.to_h).to include whatever: false
-    end
-
-    it 'excludes view types disabled by configuration (not by curator settings)' do
-      expect(subject.document_index_view_types_selected_hash.to_h).not_to include :rss
-    end
-  end
-end