blacklight-spotlight 3.4.0 → 3.4.1

data/spec/features/home_page_spec.rb

@@ -1,102 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Home page', type: :feature, versioning: true do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  before { login_as exhibit_curator }
-
-  it 'exists by default on exhibits' do
-    visit spotlight.exhibit_dashboard_path(exhibit)
-    click_link 'Feature pages'
-    expect(page).to have_selector 'h2', text: 'Homepage'
-    expect(page).to have_selector 'h3.card-title', text: 'Exhibit home'
-  end
-
-  it 'allows users to edit the home page title' do
-    visit spotlight.exhibit_dashboard_path(exhibit)
-    click_link 'Feature pages'
-    within('.home_page') do
-      click_link 'Edit'
-    end
-    fill_in 'home_page_title', with: 'New Home Page Title'
-    click_button 'Save changes'
-    expect(page).to have_content('The home page was successfully updated.')
-
-    within '.dropdown-menu' do
-      click_link 'Exhibit dashboard'
-    end
-    click_link 'Feature pages'
-    expect(page).to have_content 'New Home Page Title'
-    expect(page).to have_selector '.card-title a', text: 'New Home Page Title'
-  end
-
-  it 'redirects back to the correct home page URL after updating (no format param to interfere w/ faceting)' do
-    visit spotlight.exhibit_home_page_path(exhibit)
-
-    click_link 'Edit'
-    click_button 'Save changes'
-
-    expect(page.current_url).to eq spotlight.exhibit_home_page_url(exhibit)
-  end
-
-  it 'has working facet links' do
-    visit spotlight.exhibit_home_page_path(exhibit)
-    click_button 'Genre'
-    click_link 'map'
-    expect(page).to have_content exhibit.title
-    expect(page).to have_content 'You searched for: Genre map'
-  end
-
-  it 'has a search box' do
-    visit spotlight.exhibit_home_page_path(exhibit)
-    fill_in 'q', with: 'query'
-    click_button 'Search'
-
-    expect(page).to have_content exhibit.title
-    expect(page).to have_content 'You searched for: query'
-  end
-
-  it 'has <meta> tags' do
-    TopHat.current['twitter_card'] = nil
-    TopHat.current['opengraph'] = nil
-    Spotlight::Site.instance.update(title: 'some title')
-
-    visit spotlight.exhibit_home_page_path(exhibit)
-
-    expect(page).to have_css "meta[name='twitter:card'][value='summary']", visible: false
-    expect(page).to have_css "meta[name='twitter:url'][value='#{spotlight.exhibit_root_url(exhibit)}']", visible: false
-    expect(page).to have_css "meta[property='og:site_name'][content='#{Spotlight::Site.instance.title}']", visible: false
-  end
-
-  describe 'page options on edit form' do
-    describe 'show title' do
-      let(:home_page) { FactoryBot.create(:home_page, display_title: false, exhibit: exhibit) }
-
-      it 'is updatable from the edit page' do
-        expect(home_page.display_title).to be_falsey
-
-        visit spotlight.edit_exhibit_home_page_path(home_page.exhibit, home_page)
-        expect(find('#home_page_display_title')).not_to be_checked
-
-        check 'Show title'
-        click_button 'Save changes'
-
-        visit spotlight.edit_exhibit_home_page_path(home_page.exhibit, home_page)
-        expect(find('#home_page_display_title')).to be_checked
-      end
-    end
-  end
-
-  describe 'when configured to not display sidebar' do
-    before do
-      exhibit.home_page.display_sidebar = false
-      exhibit.home_page.save
-    end
-
-    it 'does not display the facet sidebar' do
-      visit spotlight.exhibit_home_page_path(exhibit)
-      expect(page).not_to have_css('#sidebar')
-    end
-  end
-end

data/spec/features/import_exhibit_spec.rb

@@ -1,58 +0,0 @@
-# frozen_string_literal: true
-
-require 'tempfile'
-
-describe 'Allow exhibit admins to import and export content from an exhibit', type: :feature, js: true do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:user) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-
-  before do
-    allow(Spotlight::ReindexExhibitJob).to receive(:perform_later).and_return(true) if Rails.version < '6'
-
-    login_as user
-  end
-
-  pending 'should allow admins to export content from an exhibit' do
-    pending(%(There's not really any good way to test the contents of a
-downloaded file with Poltergeist (which is now necessary since we've moved
-the export option behind a bootstrap tab)))
-    visit spotlight.exhibit_dashboard_path(exhibit)
-
-    click_link 'General'
-    within('.nav-tabs') do
-      click_link 'Export data'
-    end
-    within('#export') do
-      click_link 'Export data'
-    end
-
-    data = JSON.parse(page.body)
-
-    expect(data).to include 'title', 'searches', 'home_page'
-  end
-
-  it 'allows admins to import content into an exhibit' do
-    visit spotlight.exhibit_dashboard_path(exhibit)
-
-    click_link 'General'
-
-    within('.nav-tabs') do
-      click_link 'Import data'
-    end
-
-    file = Tempfile.new('foo')
-    file.write({ 'title' => 'A better title' }.to_json)
-    file.rewind
-    begin
-      attach_file('file', File.expand_path(file.path))
-      within('#import') do
-        click_button 'Import data'
-      end
-    ensure
-      file.close
-      file.unlink
-    end
-    expect(page).to have_content 'The exhibit was successfully updated.'
-    expect(page).to have_content 'A better title'
-  end
-end

data/spec/features/item_admin_spec.rb

@@ -1,59 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Item Administration', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  before { login_as curator }
-
-  before do
-    allow_any_instance_of(::SolrDocument).to receive_messages(reindex: true)
-  end
-
-  describe 'admin' do
-    it "does not have a 'Save this search' button" do
-      visit spotlight.admin_exhibit_catalog_path(exhibit)
-      expect(page).not_to have_css('button', text: 'Save this search')
-    end
-
-    it 'has catalog items' do
-      visit spotlight.admin_exhibit_catalog_path(exhibit)
-      expect(page).to have_css('h1 small', text: 'Items')
-      expect(page).to have_css('table#documents')
-      expect(page).to have_css('.pagination')
-
-      item = first('tr[itemscope]')
-      expect(item).to have_link 'View'
-      expect(item).to have_link 'Edit'
-    end
-
-    it 'has a public/private toggle' do
-      visit spotlight.admin_exhibit_catalog_path(exhibit)
-      item = first('tr[itemscope]')
-      expect(item).to have_button 'Make private'
-      item.click_button 'Make private'
-
-      item = first('tr[itemscope]')
-      expect(item).to have_button 'Make public'
-      item.click_button 'Make public'
-    end
-
-    it "toggles the 'blacklight-private' label", js: true, default_max_wait_time: 5 do
-      visit spotlight.admin_exhibit_catalog_path(exhibit)
-      # The label should be toggled when the checkbox is clicked
-      expect(page).not_to have_css('tr.blacklight-private')
-      within 'tr[itemscope]:first-child' do
-        find("input.toggle_visibility[type='checkbox']").click
-      end
-      expect(page).to have_css('tr.blacklight-private')
-
-      # The label should show up on page load
-      expect(page).to have_css('tr.blacklight-private')
-      visit spotlight.admin_exhibit_catalog_path(exhibit)
-      within 'tr[itemscope]:first-child' do
-        find("input.toggle_visibility[type='checkbox']").click
-      end
-      expect(page).not_to have_css('tr.blacklight-private')
-    end
-  end
-end

data/spec/features/javascript/about_page_admin_spec.rb

@@ -1,21 +0,0 @@
-# frozen_string_literal: true
-
-describe 'About Pages Adminstration', js: true do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  before { login_as exhibit_curator }
-
-  it 'is able to create new pages' do
-    login_as exhibit_curator
-    visit spotlight.exhibit_dashboard_path(exhibit)
-
-    click_link 'About pages'
-
-    add_new_via_button('My New Page')
-
-    expect(page).to have_content 'The about page was created.'
-    expect(page).to have_css('li.dd-item')
-    expect(page).to have_css('h3', text: 'My New Page')
-  end
-end

data/spec/features/javascript/block_controls_spec.rb

@@ -1,42 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Block controls' do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  before { login_as exhibit_curator }
-
-  it 'is split into separate sections', js: true do
-    # create page
-    visit spotlight.exhibit_dashboard_path(exhibit)
-
-    click_link 'Feature pages'
-
-    add_new_via_button('My New Feature Page')
-
-    expect(page).to have_css('h3', text: 'My New Feature Page')
-
-    expect(page).to have_content('The feature page was created.')
-    within('li.dd-item') do
-      click_link 'Edit'
-    end
-    # fill in title
-    fill_in 'feature_page_title', with: 'Exhibit Title'
-    # click to add widget
-    click_add_widget
-
-    within('.spotlight-block-controls') do
-      expect(page).to have_css('.st-controls-group', count: 2)
-
-      within(first('.st-controls-group')) do
-        expect(page).to have_content 'Standard widgets'
-        expect(page).to have_css('.st-block-controls__button')
-      end
-
-      within(all('.st-controls-group').last) do
-        expect(page).to have_content 'Exhibit item widgets'
-        expect(page).to have_css('.st-block-controls__button')
-      end
-    end
-  end
-end

data/spec/features/javascript/blocks/browse_group_categories_block_spec.rb

@@ -1,64 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Browse Group Categories', type: :feature, js: true do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  let(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
-  let(:search1) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good dogs') }
-  let(:search2) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good cats') }
-  let(:search3) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good birds') }
-  let(:search4) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good pigs') }
-  let(:search5) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good tigers') }
-  let(:search6) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good ferrets') }
-  let(:search7) { FactoryBot.create(:search, exhibit: exhibit, title: 'All of the good turtles') }
-  let!(:group) { FactoryBot.create(:group, exhibit: exhibit, searches: [search1, search2, search3, search4, search5, search6], title: 'Pets', published: true) }
-  let!(:group2) { FactoryBot.create(:group, exhibit: exhibit, searches: [search1, search2], title: 'Good animals', published: true) }
-
-  before do
-    login_as exhibit_curator
-
-    visit spotlight.edit_exhibit_feature_page_path(exhibit, feature_page)
-    add_widget 'browse_group_categories'
-  end
-
-  it 'allows a curator to select a caption to display' do
-    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
-    within '.dd-list' do
-      expect(page).to have_css '.title', text: 'Pets'
-    end
-
-    save_page
-
-    expect(page).to have_css 'h2', text: 'Pets'
-  end
-
-  it 'can navigate using arrows' do
-    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
-    within '.dd-list' do
-      expect(page).to have_css '.title', text: 'Pets'
-    end
-
-    save_page
-
-    expect(page).to have_css 'h2', text: 'Pets'
-
-    expect(page).to have_css '.category-title', text: 'All of the good dogs'
-    expect(page).not_to have_css '.category-title', text: 'All of the good tigers'
-    find('[data-controls="next"]').click
-    expect(page).not_to have_css '.category-title', text: 'All of the good dogs'
-    expect(page).to have_css '.category-title', text: 'All of the good tigers'
-  end
-
-  it 'only published searches are displayed' do
-    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
-    within '.dd-list' do
-      expect(page).to have_css '.title', text: 'Pets'
-    end
-
-    save_page
-
-    expect(page).to have_css 'h2', text: 'Pets'
-    expect(page).to have_css '.box.category-1', count: 6, visible: false
-  end
-end

data/spec/features/javascript/blocks/featured_browse_categories_block_spec.rb

@@ -1,46 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Featured Browse Category Block', type: :feature, js: true do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  let!(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
-  let!(:search1) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'Title1', published: true) }
-  let!(:search2) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'Title2', published: true) }
-
-  before do
-    login_as exhibit_curator
-
-    visit spotlight.edit_exhibit_feature_page_path(exhibit, feature_page)
-    add_widget 'browse'
-  end
-
-  pending 'allows a curator to select from existing browse categories' do
-    pending('Prefetched autocomplete does not work the same way as solr-backed autocompletes')
-    check 'Include item counts?'
-
-    fill_in_typeahead_field with: 'Title1'
-
-    within(:css, '.card') do
-      uncheck 'Display?'
-    end
-
-    fill_in_typeahead_field with: 'Title2'
-
-    save_page
-
-    # Documents should exist
-    expect(page).not_to have_css('.category-title', text: search1.title)
-    expect(page).to have_css('.category-title', text: search2.title)
-    expect(page).to have_css('.item-count', text: /\d+ items/i)
-  end
-
-  pending 'allows the curator to omit document counts' do
-    pending('Prefetched autocomplete does not work the same way as solr-backed autocompletes')
-    uncheck 'Include item counts?'
-    fill_in_typeahead_field with: 'Title1'
-    save_page
-
-    expect(page).not_to have_css('.item-count', text: /\d+ items/i)
-  end
-end

data/spec/features/javascript/blocks/featured_pages_block_spec.rb

@@ -1,61 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Featured Pages Blocks', type: :feature, js: true do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let!(:feature_page1) do
-    FactoryBot.create(
-      :feature_page,
-      title: 'FeaturePage1 Title',
-      weight: 1,
-      exhibit: exhibit
-    )
-  end
-  let!(:feature_page2) do
-    FactoryBot.create(
-      :feature_page,
-      title: 'FeaturePage2 Title',
-      weight: 0,
-      exhibit: exhibit
-    )
-  end
-
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  before do
-    login_as exhibit_curator
-  end
-
-  pending 'saves the selected exhibits' do
-    pending('Prefetched autocomplete does not work the same way as solr-backed autocompletes')
-    visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
-
-    click_link('Edit')
-
-    add_widget 'featured_pages'
-
-    fill_in_typeahead_field with: feature_page2.title
-
-    save_page
-
-    expect(page).to have_content feature_page2.title
-  end
-
-  pending 'persists the user selected sort order' do
-    pending('Prefetched autocomplete does not work the same way as solr-backed autocompletes')
-    visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
-
-    click_link('Edit')
-
-    add_widget 'featured_pages'
-
-    fill_in_typeahead_field with: feature_page1.title
-    fill_in_typeahead_field with: feature_page2.title
-
-    save_page
-
-    feature_page1_position = page.body =~ /<p class="category-title">\s+#{feature_page1.title}/
-    feature_page2_position = page.body =~ /<p class="category-title">\s+#{feature_page2.title}/
-
-    expect(feature_page1_position).to be < feature_page2_position
-  end
-end

data/spec/features/javascript/blocks/link_to_search_block_spec.rb

@@ -1,46 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Link to Search Block', type: :feature, js: true do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  let!(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
-  let!(:search1) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'Title1', published: true) }
-  let!(:search2) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'Title2', published: true) }
-
-  before do
-    login_as exhibit_curator
-
-    visit spotlight.edit_exhibit_feature_page_path(exhibit, feature_page)
-    add_widget 'link_to_search'
-  end
-
-  pending 'allows a curator to select from existing browse categories' do
-    pending('Prefetched autocomplete does not work the same way as solr-backed autocompletes')
-    check 'Include item counts?'
-
-    fill_in_typeahead_field with: 'Title1'
-
-    within(:css, '.card') do
-      uncheck 'Display?'
-    end
-
-    fill_in_typeahead_field with: 'Title2'
-
-    save_page
-
-    # Documents should exist
-    expect(page).not_to have_css('.category-title', text: search1.title)
-    expect(page).to have_css('.category-title', text: search2.title)
-    expect(page).to have_css('.item-count', text: /\d+ items/i)
-  end
-
-  pending 'allows the curator to omit document counts' do
-    pending('Prefetched autocomplete does not work the same way as solr-backed autocompletes')
-    uncheck 'Include item counts?'
-    fill_in_typeahead_field with: 'Title1'
-    save_page
-
-    expect(page).not_to have_css('.item-count', text: /\d+ items/i)
-  end
-end

data/spec/features/javascript/blocks/rule_block_spec.rb

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Horizontal rule block', type: :feature, js: true, versioning: true do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-  let!(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
-
-  before { login_as exhibit_curator }
-
-  it 'allows the user to select which image in a multi image object to display' do
-    exhibit.home_page.content = '[]'
-    exhibit.home_page.save
-
-    visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
-    click_link 'Edit'
-
-    add_widget 'rule'
-
-    save_page
-
-    expect(page).to have_css('hr')
-  end
-end

data/spec/features/javascript/blocks/search_result_block_spec.rb

@@ -1,47 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Search Result Block', type: :feature, js: true do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  let!(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
-  let!(:alt_search) { FactoryBot.create(:search, title: 'Alt. Search', exhibit: exhibit) }
-
-  before do
-    login_as exhibit_curator
-
-    exhibit.searches.each { |x| x.update published: true }
-    visit spotlight.edit_exhibit_feature_page_path(exhibit, feature_page)
-    add_widget 'search_results'
-  end
-
-  it 'allows a curator to select from existing browse categories' do
-    # Manually inject the inputs to the widget that the autocomplete would.
-    # fill_in_typeahead_field does not work here for us for some reason.
-    page.execute_script <<-JS
-      $("[data-twitter-typeahead]:visible").after(
-        "<input type='hidden' name='item[item_0][id]' value='all-exhibit-items' />" +
-        "<input type='hidden' name='item[item_0][display]' value='true' />"
-      );
-    JS
-
-    check 'Gallery'
-    check 'Slideshow'
-
-    save_page
-
-    expect(page).not_to have_content 'per page'
-    expect(page).not_to have_content 'Sort by'
-
-    # The two configured view types should be
-    # present and the one not selected should not be
-    within('.view-type-group') do
-      expect(page).not_to have_css('.view-type-list')
-      expect(page).to have_css('.view-type-gallery')
-      expect(page).to have_css('.view-type-slideshow')
-    end
-
-    # Documents should exist
-    expect(page).to have_css('.documents-gallery .document')
-  end
-end