blacklight-spotlight 3.4.0 → 3.4.1

data/spec/controllers/spotlight/contact_forms_controller_spec.rb

@@ -1,38 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::ContactFormsController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:honeypot_field_name) { Spotlight::Engine.config.spambot_honeypot_email_field }
-
-  before do
-    request.env['HTTP_REFERER'] = '/whatever'
-    exhibit.contact_emails_attributes = [{ 'email' => 'test@example.com' }, { 'email' => 'test2@example.com' }]
-    exhibit.save!
-    exhibit.contact_emails.first.tap do |e|
-      if e.respond_to? :confirm
-        e.confirm
-      else
-        e.confirm!
-      end
-    end
-  end
-
-  describe 'POST create' do
-    it 'sends an email' do
-      expect do
-        post :create, params: { exhibit_id: exhibit.id, contact_form: { name: 'Joe Doe', email: 'jdoe@example.com', honeypot_field_name => '' } }
-      end.to change { ActionMailer::Base.deliveries.count }.by(1)
-    end
-
-    it 'redirects back' do
-      post :create, params: { exhibit_id: exhibit.id, contact_form: { name: 'Joe Doe', email: 'jdoe@example.com', honeypot_field_name => '' } }
-      expect(response).to redirect_to end_with('/whatever')
-    end
-
-    it 'sets a flash message' do
-      post :create, params: { exhibit_id: exhibit.id, contact_form: { name: 'Joe Doe', email: 'jdoe@example.com', honeypot_field_name => '' } }
-      expect(flash[:notice]).to eq 'Thanks. Your feedback has been sent.'
-    end
-  end
-end

data/spec/controllers/spotlight/contacts_controller_spec.rb

@@ -1,103 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::ContactsController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  describe 'when not logged in' do
-    describe 'GET edit' do
-      let(:contact) { FactoryBot.create(:contact) }
-
-      it 'is successful' do
-        get :edit, params: { id: contact, exhibit_id: contact.exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-  end
-
-  describe 'when signed in as a curator' do
-    let(:user) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-    let(:exhibit) { FactoryBot.create(:exhibit) }
-    let(:contact) { FactoryBot.create(:contact, exhibit: exhibit, name: 'Andrew Carnegie') }
-
-    before { sign_in user }
-
-    describe 'GET edit' do
-      it 'is successful' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-        expect(controller).to receive(:add_breadcrumb).with('Curation', exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('About pages', exhibit_about_pages_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with(contact.name, edit_exhibit_contact_path(exhibit, contact))
-        get :edit, params: { id: contact, exhibit_id: contact.exhibit }
-        expect(response).to be_successful
-      end
-    end
-
-    describe 'PATCH update' do
-      it 'is successful' do
-        patch :update, params: { id: contact, contact: { name: 'Chester' }, exhibit_id: contact.exhibit }
-        expect(response).to redirect_to exhibit_about_pages_path(exhibit)
-        expect(contact.reload.name).to eq 'Chester'
-      end
-
-      it 'allows thumbnails to be updated' do
-        contact = FactoryBot.create(:contact, exhibit: exhibit, name: 'Andrew Carnegie')
-        patch :update, params: {
-          id: contact,
-          contact: {
-            avatar_attributes: {
-              iiif_tilesource: 'https://example.com/iiif',
-              iiif_region: '0,0,200,200'
-            }
-          },
-          exhibit_id: contact.exhibit
-        }
-
-        expect(response).to redirect_to exhibit_about_pages_path(exhibit)
-        expect(contact.reload.avatar.iiif_url).to eq 'https://example.com/iiif/0,0,200,200/70,70/0/default.jpg'
-      end
-
-      it 'fails by rendering edit' do
-        expect_any_instance_of(Spotlight::Contact).to receive(:update).and_return(false)
-        patch :update, params: { id: contact, contact: { name: 'Chester' }, exhibit_id: contact.exhibit }
-        expect(response).to render_template 'edit'
-      end
-    end
-
-    describe 'DELETE destroy' do
-      it 'is successful' do
-        contact # force contact to be created
-        expect do
-          delete :destroy, params: { id: contact, exhibit_id: contact.exhibit }
-        end.to change(Spotlight::Contact, :count).by(-1)
-        expect(response).to redirect_to exhibit_about_pages_path(exhibit)
-      end
-    end
-
-    describe 'GET new' do
-      it 'is successful' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-        expect(controller).to receive(:add_breadcrumb).with('Curation', exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('About pages', exhibit_about_pages_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('Add contact', new_exhibit_contact_path(exhibit))
-        get :new, params: { exhibit_id: exhibit }
-        expect(response).to be_successful
-      end
-    end
-
-    describe 'POST create' do
-      it 'fails by rendering new' do
-        expect_any_instance_of(Spotlight::Contact).to receive(:update).and_return(false)
-        post :create, params: { exhibit_id: exhibit, contact: { name: 'Chester' } }
-        expect(response).to render_template 'new'
-      end
-
-      it 'is successful' do
-        expect do
-          post :create, params: { exhibit_id: exhibit, contact: { name: 'Chester', avatar_attributes: { iiif_tilesource: 'someurl' } } }
-        end.to change(Spotlight::Contact, :count).by(1)
-        expect(response).to redirect_to exhibit_about_pages_path(exhibit)
-        expect(Spotlight::Contact.last.show_in_sidebar).to be_truthy
-        expect(Spotlight::Contact.last.avatar.iiif_url).to be_present
-      end
-    end
-  end
-end

data/spec/controllers/spotlight/custom_fields_controller_spec.rb

@@ -1,62 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::CustomFieldsController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  describe 'when signed in as an exhibit admin' do
-    let(:user) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-
-    before { sign_in user }
-
-    describe 'GET new' do
-      it 'assigns a new custom field' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-        expect(controller).to receive(:add_breadcrumb).with('Configuration', exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('Metadata', edit_exhibit_metadata_configuration_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('Add new field', new_exhibit_custom_field_path(exhibit))
-        get :new, params: { exhibit_id: exhibit }
-        expect(assigns(:custom_field)).to be_a_new(Spotlight::CustomField)
-      end
-    end
-
-    describe 'GET edit' do
-      let(:field) { FactoryBot.create(:custom_field, exhibit: exhibit) }
-
-      it 'assigns the requested custom_field' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-        expect(controller).to receive(:add_breadcrumb).with('Configuration', exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('Metadata', edit_exhibit_metadata_configuration_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with(field.label, edit_exhibit_custom_field_path(exhibit, field))
-        get :edit, params: { exhibit_id: exhibit, id: field }
-        expect(assigns(:custom_field)).to eq field
-        expect(assigns(:exhibit)).to eq exhibit
-      end
-    end
-
-    describe 'POST create' do
-      describe 'with valid params' do
-        it 'creates a new Page' do
-          expect do
-            post :create, params: { custom_field: { label: 'MyString' }, exhibit_id: exhibit }
-          end.to change(Spotlight::CustomField, :count).by(1)
-        end
-
-        it 'redirects to the exhibit metadata page' do
-          post :create, params: { custom_field: { label: 'MyString' }, exhibit_id: exhibit }
-          expect(response).to redirect_to(edit_exhibit_metadata_configuration_path(exhibit))
-        end
-      end
-
-      describe 'with invalid params' do
-        it "re-renders the 'new' template" do
-          # Trigger the behavior that occurs when invalid params are submitted
-          allow_any_instance_of(Spotlight::CustomField).to receive(:save).and_return(false)
-          post :create, params: { custom_field: { label: 'MyString' }, exhibit_id: exhibit }
-          expect(assigns(:custom_field)).to be_a_new(Spotlight::CustomField)
-          expect(response).to render_template('new')
-        end
-      end
-    end
-  end
-end

data/spec/controllers/spotlight/custom_search_fields_controller_spec.rb

@@ -1,62 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::CustomSearchFieldsController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  describe 'when signed in as an exhibit admin' do
-    let(:user) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-
-    before { sign_in user }
-
-    describe 'GET new' do
-      it 'assigns a new custom field' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-        expect(controller).to receive(:add_breadcrumb).with('Configuration', exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('Search', edit_exhibit_search_configuration_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('Add new field', new_exhibit_custom_search_field_path(exhibit))
-        get :new, params: { exhibit_id: exhibit }
-        expect(assigns(:custom_search_field)).to be_a_new(Spotlight::CustomSearchField)
-      end
-    end
-
-    describe 'GET edit' do
-      let(:field) { FactoryBot.create(:custom_search_field, exhibit: exhibit) }
-
-      it 'assigns the requested custom_field' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-        expect(controller).to receive(:add_breadcrumb).with('Configuration', exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('Search', edit_exhibit_search_configuration_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with(field.label, edit_exhibit_custom_search_field_path(exhibit, field))
-        get :edit, params: { exhibit_id: exhibit, id: field }
-        expect(assigns(:custom_search_field)).to eq field
-        expect(assigns(:exhibit)).to eq exhibit
-      end
-    end
-
-    describe 'POST create' do
-      describe 'with valid params' do
-        it 'creates a new Page' do
-          expect do
-            post :create, params: { custom_search_field: { label: 'MyString' }, exhibit_id: exhibit }
-          end.to change(Spotlight::CustomSearchField, :count).by(1)
-        end
-
-        it 'redirects to the exhibit metadata page' do
-          post :create, params: { custom_search_field: { label: 'MyString' }, exhibit_id: exhibit }
-          expect(response).to redirect_to(edit_exhibit_search_configuration_path(exhibit))
-        end
-      end
-
-      describe 'with invalid params' do
-        it "re-renders the 'new' template" do
-          # Trigger the behavior that occurs when invalid params are submitted
-          allow_any_instance_of(Spotlight::CustomSearchField).to receive(:save).and_return(false)
-          post :create, params: { custom_search_field: { label: 'MyString' }, exhibit_id: exhibit }
-          expect(assigns(:custom_search_field)).to be_a_new(Spotlight::CustomSearchField)
-          expect(response).to render_template('new')
-        end
-      end
-    end
-  end
-end

data/spec/controllers/spotlight/dashboards_controller_spec.rb

@@ -1,68 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::DashboardsController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:repository) { double }
-
-  before do
-    allow(controller).to receive(:repository).and_return(repository)
-  end
-
-  describe 'when logged in' do
-    let(:curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-    before { sign_in curator }
-
-    describe 'GET show' do
-      it 'loads the exhibit' do
-        exhibit.blacklight_configuration.index = { timestamp_field: 'timestamp_field' }
-        exhibit.save!
-        # TODO: restore test for: .with(sort: 'timestamp_field desc')
-        expect(controller).to receive(:search_service).and_return(double(search_results: [double(:response), [{ id: 1 }]]))
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-        expect(controller).to receive(:add_breadcrumb).with('Dashboard', exhibit_dashboard_path(exhibit))
-        get :show, params: { exhibit_id: exhibit.id }
-        expect(response).to render_template 'spotlight/dashboards/show'
-        expect(assigns[:exhibit]).to eq exhibit
-        expect(assigns[:pages].length).to eq exhibit.pages.length
-        expect(assigns[:solr_documents]).to have(1).item
-      end
-    end
-
-    describe 'GET analytics' do
-      it 'loads the exhibit' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-        expect(controller).to receive(:add_breadcrumb).with('Analytics', analytics_exhibit_dashboard_path(exhibit))
-        get :analytics, params: { exhibit_id: exhibit.id }
-        expect(response).to render_template 'spotlight/dashboards/analytics'
-        expect(assigns[:exhibit]).to eq exhibit
-      end
-    end
-  end
-
-  describe 'when user does not have access' do
-    before { sign_in FactoryBot.create(:exhibit_visitor) }
-
-    it 'does not allow show' do
-      get :show, params: { exhibit_id: exhibit.id }
-      expect(response).to redirect_to main_app.root_path
-    end
-
-    it 'does not allow analytics' do
-      get :analytics, params: { exhibit_id: exhibit.id }
-      expect(response).to redirect_to main_app.root_path
-    end
-  end
-
-  describe 'when not logged in' do
-    describe 'GET show' do
-      it 'redirects to the sign in form' do
-        get :show, params: { exhibit_id: exhibit.id }
-        expect(response).to redirect_to(main_app.new_user_session_path)
-        expect(flash[:alert]).to be_present
-        expect(flash[:alert]).to match(/You need to sign in/)
-      end
-    end
-  end
-end

data/spec/controllers/spotlight/exhibits_controller_spec.rb

@@ -1,216 +0,0 @@
-# frozen_string_literal: true
-
-require 'rack/test'
-
-describe Spotlight::ExhibitsController, type: :controller do
-  routes { Spotlight::Engine.routes }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  before do
-    allow(Spotlight::DefaultThumbnailJob).to receive(:perform_later)
-  end
-
-  describe 'when the user is not authorized' do
-    before do
-      sign_in FactoryBot.create(:exhibit_visitor)
-    end
-
-    describe 'GET edit' do
-      it 'denies access' do
-        get :edit, params: { id: exhibit }
-        expect(response).to redirect_to main_app.root_path
-        expect(flash[:alert]).to be_present
-      end
-    end
-  end
-
-  describe 'when not logged in' do
-    describe 'GET index' do
-      context 'where there are no exhibits' do
-        it 'is allowed' do
-          get :index
-          expect(response).to be_successful
-        end
-      end
-
-      context 'when there is one exhibit' do
-        let!(:exhibit) do
-          FactoryBot.create(:exhibit)
-        end
-
-        before do
-          allow(controller).to receive(:redirect_to)
-        end
-
-        it 'is allowed' do
-          get :index
-          expect(controller).to have_received(:redirect_to).with(exhibit, flash: {})
-        end
-      end
-    end
-
-    describe 'GET new' do
-      it 'is not allowed' do
-        get :new, params: { id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    describe 'GET edit' do
-      it 'is not allowed' do
-        get :edit, params: { id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    describe 'PATCH update' do
-      it 'is not allowed' do
-        patch :update, params: { id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    describe 'PATCH process_import' do
-      it 'is not allowed' do
-        patch :process_import, params: { id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-
-    describe 'DELETE destroy' do
-      it 'is not allowed' do
-        delete :destroy, params: { id: exhibit }
-        expect(response).to redirect_to main_app.new_user_session_path
-      end
-    end
-  end
-
-  describe 'when signed in as a site admin' do
-    let(:user) { FactoryBot.create(:site_admin) }
-
-    before { sign_in user }
-
-    describe 'GET new' do
-      it 'is successful' do
-        get :new
-        expect(response).to be_successful
-      end
-    end
-
-    describe 'POST create' do
-      before do
-        # decouple this test from needing solr running
-        allow_any_instance_of(Spotlight::Search).to receive(:set_default_featured_image)
-      end
-
-      it 'is successful' do
-        expect do
-          post :create, params: { exhibit: { title: 'Some Title', slug: 'custom-slug', tag_list: '2014, R. Buckminster Fuller' } }
-        end.to change(Spotlight::Exhibit, :count).by(1)
-
-        exhibit = Spotlight::Exhibit.last
-        expect(response).to redirect_to(exhibit_dashboard_path(exhibit))
-
-        expect(exhibit.title).to eq 'Some Title'
-        expect(exhibit.slug).to eq 'custom-slug'
-        expect(exhibit.tags.map(&:name)).to eq ['2014', 'R. Buckminster Fuller']
-
-        expect(user.exhibits).to include exhibit
-      end
-    end
-  end
-
-  describe 'when signed in as an exhibit admin' do
-    let(:user) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-
-    before { sign_in user }
-
-    describe 'GET new' do
-      it 'is not allowed' do
-        get :new
-        expect(response).not_to be_successful
-      end
-    end
-
-    describe 'PATCH process_import' do
-      it 'is successful' do
-        expect_any_instance_of(Spotlight::Exhibit).to receive(:reindex_later).and_return(true)
-        f = Tempfile.new('foo')
-        begin
-          f.write '{ "title": "Foo", "subtitle": "Bar"}'
-          f.rewind
-          file = Rack::Test::UploadedFile.new(f.path, 'application/json')
-          patch :process_import, params: { id: exhibit, file: file }
-        ensure
-          f.close
-          f.unlink
-        end
-        expect(response).to be_redirect
-        assigns[:exhibit].tap do |saved|
-          expect(saved.title).to eq 'Foo'
-          expect(saved.subtitle).to eq 'Bar'
-        end
-      end
-    end
-
-    describe 'GET edit' do
-      it 'is successful' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
-        expect(controller).to receive(:add_breadcrumb).with('Configuration', exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with('General', edit_exhibit_path(exhibit))
-        get :edit, params: { id: exhibit }
-        expect(response).to be_successful
-      end
-    end
-
-    describe '#update' do
-      it 'is successful' do
-        patch :update, params: {
-          id: exhibit,
-          exhibit: {
-            title: 'Foo',
-            subtitle: 'Bar',
-            description: 'Baz',
-            contact_emails_attributes: { '0' => { email: 'bess@stanford.edu' }, '1' => { email: 'naomi@stanford.edu' } }
-          }
-        }
-
-        expect(flash[:notice]).to eq 'The exhibit was successfully updated.'
-        expect(response).to redirect_to edit_exhibit_path(exhibit)
-        assigns[:exhibit].tap do |saved|
-          expect(saved.title).to eq 'Foo'
-          expect(saved.subtitle).to eq 'Bar'
-          expect(saved.description).to eq 'Baz'
-          expect(saved.contact_emails.pluck(:email)).to eq ['bess@stanford.edu', 'naomi@stanford.edu']
-        end
-      end
-
-      it 'shows errors and ignore blank emails' do
-        patch :update, params: {
-          id: exhibit,
-          exhibit: {
-            title: 'Foo',
-            subtitle: 'Bar',
-            description: 'Baz',
-            contact_emails_attributes: { '0' => { email: 'bess@stanford.edu' }, '1' => { email: 'naomi@' }, '2' => { email: '' } }
-          }
-        }
-
-        expect(response).to be_successful
-        assigns[:exhibit].tap do |obj|
-          expect(obj.contact_emails.last.errors[:email]).to eq ['is not valid']
-          expect(obj.contact_emails.size).to eq 2
-        end
-      end
-    end
-
-    describe '#destroy' do
-      it 'is successful' do
-        delete :destroy, params: { id: exhibit }
-        expect(Spotlight::Exhibit).not_to exist(exhibit.id)
-        expect(flash[:notice]).to eq 'The exhibit was deleted.'
-        expect(response).to redirect_to main_app.root_path
-      end
-    end
-  end
-end