blacklight-spotlight 3.4.0 → 3.4.1

data/spec/features/catalog_spec.rb

@@ -1,57 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Catalog', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-
-  describe 'admin' do
-    let(:curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-    before do
-      login_as curator
-      d = SolrDocument.new(id: 'dq287tq6352')
-      d.make_private! exhibit
-      d.reindex
-      Blacklight.default_index.connection.commit
-    end
-
-    after do
-      d = SolrDocument.new(id: 'dq287tq6352')
-      d.make_public! exhibit
-      d.reindex
-      Blacklight.default_index.connection.commit
-    end
-
-    it "has a 'Item Visiblity' facet" do
-      visit spotlight.search_exhibit_catalog_path(exhibit)
-      expect(page).to have_selector '.card-header', text: 'Item visibility'
-    end
-  end
-
-  it 'has breadcrumbs' do
-    visit spotlight.search_exhibit_catalog_path(exhibit, q: 'xyz')
-    expect(page).to have_breadcrumbs 'Home', 'Search results'
-    expect(page).to have_selector '.breadcrumb-item.active', text: 'Search results'
-  end
-
-  describe 'Non-spotlight #show' do
-    it 'is able to render without exhibit context' do
-      visit solr_document_path('dq287tq6352')
-      expect(page).to have_css 'h1', text: "L'AMERIQUE"
-    end
-  end
-
-  describe 'viewing the page' do
-    let(:exhibit) { FactoryBot.create(:exhibit) }
-
-    it 'has <meta> tags' do
-      TopHat.current['twitter_card'] = nil
-      TopHat.current['opengraph'] = nil
-
-      visit spotlight.exhibit_solr_document_path(exhibit, 'dq287tq6352')
-
-      expect(page).to have_css "meta[name='twitter:title']", visible: false
-      expect(page).to have_css "meta[property='og:site_name']", visible: false
-      expect(page).to have_css "meta[property='og:title']", visible: false
-    end
-  end
-end

data/spec/features/confirm_email_spec.rb

@@ -1,21 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Confirming an email', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:contact_email) { Spotlight::ContactEmail.create!(email: 'justin@example.com', exhibit: exhibit) }
-  let(:raw_token) { contact_email.instance_variable_get(:@raw_confirmation_token) }
-
-  it 'resends confirmation instructions' do
-    visit spotlight.new_contact_email_confirmation_url(confirmation_token: contact_email.confirmation_token)
-    expect(page).to have_content('Resend confirmation instructions')
-    within '#new_contact_email' do
-      fill_in 'Email', with: contact_email.email
-      click_button 'Resend confirmation instructions'
-    end
-  end
-
-  it 'confirms email' do
-    visit spotlight.contact_email_confirmation_url(confirmation_token: raw_token)
-    expect(page).to have_content('successfully confirmed')
-  end
-end

data/spec/features/create_exhibit_spec.rb

@@ -1,65 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Create a new exhibit', type: :feature do
-  let(:user) { FactoryBot.create(:site_admin) }
-
-  before do
-    allow(Spotlight::DefaultThumbnailJob).to receive(:perform_later)
-    login_as user
-  end
-
-  it 'has a link in the user dropdown' do
-    visit '/'
-    within '.dropdown-menu' do
-      click_link 'Create new exhibit'
-    end
-    expect(page).to have_selector 'h1', text: 'Create a new exhibit'
-  end
-
-  it 'allows admins to create a new exhibit' do
-    visit '/'
-    within '.dropdown-menu' do
-      click_link 'Create new exhibit'
-    end
-
-    fill_in 'Title', with: 'My exhibit title'
-
-    find('input[name="commit"]').click
-
-    expect(page).to have_content 'The exhibit was created.'
-    expect(Spotlight::Exhibit.last.slug).to eq 'my-exhibit-title'
-  end
-
-  it 'allows admins to create a new exhibit with a slug' do
-    visit '/'
-    within '.dropdown-menu' do
-      click_link 'Create new exhibit'
-    end
-
-    fill_in 'Title', with: 'My exhibit title'
-    fill_in 'URL slug', with: 'custom-slug'
-
-    find('input[name="commit"]').click
-
-    expect(page).to have_content 'The exhibit was created.'
-    expect(Spotlight::Exhibit.last.slug).to eq 'custom-slug'
-  end
-
-  it 'fails validation if the slug is already used' do
-    visit spotlight.new_exhibit_path
-
-    fill_in 'Title', with: 'My exhibit title'
-    fill_in 'URL slug', with: 'custom-slug'
-
-    find('input[name="commit"]').click
-
-    visit spotlight.new_exhibit_path
-
-    fill_in 'Title', with: 'My exhibit title'
-    fill_in 'URL slug', with: 'custom-slug'
-
-    find('input[name="commit"]').click
-
-    expect(page).to have_content 'has already been taken'
-  end
-end

data/spec/features/create_page_spec.rb

@@ -1,21 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Creating a page', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-
-  describe 'when a bunch of about pages exist' do
-    let!(:page1) { FactoryBot.create(:about_page, exhibit: exhibit) }
-    let!(:page2) { FactoryBot.create(:about_page, exhibit: exhibit) }
-    let!(:page3) { FactoryBot.create(:about_page, exhibit: exhibit, title: 'A new one') }
-
-    it 'is able to show a list of About pages to be curated' do
-      login_as exhibit_curator
-      visit spotlight.exhibit_dashboard_path(exhibit)
-      within '#sidebar' do
-        click_link 'About pages'
-      end
-      expect(page).to have_content 'A new one'
-    end
-  end
-end

data/spec/features/dashboard_spec.rb

@@ -1,34 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Dashboard', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let!(:parent_feature_page) do
-    FactoryBot.create(:feature_page, title: 'Parent Page', exhibit: exhibit)
-  end
-  let!(:child_feature_page) do
-    FactoryBot.create(
-      :feature_page,
-      title: 'Child Page',
-      parent_page: parent_feature_page,
-      exhibit: exhibit
-    )
-  end
-  let(:admin) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-
-  before do
-    login_as(admin)
-  end
-
-  it 'includes a list of recently edited feature pages' do
-    visit spotlight.exhibit_dashboard_path(exhibit)
-    expect(page).to have_content 'Recent site building activity'
-    expect(page).to have_content 'Parent Page'
-    expect(page).to have_content 'Child Page'
-  end
-
-  it 'includes a list of recently indexed items' do
-    visit spotlight.exhibit_dashboard_path(exhibit)
-    expect(page).to have_content 'Recently updated items'
-    expect(page).to have_selector('#documents')
-  end
-end

data/spec/features/edit_contact_spec.rb

@@ -1,21 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Add a contact to an exhibit', type: :feature do
-  let(:curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let!(:about_page) { FactoryBot.create(:about_page, exhibit: exhibit) }
-  let!(:contact) { FactoryBot.create(:contact, name: 'Marcus Aurelius', exhibit: exhibit) }
-
-  before { login_as curator }
-
-  it 'displays a newly added contact in the sidebar' do
-    visit spotlight.exhibit_about_pages_path(exhibit)
-
-    within '.contacts_admin' do
-      click_link 'Edit'
-    end
-
-    click_button 'Save'
-    expect(page).to have_content 'The contact was successfully updated.'
-  end
-end

data/spec/features/edit_search_fields_spec.rb

@@ -1,79 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Search Administration', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:exhibit_admin) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-
-  before { login_as exhibit_admin }
-
-  describe 'edit' do
-    it 'displays the search configuration edit screen' do
-      visit spotlight.edit_exhibit_search_configuration_path(exhibit)
-      expect(page).to have_css('h1 small', text: 'Search')
-    end
-
-    it 'has breadcrumbs' do
-      visit spotlight.edit_exhibit_search_configuration_path exhibit
-      expect(page).to have_breadcrumbs 'Home', 'Configuration', 'Search'
-    end
-
-    describe 'facets' do
-      it 'displays information about the facets' do
-        visit spotlight.edit_exhibit_search_configuration_path(exhibit)
-        within("[data-id='genre_ssim']") do
-          expect(page).to have_content('Genre')
-          expect(page).to have_content(/\d+ items/)
-          expect(page).to have_content(/([\d+]+) unique values/)
-        end
-      end
-
-      it 'allows curators to select and unselect facets for display' do
-        visit spotlight.edit_exhibit_search_configuration_path exhibit
-
-        expect(page).to have_content "Configuration Search\nOptions Facets Results"
-        expect(page).to have_button 'Save'
-
-        uncheck 'blacklight_configuration_facet_fields_language_ssim_show' # Language
-        uncheck 'blacklight_configuration_facet_fields_genre_ssim_show' # Genre
-        check 'blacklight_configuration_facet_fields_subject_temporal_ssim_show' # Era
-
-        click_on 'Save changes'
-
-        expect(exhibit.reload.blacklight_config.facet_fields.select { |_k, v| v.show }.keys).to include('subject_temporal_ssim')
-        expect(exhibit.blacklight_config.facet_fields.select { |_k, v| v.show }.keys).not_to include('language_ssim', 'genre_ssim')
-      end
-    end
-
-    describe 'sort' do
-      it 'displays the sort fields edit area' do
-        visit spotlight.edit_exhibit_search_configuration_path(exhibit)
-        expect(page).to have_content('Sort fields')
-      end
-
-      it 'updates sort options' do
-        visit spotlight.edit_exhibit_search_configuration_path(exhibit)
-
-        expect(page).to have_css("input[name='blacklight_configuration[sort_fields][relevance][enable]'][disabled='disabled']")
-        expect(page).to have_css('#nested-sort-fields .dd-item:nth-child(5) h3', text: 'date (new to old)')
-
-        uncheck 'blacklight_configuration_sort_fields_title_enabled'
-        uncheck 'blacklight_configuration_sort_fields_identifier_enabled'
-
-        find('#blacklight_configuration_sort_fields_type_weight', visible: false).set('100')
-
-        click_button 'Save changes'
-
-        click_link 'Results'
-
-        expect(page).to have_css("input[name='blacklight_configuration[sort_fields][relevance][enable]'][disabled='disabled']")
-        expect(find('#blacklight_configuration_sort_fields_type_enabled')).to be_checked
-        expect(find('#blacklight_configuration_sort_fields_date_enabled')).to be_checked
-        expect(find('#blacklight_configuration_sort_fields_title_enabled')).not_to be_checked
-        expect(find('#blacklight_configuration_sort_fields_identifier_enabled')).not_to be_checked
-
-        # Type is now sorted last
-        expect(page).to have_css('#nested-sort-fields .dd-item:nth-child(5) h3', text: 'type')
-      end
-    end
-  end
-end

data/spec/features/exhibit_masthead_spec.rb

@@ -1,112 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Add and update the site masthead', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:user) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-
-  before { login_as user }
-
-  it 'updates exhibit masthead options' do
-    visit spotlight.exhibit_dashboard_path(exhibit)
-
-    within '#sidebar' do
-      click_link 'Appearance'
-    end
-
-    click_link 'Exhibit masthead'
-
-    within '#site-masthead' do
-      check 'Show background image in masthead'
-      choose 'Upload an image'
-
-      # The JS fills in these fields:
-      find('#exhibit_masthead_attributes_iiif_tilesource', visible: false).set 'http://test.host/images/7'
-      find('#exhibit_masthead_attributes_iiif_region', visible: false).set '0,0,100,200'
-      # attach_file('exhibit_masthead_attributes_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')))
-    end
-
-    click_button 'Save changes'
-
-    expect(page).to have_content('The exhibit was successfully updated.')
-
-    within '#sidebar' do
-      click_link 'Appearance'
-    end
-
-    click_link 'Exhibit masthead'
-
-    within '#site-masthead' do
-      expect(page).to have_checked_field 'Show background image in masthead'
-      expect(page).to have_checked_field 'Upload an image'
-    end
-  end
-
-  it 'displays a masthead image when one is uploaded and configured' do
-    visit spotlight.exhibit_dashboard_path(exhibit)
-    expect(page).not_to have_css('.image-masthead')
-    within '#sidebar' do
-      click_link 'Appearance'
-    end
-
-    click_link 'Exhibit masthead'
-
-    within '#site-masthead' do
-      check 'Show background image in masthead'
-
-      # attach_file('exhibit_masthead_attributes_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')))
-      # The JS fills in these fields:
-      find('#exhibit_masthead_attributes_iiif_tilesource', visible: false).set 'http://test.host/images/7'
-      find('#exhibit_masthead_attributes_iiif_region', visible: false).set '0,0,100,200'
-    end
-
-    click_button 'Save changes'
-
-    expect(page).to have_content('The exhibit was successfully updated.')
-
-    expect(page).to have_css('.image-masthead .background-container')
-  end
-
-  it 'does not display an uploaded masthead if configured to not display' do
-    visit spotlight.exhibit_dashboard_path(exhibit)
-    expect(page).not_to have_css('.image-masthead')
-    within '#sidebar' do
-      click_link 'Appearance'
-    end
-
-    click_link 'Exhibit masthead'
-
-    within '#site-masthead' do
-      attach_file('exhibit_masthead_attributes_file', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')))
-    end
-
-    click_button 'Save changes'
-
-    expect(page).to have_content('The exhibit was successfully updated.')
-
-    expect(page).not_to have_css('.image-masthead .background-container')
-  end
-
-  it 'displays a masthead image when one is uploaded from an exhibit item', js: true do
-    skip "Capyabara and the cropping tool don't play well together.."
-
-    visit spotlight.exhibit_dashboard_path(exhibit)
-    expect(page).not_to have_css('.image-masthead')
-    within '#sidebar' do
-      click_link 'Appearance'
-    end
-
-    click_link 'Exhibit masthead'
-
-    within '#site-masthead' do
-      check 'Show background image in masthead'
-
-      fill_in_typeahead_field 'document_title', with: 'Armenia'
-    end
-
-    click_button 'Save changes'
-
-    expect(page).to have_content('The appearance was successfully updated.')
-
-    expect(page).to have_css('.image-masthead .background-container')
-  end
-end

data/spec/features/exhibit_themes_spec.rb

@@ -1,30 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Update the site theme', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:user) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-
-  before do
-    login_as user
-  end
-
-  it 'updates the exhibit theme' do
-    visit spotlight.edit_exhibit_appearance_path(exhibit)
-
-    expect(page).to have_content('Visual theme')
-    choose 'Modern'
-
-    click_button 'Save changes'
-
-    expect(page).to have_content('The exhibit was successfully updated.')
-
-    within '#sidebar' do
-      click_link 'Appearance'
-    end
-
-    click_link 'Exhibit masthead'
-
-    expect(page).to have_checked_field 'Modern'
-    expect(page).to have_xpath('//link[contains(@href, "/assets/application_modern")]', visible: false)
-  end
-end

data/spec/features/exhibits/add_tags_spec.rb

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Add tags to an item in an exhibit', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-  let(:custom_field) { FactoryBot.build_stubbed(:custom_field, exhibit: exhibit) }
-
-  before do
-    login_as(curator)
-  end
-
-  it 'changes and display the of tags' do
-    visit spotlight.exhibit_solr_document_path(exhibit, 'dq287tq6352')
-
-    expect(page).to have_link 'Edit'
-
-    click_on 'Edit'
-
-    fill_in 'Tags', with: 'One, Two and a half, Three'
-
-    click_on 'Save changes'
-
-    visit spotlight.exhibit_solr_document_path(exhibit, 'dq287tq6352')
-
-    within('dd.blacklight-exhibit_tags') do
-      expect(page).to have_selector 'a', text: 'One'
-      expect(page).to have_selector 'a', text: 'Two and a half'
-      expect(page).to have_selector 'a', text: 'Three'
-    end
-
-    click_on 'Two and a half'
-
-    expect(page).to have_content 'Remove constraint Exhibit Tags: Two and a half'
-  end
-end

data/spec/features/exhibits/administration_spec.rb

@@ -1,141 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Exhibit Administration', type: :feature do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:admin) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
-  let(:hidden_input_id_0) { 'exhibit_contact_emails_attributes_0_id' }
-  let(:email_id_0) { 'exhibit_contact_email_0' }
-  let(:email_address_0) { 'admin@example.com' }
-  let(:hidden_input_id_1) { 'exhibit_contact_emails_attributes_1_id' }
-  let(:hidden_input_val_1) { '2' }
-  let(:email_id_1) { 'exhibit_contact_email_1' }
-  let(:email_address_1) { 'admin2@example.com' }
-
-  before { login_as admin }
-
-  describe 'Contact Emails' do
-    it 'has breadcrumbs' do
-      visit spotlight.edit_exhibit_path(exhibit)
-      expect(page).to have_breadcrumbs 'Home', 'Configuration', 'General'
-    end
-
-    it 'has a blank input field when there are no contacts yet' do
-      visit spotlight.edit_exhibit_path(exhibit)
-      expect(page).to have_css('input.exhibit-contact')
-      expect(find_field(email_id_0).value).to be_blank
-    end
-
-    it 'stores and retreives a contact email address' do
-      visit spotlight.edit_exhibit_path(exhibit)
-      fill_in email_id_0, with: email_address_0
-      click_button 'Save changes'
-      expect(page).to have_content('The exhibit was successfully updated.')
-      visit spotlight.edit_exhibit_path(exhibit)
-      expect(find_field(email_id_0).value).to eq email_address_0
-    end
-
-    it "has new inputs added when clicking on the 'add contact' button", js: true do
-      # Exhibit administration edit
-      visit spotlight.edit_exhibit_path(exhibit)
-
-      # fill in first email field
-      fill_in email_id_0, with: email_address_0
-
-      # Additonal blank fields should not exist
-      expect(page).not_to have_css("input##{email_id_1}")
-      # click the + (add contact) button
-      find('#another-email').click
-      # An additional blank field should exist now
-      expect(page).to have_css("input##{email_id_1}")
-      expect(find_field(email_id_1).value).to be_blank
-
-      # fill in the second email field
-      fill_in email_id_1, with: email_address_1
-      click_button 'Save changes'
-
-      expect(page).to have_content('The exhibit was successfully updated.')
-      visit spotlight.edit_exhibit_path(exhibit)
-
-      expect(find_field(email_id_0).value).to eq email_address_0
-      expect(find_field(email_id_1).value).to eq email_address_1
-    end
-
-    it 'updates the aria-labels properly', js: true do
-      visit spotlight.edit_exhibit_path(exhibit)
-
-      expect(find_field(email_id_0)['aria-label']).to eq 'Recipient email 1'
-      find('#another-email').click
-      expect(find_field(email_id_1)['aria-label']).to eq 'Recipient email 2'
-    end
-
-    it 'allows deletion of contact email addresses', js: true do
-      # go to edit page, fill in first email field, click the + (add contact) button, fill in the second email field, click save.
-      visit spotlight.edit_exhibit_path(exhibit)
-      fill_in email_id_0, with: email_address_0
-      find('#another-email').click
-      fill_in email_id_1, with: email_address_1
-      click_button 'Save changes'
-
-      # saving should redirect back to the edit page, which should now have the contact
-      # email addresses, with delete buttons now that the entries have been saved.
-      expect(find_field(email_id_0).value).to eq email_address_0
-      expect(find_field(email_id_1).value).to eq email_address_1
-      expect(find_all('.contact-email-delete').length).to eq 2
-
-      # delete the first address in the list
-      page.accept_confirm do
-        find_all('.contact-email-delete').first.click
-      end
-
-      # the page element for the first entry should now be gone, but the second should still be present
-      expect(page).not_to have_css("##{email_id_0}")
-      expect(find_field(email_id_1).value).to eq email_address_1
-
-      # reload the edit page to confirm deletion from db...
-      visit spotlight.edit_exhibit_path(exhibit)
-
-      # what was the second address should now be the only one on the page, and should now be
-      # in the first/only form field (form fields are numbered at page load from 0).
-      expect(find_field(email_id_0).value).to eq email_address_1
-      expect(page).not_to have_css("##{email_id_1}")
-
-      # the hidden input field is what contains the underlying id of the contact for db retrieval
-      expect(find("##{hidden_input_id_0}", visible: false).value).to eq hidden_input_val_1
-    end
-
-    it 'creates an empty form field with no associated delete command or confirmation status when creating a blank row for a new contact', js: true do
-      # create a contact email address and save (shouldn't see delete button or confirmation status on unsaved entries)
-      visit spotlight.edit_exhibit_path(exhibit)
-      fill_in email_id_0, with: email_address_0
-      click_button 'Save changes'
-
-      find('#another-email').click
-      expect(find_field(email_id_0).value).to eq email_address_0
-      expect(find_field(email_id_1).value).to eq ''
-
-      # conf status and email delete are nested in a sibling div of the hidden
-      # id field that's used to indicate the id of the record to be updated.
-      expect(page).to have_css("##{hidden_input_id_0}~div div.confirmation-status")
-      expect(page).to have_css("##{hidden_input_id_0}~div span.contact-email-delete-wrapper")
-      expect(page).not_to have_css("##{hidden_input_id_1}~div div.confirmation-status")
-      expect(page).not_to have_css("##{hidden_input_id_1}~div span.contact-email-delete-wrapper")
-      expect(find_all('.confirmation-status').length).to eq 1
-      expect(find_all('.contact-email-delete-wrapper').length).to eq 1
-    end
-
-    it 'displays the error message from the server if there is one', js: true do
-      visit spotlight.edit_exhibit_path(exhibit)
-      fill_in email_id_0, with: email_address_0
-      find('#another-email').click
-      fill_in email_id_1, with: email_address_1
-      click_button 'Save changes'
-
-      Spotlight::ContactEmail.all.first.destroy
-      page.accept_confirm do
-        find_all('.contact-email-delete').first.click
-      end
-
-      expect(page).to have_css("##{hidden_input_id_0}~div span.contact-email-delete-error", text: 'Problem deleting recipient: Not Found')
-    end
-  end
-end